From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 951B3C47258 for ; Thu, 11 Jan 2024 18:18:30 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 312526B009F; Thu, 11 Jan 2024 13:18:30 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 29B186B00A0; Thu, 11 Jan 2024 13:18:30 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 0C7F36B00A1; Thu, 11 Jan 2024 13:18:30 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id EAC666B009F for ; Thu, 11 Jan 2024 13:18:29 -0500 (EST) Received: from smtpin16.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id C0FC4160B38 for ; Thu, 11 Jan 2024 18:18:29 +0000 (UTC) X-FDA: 81667840338.16.CFC4C85 Received: from NAM11-BN8-obe.outbound.protection.outlook.com (mail-bn8nam11on2040.outbound.protection.outlook.com [40.107.236.40]) by imf26.hostedemail.com (Postfix) with ESMTP id EDCF114002A for ; Thu, 11 Jan 2024 18:18:25 +0000 (UTC) Authentication-Results: imf26.hostedemail.com; dkim=pass header.d=Nvidia.com header.s=selector2 header.b=TehXaHKt; spf=pass (imf26.hostedemail.com: domain of jhubbard@nvidia.com designates 40.107.236.40 as permitted sender) smtp.mailfrom=jhubbard@nvidia.com; dmarc=pass (policy=reject) header.from=nvidia.com; arc=pass ("microsoft.com:s=arcselector9901:i=1") ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1704997106; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=Ynie69TsOM2zYpBWsC2S6NMEXgWIi4OwQWmd5ZEqN6E=; b=kwbA3Mh4aMwvpm88OWiUstlUTFMcsn6u2LzmnwnadIp+mzAbbn9wudWAbeMHOA3SuyMINq 9X2O+vcdPhgXK2KziHNQyDRR+j2f4ABq5FAxblqpDMZBtirS/Wm62RGrt/mNcV7oScCUEH y95zk/c5AbPeS5Mp7WqeTGb9tSHS2/k= ARC-Seal: i=2; s=arc-20220608; d=hostedemail.com; t=1704997106; a=rsa-sha256; cv=pass; b=N9jgE0nQviKRwflE7/n30XOmmnvc43VOKFE5yqR+JOz96gIWgBSsQI/wXKVEvESmrA0rSv /1QZFPvzLJbWiOZHbyNwKiJU3pSo/Zcgk1MO/H5LeKjuCrZyRuswqFJGQcTa7K4W32Rm8X ngHuGt9B1DH/aDPuHg1EtlfeJvd7Rtw= ARC-Authentication-Results: i=2; imf26.hostedemail.com; dkim=pass header.d=Nvidia.com header.s=selector2 header.b=TehXaHKt; spf=pass (imf26.hostedemail.com: domain of jhubbard@nvidia.com designates 40.107.236.40 as permitted sender) smtp.mailfrom=jhubbard@nvidia.com; dmarc=pass (policy=reject) header.from=nvidia.com; arc=pass ("microsoft.com:s=arcselector9901:i=1") ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Oe6/krBrFwaAaTbfxJ2N65le0pibUXu6HfYbNR6z4APq9g5S3KRcrbdStORA9rL3aS26k6MA+wxGs3AUTyJ5Cj/nbVnHn+cJ215ay80gImVdGL8TAEpjK1Le63/jcvYaL+CXTjYNj6vbG7LbgquDJyaIQn5H61VMaxzVJrgGPLcukaJkYi/OGpIsgpWHn3pq70AW/Aa2MjZzsjCizTmeS8XQrMZqeBYv93PwXLxBY9WOVv9Id7ytT6Hbjifbx7i7COOnYu/e9uLb1+mSTjoBAMzYA3fb7c7fcfy7uGMPzU5l0lhynwzIOgkLg08F3x0wiXpfNU3uRcUAwSb70OlB5g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=Ynie69TsOM2zYpBWsC2S6NMEXgWIi4OwQWmd5ZEqN6E=; b=mkhGyC/vbCyaa5GezFstQfKBsdVNHtoWPn3iPXqjVJDNKm7Ti9IxsBp6lV0qvyc9tIq1nF+uOoI+vdMhZo93LHbLYJBK012u32QEGRPBipodz4ZB4qc0f+heO1GzmbAIO3s/DrgsDk7Niu8C+/uWTqnuvSKvBbhYB1kk+jbKIRqiTDEX1IKtqKc6f7oe7Cpxw7Ar6J3WOakZkGQRJ15g5pSInfPhoQFPWvdDIPBJeMVQkXXdIiqfAFePP46tltJUncgqCig0Fz+wSuuIih0h1sxTt7A50Q3T4q5+okx/MNvkLanzZ+RxjAUGmssE5mlX4eIS9KWODjDVgL7yURzdhw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nvidia.com; dmarc=pass action=none header.from=nvidia.com; dkim=pass header.d=nvidia.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=Ynie69TsOM2zYpBWsC2S6NMEXgWIi4OwQWmd5ZEqN6E=; b=TehXaHKt0JvqO9p7r52GmNpPtW2sf7TMBR1/7J8RrCFm3RkwW70L+J5TZ8bMm7zzFWWoVE3bPjiyuSkMScA973oULTYGefEIoFQJMEV/uQ4Ih50H7b8xpgupItb9DCzVVyax31qsyfiGFEpji5YWwlpgeGiTQbh6jnkYnlochay6UhdL4Mb8eDHF60fvIn3i1ck8DEul8VPH8xXP4BAVe27IwiXnwJ2p2pyAXKDJ72Z9rnu5lviYDlTzDPeib+ZO2p9bsEpvt1bPdKGbbNiNxq68AxYhU9tZnfLm5NRMZycuY7WwgzGvobGZh65CSwPX9DfQuGOX9pTSWg3gBRdyRQ== Received: from BY5PR12MB4130.namprd12.prod.outlook.com (2603:10b6:a03:20b::16) by SA0PR12MB7001.namprd12.prod.outlook.com (2603:10b6:806:2c0::11) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7181.18; Thu, 11 Jan 2024 18:18:20 +0000 Received: from BY5PR12MB4130.namprd12.prod.outlook.com ([fe80::90bb:c583:cc57:aa1a]) by BY5PR12MB4130.namprd12.prod.outlook.com ([fe80::90bb:c583:cc57:aa1a%4]) with mapi id 15.20.7181.019; Thu, 11 Jan 2024 18:18:20 +0000 Message-ID: Date: Thu, 11 Jan 2024 10:17:34 -0800 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2] tools/mm: Add thpmaps script to dump THP usage info Content-Language: en-US To: Ryan Roberts , Andrew Morton , Zenghui Yu , Matthew Wilcox , David Hildenbrand , Kefeng Wang , Zi Yan , Barry Song <21cnbao@gmail.com>, Alistair Popple , William Kucharski Cc: linux-mm@kvack.org, Barry Song References: <20240110173203.3419437-1-ryan.roberts@arm.com> <33341ca8-1354-4f3f-b377-0b7d04da48d0@nvidia.com> <43230798-af22-4f59-b37c-8257bae32af8@arm.com> From: John Hubbard In-Reply-To: <43230798-af22-4f59-b37c-8257bae32af8@arm.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-ClientProxiedBy: BYAPR07CA0007.namprd07.prod.outlook.com (2603:10b6:a02:bc::20) To BY5PR12MB4130.namprd12.prod.outlook.com (2603:10b6:a03:20b::16) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: BY5PR12MB4130:EE_|SA0PR12MB7001:EE_ X-MS-Office365-Filtering-Correlation-Id: fc609cf7-6f8c-4def-367b-08dc12d1b08a X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: O+OS5kYV+8Xcvyp1vVkYmxIPlMnrSBuAxMDAa1qaVFRDj3Plo/0Zc/1w8dd7dzll0WCZFDEayLqoQrHpFZWgV3sk8h98lCv/eMePDKR5XikR8Gme14uOqBnEYQfhadnvE+vWiWRMLvgtOlRf6snDd8pk5szQ232bUkyhPjsfXDHJsr4wcF9t6cNGZYv19cpKaSA7te0XfgehqjM4M1MkeOpRQpbvoiFzCjzFhbCeZn47df2L9qXLK238FHZ3JIl0V260iOninyPpPwuVx/FvXXBg/W/Vq3HwikwKyRhpZ4BVpirSqo7tRtkuUGJMR6Fm9Ja5kzRPccGAkQB/Nif+PJHXsTRtUkmvZMKGhOJEeplZOlIfaJbxVyYsJptSp02smiDw0SxgJ/8ftJRHDrwLHOkFn8l3CLyqRyaoqowREEKUXyoRmb+Ujk7JwdRGZt3N/mFEW+3hj96O/Ij021Ex0C2W0VrP9MDdnJANU+V/0sTUgbuHGlwWES6phjJAQTxKm4Fa2hdMtOvoPdDW+Th0tplDij33KwvROKP2jgd4DxD1KUyUqLG4fRa8TPOsoc4JeW+BxA/HbnKMhU7rRO7Bz9T6a/1Cl/By5t4rjxZNCtGrZzWJ2I9EvRcLrsF6w67XmpQv+kbUIP0mf24Y9UWKzBd7j9y9x28/5t1uZVT1DLg= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BY5PR12MB4130.namprd12.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230031)(376002)(346002)(136003)(366004)(39860400002)(396003)(230922051799003)(64100799003)(451199024)(186009)(1800799012)(4326008)(8936002)(5660300002)(8676002)(31686004)(7416002)(316002)(2906002)(66556008)(66946007)(66476007)(110136005)(6512007)(6666004)(6506007)(6486002)(53546011)(478600001)(921011)(31696002)(2616005)(36756003)(83380400001)(41300700001)(38100700002)(86362001)(43740500002)(45980500001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?NHpKL3lyNU1Ud2tFNXpaRmlOV3pBK05Ubkw3dEpXNHpwU09GWWxKTXhFSm91?= =?utf-8?B?bGFFN3BydEJzdVAwRVBkSFdZcVVDQWphTUltK0lGYktXT1FHd0oySEk2bHpY?= =?utf-8?B?a3ZPV2I0bXlHS3lYWXJpUUJSamFoaVJjR2o4SEFZcndFZ1hoellLdkJGMEVO?= =?utf-8?B?OWhXRS9ITjhYcUR4dk9kNk15b20reHo5VmRPd0prc3BZaVc4WjVicWFOaVVo?= =?utf-8?B?TnFRYWl5elJvb2lkdWQ5VEwvUEpWUlUxTE9ORFllVno1LzR4cHQwTDhaQ1VI?= =?utf-8?B?NEZuVG8rMDdteTFXWVk1amt3SWw4MG5xclZOS1ZxOVZzeW1vTEh5d1JkbFMy?= =?utf-8?B?bFdpUElhYWRhdVdMSTZoNWVsVWRoUVpVN0MyMlRhYlJmUTcvSE1mUHoxWmRU?= =?utf-8?B?dFMyYzY1RDVJRXhiSTF5eDZvYW4zOStLVkpTRnBBUGtqNnVRNDI2N0J3RFNI?= =?utf-8?B?U0ZBY21QTi90TGN6SWlJTDRXaWhuMFBlWUQ4dG4yM0R3OE5DVTNyZUlMMDUr?= =?utf-8?B?dWxlQ0FHaXBXZnM0MGpXM1hnZGVkQ3lYYmd6V2diYkFLWDdpc2l2aXd2TVNv?= =?utf-8?B?MVp5UGp3MVMyVEhwdXZxS3J6S0ZHMmk4YTdERDhRaW1ZTmFTWGZxZmN5Y3pU?= =?utf-8?B?NzFWY1BKZDlhOEs5TVMzQjUvbmVpZC8rbk9Bd1pwcHNZajgrVkFpaVMyNlZx?= =?utf-8?B?UEw2ZGRsSzVNbU5YdnlsZVBaOFZqTTgwdVdwSEVSaHRtOVVmL3ZuNi9jTWtS?= =?utf-8?B?NEl2ZHNYMUZ6ZzhrYUdmSDRMYnNIVS9INml4ZGtNeC9OdjNNcFpGaW4rY1NL?= =?utf-8?B?WlpReDNBQW0yVHFMdkdmT0drYlhqZDZSUzJqU3lRdnBjZkZuMjZuaWYxOFVh?= =?utf-8?B?NkxBT1FveXdzdzBEOTBJSXZIejBWSDdpZDN0RmdXeFdwUFlZLzNNc2xtbW42?= =?utf-8?B?dmhRT0JqMUNBS2xXNWtwRXdlSmo1NldlWWRxS1VWTmlORFo1YnMrK05va2lM?= =?utf-8?B?UXVYYldaQ1YrSTJtNUhMeWpHam1VSHBUY3dOUjd0Rkh3VHl1VVhrTGhMells?= =?utf-8?B?TGRsMzY2dWtpdE9Tb0Y2SVhaTXJ4b2N5TDZMVW9hK21YeWloM2YzZ0JEZHdJ?= =?utf-8?B?TFp0WWNjdVUwaXpsVjlGSmY1SXhESlFDZTNBKytYWDcxQkRIMFVWamN1OFVG?= =?utf-8?B?MkdBN00vZ2owb0k0QzhISHdTd3plZXFrK3Y2Q0NlYWdLZ29LNGNkMTdaWGhn?= =?utf-8?B?N1AyMUJFNmt1bWE5YVgrMURpOTFOc1FCaCtsVVRzalZrNTVOTll4THRMdDky?= =?utf-8?B?aGlaT3QyeFd1TEZqSFFOSzR2bzdRK25XMXBtbUkrMk5IR29CTGZHa0hiWC9o?= =?utf-8?B?ampaYkxaK0JuT0tnQ2JhSHpES2RtS3UraGtuakd3UURqRjhhVnljaUhkZ2Rw?= =?utf-8?B?cmNLcXZHWUFKRmdDVVNWR0RHU3ZPRXp2WGtkc2t4YXJyZERFTzZhdUlmTGJU?= =?utf-8?B?UWl1VENiaFlDVXNzZEhBQzloWHBVVGkxVkJFMW5vVmtHSjZ4dXhmdkVYdkEv?= =?utf-8?B?VVh2MS9zUllGWUVobXB1M1JzeDdrdk9ZQUZYVkl1VlBrdmZjTUJjVjlXOUFW?= =?utf-8?B?T2NuWGVZSktDbndaWWpZaGoyS3R1OUtXR2gxNzczdXNLOGdRRWwwcWlhdDZ4?= =?utf-8?B?RmJ3a2wxSHlmUHAwd3ZDU2JUNFQ2eHlnMmxiQk1EQ0UvY3ZJa1F1M0dHVkJ0?= =?utf-8?B?UkNhUlZwRXRnYVBnT1J4bGZaRm9YUklYb0tOWEpWNmJPRHZETTdiTm1sR3Uw?= =?utf-8?B?SmQ4RGVCYjdWSmE2T09mSDA2ZXg4bVpFaWRiNGhxcVZTcEhNYlZ1dXI2NXdx?= =?utf-8?B?ZUlXZUdDblgwVnVXa2pCTTJ1ekFzMWpVcytHM3NnRC85cHhxd0pEYkhNWGx4?= =?utf-8?B?YTZDSzUxc2ZVYk5VTDJqS0NKU0FRcStDd3pUdDcvT05pYzdSRnRBd0dZbjYv?= =?utf-8?B?bkxkSTU1eHdQbGRrMmk2cFlvb0FDQjQ5dUVleUM3R3VRcUJ4STFWb1VHWElH?= =?utf-8?B?S3BQQVgxQVFPcFZWdkdwTC9JQldCTHN2aDFwWUcrL1hjb2xSRU10cUFYWm95?= =?utf-8?B?WTIzL2NsQ1dwekk3WWZ2cktMalIwcDhZMFJycmhUNGh4UjBaNHhpdFo0ZzRq?= =?utf-8?B?c3c9PQ==?= X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-Network-Message-Id: fc609cf7-6f8c-4def-367b-08dc12d1b08a X-MS-Exchange-CrossTenant-AuthSource: BY5PR12MB4130.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 11 Jan 2024 18:18:20.0313 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: Vqefr5RWCJzVrH1Y/18B+uECVu+tAHttJBpd0DRji+Ou+YvfAmwCWcDt6x1HSLVGe11AlYK3JahqrfW8z3berg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: SA0PR12MB7001 X-Rspamd-Queue-Id: EDCF114002A X-Rspam-User: X-Stat-Signature: rb3b5gj6hxnhsn9xqj7jj5rpiz5hyezj X-Rspamd-Server: rspam03 X-HE-Tag: 1704997105-981933 X-HE-Meta: U2FsdGVkX1/Csnrzy4pBMta1gsCpZWn5Kyg3vFnT5hqTAsnZ6XfQjWhrDxvj+z22GYayqxGedxDXCNj+Pn/O7KtrLBwLzhF+yhgOuHN3eC71tjJuF/ewbzc0nVU9vt83o0igam9FHxxVRN+WnjhIAlni1B2dGb5uKFeyaHhJ0CSbwQ8GxDsrr0dyZRxnvMLXkpg+ARl7MaX4ZRfHHyYV62yydG51i6g4PMX9hPDHC7/PkM3snZv17l567gVhWYHMd0gWISMDUCPIM+E4k1jnXd9DeD/TmucSPvalTLHV9fWaw5uahFyfri45aKPiO3N6jcnrCkIWOLJWu54mKKaWfZ3K29r2yjSc9xuvvhM5v+XnCG77sh2yMqpiVnbQrcc6LZG5a7F6NAy/nFR9bzoUDuGtWZ2p9AzRKDFbKiYoW7tFizjv75NbrNfkymloF/rPpneDtlll8zrkmIMhHgMSEyqovdEP8L1/ToRi+ipAIHv1c/yHDO5M07LQZs4rKxhmKcMzpK8dpy3vIEJtX+Bi+FmA5M28TUk4ld1s5zIhQjKNBpqyy1rLZGGenHHEA7b7Z7H2b7PWDsGNNMmBxDnFhECmkJqPykRmSYY9InNV+IUQiW6wlbwYy0sSFRJ1LtAJVhGc8dEpYHo5NtklRKbU2Qj6MiSvFd080yT1l5Wo+iJ7EcCLKgaza4v2HHVGvNruR8ZApEUY8Xw/LSDGe4D49xWA76xvyA4WRTlhJVzrDdLbz+DrDIHy23LwNW2YSnI97/VC8L6f1Fq8MdDMbe+T0T8iV+mXrGh9lPRHu3OqWOao5TnznXf6nKvusBvDlvsTloQ/MlAPWuQKY6XT1ISRPTQnoHNPozkmANWv4UE8TuFxds7IQl4MGrNUQSQSi5MXFgtFEXNMBZDYPurofhV6avWmwWe1W5vg2GgIlRfn3VKWrWzn+vGE3+YFyUI+psLI8aYjtVmV0MMZijQYT32 rdj4ETsF 0WN9k0/RE0uY50br6d5dv1seSIngOJEUfBmbS+j8nWmZsX1mqNKHu8iiYmma94WN6eudO+DnCfeHwsJKC3Lf4/SnYj8QcfzqopK2+GhjWlo+zE2xXf+8auE36QfiLdU/zRlOSGba6ZLIVKO3LoPYmruDxVPwVsIttJdmeu6Vf+PQcXKj54+BuWDM3Mip/dfSiO4rsqscpLQdfjD/bM+KkkYDxa0O91eLZFbd08uudz3hskEzZicGYH8B+SlvFlZg4b3ecgcyAx4QjRf4RrhsDDPoK+aCMeHTx7pBfbOahd+BNjybObW1A269jTuEbC9ewxecd6G/0ltpiN0UeF5nMbIny2Q== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 1/11/24 03:54, Ryan Roberts wrote: ... > I'm not sure exectly what you are asking. The "cont" counters are counting > blocks of contiguous, naturally aligned physical memory, which are also mapped > contiguously and aligned. So a smaller --cont would always include all the > memory captured in a larger --cont. In this case, its all the *file-backed* > memory (as highighted in the label name) so nothing to do with (m)THP. But where > you have THP, --cont doesn't care what the underlying THP size is as long as its > requirements are met, so PMD-sized THPs would be included in e.g. > *anon*-cont-aligned-128kB. > > Note the the "--cont" counters don't directly count memory that is PTE-mapped > with the contiguous bit set in the page table; it just counts memory that meets > the alignment, size and mapping requirements. On arm64 systems with the contpte > series, the contiguous bit would be used here, but its not a part of what's > getting measured. > The "cont" and "naturally aligned" terms are difficult here, even though I'm familiar with the implementation. But putting on my systems monitoring hat, these terms are not helping people as much as I'd like, because: a) "Contiguous" is not really a unique situation, so measuring large pages that are "contiguous" is confusing. All folios are contiguous, and anything a pte points to is contiguous as well. So --cont really throws off the user/reader. b) "Naturally aligned" is also tricky. Because "natural" is not explained. Here it means NAPOT (naturally aligned power of two, I saw that in the riscv docs). After spending a day or two exploring running systems with this, I'd like to suggest: 1) measure "native PMD THPs" vs. pte-mapped mTHPs. This provides a lot of information: mTHP is configured as expected, and is helping or not, etc. 2) Not having to list out all the mTHP sizes would be nice. Instead, just use the possible sizes from /sys/kernel/mm/transparent_hugepage/* , unless the user specifies sizes. ...                         (e.g. /sys/fs/cgroup for cgroup-v2 or >>>                         /sys/fs/cgroup/pids for cgroup-v1). Exactly one >>>                         of --pid and --cgroup must be provided. >> >> Maybe we could add "--global" to that list. That would look, in order, >> inside cgroups2 and cgroups, for a list of pids, and then run as if >> --cgroup /sys/fs/cgroup or --cgroup /sys/fs/cgroup/pids were specified. > > I think actually it might be better just to make global the default when neither > --pid nor --cgroup are provided? And in this case, I'll just grab all the pids > from /proc rather than traverse the cgroup hierachy, that way it will work on > systems without cgroups. Does that work for you? Yes! That was my initial idea, in fact, and after over-thinking it for a while, it turned into the above. haha :) thanks, -- John Hubbard NVIDIA