From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 87A0BC001DB for ; Mon, 7 Aug 2023 15:20:37 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 24F5D6B007B; Mon, 7 Aug 2023 11:20:37 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 1FF6B8E0001; Mon, 7 Aug 2023 11:20:37 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 0A0428D0003; Mon, 7 Aug 2023 11:20:37 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id EB88E6B007B for ; Mon, 7 Aug 2023 11:20:36 -0400 (EDT) Received: from smtpin30.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id BB878120261 for ; Mon, 7 Aug 2023 15:20:36 +0000 (UTC) X-FDA: 81097670472.30.D980AC8 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by imf05.hostedemail.com (Postfix) with ESMTP id 5320510001B for ; Mon, 7 Aug 2023 15:20:34 +0000 (UTC) Authentication-Results: imf05.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=cNQEwQbb; spf=pass (imf05.hostedemail.com: domain of david@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1691421634; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=/02dTAcik69IL2Uu7390fVV3gEku8KkLFIb+3PEUoAk=; b=lxBxeLGUOyVSRMY4T0lj5uSj3VZ9zNxvDFTVUUW43XMxDbVWaTEh/FnwmkF2H9hTBll2hs M5ppA3tK+QTxBwkRtoWUmciVuwFhN6LdM6DQqrsCvNzyNkFuyyqA130AYabw9FYt3E0xxW 9v/F6G+ZfutgCc7sUG3x9CacpC/JHMU= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1691421634; a=rsa-sha256; cv=none; b=7ZvIHUVvy89FPDEuakTlxguwmtDEbtIrSfLxrf21znT4q/K1f/3ZhKVPwlzw7wU+UMtgBK x5br4Sz3R1/XbgJenCrG+p44WdI2VLp86GIkkxO+nyEDDNFU2dz7rEHQS+mxp1+v9P9ns/ 67efwDo7N03WzwhOfst2dhbF62HlQiI= ARC-Authentication-Results: i=1; imf05.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=cNQEwQbb; spf=pass (imf05.hostedemail.com: domain of david@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=none) header.from=redhat.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1691421633; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=/02dTAcik69IL2Uu7390fVV3gEku8KkLFIb+3PEUoAk=; b=cNQEwQbbS/9kk3PcbPLpwW9V1DRi38dlJW2MjdMer9Ha2b3vdGZPXLmibMZACTRaFR44ze LKcTFV26rkJ0A9IHQ0VWVK+l7ABmWSX/oKjcuNtTi+xNbKSmViqvbMF8cM2p0q2s//O6lU 0PrVlIXiOsJguHoO1Nttv/jWkq3BWvU= Received: from mail-wr1-f71.google.com (mail-wr1-f71.google.com [209.85.221.71]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-627-2FDhvGbuO0SAqiNOXNOl8A-1; Mon, 07 Aug 2023 11:20:32 -0400 X-MC-Unique: 2FDhvGbuO0SAqiNOXNOl8A-1 Received: by mail-wr1-f71.google.com with SMTP id ffacd0b85a97d-317dff409dfso676121f8f.1 for ; Mon, 07 Aug 2023 08:20:32 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1691421631; x=1692026431; h=content-transfer-encoding:in-reply-to:organization:from:references :cc:to:content-language:subject:user-agent:mime-version:date :message-id:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=/02dTAcik69IL2Uu7390fVV3gEku8KkLFIb+3PEUoAk=; b=GgQd2GTEBM4h7b9BscWEvCUVpO/wjNI6ZuH8Hhtxn+sQo4smtdYWxG+lkxXqYv7F+e QAhereA6jzLnBPhMfivjLNTjs/vlIHmuRwEswDU3QAWVvuyBa4V3hdXTR273C330by4+ paLPSgcouzl0fDLwK0NQuBQfzc5K8LIYxQzWCdIKpyLQ/ARrWG6dKSaAs14sdohDa7ra Jef88HPl2ga57f1p1yTSTBZl3GSZtMKQMkm1iaRkS4UrmrXdOlwWQ5hETYq8KMjnGepG /tohHJObga6Jjs1vkx1TnmSFHxr0zMaHgxyIMktA78pnDZ79MMS1M/BCPKQxoYEr8zi4 PxZw== X-Gm-Message-State: AOJu0YwJX26Wn594TYrtk8OpkY0238t9HG9GlrqBkal75EVp0kxG1a+R ymO4s6jo4EFIpZjh7kyHHr6SCoXoz9SRzVXcREzRXJ9RAn4JbD8RoD7+ZD30KR6GY+BwpgB5nlT LDEBaJwdS0nbjakzpD5E= X-Received: by 2002:adf:f6c3:0:b0:317:417e:a467 with SMTP id y3-20020adff6c3000000b00317417ea467mr5810466wrp.6.1691421631117; Mon, 07 Aug 2023 08:20:31 -0700 (PDT) X-Google-Smtp-Source: AGHT+IG71BBYqKeooQo+AlNKcVKfhygtEl012cofbMpbhHLqzPuwP9BuijkQXqX0R3rUf/p0W8+OWw== X-Received: by 2002:adf:f6c3:0:b0:317:417e:a467 with SMTP id y3-20020adff6c3000000b00317417ea467mr5810447wrp.6.1691421630732; Mon, 07 Aug 2023 08:20:30 -0700 (PDT) Received: from ?IPV6:2003:cb:c740:5d00:5143:1cd2:a300:ceff? (p200300cbc7405d0051431cd2a300ceff.dip0.t-ipconnect.de. [2003:cb:c740:5d00:5143:1cd2:a300:ceff]) by smtp.gmail.com with ESMTPSA id k2-20020adfe8c2000000b00317ddccb0d1sm6854635wrn.24.2023.08.07.08.20.30 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 07 Aug 2023 08:20:30 -0700 (PDT) Message-ID: Date: Mon, 7 Aug 2023 17:20:29 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.13.0 Subject: Re: [PATCH 1/7] mm: remove redundant K() macro definition To: Kefeng Wang , Peng Zhang , linux-mm@kvack.org Cc: akpm@linux-foundation.org, sunnanyong@huawei.com References: <20230804012559.2617515-1-zhangpeng362@huawei.com> <20230804012559.2617515-2-zhangpeng362@huawei.com> <3df967c2-5635-422b-959a-07632a783690@huawei.com> From: David Hildenbrand Organization: Red Hat In-Reply-To: <3df967c2-5635-422b-959a-07632a783690@huawei.com> X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Rspamd-Queue-Id: 5320510001B X-Rspam-User: X-Rspamd-Server: rspam11 X-Stat-Signature: 3pp95ynymckko46gzxcs3db1kgrmiqy8 X-HE-Tag: 1691421634-842997 X-HE-Meta: U2FsdGVkX1/aEdLxMCwHUlkdejCIrkxnsWWT6YifcCDy3hyLQ6LYWwJpdox6ZMW20ztwRXHTn4+IfFgJMpklPJWdLTpUXfE65SxAhnxKrRvXS8WaUjUw8RPwEvZ5smxZA5FOag3hZl0EfUpmkc7lPq282ZQlEor+WZ2C6Axlui6J6uy1158x8Znp+rVldn5rYLq10/ZqSBVzYr8rjaXDcyAKPg3JR1J7sqb8CfbiTXNYunKe+yn5l2HIwXJ+tYQr0vl8xJoyam82enizzKWoo4Oc46voxIUKUrzNsITb1wpydhvEEiBArPgkZGelsyvAdyBxSrphHIW7MyvF2YD61SqqDHwXu2MiF7eDkNOLGlGe7IBVh8zxmO0RF0Dr4+Qo/GrWaq0fA8pYk8njy7nS8BS2I1HLkYiFytJsT/ejC0bpTAp3AbelVUvbyRTlxSZ9xuo6AL0YiMK12ZJBcTtbj49Sds6XcsAnfGmZjQwinDpmBFndrCmeRCyW9Zl5H+vnD8W2eKygsi4ZvPXy7AKBTEp0/Q+Xn6ALcIMAcKJvb0qPuq1f26f3NFPir/YDQADIdHo4IUfXOrPZmiqOKcXCcak9RTQXY6Q9RqHkTZwHse2ZftF0wA+xOETf9ARH5fZBFhh9wrcaDC2gXDZf8LrKsWXy3SI9Kv/DvY2covekGdA0na7rpSKDMuVvwVdtugoRXMMmxUE8Ik3gVAz1H3h4ky3+PFqrsGWf2EMCC3yLWbAiNipN+XRNOc9AiRN9IFqBBi3TcY/nqWKNdO3xLy9ccbrhS6p73rDBh0+J9PskIAZAggEhqfpSN+SoEiFzl2nUpgSOLS+S5miKFMLYrxH76GSjpYINDLRB5v6X99BwxzqCXIIsQFp2hP3w+N2Wi8TEafZXuRrcD6Sw8PU12V4PsaU7GsZ9NQ1L9+Cm+VD7Nzx4yk0Vo9z0ukXbZJg4XUHHjdm04OWN5Z/PlP2j6W8 FBY7HDwz RLJk+TC2OQ8dLZLZrd3QExRl3y0WIH/ycxjvgi8FBwpUreyw07sFIlma13oZRYubEPvnDgAy/2OkgWnPo95zZ6omxPpElg1XwEnT8bwDS3DeRHJZGo8KC/fxcVGL42oYt/xQfNEqGuovRwyVw/kyCmRkOPYWHVdXz3Kp0Ic0YSv24tdtVscdfmUKjlyzB1cnG04G1i1oi16bWuG7GzznEg1n/usycTZeLyLtXpCf7LWiIQMdBrYanCrwRWuysN4f97khgtmB1E6m2/JigjuezbL20eBf9VYemed+WBsqqI5BWQyrQykam4cywOhxCyFpTldwwgR5xOtk9sLdQ2ALniZRsooXdkTETkshJA2uTzOpmo7qMYBQFNtwITdk5/32eJl5boKKIZMVFg1RSwdFu1weoqkMAVfMDbRcCcqsFk/CcxY4= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 07.08.23 10:31, Kefeng Wang wrote: > > > On 2023/8/4 9:25, Peng Zhang wrote: >> From: ZhangPeng >> >> Since commit eb8589b4f8c1 ("mm: move mem_init_print_info() to >> mm_init.c"), the K() macro definition has been moved to mm/internal.h. >> Therefore, the definitions in mm/memcontrol.c, mm/backing-dev.c and >> mm/oom_kill.c are redundant. Drop redundant definitions. >> >> Signed-off-by: ZhangPeng >> --- >> mm/backing-dev.c | 3 +-- >> mm/memcontrol.c | 1 - >> mm/oom_kill.c | 2 -- >> 3 files changed, 1 insertion(+), 5 deletions(-) >> > > ... >> diff --git a/mm/oom_kill.c b/mm/oom_kill.c >> index 612b5597d3af..471061a3a0f5 100644 >> --- a/mm/oom_kill.c >> +++ b/mm/oom_kill.c >> @@ -479,8 +479,6 @@ static DECLARE_WAIT_QUEUE_HEAD(oom_victims_wait); >> >> static bool oom_killer_disabled __read_mostly; >> >> -#define K(x) ((x) << (PAGE_SHIFT-10)) >> - >> /* >> * task->mm can be NULL if the task is the exited group leader. So to >> * determine whether the task is using a particular mm, we examine all the > > Please drop "#undef K" in oom_kill.c With that Reviewed-by: David Hildenbrand -- Cheers, David / dhildenb