From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4FBE2C3DA42 for ; Wed, 17 Jul 2024 07:42:35 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id D40AF6B0082; Wed, 17 Jul 2024 03:42:34 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id CCA136B0096; Wed, 17 Jul 2024 03:42:34 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id B1CF46B0083; Wed, 17 Jul 2024 03:42:34 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id 902746B0096 for ; Wed, 17 Jul 2024 03:42:34 -0400 (EDT) Received: from smtpin10.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id 4873A16094F for ; Wed, 17 Jul 2024 07:42:34 +0000 (UTC) X-FDA: 82348452228.10.04AFE0A Received: from mail-lj1-f169.google.com (mail-lj1-f169.google.com [209.85.208.169]) by imf05.hostedemail.com (Postfix) with ESMTP id 36B69100008 for ; Wed, 17 Jul 2024 07:42:31 +0000 (UTC) Authentication-Results: imf05.hostedemail.com; dkim=pass header.d=suse.com header.s=google header.b=cIGBj0ul; dmarc=pass (policy=quarantine) header.from=suse.com; spf=pass (imf05.hostedemail.com: domain of wqu@suse.com designates 209.85.208.169 as permitted sender) smtp.mailfrom=wqu@suse.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1721202108; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=ovwn3DW6TedKlvHEbgoQx/5Vd4igDUlWIvl8s9WQmRU=; b=nVHGCwNJy3PQqv19j8PxiTGujq6lQAPTxs6DFAGnm5ec390Z8qa0XEQEicE/NP3Zr80/84 u7kqAh2CtXHK8BXrDVc3CgL0mhITApD+z1bviWLhE4mLrUmZAbiBNlJFxIoG5oUAQiOoL1 UaGYSzvwFLeMYWPMBI9eUxMbG1JNvkA= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1721202108; a=rsa-sha256; cv=none; b=BqRbAUGFquwpQSLmBuzpJ1oN4OKtxH2SXbIAslIrLgPhSOBO4fIX6WO55sS3RqIqE9s2ja NNqWEY9F3O9qIvGRsNUl15BA+mATPCQIqi/g6EDpzCUQPUoK0WPVXJMd17glKAt9YzQ3m3 u6Gr77jrTIFGPeiBdYe74Sxg9o3ajD0= ARC-Authentication-Results: i=1; imf05.hostedemail.com; dkim=pass header.d=suse.com header.s=google header.b=cIGBj0ul; dmarc=pass (policy=quarantine) header.from=suse.com; spf=pass (imf05.hostedemail.com: domain of wqu@suse.com designates 209.85.208.169 as permitted sender) smtp.mailfrom=wqu@suse.com Received: by mail-lj1-f169.google.com with SMTP id 38308e7fff4ca-2eefe705510so2497341fa.1 for ; Wed, 17 Jul 2024 00:42:31 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=google; t=1721202150; x=1721806950; darn=kvack.org; h=content-transfer-encoding:in-reply-to:autocrypt:content-language :references:to:from:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=ovwn3DW6TedKlvHEbgoQx/5Vd4igDUlWIvl8s9WQmRU=; b=cIGBj0ul0HtaqLDPF08WS3G8ioqs4cQ3XiTCvd2wT/qHeYdYeV3CTEG62zj32Wg3pO +i8fAAMhtPn1HNgEmx6orjLVsHVaAJEsaMclZp2/WLwcNhLr/7F400BIUnwspUqKhXLa 4/b9iuRgmqZIr0vGvPImUb0cIc8ft5yhRTwzSr0Xkol1QdDnv06YEBFSDZsH4cRbAoNX BTkbpuEZZfycY95Cd7PHwgLLfVAtsc0Sfkd04twXilNwVgeRamQAdAAnxIq9BGQXDcWg Wm/2k2oxgsliXOf78KcnrxFzW3khuXTvh6U5arq4ttNSuOWlEJE07QOXoH021JOb7ave 3OPg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1721202150; x=1721806950; h=content-transfer-encoding:in-reply-to:autocrypt:content-language :references:to:from:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=ovwn3DW6TedKlvHEbgoQx/5Vd4igDUlWIvl8s9WQmRU=; b=MRx6tVVuLYh1l0k1Fjha5aMkWUbAfQdg20Bmg6LwOIKok/J/b53ORzPkGCBEprHdDy btvtMUt7K1YriTjtB7aP/D9JeLyWuALt7j5Ljsz6uAuq/7YqBA+gBJ8Il8hBIMjopTAA Waf9/77254dkN0NGbKj9379vH7PTTBkr9FdjXBzjLWCi8S+UmwVkWrvIkCVrDOwhuqb7 KPDShstZMWYgGkHTEF1JetNBzcrnJT9oNIqDUpmmEKUWLWJvzkF4n7IcnZQCma53iilQ 89lKX+8aVywUrat87rVAKBWZkLwNt/XKTa12PXT8coKZ+3ivN4d9vR/hijLIIAzgEyY3 8Vzw== X-Forwarded-Encrypted: i=1; AJvYcCVc2HseyOyKDjpLWdGFY1ANGk8oZvhsNVBhoLBuWQ/2BmBLv0JwxdftmP5x+pQyx7H3tXGDC9BeeS36izkfhC0JP7o= X-Gm-Message-State: AOJu0Yz8fdJp2Evfn7kUo6scXxmxai0J01t8XjG7vgwgTYFz7YEJ3+2f NFkWkDMXn7AQL7ZmdxQ3PrKU1Y+HbnL9mYthXQ987JhKE1pNG6je6ZwY8LwB+hBlhvToEkgcrLA B X-Google-Smtp-Source: AGHT+IEbmvUx2Tku1m7n3VYmkCoOi72VBlj6R2Ay0fT/hCS949+rAMA+wRCub2dH2lx/PEDFiZ28Nw== X-Received: by 2002:a05:651c:14d:b0:2eb:f472:e7d3 with SMTP id 38308e7fff4ca-2eefd04fa1emr6949041fa.6.1721202150087; Wed, 17 Jul 2024 00:42:30 -0700 (PDT) Received: from ?IPV6:2403:580d:fda1::299? (2403-580d-fda1--299.ip6.aussiebb.net. [2403:580d:fda1::299]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-1fc0bc38a81sm69966755ad.220.2024.07.17.00.42.26 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 17 Jul 2024 00:42:28 -0700 (PDT) Message-ID: Date: Wed, 17 Jul 2024 17:12:23 +0930 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 0/2] mm: skip memcg for certain address space From: Qu Wenruo To: linux-btrfs@vger.kernel.org, linux-mm@kvack.org, linux-fsdevel@vger.kernel.org References: Content-Language: en-US Autocrypt: addr=wqu@suse.com; keydata= xsBNBFnVga8BCACyhFP3ExcTIuB73jDIBA/vSoYcTyysFQzPvez64TUSCv1SgXEByR7fju3o 8RfaWuHCnkkea5luuTZMqfgTXrun2dqNVYDNOV6RIVrc4YuG20yhC1epnV55fJCThqij0MRL 1NxPKXIlEdHvN0Kov3CtWA+R1iNN0RCeVun7rmOrrjBK573aWC5sgP7YsBOLK79H3tmUtz6b 9Imuj0ZyEsa76Xg9PX9Hn2myKj1hfWGS+5og9Va4hrwQC8ipjXik6NKR5GDV+hOZkktU81G5 gkQtGB9jOAYRs86QG/b7PtIlbd3+pppT0gaS+wvwMs8cuNG+Pu6KO1oC4jgdseFLu7NpABEB AAHNGFF1IFdlbnJ1byA8d3F1QHN1c2UuY29tPsLAlAQTAQgAPgIbAwULCQgHAgYVCAkKCwIE FgIDAQIeAQIXgBYhBC3fcuWlpVuonapC4cI9kfOhJf6oBQJjTSJVBQkNOgemAAoJEMI9kfOh Jf6oapEH/3r/xcalNXMvyRODoprkDraOPbCnULLPNwwp4wLP0/nKXvAlhvRbDpyx1+Ht/3gW p+Klw+S9zBQemxu+6v5nX8zny8l7Q6nAM5InkLaD7U5OLRgJ0O1MNr/UTODIEVx3uzD2X6MR ECMigQxu9c3XKSELXVjTJYgRrEo8o2qb7xoInk4mlleji2rRrqBh1rS0pEexImWphJi+Xgp3 dxRGHsNGEbJ5+9yK9Nc5r67EYG4bwm+06yVT8aQS58ZI22C/UeJpPwcsYrdABcisd7dddj4Q RhWiO4Iy5MTGUD7PdfIkQ40iRcQzVEL1BeidP8v8C4LVGmk4vD1wF6xTjQRKfXHOwE0EWdWB rwEIAKpT62HgSzL9zwGe+WIUCMB+nOEjXAfvoUPUwk+YCEDcOdfkkM5FyBoJs8TCEuPXGXBO Cl5P5B8OYYnkHkGWutAVlUTV8KESOIm/KJIA7jJA+Ss9VhMjtePfgWexw+P8itFRSRrrwyUf E+0WcAevblUi45LjWWZgpg3A80tHP0iToOZ5MbdYk7YFBE29cDSleskfV80ZKxFv6koQocq0 vXzTfHvXNDELAuH7Ms/WJcdUzmPyBf3Oq6mKBBH8J6XZc9LjjNZwNbyvsHSrV5bgmu/THX2n g/3be+iqf6OggCiy3I1NSMJ5KtR0q2H2Nx2Vqb1fYPOID8McMV9Ll6rh8S8AEQEAAcLAfAQY AQgAJgIbDBYhBC3fcuWlpVuonapC4cI9kfOhJf6oBQJjTSJuBQkNOge/AAoJEMI9kfOhJf6o rq8H/3LJmWxL6KO2y/BgOMYDZaFWE3TtdrlIEG8YIDJzIYbNIyQ4lw61RR+0P4APKstsu5VJ 9E3WR7vfxSiOmHCRIWPi32xwbkD5TwaA5m2uVg6xjb5wbdHm+OhdSBcw/fsg19aHQpsmh1/Q bjzGi56yfTxxt9R2WmFIxe6MIDzLlNw3JG42/ark2LOXywqFRnOHgFqxygoMKEG7OcGy5wJM AavA+Abj+6XoedYTwOKkwq+RX2hvXElLZbhYlE+npB1WsFYn1wJ22lHoZsuJCLba5lehI+// ShSsZT5Tlfgi92e9P7y+I/OzMvnBezAll+p/Ly2YczznKM5tV0gboCWeusM= In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-Rspamd-Server: rspam07 X-Rspamd-Queue-Id: 36B69100008 X-Stat-Signature: cnd3wszoqxqu4tqpbboj6aj9madzpmy1 X-Rspam-User: X-HE-Tag: 1721202151-707167 X-HE-Meta: U2FsdGVkX1+J+rFBdfVbhBN1i7v6KGCiCIcCNeeTxJTlId6k4g289MYmIACEUy1tO28RUIDjhPRMD5+Zkx5kDyS23p2dZPBP6CXD9pZbqKOIJYhFgHMR1bjOzIBqTb9yojalkkw73KQi9tFqthdbhgK8cnhLRU/iuyFqXd5JxJBVe9383Dv1v/2YKkZQ/sAdhTz0t9FYaTchT+cQu71zCq0H8MqirbKIAuHuNX1jOwzv5R6rWkg1QjA4Rn4S6esqZ2D9185xeuBzOpznqoPQZlZZa0b3FdUp5u+4hYd3BgrC1EDc/2wYzUzNu7YgJpJ/L11g6y10VLNXPJiqivwb129K3SY7Of4r0POU0mQ6iJChEYW3Ukf6q5FxihyDs8F8ArxIcCM74azBQ6K1WUkuGwQ9TGfR5x3Doti4Carg339TR7iQO+GPdinJu6RZ7GoFswNs0/6fHlgiYZP6NZSZBju7LQwP9XNr3ennEpQswfnmjG4EPPPGYMFvcM0l93vl5Kc4Jc/pNA18ZtQaU+vpmGSpnVb1HAj2yffuyqS6Cx8pnd95FlF14W6wPOzlj9d7UFzyTi0XuLFnGSuB+Law/4nkfbr2bUn43TQsV0snAtNfsxeBBB/71WnXZsiAFcrCjHz+RmZ5YFzbSNkqxwb7nyCFXi5Ko/jYTDar1tCkasY3WiitIFuj0sCbYBIyJbKI06uQhEnKOiPIid+XDiQqGMRKxQvxN1DIAJkokmb7TjjOK0xjr4A7chr0I0+CuuGmxC+bLfKLF9Cdv9R3AmGZbbsxPdUpM5OE1boC/IZJoOtjT+hDwzTlVyWkGL/K2ivWH0jDDmVA4Iabl3XhszNsb79nLHPKmiXEybo/A95cl4ZEIyen6hW8hVsVGrPaAlHvPPzXHRiyEDs+54M/kHjuxPIGT/c+OKh8PO96UhNW7t7TItIxIMZFRT/7We2km+m9u0Z1L/tvIGQr0Ysl72o p5ka2sDu r5aWR06nwUic+/kGK5xmqP/yai8cf2UgKJ+z5kDUJ7Nk1T/nDLiYsZC+xtEUzjAdE3YnNFTXLYvjkYzZdo90gSxXzqA25GCCsDacgfSoiBgoGGkHYBtczPfEU/9h4a7P+lvZAdSVoFLeNYg2Agebx1yJieRsALhPBYm64CgnRx1N4k+u3bpow7SMqThent1fB0jTxiLVTXXbi+p6X379chK7jPDoFCmi2aCZhceEqcLWARpA7sKzFsUGqYlYKrUUbETCAH+8d3GV+FiRm9+CRrVD8TVPRB1nNW1mfFPKulclK2vc= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000273, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: Ping? Any feedback? I guess in this case btrfs is really the only one can benefit from this feature? Thanks, Qu 在 2024/7/10 10:37, Qu Wenruo 写道: > Recently I'm hitting soft lockup if adding an order 2 folio to a > filemap using GFP_NOFS | __GFP_NOFAIL. The softlockup happens at memcg > charge code, and I guess that's exactly what __GFP_NOFAIL is expected to > do, wait indefinitely until the request can be met. > > On the other hand, if we do not use __GFP_NOFAIL, we can be limited by > memcg at a lot of critical location, and lead to unnecessary transaction > abort just due to memcg limit. > > However for that specific btrfs call site, there is really no need charge > the memcg, as that address space belongs to btree inode, which is not > accessible to any end user, and that btree inode is a shared pool for > all metadata of a btrfs. > > So this patchset introduces a new address space flag, AS_NO_MEMCG, so > that folios added to that address space will not trigger any memcg > charge. > > This would be the basis for future btrfs changes, like removing > __GFP_NOFAIL completely and larger metadata folios. > > Qu Wenruo (2): > mm: make lru_gen_eviction() to handle folios without memcg info > mm: allow certain address space to be not accounted by memcg > > fs/btrfs/disk-io.c | 1 + > include/linux/pagemap.h | 1 + > mm/filemap.c | 12 +++++++++--- > mm/workingset.c | 2 +- > 4 files changed, 12 insertions(+), 4 deletions(-) >