From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 43228C02192 for ; Fri, 7 Feb 2025 07:07:00 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id AD9CC6B007B; Fri, 7 Feb 2025 02:06:59 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id A62BE6B0082; Fri, 7 Feb 2025 02:06:59 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 8DC176B0083; Fri, 7 Feb 2025 02:06:59 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id 6EFAA6B007B for ; Fri, 7 Feb 2025 02:06:59 -0500 (EST) Received: from smtpin22.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id 0DCF1141711 for ; Fri, 7 Feb 2025 07:06:59 +0000 (UTC) X-FDA: 83092266558.22.73A4E8E Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.223.130]) by imf20.hostedemail.com (Postfix) with ESMTP id B77AD1C000F for ; Fri, 7 Feb 2025 07:06:56 +0000 (UTC) Authentication-Results: imf20.hostedemail.com; dkim=pass header.d=suse.de header.s=susede2_rsa header.b=0wD4kP13; dkim=pass header.d=suse.de header.s=susede2_ed25519 header.b=i+TUYHyh; dkim=pass header.d=suse.de header.s=susede2_rsa header.b=0wD4kP13; dkim=pass header.d=suse.de header.s=susede2_ed25519 header.b=i+TUYHyh; spf=pass (imf20.hostedemail.com: domain of hare@suse.de designates 195.135.223.130 as permitted sender) smtp.mailfrom=hare@suse.de; dmarc=pass (policy=none) header.from=suse.de ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1738912017; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=OeAq5WgyNpyXwAYWhu2LEmnw14pRolj6vTmiCshrrJc=; b=fSvBOYPmDVZNAiwPEFScH3N07PtfIJAR79xISj9vN5Z01/uC/nZnTGQmplJDwFuKDvPQsx 0cwZG18KLM+tz+bL9hl7cJLWMP6ceohcp6fX9qGYIKvpZX5LfvT2vu1Z3FKj8RKXW4Nxuo wnLBzN5HW0ueT7M2AaWqb2RclbQbjTI= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1738912017; a=rsa-sha256; cv=none; b=mw3xXHyzgREqiK5BwqJyJ7x4vL5PD0EzSEvI6MBFr6rcKflZHcBszciarlpQt5XoHGpLMC Cy9SZjWjaSVJ5SfnpO6+5NOBIcgjEvR8LlrHEbql5wpleBeTeKBKe7YRxnchTTkZiHtH2B DyA7OwW6caEjynr1mfU5SYcwWDdJ/p0= ARC-Authentication-Results: i=1; imf20.hostedemail.com; dkim=pass header.d=suse.de header.s=susede2_rsa header.b=0wD4kP13; dkim=pass header.d=suse.de header.s=susede2_ed25519 header.b=i+TUYHyh; dkim=pass header.d=suse.de header.s=susede2_rsa header.b=0wD4kP13; dkim=pass header.d=suse.de header.s=susede2_ed25519 header.b=i+TUYHyh; spf=pass (imf20.hostedemail.com: domain of hare@suse.de designates 195.135.223.130 as permitted sender) smtp.mailfrom=hare@suse.de; dmarc=pass (policy=none) header.from=suse.de Received: from imap1.dmz-prg2.suse.org (imap1.dmz-prg2.suse.org [IPv6:2a07:de40:b281:104:10:150:64:97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id 093BC21161; Fri, 7 Feb 2025 07:06:55 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1738912015; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=OeAq5WgyNpyXwAYWhu2LEmnw14pRolj6vTmiCshrrJc=; b=0wD4kP13iqwgArOJELuH1Ygp0UJE6Wd6D7uvETz+xk8HvGU+DjZwvQxZQT5IOswgU8UcNB Rey1Ip5OyUaYDEUNEmLIlHjwj0frXoRqGbTXuYoOvTOvhZAuV9WRhXd1AUdFc2Rofn92d5 FCe7+YQgJI5ZWnoMnWz6whGAd+ZzHFo= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1738912015; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=OeAq5WgyNpyXwAYWhu2LEmnw14pRolj6vTmiCshrrJc=; b=i+TUYHyhDlYBLPTohEUtbfKzC1eQGJPcA3lRwwsfgCvs/Aw3k4kArXPZchvKzCOK2MoEAB wHjrqeXgwwZy04AQ== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1738912015; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=OeAq5WgyNpyXwAYWhu2LEmnw14pRolj6vTmiCshrrJc=; b=0wD4kP13iqwgArOJELuH1Ygp0UJE6Wd6D7uvETz+xk8HvGU+DjZwvQxZQT5IOswgU8UcNB Rey1Ip5OyUaYDEUNEmLIlHjwj0frXoRqGbTXuYoOvTOvhZAuV9WRhXd1AUdFc2Rofn92d5 FCe7+YQgJI5ZWnoMnWz6whGAd+ZzHFo= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1738912015; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=OeAq5WgyNpyXwAYWhu2LEmnw14pRolj6vTmiCshrrJc=; b=i+TUYHyhDlYBLPTohEUtbfKzC1eQGJPcA3lRwwsfgCvs/Aw3k4kArXPZchvKzCOK2MoEAB wHjrqeXgwwZy04AQ== Received: from imap1.dmz-prg2.suse.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by imap1.dmz-prg2.suse.org (Postfix) with ESMTPS id 6F7AE13694; Fri, 7 Feb 2025 07:06:54 +0000 (UTC) Received: from dovecot-director2.suse.de ([2a07:de40:b281:106:10:150:64:167]) by imap1.dmz-prg2.suse.org with ESMTPSA id SAMhGQ6xpWf+MgAAD6G6ig (envelope-from ); Fri, 07 Feb 2025 07:06:54 +0000 Message-ID: Date: Fri, 7 Feb 2025 08:06:54 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2 1/8] fs/buffer: simplify block_read_full_folio() with bh_offset() To: Luis Chamberlain Cc: Matthew Wilcox , dave@stgolabs.net, david@fromorbit.com, djwong@kernel.org, kbusch@kernel.org, john.g.garry@oracle.com, hch@lst.de, ritesh.list@gmail.com, linux-fsdevel@vger.kernel.org, linux-xfs@vger.kernel.org, linux-mm@kvack.org, linux-block@vger.kernel.org, gost.dev@samsung.com, p.raghav@samsung.com, da.gomez@samsung.com, kernel@pankajraghav.com References: <20250204231209.429356-1-mcgrof@kernel.org> <20250204231209.429356-2-mcgrof@kernel.org> <1b211dd3-a45d-4a2e-aa2a-e0d3e302d4ca@suse.de> <13223185-5c5e-4c52-b7ab-00155b5ebd86@suse.de> Content-Language: en-US From: Hannes Reinecke In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-Rspamd-Action: no action X-Rspam-User: X-Rspamd-Queue-Id: B77AD1C000F X-Rspamd-Server: rspam07 X-Stat-Signature: fktzgcofd6dcdkiis33zddu7cx96ptcn X-HE-Tag: 1738912016-946703 X-HE-Meta: U2FsdGVkX1/Nby2ESNr0Xlf1VbhkRCB3C9V5+tPAQALZvvk5UWSPO+cn2MAkC1I8LD+Ne5elUrB1QIj9FkbCAceFp5eJ9vX994imIu0ghggrBG5XkdPrJKn1kw0yDopRs8YWEMndaAqjUeAtLZ213+TcAx8oUyslopdEBqxPicUgpMMuBohpAOgZM1oNmzYuTUtq3ZlLhcc+TPnh+3tzAl6qm9eEWj/S4Chwa4OSoRFqOkcN4TnuM4nEDf3Tg/WdIuX8SgZ+CTALZ7s9x2OAva9tUV9r/9oDGmYg7EZjfLdzhf12nL2ROQYoBRfeZ4GTBMhEAGr5ZoY6IjAds9oue4SX+eqEIlj0m3DQybl74GASqERHD4gvqlmHcHwwwbRvDbxd8JW80vHngYbpPLzMh2iHSW07eoju5FWHxZs8AiTw+Iil29CNLBSRo1lxZb4pPNV1z3Ewb6Z7/rfiKh50ZD94j/6xz7oUrzz1zzyCI8sYMjsPk9OaDgr7H2tp/djrMtc5WV4GRE0eumEX/N48tAmlBz1BBRKkEP/42XFJ/jJ7dq5WNk9iGEg01VfWg/nw/GtxgZ1OIPNJexs7/v0eoez4ZX0SN+bD9j+7ZIW/ZywwAwIxUFdYUBlXTzTqOL9FA4ARTXP+OkLatf4RgDOF/4USsLv17xQJ5S6T/E0I9B0Z8P76E6vHp69OSiZul7b1C1ajVqQqm79F8/IA+jU0ivZxB0v7pytI3/FwV3SR39K8MJjMz9yWRssqiWNisJeF6l8tU7HxmXsZrhYv9Cuo1PjWIcgP0ntrp6R+L+rx9e/ICUumtA5CGBwcgCGufpMqRiSpq/jdbYGDodjXHOiflpwyhUODUvthMd5HCTxrmwUz3DuvVMfdczR/YR9V5RB3tWZbHkBpoCNcNMxa9/3zmDi1oFUEdrGZk4IOa5NKMX/1Vji9dOkYaZV+0oaZzsNoIk55IwkX2WHkj57lvdn owPcpJPR bkmK9mdd0pi3hi5C5jXwYWldONeIhie/DzLikWTe6OhJPaiDze4D8Duu2LvFpIkY1dP4J5NeMkgWD2Bv2Og3mkAmALoC545Y09oz25B0Z3A+o9zXqA0vGf311Ewvy4riU2/iFxDRbiwH6rWJM/HJ8mUarHx2QZpqLmzfoP04P8ik3+3ss8xlk4Cn44+btkGcw1jpBm/MCRPxJn45ozyAwMKXsWsL1sTVycuKVOK2aMwWrQb+dbg9gXcjNz9aR5pzEaLSSjODxI0ZT+pxpNXjtGaOAZEGbmMQxPc4cN2R1ex6dAjnKHXchv+GTusjVYd06dVmfRiUAZ5AjoytsYMD0B3RbM0EMxn1y5vJPFdFbF5O+TCK+l2P3QR7NSqK9bmzK2q0MMpNA/zd1sNwieox1WLAB46U1pVfyaG4CwrIPnzxxB9z5lKi+pxVySJNMfNLZR8oUIBg/LvsMFSc= X-Bogosity: Ham, tests=bogofilter, spamicity=0.003992, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 2/6/25 18:30, Luis Chamberlain wrote: > On Thu, Feb 06, 2025 at 08:17:32AM +0100, Hannes Reinecke wrote: >> On 2/5/25 23:03, Matthew Wilcox wrote: >>> On Wed, Feb 05, 2025 at 05:18:20PM +0100, Hannes Reinecke wrote: >>>> One wonders: shouldn't we use plugging here to make I/O more efficient? >>> >>> Should we plug at a higher level? >>> >>> Opposite question: What if getblk() needs to do a read (ie ext2 indirect >>> block)? >> >> Ah, that. Yes, plugging on higher level would be a good idea. >> (And can we check for nested plugs? _Should_ we check for nested plugs?) > > I think given the discussion less is more for now, and if we really want > this we can add it later. Thoughts? > Yeah, go for it. Reviewed-by: Hannes Reinecke Cheers, Hannes -- Dr. Hannes Reinecke Kernel Storage Architect hare@suse.de +49 911 74053 688 SUSE Software Solutions GmbH, Frankenstr. 146, 90461 Nürnberg HRB 36809 (AG Nürnberg), GF: I. Totev, A. McDonald, W. Knoblich