From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-1.0 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 146EEC10F03 for ; Thu, 7 Mar 2019 19:27:48 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id B7B9520854 for ; Thu, 7 Mar 2019 19:27:47 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org B7B9520854 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 51B078E0003; Thu, 7 Mar 2019 14:27:47 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 4CA828E0002; Thu, 7 Mar 2019 14:27:47 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 392AC8E0003; Thu, 7 Mar 2019 14:27:47 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from mail-qt1-f200.google.com (mail-qt1-f200.google.com [209.85.160.200]) by kanga.kvack.org (Postfix) with ESMTP id 0A4408E0002 for ; Thu, 7 Mar 2019 14:27:47 -0500 (EST) Received: by mail-qt1-f200.google.com with SMTP id j22so16161962qtq.21 for ; Thu, 07 Mar 2019 11:27:47 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-original-authentication-results:x-gm-message-state:subject:to:cc :references:from:openpgp:autocrypt:organization:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=yjNMZ9a7DNrtERJxiBJjgVPfNo6z/lHXX+XJ4t29lU8=; b=jn8PgaMbCsrkLSKMCjQQh/rzZwQ/Ajv5pcBu9eeGZVDAaXQtSdGkGO7YcXzRoW4r7N MwtjJIomBGlAVSlUcDU5Nyfyhx01eiMtDE9q/iIVXWh9Xs1j3Qm2QxrcoD3VOXzYLvmr PlVxphmTvmg6OPDCbNsUEg9nISgBJK1nNsKGlK/Q68iTwyVU/VW9lm/gpKzmo8DO++Mu DGQFmVCfLXNfoGs+wT7wBUdm+20qkGUzpDNPmONFFf9bRifeFhGbT3YOpwOl6ILaYilx T1AyHZv0SkLeeTgL20DbcEkP+XzmMjxgV7u5KmTx456j76eOuhnMySP+mmM0z2k9z61k Muaw== X-Original-Authentication-Results: mx.google.com; spf=pass (google.com: domain of david@redhat.com designates 209.132.183.28 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=redhat.com X-Gm-Message-State: APjAAAX0iwRLclkAsmcPHVONn2SzTjXz6Mb9qUgLF1NuUf6Ma0CQDKf5 c2ttFFqGg7TcUK8M8FqLGBx5uYJ7S5vlNEPy7QCxJ50xUzfPfChYmWGYWT/hTIr1kWSMuxo7y81 G9ltG42hYfXpGoxOfNJXFtN2MWBjFBTD8uLqY/te5VJKu9jLX6ZJUapdrt3Ssj6xTdg== X-Received: by 2002:a37:8586:: with SMTP id h128mr11483351qkd.322.1551986866817; Thu, 07 Mar 2019 11:27:46 -0800 (PST) X-Google-Smtp-Source: APXvYqz+oHeKHYCneOB/v3sCiZ135IVFoRT7UH08O+ty1aSnY+Bp8ZnIf6VPvrA54NivnfNaRREb X-Received: by 2002:a37:8586:: with SMTP id h128mr11483308qkd.322.1551986865958; Thu, 07 Mar 2019 11:27:45 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1551986865; cv=none; d=google.com; s=arc-20160816; b=YZ71fFzIfjYONz42RaVGJjhqzy5Czo6VXlDaoFiOAyp1Uvl/w/CsqzwmGcA0MlS7Ip yGva+WDxss1rIDIkvb3cj0opKvLAromlu6e0L1kE+GMfPvGkHomOLkHAZZYXRfgQ/6TA B1bQ+yMloz/UQsnJKhIWw0rzNXynhxW2ghgdcreSnRMtvHB30aTjaGbIzCg6DRA5bJcn ssiQwmeZ4hmR+XUuaUCbd0Nm0riuh345Ng8WnO/5MDUiWa6Zso87Gbioon6/EVAcfREI hSQOPwjKiw6WknmwW/zu6g5WaHBGFq2wskLlW80/K/LoUsGp9hMiU4/vnklk42fK1Qjq idKQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:content-language:in-reply-to:mime-version :user-agent:date:message-id:organization:autocrypt:openpgp:from :references:cc:to:subject; bh=yjNMZ9a7DNrtERJxiBJjgVPfNo6z/lHXX+XJ4t29lU8=; b=0sjoDsPj8TW9WQg+Pej+va1XwgV/Uh/GB0PfvsXrqdP7w2ebLeZQfaXIN/aWBGtCSl rUh+5ErtHoJ8Hka5g25Ysdk3/B3bCUKl3O+AyMKgZD6hyQD0gL4tWHkq4rJH5sypr0Vt xA8Pe95QOkHp773P5gRm0o91tUwaHMIFoocQvBpQNH1i5jncYLxs2Qp8xukG0pcOj29X 030wupR2J0f/JetEMLS8ptHldkZs6YhAAe//rHYhHYyf13mwpoyKJIreRQrK6oN4NsLz wZlWh24eiO30iCvSwB+kLlkKgFXOonLesTYw8HJ4ODcD3f29UuRzAcUaafyDiHSV5ns1 29Wg== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of david@redhat.com designates 209.132.183.28 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=redhat.com Received: from mx1.redhat.com (mx1.redhat.com. [209.132.183.28]) by mx.google.com with ESMTPS id e7si2165522qkb.189.2019.03.07.11.27.45 for (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Thu, 07 Mar 2019 11:27:45 -0800 (PST) Received-SPF: pass (google.com: domain of david@redhat.com designates 209.132.183.28 as permitted sender) client-ip=209.132.183.28; Authentication-Results: mx.google.com; spf=pass (google.com: domain of david@redhat.com designates 209.132.183.28 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=redhat.com Received: from smtp.corp.redhat.com (int-mx06.intmail.prod.int.phx2.redhat.com [10.5.11.16]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 1F98A8762B; Thu, 7 Mar 2019 19:27:45 +0000 (UTC) Received: from [10.36.116.67] (ovpn-116-67.ams2.redhat.com [10.36.116.67]) by smtp.corp.redhat.com (Postfix) with ESMTP id E08A35C646; Thu, 7 Mar 2019 19:27:32 +0000 (UTC) Subject: Re: [RFC][Patch v9 0/6] KVM: Guest Free Page Hinting To: "Michael S. Tsirkin" , Alexander Duyck Cc: Nitesh Narayan Lal , kvm list , LKML , linux-mm , Paolo Bonzini , lcapitulino@redhat.com, pagupta@redhat.com, wei.w.wang@intel.com, Yang Zhang , Rik van Riel , dodgen@google.com, Konrad Rzeszutek Wilk , dhildenb@redhat.com, Andrea Arcangeli References: <20190306155048.12868-1-nitesh@redhat.com> <1d5e27dc-aade-1be7-2076-b7710fa513b6@redhat.com> <2269c59c-968c-bbff-34c4-1041a2b1898a@redhat.com> <20190307134744-mutt-send-email-mst@kernel.org> From: David Hildenbrand Openpgp: preference=signencrypt Autocrypt: addr=david@redhat.com; prefer-encrypt=mutual; keydata= xsFNBFXLn5EBEAC+zYvAFJxCBY9Tr1xZgcESmxVNI/0ffzE/ZQOiHJl6mGkmA1R7/uUpiCjJ dBrn+lhhOYjjNefFQou6478faXE6o2AhmebqT4KiQoUQFV4R7y1KMEKoSyy8hQaK1umALTdL QZLQMzNE74ap+GDK0wnacPQFpcG1AE9RMq3aeErY5tujekBS32jfC/7AnH7I0v1v1TbbK3Gp XNeiN4QroO+5qaSr0ID2sz5jtBLRb15RMre27E1ImpaIv2Jw8NJgW0k/D1RyKCwaTsgRdwuK Kx/Y91XuSBdz0uOyU/S8kM1+ag0wvsGlpBVxRR/xw/E8M7TEwuCZQArqqTCmkG6HGcXFT0V9 PXFNNgV5jXMQRwU0O/ztJIQqsE5LsUomE//bLwzj9IVsaQpKDqW6TAPjcdBDPLHvriq7kGjt WhVhdl0qEYB8lkBEU7V2Yb+SYhmhpDrti9Fq1EsmhiHSkxJcGREoMK/63r9WLZYI3+4W2rAc UucZa4OT27U5ZISjNg3Ev0rxU5UH2/pT4wJCfxwocmqaRr6UYmrtZmND89X0KigoFD/XSeVv jwBRNjPAubK9/k5NoRrYqztM9W6sJqrH8+UWZ1Idd/DdmogJh0gNC0+N42Za9yBRURfIdKSb B3JfpUqcWwE7vUaYrHG1nw54pLUoPG6sAA7Mehl3nd4pZUALHwARAQABzSREYXZpZCBIaWxk ZW5icmFuZCA8ZGF2aWRAcmVkaGF0LmNvbT7CwX4EEwECACgFAljj9eoCGwMFCQlmAYAGCwkI BwMCBhUIAgkKCwQWAgMBAh4BAheAAAoJEE3eEPcA/4Na5IIP/3T/FIQMxIfNzZshIq687qgG 8UbspuE/YSUDdv7r5szYTK6KPTlqN8NAcSfheywbuYD9A4ZeSBWD3/NAVUdrCaRP2IvFyELj xoMvfJccbq45BxzgEspg/bVahNbyuBpLBVjVWwRtFCUEXkyazksSv8pdTMAs9IucChvFmmq3 jJ2vlaz9lYt/lxN246fIVceckPMiUveimngvXZw21VOAhfQ+/sofXF8JCFv2mFcBDoa7eYob s0FLpmqFaeNRHAlzMWgSsP80qx5nWWEvRLdKWi533N2vC/EyunN3HcBwVrXH4hxRBMco3jvM m8VKLKao9wKj82qSivUnkPIwsAGNPdFoPbgghCQiBjBe6A75Z2xHFrzo7t1jg7nQfIyNC7ez MZBJ59sqA9EDMEJPlLNIeJmqslXPjmMFnE7Mby/+335WJYDulsRybN+W5rLT5aMvhC6x6POK z55fMNKrMASCzBJum2Fwjf/VnuGRYkhKCqqZ8gJ3OvmR50tInDV2jZ1DQgc3i550T5JDpToh dPBxZocIhzg+MBSRDXcJmHOx/7nQm3iQ6iLuwmXsRC6f5FbFefk9EjuTKcLMvBsEx+2DEx0E UnmJ4hVg7u1PQ+2Oy+Lh/opK/BDiqlQ8Pz2jiXv5xkECvr/3Sv59hlOCZMOaiLTTjtOIU7Tq 7ut6OL64oAq+zsFNBFXLn5EBEADn1959INH2cwYJv0tsxf5MUCghCj/CA/lc/LMthqQ773ga uB9mN+F1rE9cyyXb6jyOGn+GUjMbnq1o121Vm0+neKHUCBtHyseBfDXHA6m4B3mUTWo13nid 0e4AM71r0DS8+KYh6zvweLX/LL5kQS9GQeT+QNroXcC1NzWbitts6TZ+IrPOwT1hfB4WNC+X 2n4AzDqp3+ILiVST2DT4VBc11Gz6jijpC/KI5Al8ZDhRwG47LUiuQmt3yqrmN63V9wzaPhC+ xbwIsNZlLUvuRnmBPkTJwwrFRZvwu5GPHNndBjVpAfaSTOfppyKBTccu2AXJXWAE1Xjh6GOC 8mlFjZwLxWFqdPHR1n2aPVgoiTLk34LR/bXO+e0GpzFXT7enwyvFFFyAS0Nk1q/7EChPcbRb hJqEBpRNZemxmg55zC3GLvgLKd5A09MOM2BrMea+l0FUR+PuTenh2YmnmLRTro6eZ/qYwWkC u8FFIw4pT0OUDMyLgi+GI1aMpVogTZJ70FgV0pUAlpmrzk/bLbRkF3TwgucpyPtcpmQtTkWS gDS50QG9DR/1As3LLLcNkwJBZzBG6PWbvcOyrwMQUF1nl4SSPV0LLH63+BrrHasfJzxKXzqg rW28CTAE2x8qi7e/6M/+XXhrsMYG+uaViM7n2je3qKe7ofum3s4vq7oFCPsOgwARAQABwsFl BBgBAgAPBQJVy5+RAhsMBQkJZgGAAAoJEE3eEPcA/4NagOsP/jPoIBb/iXVbM+fmSHOjEshl KMwEl/m5iLj3iHnHPVLBUWrXPdS7iQijJA/VLxjnFknhaS60hkUNWexDMxVVP/6lbOrs4bDZ NEWDMktAeqJaFtxackPszlcpRVkAs6Msn9tu8hlvB517pyUgvuD7ZS9gGOMmYwFQDyytpepo YApVV00P0u3AaE0Cj/o71STqGJKZxcVhPaZ+LR+UCBZOyKfEyq+ZN311VpOJZ1IvTExf+S/5 lqnciDtbO3I4Wq0ArLX1gs1q1XlXLaVaA3yVqeC8E7kOchDNinD3hJS4OX0e1gdsx/e6COvy qNg5aL5n0Kl4fcVqM0LdIhsubVs4eiNCa5XMSYpXmVi3HAuFyg9dN+x8thSwI836FoMASwOl C7tHsTjnSGufB+D7F7ZBT61BffNBBIm1KdMxcxqLUVXpBQHHlGkbwI+3Ye+nE6HmZH7IwLwV W+Ajl7oYF+jeKaH4DZFtgLYGLtZ1LDwKPjX7VAsa4Yx7S5+EBAaZGxK510MjIx6SGrZWBrrV TEvdV00F2MnQoeXKzD7O4WFbL55hhyGgfWTHwZ457iN9SgYi1JLPqWkZB0JRXIEtjd4JEQcx +8Umfre0Xt4713VxMygW0PnQt5aSQdMD58jHFxTk092mU+yIHj5LeYgvwSgZN4airXk5yRXl SE+xAvmumFBY Organization: Red Hat GmbH Message-ID: Date: Thu, 7 Mar 2019 20:27:32 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.4.0 MIME-Version: 1.0 In-Reply-To: <20190307134744-mutt-send-email-mst@kernel.org> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit X-Scanned-By: MIMEDefang 2.79 on 10.5.11.16 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.26]); Thu, 07 Mar 2019 19:27:45 +0000 (UTC) X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 07.03.19 19:53, Michael S. Tsirkin wrote: > On Thu, Mar 07, 2019 at 10:45:58AM -0800, Alexander Duyck wrote: >> To that end what I think w may want to do is instead just walk the LRU >> list for a given zone/order in reverse order so that we can try to >> identify the pages that are most likely to be cold and unused and >> those are the first ones we want to be hinting on rather than the ones >> that were just freed. If we can look at doing something like adding a >> jiffies value to the page indicating when it was last freed we could >> even have a good point for determining when we should stop processing >> pages in a given zone/order list. >> >> In reality the approach wouldn't be too different from what you are >> doing now, the only real difference would be that we would just want >> to walk the LRU list for the given zone/order rather then pulling >> hints on what to free from the calls to free_one_page. In addition we >> would need to add a couple bits to indicate if the page has been >> hinted on, is in the middle of getting hinted on, and something such >> as the jiffies value I mentioned which we could use to determine how >> old the page is. > > Do we really need bits in the page? > Would it be bad to just have a separate hint list? > > If you run out of free memory you can check the hint > list, if you find stuff there you can spin > or kick the hypervisor to hurry up. > > Core mm/ changes, so nothing's easy, I know. We evaluated the idea of busy spinning on some bit/list entry a while ago. While it sounds interesting, it is usually not what we want and has other negative performance impacts. Talking about "marking" pages, what we actually would want is to rework the buddy to skip over these "marked" pages and only really spin in case there are no other pages left. Allocation paths should only ever be blocked if OOM, not if just some hinting activity is going on on another VCPU. However as you correctly say: "core mm changes". New page flag? Basically impossible. Reuse another one? Can easily get horrbily confusing and can easily get rejected upstream. What about the buddy wanting to merge pages that are marked (assuming we also want something < MAX_ORDER - 1)? This smells like possibly heavy core mm changes. Lesson learned: Avoid such heavy changes. Especially in the first shot. The interesting thing about Nitesh's aproach right now is that we can easily rework these details later on. The host->guest interface will stay the same. Instead of temporarily taking pages out of the buddy, we could e.g. mark them and make the buddy or other users skip over them. -- Thanks, David / dhildenb