From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6EA9CC83F1B for ; Wed, 16 Jul 2025 06:11:40 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id C505F6B008C; Wed, 16 Jul 2025 02:11:39 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id C289C6B0092; Wed, 16 Jul 2025 02:11:39 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id B3E0B6B0093; Wed, 16 Jul 2025 02:11:39 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id A53E56B008C for ; Wed, 16 Jul 2025 02:11:39 -0400 (EDT) Received: from smtpin04.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay05.hostedemail.com (Postfix) with ESMTP id 3FFD058334 for ; Wed, 16 Jul 2025 06:11:39 +0000 (UTC) X-FDA: 83669106318.04.F17B924 Received: from mgamail.intel.com (mgamail.intel.com [192.198.163.7]) by imf29.hostedemail.com (Postfix) with ESMTP id 08C66120007 for ; Wed, 16 Jul 2025 06:11:35 +0000 (UTC) Authentication-Results: imf29.hostedemail.com; dkim=pass header.d=intel.com header.s=Intel header.b=T0ykiRQU; spf=pass (imf29.hostedemail.com: domain of xiaoyao.li@intel.com designates 192.198.163.7 as permitted sender) smtp.mailfrom=xiaoyao.li@intel.com; dmarc=pass (policy=none) header.from=intel.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1752646297; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=i+YgfA5e2EvZx098zCWOQnK7cuAUCR8e0qOfU563P58=; b=RLoN03UZymZvFCHOJl1CbvOFxL3JmaS5yD9bKpnc+lbqvpluf/Fc7etFJHjxFdSrPalfZu 89S4sEWi859HHE+jWcbGlT4w7KnIwe7TAtew3FznXAAhdTNiIojWK7sWXLjsFB8rgM/dSG tnjBiLnwMwcwx9aOSbnRTYZWMUPTOl8= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1752646297; a=rsa-sha256; cv=none; b=Xk5b7CLLlfDhDJlOh81K2XtiqACP/y5nr59lYCMoloG7JAnhVhXS9ooNs65vJwjNSFoCCx 6lrYSzqwHTe/SRLcUer65gZOoC8NAtIy1nOfv06dP8rM6s6im0JKpQlgdd60T6khHv1+CX NcD4aIV5/tQMmRAJsMVjkt7hZsH5NRo= ARC-Authentication-Results: i=1; imf29.hostedemail.com; dkim=pass header.d=intel.com header.s=Intel header.b=T0ykiRQU; spf=pass (imf29.hostedemail.com: domain of xiaoyao.li@intel.com designates 192.198.163.7 as permitted sender) smtp.mailfrom=xiaoyao.li@intel.com; dmarc=pass (policy=none) header.from=intel.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1752646296; x=1784182296; h=message-id:date:mime-version:subject:to:cc:references: from:in-reply-to:content-transfer-encoding; bh=c6u/3ojwb9CcAkBXSLSNnkBgcofV6SgyFH8EacCPr78=; b=T0ykiRQUohAPHUG9Zn8/TwJtiGMKP/jb83670CYBV/yguF/B8Xk81nKG HqVh+NBOlQCtWZ99cOWrMPYRIuS7zqdOK7GgXw+uy1oCpJO26zfcvn5Vz FTvSCc+5iAkjLl8NNLLkj8UXaUtRNj8CzGWoCFxt8O2zymkgq3g3BVcIP gDSeqdA1Ouq/YoHdXjM52FfIY6pWYdVhYk82P7W4octfPhBn9TVY3v4pL fWuFu/HLUuZ+xCqvPfrB0nGUaHb1kdFXxlDStBkAbaji5XDvazQU6k4zS cXVem5mriREFZKbz5Z1ZDdmbOq1ExKgfaZnIVXo0Tm6Rdj3LLKJohpJIz Q==; X-CSE-ConnectionGUID: 77lh65uFRaW3x1o04g5JAw== X-CSE-MsgGUID: NC8qF8HHS7yG4xcEpDQ7fQ== X-IronPort-AV: E=McAfee;i="6800,10657,11493"; a="80329676" X-IronPort-AV: E=Sophos;i="6.16,315,1744095600"; d="scan'208";a="80329676" Received: from orviesa002.jf.intel.com ([10.64.159.142]) by fmvoesa101.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 15 Jul 2025 23:11:24 -0700 X-CSE-ConnectionGUID: jZPozQdBTsOjGre4uRsADw== X-CSE-MsgGUID: jcMR3HMmTvCVSp7FSE7gIQ== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.16,315,1744095600"; d="scan'208";a="188386724" Received: from xiaoyaol-hp-g830.ccr.corp.intel.com (HELO [10.124.247.1]) ([10.124.247.1]) by orviesa002-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 15 Jul 2025 23:10:59 -0700 Message-ID: Date: Wed, 16 Jul 2025 14:10:56 +0800 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v14 09/21] KVM: guest_memfd: Track guest_memfd mmap support in memslot To: Fuad Tabba , kvm@vger.kernel.org, linux-arm-msm@vger.kernel.org, linux-mm@kvack.org, kvmarm@lists.linux.dev Cc: pbonzini@redhat.com, chenhuacai@kernel.org, mpe@ellerman.id.au, anup@brainfault.org, paul.walmsley@sifive.com, palmer@dabbelt.com, aou@eecs.berkeley.edu, seanjc@google.com, viro@zeniv.linux.org.uk, brauner@kernel.org, willy@infradead.org, akpm@linux-foundation.org, yilun.xu@intel.com, chao.p.peng@linux.intel.com, jarkko@kernel.org, amoorthy@google.com, dmatlack@google.com, isaku.yamahata@intel.com, mic@digikod.net, vbabka@suse.cz, vannapurve@google.com, ackerleytng@google.com, mail@maciej.szmigiero.name, david@redhat.com, michael.roth@amd.com, wei.w.wang@intel.com, liam.merwick@oracle.com, isaku.yamahata@gmail.com, kirill.shutemov@linux.intel.com, suzuki.poulose@arm.com, steven.price@arm.com, quic_eberman@quicinc.com, quic_mnalajal@quicinc.com, quic_tsoni@quicinc.com, quic_svaddagi@quicinc.com, quic_cvanscha@quicinc.com, quic_pderrin@quicinc.com, quic_pheragu@quicinc.com, catalin.marinas@arm.com, james.morse@arm.com, yuzenghui@huawei.com, oliver.upton@linux.dev, maz@kernel.org, will@kernel.org, qperret@google.com, keirf@google.com, roypat@amazon.co.uk, shuah@kernel.org, hch@infradead.org, jgg@nvidia.com, rientjes@google.com, jhubbard@nvidia.com, fvdl@google.com, hughd@google.com, jthoughton@google.com, peterx@redhat.com, pankaj.gupta@amd.com, ira.weiny@intel.com References: <20250715093350.2584932-1-tabba@google.com> <20250715093350.2584932-10-tabba@google.com> Content-Language: en-US From: Xiaoyao Li In-Reply-To: <20250715093350.2584932-10-tabba@google.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Rspamd-Queue-Id: 08C66120007 X-Rspam-User: X-Rspamd-Server: rspam09 X-Stat-Signature: ig1tpeitg73xqwr7fm9q8pxrsma8cg9y X-HE-Tag: 1752646295-439699 X-HE-Meta: U2FsdGVkX1+FC7UjJHpl1hj0mdEO1dD/KxG0fAnuxkLeTvFETQUWr9t3m1BhTLRuHI6+BcqQpr35Ef9cBl14FU3mRwbt4VOvnz2/VsqY0nVohiLuuMvRfbjKPMVhKAJj92pqD1Mj2B0S2HuY1jMEZWvATas7MooSbBNZ1Wirao9Nxwu0tns7xiBZKyijFePXkUeZpptbx0c0o8VqByJ/qA0+E4TKD3nQzHt7FPQHh+77F8C1UQL3d/b6DgJxVMSqduguPXiA0V+II9L+La2aYnTYGQckRb/qMsH0ZjsPyC5gBIejFpHDVXci2R+QedhXZLOZm0793iiU94Bf41OW5jm8MkZFLLSFgowRv8rhLdIcsC776029UyTkYrpuVyrD9ZRbqOnc7MGTHHD/hv6yyLjsSm8GiVbbHyo30gR6hSmLyPMFyp0/3fBHIeQ0cQDEGc1Pm/ChxG/z8hmCOzgPrgQBB9+uj5vmCXyhod5eCYda1SMFaiLwxeeJDAIhUGVNwqC8QX2xdJXUASMZBIJVozoR/r2QbGL8woL9BwK8sshWSVy5DYhJIm882z1lhqE8z4KPzr/4rAFB47CVpyL9Q9W5DUPAcEylvAE5mG/t9271vlZ38s6DSqoalr3JfpsNah/ZM8UaGu7y2iNPg7PYvNWY6BiwNBu7zGeZdSDvCQskElPyePT6RpbuTGWNDE+SHnDiGGot7MyAX+IV1Iyej5hYXm4adtTBX9HTJvQKjVzMbDxAainBj7pAyAM5HuI5HDGWBfHi2xdKGCP4ep3GXmAwSUoMKH1uGLLgwZHDNaPBPoTQTJCKKp6RYCw8Nd/halRpo8dsgnaaim4fJRwjXY8c46gb1rHETwT7vlca6/uGmRjGN6MDIEc5OqhUXnFFC5ttlPbFREnotj709xD6G9+P9T4AF6HdTMF2jqgtskwaVCIAlWSedoyfMxWAVbcWju+Ctp8B20u7C61Gv8U OKQPqftD P35RGp7iqggcPAT9d+M9IM0p3Ul3j1WId9Gtw64qWIYOBAY/+k73bHs9jCnPqb4Tp/zGCOPCN5yzyfgTW67xvFHouxfMEuKzuhTq4kkaJypdF/HIQdwkO2tG6lgB2Tmw80FtZJEpoh3LowYmGsiScSpsvDuO4zY1n0e+NrVSH5HYeYN1RosKQ+EEfYCotOKUOv3tk8vHyouJQwlLlm/YrcK5YnKGUUXhn2WEbAkf2jn0/CrwJzR7AcNg6wUQq7ROx3PwkW5WDd4hDB4Ee2EMljtNsJdvT28gqN6rwi/5cTW7pXcu9QoJJhJVsHBHvnygTeeKaugTxXM8iiWBPOEDSCojA7wF/jMLGv0z6zi1Hc3ygcp2bbAze+VFJuQ== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 7/15/2025 5:33 PM, Fuad Tabba wrote: > Add a new internal flag, KVM_MEMSLOT_GMEM_ONLY, to the top half of > memslot->flags. This flag tracks when a guest_memfd-backed memory slot > supports host userspace mmap operations. It's strictly for KVM's > internal use. I would expect some clarification of why naming it with KVM_MEMSLOT_GMEM_ONLY, not something like KVM_MEMSLOT_GMEM_MMAP_ENABLED There was a patch to check the userspace_addr of the memslot refers to the same memory as guest memfd[1], but that patch was dropped. Without the background that when guest memfd is mmapable, userspace doesn't need to provide separate memory via userspace_addr, it's hard to understand and accept the name of GMEM_ONLY. [1] https://lore.kernel.org/all/20250513163438.3942405-9-tabba@google.com/ > This optimization avoids repeatedly checking the underlying guest_memfd > file for mmap support, which would otherwise require taking and > releasing a reference on the file for each check. By caching this > information directly in the memslot, we reduce overhead and simplify the > logic involved in handling guest_memfd-backed pages for host mappings. > > Reviewed-by: Gavin Shan > Reviewed-by: Shivank Garg > Acked-by: David Hildenbrand > Suggested-by: David Hildenbrand > Signed-off-by: Fuad Tabba > --- > include/linux/kvm_host.h | 11 ++++++++++- > virt/kvm/guest_memfd.c | 2 ++ > 2 files changed, 12 insertions(+), 1 deletion(-) > > diff --git a/include/linux/kvm_host.h b/include/linux/kvm_host.h > index 9ac21985f3b5..d2218ec57ceb 100644 > --- a/include/linux/kvm_host.h > +++ b/include/linux/kvm_host.h > @@ -54,7 +54,8 @@ > * used in kvm, other bits are visible for userspace which are defined in > * include/uapi/linux/kvm.h. > */ > -#define KVM_MEMSLOT_INVALID (1UL << 16) > +#define KVM_MEMSLOT_INVALID (1UL << 16) > +#define KVM_MEMSLOT_GMEM_ONLY (1UL << 17) > > /* > * Bit 63 of the memslot generation number is an "update in-progress flag", > @@ -2536,6 +2537,14 @@ static inline void kvm_prepare_memory_fault_exit(struct kvm_vcpu *vcpu, > vcpu->run->memory_fault.flags |= KVM_MEMORY_EXIT_FLAG_PRIVATE; > } > > +static inline bool kvm_memslot_is_gmem_only(const struct kvm_memory_slot *slot) > +{ > + if (!IS_ENABLED(CONFIG_KVM_GMEM_SUPPORTS_MMAP)) > + return false; > + > + return slot->flags & KVM_MEMSLOT_GMEM_ONLY; > +} > + > #ifdef CONFIG_KVM_GENERIC_MEMORY_ATTRIBUTES > static inline unsigned long kvm_get_memory_attributes(struct kvm *kvm, gfn_t gfn) > { > diff --git a/virt/kvm/guest_memfd.c b/virt/kvm/guest_memfd.c > index 07a4b165471d..2b00f8796a15 100644 > --- a/virt/kvm/guest_memfd.c > +++ b/virt/kvm/guest_memfd.c > @@ -592,6 +592,8 @@ int kvm_gmem_bind(struct kvm *kvm, struct kvm_memory_slot *slot, > */ > WRITE_ONCE(slot->gmem.file, file); > slot->gmem.pgoff = start; > + if (kvm_gmem_supports_mmap(inode)) > + slot->flags |= KVM_MEMSLOT_GMEM_ONLY; > > xa_store_range(&gmem->bindings, start, end - 1, slot, GFP_KERNEL); > filemap_invalidate_unlock(inode->i_mapping);