From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id D28ABC36010 for ; Tue, 1 Apr 2025 14:21:58 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id CD354280006; Tue, 1 Apr 2025 10:21:57 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id C82F8280004; Tue, 1 Apr 2025 10:21:57 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id B4924280006; Tue, 1 Apr 2025 10:21:57 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id 97D6E280004 for ; Tue, 1 Apr 2025 10:21:57 -0400 (EDT) Received: from smtpin30.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay03.hostedemail.com (Postfix) with ESMTP id DB17FA7DE8 for ; Tue, 1 Apr 2025 14:21:57 +0000 (UTC) X-FDA: 83285689074.30.4808E2B Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.223.130]) by imf14.hostedemail.com (Postfix) with ESMTP id 90DA310000D for ; Tue, 1 Apr 2025 14:21:55 +0000 (UTC) Authentication-Results: imf14.hostedemail.com; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=d3d45uic; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=W56mgY5G; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=d3d45uic; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=W56mgY5G; dmarc=none; spf=pass (imf14.hostedemail.com: domain of vbabka@suse.cz designates 195.135.223.130 as permitted sender) smtp.mailfrom=vbabka@suse.cz ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1743517315; a=rsa-sha256; cv=none; b=jYySYA5qxywsHG8tEOc+LudhU4mWU7ecYY1qqlyckmHWno5WGqT9GZvz5uhPkPQVmNGlHl OnO8Qaqb9LmMv7GMEl0ziUCQKeODBPTWgxbnkQFQG3eP/kcWTxHSmiVKQ0QmOYfHhLQs4D mv1gNkp3IPOCH3sIsCzSAthiZfocmnc= ARC-Authentication-Results: i=1; imf14.hostedemail.com; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=d3d45uic; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=W56mgY5G; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=d3d45uic; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=W56mgY5G; dmarc=none; spf=pass (imf14.hostedemail.com: domain of vbabka@suse.cz designates 195.135.223.130 as permitted sender) smtp.mailfrom=vbabka@suse.cz ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1743517315; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=hRopYg0nMXHBCoyj0TzK2W8QQh8ZQVQe5OPShAd9238=; b=x6Ev/IbnMyfyRcS71G1YayTB/lEg/9jiHLR4Mit6lUXhrC8aRT0fqJRiTKKhgUoWqHIafV 6fKqk6EbS+XoK5RZX0D6LlGcJbVswH3/J46f0zZHd0chPlqj9ju6HWmm6On7jiATG2h0AU rDqjqRr6M0m7YN0qcsO7UavS4gmX+rQ= Received: from imap1.dmz-prg2.suse.org (unknown [10.150.64.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id 379CF21164; Tue, 1 Apr 2025 14:21:54 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_rsa; t=1743517314; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=hRopYg0nMXHBCoyj0TzK2W8QQh8ZQVQe5OPShAd9238=; b=d3d45uicBlMw7nlc5dM58xG3Z5cBDz548KUSqJOP6RV3gd0NaM6HokAl/G/TRxGctbV0fW CsAk++ddH70HsOv9TYNwe0v007DwPsn5qk0TuVTs8nWYuxKFMu9uF556hkQibjV2xTT51X HWgi9PC01I3vyYQwLG7kIQu3JpitadY= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_ed25519; t=1743517314; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=hRopYg0nMXHBCoyj0TzK2W8QQh8ZQVQe5OPShAd9238=; b=W56mgY5GD8un0bueDBYt+9DFR+JBcvIbBwsKHgKJLL7CWLLrR86iuzha/m9nKuT6nnrCdD Mavy+Kkaz42dh+BQ== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_rsa; t=1743517314; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=hRopYg0nMXHBCoyj0TzK2W8QQh8ZQVQe5OPShAd9238=; b=d3d45uicBlMw7nlc5dM58xG3Z5cBDz548KUSqJOP6RV3gd0NaM6HokAl/G/TRxGctbV0fW CsAk++ddH70HsOv9TYNwe0v007DwPsn5qk0TuVTs8nWYuxKFMu9uF556hkQibjV2xTT51X HWgi9PC01I3vyYQwLG7kIQu3JpitadY= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_ed25519; t=1743517314; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=hRopYg0nMXHBCoyj0TzK2W8QQh8ZQVQe5OPShAd9238=; b=W56mgY5GD8un0bueDBYt+9DFR+JBcvIbBwsKHgKJLL7CWLLrR86iuzha/m9nKuT6nnrCdD Mavy+Kkaz42dh+BQ== Received: from imap1.dmz-prg2.suse.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by imap1.dmz-prg2.suse.org (Postfix) with ESMTPS id 2636213A43; Tue, 1 Apr 2025 14:21:54 +0000 (UTC) Received: from dovecot-director2.suse.de ([2a07:de40:b281:106:10:150:64:167]) by imap1.dmz-prg2.suse.org with ESMTPSA id wgv+CIL262dSYwAAD6G6ig (envelope-from ); Tue, 01 Apr 2025 14:21:54 +0000 Message-ID: Date: Tue, 1 Apr 2025 16:21:53 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] mm: Rename vm_area_struct to mm_area Content-Language: en-US To: "Liam R. Howlett" , "Matthew Wilcox (Oracle)" , Andrew Morton , Lorenzo Stoakes , Jann Horn , linux-mm@kvack.org References: <20250401122602.1738511-1-willy@infradead.org> From: Vlastimil Babka In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Rspamd-Server: rspam04 X-Rspamd-Queue-Id: 90DA310000D X-Stat-Signature: tmgigxehoetqrq958okhmd53w7hgpnyr X-Rspam-User: X-HE-Tag: 1743517315-725376 X-HE-Meta: U2FsdGVkX1/p0ffJQQTW3Vf5ftXolWCRgsyCn1RFdmLsjWYCoKfkOWYwgsMDMvf1LuWcHvDI+3fDcoV6yoXgfh7WI29Ancnj6JrCFW7SZiKvygmKCrFrw71S5lythFo+wiU03U4QwrlkdMh5BOJvcMh3nBhzdPAdkT5c5hwBEGQLu2e7wRFC0bAUvSpupZWtjuDFZo2ksb8m6AGiGDb87UZqOY42AFpu3M1McoFzvmDLKjWnYuc2q2lffOlqqmfLgNvc8f5VBUqcWYlCRVKvBpD7dMZRFT1UplcmhpF4bbe0oj7kXkaIV4ijSYE4woEyBqJ3M5bIqCMabUmh329tbZpd7TMlZwURtZ3r2CAbSgOExGCZyT4WscSzs6qbf8+p+4EqInac7nscn0uEIgE11H38xKUkvxe7UydOfPrqHhrP1On7HNeAd03NiTujCIkRBkozWt5iAX1JReEmq8PMznl/1Lmeo1bHF93TGLf0fnK5IEyVWJERJWswt+D+ar8U/gesAi89FJgCv5fx/yIXmROAnLqwONXICfKMqOJkNw2cgQw7ZaonVLsVUFSUx2Vek/yCxohk/yUHy17P06ipeRdf/ZIKUdRgi4LamC0lcpy5NWS8sflVFlCVxD7JLRqN91ApppDTH5Z4XkKOEXKLVDuXiSyfcfaknp2enWKbP9HpVJ2W5izzew9gpiHjm/lqOORFXNw19/LBcn1qIyVVLozbvX/2XS5esGM+GCXBTXdr0iEByWiS9iHzlri4z7xT53cDAQ5H+/xXPTAHLNvHpqd5ceSjL7jXXK2Pm8Dt1BCt4sHb2IEVM3Z4KGpsEkMHCiTfvsPjMpYQ7x5Edj1qD0VuPZsvtJpSto5FfXAL72bg7G5TMSoN7hCeaZGVfrhNcGLoK3HvEEUfD+wzYebhDUS4hjTsiyTnxh2c+ffXHJkaNXwleWmWv05azI0V9bq7wxmlo6V1cPwMOheREwa EtRErqx2 bdUlZ+a9PZMtfzfa28gH5U08FVTnP+3SCWAjRZyxvsRCG/6nHxIp07vH/Yn6V2mwTgzUa944XshiXEMZyoMk5KDhmQm/z2vK0ZK+qOlWvBDHxzCjUx3z5CC66o5f3eVpvpJ3iaZCJ62nWuqGIX3MODVbMBxMY8mfTWfR9vSN3JlUL2ZXIwGhr67lpfP4ftuWUkiF4d1033vku2O8snX2CUjedfYUlTSEQ16WqdxIG7MQYeFo2XJBftrL6hAFagWPJOrwXzwxGox46Syi3apAQSo2G5l+nnB7S02bWWyz6IIaC7jW1tjQVeol3a25Lr7eKUnjeyNrX7O2/gEueC73IxhhnfohmSo2wdqZ5pHii7Mzd9TB0Tt8La42v+YmtiQPGdCe+cxgPpU71AeA= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000214, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 4/1/25 16:17, Liam R. Howlett wrote: > * Matthew Wilcox (Oracle) [250401 08:26]: >> We don't need to put "_struct" on the end of the name. It's obviously >> a struct. Just look at the word "struct" before the name. The acronym >> "vm" tends to mean "virtual machine" rather than "virtual memory" these >> days, so use "mm_area" instead of "vm_area". I decided not to rename >> the variables (typically "vma") of type "struct mm_area *" as that would >> be a fair bit more disruptive. > > I'm not sure I like this idea. I mean, we should be more clear about > the type. It's not even saying it is _in_ a struct. > > Maybe we should go another direction and change vm_area_struct to > "memory_area_virtual_in_struct" to really clarify what we are talking > about. > > Obviously the variables "vma" should be updated (over time, as code is > changed..) to "mavis" to match the new struct name, for type clarity - > like a beacon. I really like the mavis beacon idea, it makes typing > easier. I agree with this direction. We should also rename "struct address_space" to "struct address_space_struct" and rename folio.mapping accordingly. > Another added benefit to this naming convention is that the virtual > machine code is free to use "machine_address_under_virtual_enrichment". > This will will provide colour to the code, especially in the variable > names. > > Thanks, > Liam