linux-mm.kvack.org archive mirror
 help / color / mirror / Atom feed
* [PATCH -next] selftests/memory-hotplug: Remove the redundant warning information
@ 2022-10-11  1:39 Zhao Gongyi
  2022-10-11  7:31 ` David Hildenbrand
  0 siblings, 1 reply; 2+ messages in thread
From: Zhao Gongyi @ 2022-10-11  1:39 UTC (permalink / raw)
  To: linux-mm, linux-kselftest, linux-kernel
  Cc: david, osalvador, shuah, Zhao Gongyi

Remove the redundant warning information of online_all_offline_memory()
since there is a warning in online_memory_expect_success().

Signed-off-by: Zhao Gongyi <zhaogongyi@huawei.com>
---
 tools/testing/selftests/memory-hotplug/mem-on-off-test.sh | 1 -
 1 file changed, 1 deletion(-)

diff --git a/tools/testing/selftests/memory-hotplug/mem-on-off-test.sh b/tools/testing/selftests/memory-hotplug/mem-on-off-test.sh
index 74ee5067a8ce..611be86eaf3d 100755
--- a/tools/testing/selftests/memory-hotplug/mem-on-off-test.sh
+++ b/tools/testing/selftests/memory-hotplug/mem-on-off-test.sh
@@ -138,7 +138,6 @@ online_all_offline_memory()
 {
 	for memory in `hotpluggable_offline_memory`; do
 		if ! online_memory_expect_success $memory; then
-			echo "$FUNCNAME $memory: unexpected fail" >&2
 			retval=1
 		fi
 	done
--
2.17.1



^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: [PATCH -next] selftests/memory-hotplug: Remove the redundant warning information
  2022-10-11  1:39 [PATCH -next] selftests/memory-hotplug: Remove the redundant warning information Zhao Gongyi
@ 2022-10-11  7:31 ` David Hildenbrand
  0 siblings, 0 replies; 2+ messages in thread
From: David Hildenbrand @ 2022-10-11  7:31 UTC (permalink / raw)
  To: Zhao Gongyi, linux-mm, linux-kselftest, linux-kernel; +Cc: osalvador, shuah

On 11.10.22 03:39, Zhao Gongyi wrote:
> Remove the redundant warning information of online_all_offline_memory()
> since there is a warning in online_memory_expect_success().
> 
> Signed-off-by: Zhao Gongyi <zhaogongyi@huawei.com>
> ---
>   tools/testing/selftests/memory-hotplug/mem-on-off-test.sh | 1 -
>   1 file changed, 1 deletion(-)
> 
> diff --git a/tools/testing/selftests/memory-hotplug/mem-on-off-test.sh b/tools/testing/selftests/memory-hotplug/mem-on-off-test.sh
> index 74ee5067a8ce..611be86eaf3d 100755
> --- a/tools/testing/selftests/memory-hotplug/mem-on-off-test.sh
> +++ b/tools/testing/selftests/memory-hotplug/mem-on-off-test.sh
> @@ -138,7 +138,6 @@ online_all_offline_memory()
>   {
>   	for memory in `hotpluggable_offline_memory`; do
>   		if ! online_memory_expect_success $memory; then
> -			echo "$FUNCNAME $memory: unexpected fail" >&2
>   			retval=1
>   		fi
>   	done
> --
> 2.17.1
> 

Reviewed-by: David Hildenbrand <david@redhat.com>

-- 
Thanks,

David / dhildenb



^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2022-10-11  7:31 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-10-11  1:39 [PATCH -next] selftests/memory-hotplug: Remove the redundant warning information Zhao Gongyi
2022-10-11  7:31 ` David Hildenbrand

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox