From: David Hildenbrand <david@redhat.com>
To: Zhao Gongyi <zhaogongyi@huawei.com>,
linux-mm@kvack.org, linux-kselftest@vger.kernel.org,
linux-kernel@vger.kernel.org
Cc: osalvador@suse.de, shuah@kernel.org
Subject: Re: [PATCH -next] selftests/memory-hotplug: Remove the redundant warning information
Date: Tue, 11 Oct 2022 09:31:16 +0200 [thread overview]
Message-ID: <eb839bff-90ff-adfe-c463-a20fdfa86b0e@redhat.com> (raw)
In-Reply-To: <20221011013926.200774-1-zhaogongyi@huawei.com>
On 11.10.22 03:39, Zhao Gongyi wrote:
> Remove the redundant warning information of online_all_offline_memory()
> since there is a warning in online_memory_expect_success().
>
> Signed-off-by: Zhao Gongyi <zhaogongyi@huawei.com>
> ---
> tools/testing/selftests/memory-hotplug/mem-on-off-test.sh | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/tools/testing/selftests/memory-hotplug/mem-on-off-test.sh b/tools/testing/selftests/memory-hotplug/mem-on-off-test.sh
> index 74ee5067a8ce..611be86eaf3d 100755
> --- a/tools/testing/selftests/memory-hotplug/mem-on-off-test.sh
> +++ b/tools/testing/selftests/memory-hotplug/mem-on-off-test.sh
> @@ -138,7 +138,6 @@ online_all_offline_memory()
> {
> for memory in `hotpluggable_offline_memory`; do
> if ! online_memory_expect_success $memory; then
> - echo "$FUNCNAME $memory: unexpected fail" >&2
> retval=1
> fi
> done
> --
> 2.17.1
>
Reviewed-by: David Hildenbrand <david@redhat.com>
--
Thanks,
David / dhildenb
prev parent reply other threads:[~2022-10-11 7:31 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-10-11 1:39 Zhao Gongyi
2022-10-11 7:31 ` David Hildenbrand [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=eb839bff-90ff-adfe-c463-a20fdfa86b0e@redhat.com \
--to=david@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=osalvador@suse.de \
--cc=shuah@kernel.org \
--cc=zhaogongyi@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox