From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 12D72C021BE for ; Thu, 27 Feb 2025 05:01:07 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 67966280004; Thu, 27 Feb 2025 00:01:07 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 600EC280003; Thu, 27 Feb 2025 00:01:07 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 405BE280004; Thu, 27 Feb 2025 00:01:07 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id 14E1A280003 for ; Thu, 27 Feb 2025 00:01:07 -0500 (EST) Received: from smtpin24.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id B53B21603CF for ; Thu, 27 Feb 2025 05:01:06 +0000 (UTC) X-FDA: 83164525332.24.E4B2658 Received: from out199-4.us.a.mail.aliyun.com (out199-4.us.a.mail.aliyun.com [47.90.199.4]) by imf07.hostedemail.com (Postfix) with ESMTP id C0DD74000A for ; Thu, 27 Feb 2025 05:01:03 +0000 (UTC) Authentication-Results: imf07.hostedemail.com; dkim=pass header.d=linux.alibaba.com header.s=default header.b=p+WmGYA6; spf=pass (imf07.hostedemail.com: domain of baolin.wang@linux.alibaba.com designates 47.90.199.4 as permitted sender) smtp.mailfrom=baolin.wang@linux.alibaba.com; dmarc=pass (policy=none) header.from=linux.alibaba.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1740632465; a=rsa-sha256; cv=none; b=OsS2cSuLbK82Wrae/12Z37urbXtHljQjWtBGGtBVcCEZdJYcV7osQ++ec8IoHKQI3F3Osh EB+8WVlBc53CirdcKVfw7DwWrfGLFtoI/AELqiz7i2DjTZ/+NNQH1sKb4w7h8NfcWNmRIW 8h1y4fP893Ib+WDzf4i0ZU9nDwaoU30= ARC-Authentication-Results: i=1; imf07.hostedemail.com; dkim=pass header.d=linux.alibaba.com header.s=default header.b=p+WmGYA6; spf=pass (imf07.hostedemail.com: domain of baolin.wang@linux.alibaba.com designates 47.90.199.4 as permitted sender) smtp.mailfrom=baolin.wang@linux.alibaba.com; dmarc=pass (policy=none) header.from=linux.alibaba.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1740632465; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=teBbDeeWomhuKYrmqY15HEQouHnOjTiz77oFo6Ak1ns=; b=IzY8kasRPDtcRzEJgWjKBPxx7Lhlwcdw5NdwUud7iWvslTg4PRGnMGiTpRO2XZHB1rNECa y06ut/u2zOmh/s+hDteQwpGDvdgQ0rpnokzr1s4xhhu1vH1GB5C2Wa/WfPR6SlwlfGqKGU AvnwnA22O7ZL71JGsjtP9zc/J+LmNcQ= DKIM-Signature:v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.alibaba.com; s=default; t=1740631855; h=Message-ID:Date:MIME-Version:Subject:To:From:Content-Type; bh=teBbDeeWomhuKYrmqY15HEQouHnOjTiz77oFo6Ak1ns=; b=p+WmGYA68F7mgOON9TLBVARTLHsrcjomsJtoxl777o82epBeuKJK/qnd48h/exixW5HKQo1muRMtS7E7TDuwrK66+Xam2oA/qpEnI92tScScKDRdw91xYWlk7T9PUPM82L1J6hS4crhWEaFxHgIhcIqPTIj3egRkLXTDnXUj6rA= Received: from 30.74.144.117(mailfrom:baolin.wang@linux.alibaba.com fp:SMTPD_---0WQL0NIW_1740631850 cluster:ay36) by smtp.aliyun-inc.com; Thu, 27 Feb 2025 12:50:50 +0800 Message-ID: Date: Thu, 27 Feb 2025 12:50:49 +0800 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] mm: shmem: remove unnecessary warning in shmem_writepage() To: =?UTF-8?Q?Ricardo_Ca=C3=B1uelo_Navarro?= , Hugh Dickins , Andrew Morton , David Hildenbrand , Yosry Ahmed , Luis Chamberlain , Davidlohr Bueso Cc: Christian Brauner , linux-mm@kvack.org, linux-kernel@vger.kernel.org, Florent Revest , kernel-dev@igalia.com, Pengfei Xu References: <20250226-20250221-warning-in-shmem_writepage-v1-1-5ad19420e17e@igalia.com> From: Baolin Wang In-Reply-To: <20250226-20250221-warning-in-shmem_writepage-v1-1-5ad19420e17e@igalia.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-Rspamd-Queue-Id: C0DD74000A X-Stat-Signature: hgehjeoraq6mp7qcria9tts791qe4eru X-Rspam-User: X-Rspamd-Server: rspam10 X-HE-Tag: 1740632463-740286 X-HE-Meta: U2FsdGVkX1+3Z3+44Z8gOFIr5Pc/l2QEz43G+lnkc9sffN9OTgtzuwdSm7XBN0zZlqHdh2OcRoUJmOXlUCZGl/Nxv7VQTd5vuUXAavZNaDZeHKpgd61Np4sQz/NYe5sMOyIJhZzRoRr74/9dMOQsZT/uKZkZZc9giXDIGY4PL+X9hO0nL97g21K+fBF7wKmrwBU+KpsC8R6SbGnVriTlvOeaC2/YLzJUi9LG3g6HdKv10zHY/tGH5ebenKUC9t/fHGoCgm7DtZbVcZ3ditTr19dODhPW0bclvIp0lJ71vslbSbrbTei4Qw6a4uIRLbs0qCjk71KR3yWz4EKV27+L1JVwBDAQX15cNmTSzYZPuXEosYNVh1+7R4USZJ0X83YO5CXftWs/G2m46OKLjskj5hSEELXHctqd/c+D95JS7XNgSBMFvdxfcipFjIugUZZCBWlKQx4e2SJGN/EZDxoybPzbIjGF041z4/p+90kpiQl/ubWwl9rnngWE3IzBIIilfy2mbXBuW6a1RP/OLO25By2zOPkUrS5FVzlMRZG3ySB6cwifmiYTFDewU7KSJXGbI2egIXr2V1MP/tr+6GX1VscKutGxhKexriGCASSjfNXMvh3BBHkO90TDxC6ZMaSwi1K0nMX81tJc6+aimsCFywcBuKQJ/R4marnpKcyEOqHlq5EjDpIIlXcZzY1LRImZ86AYyuHGCTU2Dy5Qg7DMgGQoRzixdyy6MJ0pVtxy8IU7paUZAqJOXarwxOjCNJjPIjCtRu7Ei0UNHbcA26Sui7D9PVkP0bWJskvFF+WxCTwNwbieZfgvY7YB+sCvkb1zFGUkrEjumPayqb12KWo06bK7sf4w1X/QkqLp9LiPN7VVIv8VfT0WbINwfu7RMnvnL8WoBkAevP8END06ByJjOmwrmkqSGFRts+LH/7OZz6p+EdmbQxnFEPw4F5rPCn14wbNKjF/R0Nt9KywhsFv BkCm+IzY 4DRgfxpqsUeBqOCmj08JyPFfJrTtOxyxgW5ABsv3t3SmyjWZpnbr0fmiaYUHS2PRubN1UzSyH1I/tPIFXgpH4qbN4dYeo4Hxly3R2evAeLnTzLA5Y1GBDBsS67+nC0IZ2w6IepUOj4g9OqxatwvHLQ2T0eQ+yzlxGiMCdPCPd0uo8R/hP3KOxkDo+JQqX1yqTCYgpMRp0Egi+UcoeMVXDm09+lamttJ7e4vynUnTYTgrl565Q/05YdH5FGDAHWW+JsqnZqAENT+b7PPT2jCG8vNCqK4KUGznfKmwgiA4AmLw7X6SRUXDUV4MO1kxUJU/zi6uUEagfYUEpS8VgTo88yKGfsbF3biwvPVOFghDYBr7aHbYKk8a2/6mmTsZx0XcVdNcTH/C+CWqeMQ4A5i3PBfg8YZ3rsBcouFi3+A8Mj+UhFYJE6Ui7O7XWIhY+VHvzmX7F0bY8rWrDvsbsm0Yc2OZo37z+3kFK74aXkvDLuw59MzbNqSf12XoxEefZYhXuLnvMTKnJrvTpoorreN1dc+vXg2yVEHx1iah8hVaGbrxpEE4SJhkazKWTC3X+kiYOP//Pzp7+WKzZIzrUlPr4uoLrScbqXZ6SdQUgsLPeiH7JkvY= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 2025/2/26 20:26, Ricardo Cañuelo Navarro wrote: > Although the scenario where shmem_writepage() is called with info->flags > & VM_LOCKED is unlikely to happen, it's still possible, as evidenced by > syzbot [1]. However, the warning in this case isn't necessary because > the situation is already handled correctly [2]. > > [2] https://lore.kernel.org/lkml/8afe1f7f-31a2-4fc0-1fbd-f9ba8a116fe3@google.com/ > > Reported-by: Pengfei Xu > Closes: https://lore.kernel.org/lkml/ZZ9PShXjKJkVelNm@xpf.sh.intel.com/ [1] > Suggested-by: Hugh Dickins > Cc: Florent Revest > Signed-off-by: Ricardo Cañuelo Navarro > Fixes: 9a976f0c847b ("shmem: skip page split if we're not reclaiming") > --- LGTM. Reviewed-by: Baolin Wang > mm/shmem.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/mm/shmem.c b/mm/shmem.c > index 4ea6109a80431e5eeae15278064d5c86412f9fc9..a5eaad03038e8ca56a54d096159892e01c7a5bfe 100644 > --- a/mm/shmem.c > +++ b/mm/shmem.c > @@ -1548,7 +1548,7 @@ static int shmem_writepage(struct page *page, struct writeback_control *wbc) > if (WARN_ON_ONCE(!wbc->for_reclaim)) > goto redirty; > > - if (WARN_ON_ONCE((info->flags & VM_LOCKED) || sbinfo->noswap)) > + if ((info->flags & VM_LOCKED) || sbinfo->noswap) > goto redirty; > > if (!total_swap_pages) > > --- > base-commit: ac9c34d1e45a4c25174ced4fc0cfc33ff3ed08c7 > change-id: 20250226-20250221-warning-in-shmem_writepage-e7f8f273317c > > Cheers, > Ricardo >