From: Tetsuo Handa <penguin-kernel@i-love.sakura.ne.jp>
To: Waiman Long <llong@redhat.com>, Aaron Tomlin <atomlin@redhat.com>,
linux-mm@kvack.org
Cc: akpm@linux-foundation.org, vbabka@suse.cz, mhocko@suse.com,
linux-kernel@vger.kernel.org
Subject: Re: [RFC PATCH] mm/oom_kill: show oom eligibility when displaying the current memory state of all tasks
Date: Sat, 12 Jun 2021 09:23:03 +0900 [thread overview]
Message-ID: <eb77e210-1088-d140-043f-088141deb94d@i-love.sakura.ne.jp> (raw)
In-Reply-To: <d233acb6-72ff-4914-88a3-75bf137e5286@redhat.com>
On 2021/06/12 2:42, Waiman Long wrote:
> A minor nit:
>
> "oom eligible?" has 13 characters. The field width is 15. Maybe you should pad 2 more spaces to make the proper alignment.
Maybe single character (e.g. 'S' for OOM_SCORE_ADJ_MIN, 'R' for MMF_OOM_SKIP, 'V' for in_vfork(),
none for eligible) is better because dump_task() might print many hundreds of lines?
next prev parent reply other threads:[~2021-06-12 0:23 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-06-11 17:19 Aaron Tomlin
2021-06-11 17:42 ` Waiman Long
2021-06-12 0:23 ` Tetsuo Handa [this message]
2021-06-12 3:08 ` ownia
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=eb77e210-1088-d140-043f-088141deb94d@i-love.sakura.ne.jp \
--to=penguin-kernel@i-love.sakura.ne.jp \
--cc=akpm@linux-foundation.org \
--cc=atomlin@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=llong@redhat.com \
--cc=mhocko@suse.com \
--cc=vbabka@suse.cz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox