From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 31F13C25B79 for ; Tue, 14 May 2024 20:39:46 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id A24FB6B037C; Tue, 14 May 2024 16:39:45 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 9D45A6B037D; Tue, 14 May 2024 16:39:45 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 89BDE6B037E; Tue, 14 May 2024 16:39:45 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id 6BD226B037C for ; Tue, 14 May 2024 16:39:45 -0400 (EDT) Received: from smtpin24.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay04.hostedemail.com (Postfix) with ESMTP id E0D1B1A114F for ; Tue, 14 May 2024 20:39:44 +0000 (UTC) X-FDA: 82118167488.24.7880E1F Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by imf11.hostedemail.com (Postfix) with ESMTP id 26CEA4000C for ; Tue, 14 May 2024 20:39:40 +0000 (UTC) Authentication-Results: imf11.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b="eij+r6+/"; spf=pass (imf11.hostedemail.com: domain of david@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1715719182; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=ITMhM4TN9IG8BffABJDJLkO9uSK3vlKikLrGNKRSMoc=; b=Q5XltDluZ1Lx4903Nb5jYHNVU5MW3T+d8LnlbPBGYrqhD+ksBnTo7dZDl+LO5eAT/BOf7x wbH/z8fUmAgbtyDVeQp2gfRgC/VemLrTIfdP/jyq7oJbqHsahSJb0nuvmtA3GxfBVeVKgk rvrtHE5ATv+JtpyL+TbzO8hYfv7UTr8= ARC-Authentication-Results: i=1; imf11.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b="eij+r6+/"; spf=pass (imf11.hostedemail.com: domain of david@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1715719182; a=rsa-sha256; cv=none; b=dK4a2ugJAM04AaadjG76x12wsedzFBrgjbhm7BXxVhq56bXKm6fGO11zTOscQUB+JQ5fQO pFTqvl8+qRDUG/1J2DAkjpsehUlekZCTgV0DF0J7WaBXvHROG/5edbjAldBFsZGF/3bFwe NFxf6j/FsXnj2WvuK3EWBjF0r33iZ2s= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1715719180; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=ITMhM4TN9IG8BffABJDJLkO9uSK3vlKikLrGNKRSMoc=; b=eij+r6+/QcD7CJ7/h18zzRTvjQjgwucGOCki1NuTeEIuuEutGPw4NeElFC4lJ1zvmEJze/ gs0u6fSur3QrlZldk5WpZNzIGSyOyqiCWjuxO/uyCxoYGW8dtefH9+4LZlgIkAQiKIfPGo m0RTmud8TiI/yAItjOE16+/NfH3D/q0= Received: from mail-pg1-f200.google.com (mail-pg1-f200.google.com [209.85.215.200]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-519-cAp5sxXtOE-H0kq0n1ziNA-1; Tue, 14 May 2024 16:39:34 -0400 X-MC-Unique: cAp5sxXtOE-H0kq0n1ziNA-1 Received: by mail-pg1-f200.google.com with SMTP id 41be03b00d2f7-604bad9b2e8so5664228a12.2 for ; Tue, 14 May 2024 13:39:33 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1715719173; x=1716323973; h=content-transfer-encoding:in-reply-to:organization:autocrypt :content-language:from:references:cc:to:subject:user-agent :mime-version:date:message-id:x-gm-message-state:from:to:cc:subject :date:message-id:reply-to; bh=ITMhM4TN9IG8BffABJDJLkO9uSK3vlKikLrGNKRSMoc=; b=P5CwIp1k6XneyiFdkNioAtVogpXLVmu0CTwvxqu3cf4w/S/RqWPV2PAPTe6FpmwVly gZ+dHN2f3lwnacqZ5XtobUAHLiSU9GgO7VADbIeBGloO30qc5xlLVA6CWU9knymWP7NX oOxLlTfBPlNvBFT/kY7abapZpu+avai62ZeKKx2B6aEQ1nKiNiW99Mr2bp6zyQPm79q5 D36sihh2G3JEtEspPI00tOGMMmVd2JPtMxhrDDvRn7tsPA0T9qOTVv4h7rKHJLOnMmj6 J3YX8YYJlrVpiSNbRFk/+jjclTnZuzD6uHBUkOJE0gHgDomc5yFaHUHBFQd5fUpP/1+W Z0lQ== X-Forwarded-Encrypted: i=1; AJvYcCXKy/U9GP0qBDk6Enu4JzhUvdiFezMkg8Lu5uZChXf+4adTCl0ZJB7koLeysY38IAGbNUm8N1d06RtkkFnMNC0tsqA= X-Gm-Message-State: AOJu0Yw3xeDrU9KgUUo6173UgbHDfZ4F9XMLFumG7tsXXo6jMoL48LDs wTgzOMfsg6h61aufQGRgslXjjkfE7MoN0VIanuKgNv0zm6MdvUqpXbcODFH9be5x4X0MwiIltoB e0jdkuxhT+ou6Q/9vaE5MNyy4LKYHrQPjpjXG97DF2J+d3FCX X-Received: by 2002:a17:902:f54d:b0:1e2:aa62:2fbf with SMTP id d9443c01a7336-1ef4404a379mr183346855ad.45.1715719172838; Tue, 14 May 2024 13:39:32 -0700 (PDT) X-Google-Smtp-Source: AGHT+IGZIK2cFpjPQfSL+bLZI1/OS2KM8wi7MbrbKIssFODspkwohw7SVfmm+SN9dNhpzxuT3OOpIA== X-Received: by 2002:a17:902:f54d:b0:1e2:aa62:2fbf with SMTP id d9443c01a7336-1ef4404a379mr183346485ad.45.1715719172282; Tue, 14 May 2024 13:39:32 -0700 (PDT) Received: from [172.21.1.2] ([50.204.89.31]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-1ef0b9d176fsm101887075ad.58.2024.05.14.13.39.30 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 14 May 2024 13:39:31 -0700 (PDT) Message-ID: Date: Tue, 14 May 2024 22:39:30 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2 5/8] riscv: mm: Take memory hotplug read-lock during kernel page table dump To: =?UTF-8?B?QmrDtnJuIFTDtnBlbA==?= , Alexandre Ghiti , Albert Ou , Palmer Dabbelt , Paul Walmsley , linux-riscv@lists.infradead.org Cc: =?UTF-8?B?QmrDtnJuIFTDtnBlbA==?= , Andrew Bresticker , Chethan Seshadri , Lorenzo Stoakes , Oscar Salvador , Santosh Mamila , Sivakumar Munnangi , Sunil V L , linux-kernel@vger.kernel.org, linux-mm@kvack.org, virtualization@lists.linux-foundation.org References: <20240514140446.538622-1-bjorn@kernel.org> <20240514140446.538622-6-bjorn@kernel.org> From: David Hildenbrand Autocrypt: addr=david@redhat.com; keydata= xsFNBFXLn5EBEAC+zYvAFJxCBY9Tr1xZgcESmxVNI/0ffzE/ZQOiHJl6mGkmA1R7/uUpiCjJ dBrn+lhhOYjjNefFQou6478faXE6o2AhmebqT4KiQoUQFV4R7y1KMEKoSyy8hQaK1umALTdL QZLQMzNE74ap+GDK0wnacPQFpcG1AE9RMq3aeErY5tujekBS32jfC/7AnH7I0v1v1TbbK3Gp XNeiN4QroO+5qaSr0ID2sz5jtBLRb15RMre27E1ImpaIv2Jw8NJgW0k/D1RyKCwaTsgRdwuK Kx/Y91XuSBdz0uOyU/S8kM1+ag0wvsGlpBVxRR/xw/E8M7TEwuCZQArqqTCmkG6HGcXFT0V9 PXFNNgV5jXMQRwU0O/ztJIQqsE5LsUomE//bLwzj9IVsaQpKDqW6TAPjcdBDPLHvriq7kGjt WhVhdl0qEYB8lkBEU7V2Yb+SYhmhpDrti9Fq1EsmhiHSkxJcGREoMK/63r9WLZYI3+4W2rAc UucZa4OT27U5ZISjNg3Ev0rxU5UH2/pT4wJCfxwocmqaRr6UYmrtZmND89X0KigoFD/XSeVv jwBRNjPAubK9/k5NoRrYqztM9W6sJqrH8+UWZ1Idd/DdmogJh0gNC0+N42Za9yBRURfIdKSb B3JfpUqcWwE7vUaYrHG1nw54pLUoPG6sAA7Mehl3nd4pZUALHwARAQABzSREYXZpZCBIaWxk ZW5icmFuZCA8ZGF2aWRAcmVkaGF0LmNvbT7CwZgEEwEIAEICGwMGCwkIBwMCBhUIAgkKCwQW AgMBAh4BAheAAhkBFiEEG9nKrXNcTDpGDfzKTd4Q9wD/g1oFAl8Ox4kFCRKpKXgACgkQTd4Q 9wD/g1oHcA//a6Tj7SBNjFNM1iNhWUo1lxAja0lpSodSnB2g4FCZ4R61SBR4l/psBL73xktp rDHrx4aSpwkRP6Epu6mLvhlfjmkRG4OynJ5HG1gfv7RJJfnUdUM1z5kdS8JBrOhMJS2c/gPf wv1TGRq2XdMPnfY2o0CxRqpcLkx4vBODvJGl2mQyJF/gPepdDfcT8/PY9BJ7FL6Hrq1gnAo4 3Iv9qV0JiT2wmZciNyYQhmA1V6dyTRiQ4YAc31zOo2IM+xisPzeSHgw3ONY/XhYvfZ9r7W1l pNQdc2G+o4Di9NPFHQQhDw3YTRR1opJaTlRDzxYxzU6ZnUUBghxt9cwUWTpfCktkMZiPSDGd KgQBjnweV2jw9UOTxjb4LXqDjmSNkjDdQUOU69jGMUXgihvo4zhYcMX8F5gWdRtMR7DzW/YE BgVcyxNkMIXoY1aYj6npHYiNQesQlqjU6azjbH70/SXKM5tNRplgW8TNprMDuntdvV9wNkFs 9TyM02V5aWxFfI42+aivc4KEw69SE9KXwC7FSf5wXzuTot97N9Phj/Z3+jx443jo2NR34XgF 89cct7wJMjOF7bBefo0fPPZQuIma0Zym71cP61OP/i11ahNye6HGKfxGCOcs5wW9kRQEk8P9 M/k2wt3mt/fCQnuP/mWutNPt95w9wSsUyATLmtNrwccz63XOwU0EVcufkQEQAOfX3n0g0fZz Bgm/S2zF/kxQKCEKP8ID+Vz8sy2GpDvveBq4H2Y34XWsT1zLJdvqPI4af4ZSMxuerWjXbVWb T6d4odQIG0fKx4F8NccDqbgHeZRNajXeeJ3R7gAzvWvQNLz4piHrO/B4tf8svmRBL0ZB5P5A 2uhdwLU3NZuK22zpNn4is87BPWF8HhY0L5fafgDMOqnf4guJVJPYNPhUFzXUbPqOKOkL8ojk CXxkOFHAbjstSK5Ca3fKquY3rdX3DNo+EL7FvAiw1mUtS+5GeYE+RMnDCsVFm/C7kY8c2d0G NWkB9pJM5+mnIoFNxy7YBcldYATVeOHoY4LyaUWNnAvFYWp08dHWfZo9WCiJMuTfgtH9tc75 7QanMVdPt6fDK8UUXIBLQ2TWr/sQKE9xtFuEmoQGlE1l6bGaDnnMLcYu+Asp3kDT0w4zYGsx 5r6XQVRH4+5N6eHZiaeYtFOujp5n+pjBaQK7wUUjDilPQ5QMzIuCL4YjVoylWiBNknvQWBXS lQCWmavOT9sttGQXdPCC5ynI+1ymZC1ORZKANLnRAb0NH/UCzcsstw2TAkFnMEbo9Zu9w7Kv AxBQXWeXhJI9XQssfrf4Gusdqx8nPEpfOqCtbbwJMATbHyqLt7/oz/5deGuwxgb65pWIzufa N7eop7uh+6bezi+rugUI+w6DABEBAAHCwXwEGAEIACYCGwwWIQQb2cqtc1xMOkYN/MpN3hD3 AP+DWgUCXw7HsgUJEqkpoQAKCRBN3hD3AP+DWrrpD/4qS3dyVRxDcDHIlmguXjC1Q5tZTwNB boaBTPHSy/Nksu0eY7x6HfQJ3xajVH32Ms6t1trDQmPx2iP5+7iDsb7OKAb5eOS8h+BEBDeq 3ecsQDv0fFJOA9ag5O3LLNk+3x3q7e0uo06XMaY7UHS341ozXUUI7wC7iKfoUTv03iO9El5f XpNMx/YrIMduZ2+nd9Di7o5+KIwlb2mAB9sTNHdMrXesX8eBL6T9b+MZJk+mZuPxKNVfEQMQ a5SxUEADIPQTPNvBewdeI80yeOCrN+Zzwy/Mrx9EPeu59Y5vSJOx/z6OUImD/GhX7Xvkt3kq Er5KTrJz3++B6SH9pum9PuoE/k+nntJkNMmQpR4MCBaV/J9gIOPGodDKnjdng+mXliF3Ptu6 3oxc2RCyGzTlxyMwuc2U5Q7KtUNTdDe8T0uE+9b8BLMVQDDfJjqY0VVqSUwImzTDLX9S4g/8 kC4HRcclk8hpyhY2jKGluZO0awwTIMgVEzmTyBphDg/Gx7dZU1Xf8HFuE+UZ5UDHDTnwgv7E th6RC9+WrhDNspZ9fJjKWRbveQgUFCpe1sa77LAw+XFrKmBHXp9ZVIe90RMe2tRL06BGiRZr jPrnvUsUUsjRoRNJjKKA/REq+sAnhkNPPZ/NNMjaZ5b8Tovi8C0tmxiCHaQYqj7G2rgnT0kt WNyWQQ== Organization: Red Hat In-Reply-To: <20240514140446.538622-6-bjorn@kernel.org> X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-Rspamd-Server: rspam05 X-Rspamd-Queue-Id: 26CEA4000C X-Stat-Signature: kr7dshyd77tx1rowxqxzw89i3cur8dkd X-Rspam-User: X-HE-Tag: 1715719180-135409 X-HE-Meta: U2FsdGVkX18T7RKdxlTXs0FUxIkARVYjycMFb2KsHZ/BzZ7XISYyOCnz+PYw6JYvCIN6htZJ5LybSDffYnyCoT5EvRYbON0NJ61i6RlUXkUfA+PAXym2sVrVbYVahhRlz5pqDA3BBmt6JzqtN7hRRVTiMwsVeLUcuyWKIvcDPqTOxSsgQwTWLH3ZYycCgCTjsACtrwHkvXdzGkmzsQPyAa254MB/5SSgUImRoewjOdMQqiAFwQjJowZwOeKvZY8nAbizZTS8xsuQitmGLfrHj8ZfabiYbTYaqu8WGx6GTZxigJmipCTvIhe1l2YAg2/fUyr3+mLgP/IN8d5p8lZvnxzrmNQC9ojJ0et79BVvSdwVQbSVaXB4gInNNKzs5CwFa1VehtBCNbYhyn+r0W1vPwAMpFPhnQPOQVJikKSm3BfbGmWJ4uGdDnPmdSwUinFKo1HmllwJy0+cUcfwRfT+53RmMBF7QmmLgJ8o2UGxZAddQ1nckBF/rqrgQo9FL0Bu3bnPxxayw21PiCCA6zYtd79syZRBMKRBwEXzcvGOSExPZTMAv66ORGSofv67s1Y+UrqXUfwNJYLC2NWhYaNXmD0HyWBOmliWgHHC/GU55btqHM3cQIoYeSmRa42ALt4q0C2KlNCjgUrOKgf1iqY+YZS+4euF7OtqlP9AjV5aj9HuDmjoKQ65TZs/WlR5dL0eqn6ULq5V5KRi2UkbtvTSRd0bQLWk+dF4VN2HdDQHhgHseXKfS9SU98tsWdF7Mb2OjCJzHH9gdMLX8/bPHIKrnMScSCuntG6ZVNX4HbgwVglJmd2QWJXdb0DPe/wgQlyuOVEOsKM0ezgMmhxX7QHMWDjzlHVIlTop7noFa/ZQoIQ8JZTC9kRoZqq2j3EBEet6Bv7LeNPBl7mrmxkKCFablWUE78Z8ZlNQqMFr+RBfhkZ5C1fG6ryhRRfD7ZAubWnZbPTo+grOvwsngf1cB37 oF+lmh/P WQUfs9agSI06GUi++9tiG+x6IqlPl1Yi9ZI1J9LCE+tF9U06jUCbiv5JgzJUInh3bCGQNI8oUKLtCSCK8u8rzWdDwOVQZ42nTFLvfAg0NHIy4KVCo5gLv9Ghc9Rzg/TH50ArLNPxbBTu6TUUH0idY1ggWftaI6lBX/Ign1y6gu4ik5TE2ruJ6yCjXlqrb/X/Qy58V+xAvEE8s+nkP+o8mTOiKl2GXbaGdrgJYLNBeI5J7VoBZ0fNoFUJWkJIUZetM6hRxzekv+YsjZ51SItGKlh2vpHCpQ3xqo6D/96n4XAXndEWqw6hQkwtsCHwAGYrxJo0z6iTmFjzYrb3nywXKCMWDDgBiMYueOvCjiKzHi5avkwZe3g+pMBXEz537fFumvv2Xd1o22SGWQ+Wm51P4TjfoDeRHf/5WmzXR6Gj1Wg10MZ6CPI4b/H3qEvfc81cHb7oz5fuXFicQ++tt9bk1YIXpQaASlckHawKNGvg7mCpIFTEmyzPYrhcwQgyKS8rl71jI/cWqLewcMkIMxKtBpYcUlMwBwvsD/SgrVqpSL4SHwSPUcLDvnrPgTQS0mOTT6SQhjzp9mjCxyWGGGeGCafMp/Q== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 14.05.24 16:04, Björn Töpel wrote: > From: Björn Töpel > > During memory hot remove, the ptdump functionality can end up touching > stale data. Avoid any potential crashes (or worse), by holding the > memory hotplug read-lock while traversing the page table. > > This change is analogous to arm64's commit bf2b59f60ee1 ("arm64/mm: > Hold memory hotplug lock while walking for kernel page table dump"). > > Signed-off-by: Björn Töpel > --- > arch/riscv/mm/ptdump.c | 3 +++ > 1 file changed, 3 insertions(+) > > diff --git a/arch/riscv/mm/ptdump.c b/arch/riscv/mm/ptdump.c > index 1289cc6d3700..9d5f657a251b 100644 > --- a/arch/riscv/mm/ptdump.c > +++ b/arch/riscv/mm/ptdump.c > @@ -6,6 +6,7 @@ > #include > #include > #include > +#include > #include > #include > > @@ -370,7 +371,9 @@ bool ptdump_check_wx(void) > > static int ptdump_show(struct seq_file *m, void *v) > { > + get_online_mems(); > ptdump_walk(m, m->private); > + put_online_mems(); > > return 0; > } Reviewed-by: David Hildenbrand -- Cheers, David / dhildenb