From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8571ED0BB78 for ; Thu, 24 Oct 2024 09:03:50 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 120B06B0082; Thu, 24 Oct 2024 05:03:50 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 0A8CC6B0083; Thu, 24 Oct 2024 05:03:50 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id E16CD6B0085; Thu, 24 Oct 2024 05:03:49 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id B97F96B0082 for ; Thu, 24 Oct 2024 05:03:49 -0400 (EDT) Received: from smtpin13.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id 03098AC665 for ; Thu, 24 Oct 2024 09:03:12 +0000 (UTC) X-FDA: 82707907296.13.9D53239 Received: from mx0a-00069f02.pphosted.com (mx0a-00069f02.pphosted.com [205.220.165.32]) by imf24.hostedemail.com (Postfix) with ESMTP id 06DC8180015 for ; Thu, 24 Oct 2024 09:03:42 +0000 (UTC) Authentication-Results: imf24.hostedemail.com; dkim=pass header.d=oracle.com header.s=corp-2023-11-20 header.b=PbwzHfgA; dkim=pass header.d=oracle.onmicrosoft.com header.s=selector2-oracle-onmicrosoft-com header.b=Dj2a7QXU; arc=pass ("microsoft.com:s=arcselector10001:i=1"); spf=pass (imf24.hostedemail.com: domain of lorenzo.stoakes@oracle.com designates 205.220.165.32 as permitted sender) smtp.mailfrom=lorenzo.stoakes@oracle.com; dmarc=pass (policy=reject) header.from=oracle.com ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1729760474; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=9/e7IEUDw9vmHneJ/17uni2wriWFcTvRBQEgHgXy1nI=; b=0Y2rJBU+V3LTFVfHao9jEMDS8fGeuL1/lWcTFNCmf3Nx+L3z2I/Gg2OXbE/1t/TVbwgPZF wQcuz8DbsAkMoEh29dTqw1RqZNC3prtUSo4aeoNsIOaGtBnwWjZlb7CjrpajKs/2vyCGHM DMPXuNWl2RU5Hp9+3nqVyD2f4iLWtOw= ARC-Seal: i=2; s=arc-20220608; d=hostedemail.com; t=1729760474; a=rsa-sha256; cv=pass; b=mmxzkhVWZKWJ7Vz/ETsTKLY3tAIWG+y/TzMmMA4dqPzs9gDmx5VVhbHTBpcMNQ4A+n19Ls Wgz3KyM/yQzSoglZvlPWxPIY3ODGPh5lq7Sf7Ptoq3+0mJYKtCOwDmZTYkkKx3Y30uQMLh 0FsL+FHCfK0XMQ/5pEXMheBMajZ1pQA= ARC-Authentication-Results: i=2; imf24.hostedemail.com; dkim=pass header.d=oracle.com header.s=corp-2023-11-20 header.b=PbwzHfgA; dkim=pass header.d=oracle.onmicrosoft.com header.s=selector2-oracle-onmicrosoft-com header.b=Dj2a7QXU; arc=pass ("microsoft.com:s=arcselector10001:i=1"); spf=pass (imf24.hostedemail.com: domain of lorenzo.stoakes@oracle.com designates 205.220.165.32 as permitted sender) smtp.mailfrom=lorenzo.stoakes@oracle.com; dmarc=pass (policy=reject) header.from=oracle.com Received: from pps.filterd (m0333521.ppops.net [127.0.0.1]) by mx0b-00069f02.pphosted.com (8.18.1.2/8.18.1.2) with ESMTP id 49O2fusw012085; Thu, 24 Oct 2024 09:03:41 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h=cc :content-type:date:from:in-reply-to:message-id:mime-version :references:subject:to; s=corp-2023-11-20; bh=9/e7IEUDw9vmHneJ/1 7uni2wriWFcTvRBQEgHgXy1nI=; b=PbwzHfgAaa4mjLIrdVwCFMfKZNjtLIJa4a BiB3HzGmdanWWA3misUkLtMxvd7GiB/War7q1IFBnaK38FlA3vyHvIgyTY9tiXJI F3TiPDL4GYhNydTC3YFyHC3jrOtc1+Qr7gmWm76HBvVcqSm5ULSHUJTTWaJy9YeZ KLPWwjX7O/qZqia404x0t/QRCQ7LCLxk/+8vYOYEpcPGaifOgZVEDqrtqFS0x44t cz1RvlamYw3YZNuoUf21wQ5YdfcJx+WpndR9LiT+yLYIrRxR2SZRvxndm3yyDwPk FMpX4eGD7cI9ngVru1W08QYZFrCNTGl+nnzYXF4EPOwawq+wQDbA== Received: from phxpaimrmta01.imrmtpd1.prodappphxaev1.oraclevcn.com (phxpaimrmta01.appoci.oracle.com [138.1.114.2]) by mx0b-00069f02.pphosted.com (PPS) with ESMTPS id 42c53ut23d-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Thu, 24 Oct 2024 09:03:41 +0000 (GMT) Received: from pps.filterd (phxpaimrmta01.imrmtpd1.prodappphxaev1.oraclevcn.com [127.0.0.1]) by phxpaimrmta01.imrmtpd1.prodappphxaev1.oraclevcn.com (8.18.1.2/8.18.1.2) with ESMTP id 49O8uwWv030873; Thu, 24 Oct 2024 09:03:40 GMT Received: from nam02-sn1-obe.outbound.protection.outlook.com (mail-sn1nam02lp2041.outbound.protection.outlook.com [104.47.57.41]) by phxpaimrmta01.imrmtpd1.prodappphxaev1.oraclevcn.com (PPS) with ESMTPS id 42emh2ms03-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Thu, 24 Oct 2024 09:03:40 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=dS8mfvc3s9FE06zv++5csXTH146Fb3+9g2s8W6pgvtkpgI0KymsVm/76UZLDq9+4QBHplGgmMrw2HFCNQcxRO9xkwAoXbnp23Smx4tG7kHgP3l7lQrg/iWAPbobDTJHR5aYOf8lrRM8YbIEQSp5o+1o05i4MR4fVxn8ezkRkPMBG6u4k9nlDx3nzBt1/mdw6NSgZqN9Nrr3W4km0k+O84FmSIYU1/Esa76ejM3qJ0Km5GD1pK+aJ0tjRsNJU2KHN0a+pcM5ymSumP4u8zYUg4vGDDFpLMIBBfA5AtQ3u5YjH8lGcwykNmTwo0PGsscfZ05syj8/3uqC3R48j4nuoug== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=9/e7IEUDw9vmHneJ/17uni2wriWFcTvRBQEgHgXy1nI=; b=g2qfz5rbN15U20NsfHuaMYVn/4UZ2VJch39kSNnHYW09jicwrR+tmXAkedoyCwIIUeg+e5AwYQxjTGdGXEYItXf8WgfKq5b52hIcYaMMoNCFD1YcBmKZms8JdfwI7OtPyIKUkE9sevQQW78Dnkj/pQB83tdR2Aw1gYiQru9mYh0LvlL+GKw4JICYz3iK6dba3TkHEwXv6mC+yOJpqWdmQg99dKTDl4C3taj63r1JGBOLihIRw58R1Qx6dVZwj8dIg8WQwEQBXjeOjOfZI3JdEytIkxwf0ofvZILgV5/jC0UxMZZKse7iqkrxltsvVoYdZZxYne68W63LBTv11DEWMA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=oracle.com; dmarc=pass action=none header.from=oracle.com; dkim=pass header.d=oracle.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.onmicrosoft.com; s=selector2-oracle-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=9/e7IEUDw9vmHneJ/17uni2wriWFcTvRBQEgHgXy1nI=; b=Dj2a7QXUo7nfyTJmpiS8fP+lUnL9OKGsR17Lle4Yiufb5ucoBHtTWcPUMKeIIS0TH5tKDmbq8VkfnHG1O2bgM8dh4JUdkHxWMJ8fwK4jDivIIZVidh/7HjKrIBTy8hpCotZunEbXK6rJq5Qud2Ays+1gMR7vLUWsuMOJkXBogdo= Received: from BYAPR10MB3366.namprd10.prod.outlook.com (2603:10b6:a03:14f::25) by PH7PR10MB6965.namprd10.prod.outlook.com (2603:10b6:510:272::7) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.8093.17; Thu, 24 Oct 2024 09:03:38 +0000 Received: from BYAPR10MB3366.namprd10.prod.outlook.com ([fe80::baf2:dff1:d471:1c9]) by BYAPR10MB3366.namprd10.prod.outlook.com ([fe80::baf2:dff1:d471:1c9%6]) with mapi id 15.20.8093.014; Thu, 24 Oct 2024 09:03:38 +0000 Date: Thu, 24 Oct 2024 10:03:34 +0100 From: Lorenzo Stoakes To: Wei Yang Cc: akpm@linux-foundation.org, vbabka@suse.cz, jannh@google.com, linux-mm@kvack.org Subject: Re: [PATCH] mm/vma: the pgoff is correct if can_merge_right Message-ID: References: <20241024084222.17201-1-richard.weiyang@gmail.com> Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20241024084222.17201-1-richard.weiyang@gmail.com> X-ClientProxiedBy: LO4P123CA0612.GBRP123.PROD.OUTLOOK.COM (2603:10a6:600:314::6) To BYAPR10MB3366.namprd10.prod.outlook.com (2603:10b6:a03:14f::25) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: BYAPR10MB3366:EE_|PH7PR10MB6965:EE_ X-MS-Office365-Filtering-Correlation-Id: d4b9672a-ec43-4949-ada5-08dcf40abf60 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|1800799024|376014|366016|10070799003; X-Microsoft-Antispam-Message-Info: =?us-ascii?Q?jFtUdeIstn4ZkdRyCF8jOlvBrjk4Du9nCs/+EsVvRneI8dLDhRlfyCSfuiYH?= =?us-ascii?Q?XrV3QA5Rmww7uL5aN4ItJxMf21f4udiBrlVKj27cScIYm1QfT9b2+bxewsGk?= =?us-ascii?Q?DLnfgC62TfeLXLvs4NUcrYSdZfn/lxvVZrYxrwc/Zqfetd/Q5E77LRT8dhUH?= =?us-ascii?Q?AnTZUOSPkBR4edGw2/bYCZE8xlWN0a5nJR5PrOqKXqi1+6gXa0oymJlbJ0T5?= =?us-ascii?Q?L3psftgweZ/9iISkqoDfO/13l7ivNONbBecD7MtjcvsNEMH3VikHfU44BoBR?= =?us-ascii?Q?2U/PQHXi+++Li0yr2lfw7pqvNe9RlhCE6fZoEEK1Ume9czZ/jU1wdAEzwtIW?= =?us-ascii?Q?ksFBtBWHRkb08ur1+iemuc1ioK/w0A0faE/TSg8BfNL+WxkMWy2kDNZ2uVuF?= =?us-ascii?Q?ztjppdG59bNjqmZSJZAN1myE4QIrjc4wwF6UsGmsFVPujUqQ/9fejqCwGqaw?= =?us-ascii?Q?xO66PGk+bp/L/K6uq3+tSYLGwviVS55k8V7YDY82Zvo56SmCzfDktaOoTZmJ?= =?us-ascii?Q?1vLE5KCa57tI/lW7qXUOjsH3zGiNEEjN7gtciRZtsE8Kgf4hC+ZbrM3KOK3c?= =?us-ascii?Q?kr+T4SIJw7HmZHoLEOud3unD+oALcOWBh/yyDMbZmOfaFLbReWEGf6byZVpO?= =?us-ascii?Q?h2RcZHIDgvlEDqAXaDgWdUwMCAWCE6tvvWUn8lP+ja/qbfOVJfdzrSuNj8a0?= =?us-ascii?Q?sYuMN9Z/RlljcA6YD+b5T1MuxGUF+iGIEnZ9JCwbm7OMaGuUFgEVuldDxuqR?= =?us-ascii?Q?n80AtWNswFJZvW34psLyb1+nM4eOnQJ7Z1rXAFnNU+uQYV2nOkHjZ6Ot3QhN?= =?us-ascii?Q?dPre79iDlXUsTDnufZT+lod90zlXgVZOyWhNHJxylwd3zU83OHnL/+qkPZzp?= =?us-ascii?Q?f4MDd6l/EZI+JA8v/oPx6PHBHXZ2pXAKBEBkF+D9Iks04G9s2GAtOyTjT75U?= =?us-ascii?Q?8mmvVadQiD9f+244IqI6VVn9iNWE2uHaBIWDsNm8FhaagZo8ni68IKHe1AeD?= =?us-ascii?Q?nFDmst7DRg50dgHRxXS2sgHcE8QQwlDlyqgE87BeUjWwPOmt7kInfYhnzyHU?= =?us-ascii?Q?t31bn9+6qbeVf5wuT2wpa7SetGnAwbteLK2aD+4BmcZMCT/ogNoh79IMG2QE?= =?us-ascii?Q?qOOhZ13HcFLCLymgf/BNDGhZzrtJWSbDYzMMYKF8yUt3srfsKRFAUDIorUA+?= =?us-ascii?Q?Hiskx1ImdpHGwQF/Hu3S9k18UxogKOsmXmwTmUsfxP7gZ5gQ+uiSbVPoKqst?= =?us-ascii?Q?01nxgy9QsebdKkUcoV7fpqvJ/KjFeip6VdJ0AMP9t6V/zerRMyj/W7iOICpF?= =?us-ascii?Q?F+4RNnbt4T8f3Ag6F6GlU3Zu?= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BYAPR10MB3366.namprd10.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230040)(1800799024)(376014)(366016)(10070799003);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?KuFlrdNfoi4xK0f7whgf6MG3oRvY9pdG4tubbOYTyaLnYM9FbxWPN0JkS4WR?= =?us-ascii?Q?2Qhd7sCzjzVNVtzdWK1gzPv3MfXz3rHunPAgU2xLEVQha1D4m2X/oLBJ6pmq?= =?us-ascii?Q?3k66bjG4YZ1BeZGgzPe/7IspQW4JhCEgu8g2rl7Uhs5Gxb2hlQtGCp1GJOyi?= =?us-ascii?Q?QlZf6K0Gox+ltMYpVbZ/Bsvs+A55JnSXAbkYE+RMQHT3Z+ixP3UJCnHezgMJ?= =?us-ascii?Q?XS3XxgyPu78rAMwP7DAvnBrtLkZ8Z7Jg0qnv0VE4qKe4/8K722pDYmh8VD1V?= =?us-ascii?Q?82bXIg87IHRjqGo/elEYdNF4L8+aJHLFkHjmQrvTMSY1rlOyQjirGoOwMgCl?= =?us-ascii?Q?skgRzePwS2+TJELNkUZM5LyU+ARPKijtx6zWG4hU1JrmjvEeJoP+KDtr55gW?= =?us-ascii?Q?sR1r4tIVuJ9n65sU6fHldf6QjrnQeladbX+lgN1ePvScPDNRGGWn2l7UKBsW?= =?us-ascii?Q?OYClcOHitktiJIXqo9ocNBZ6PyUAXfBRs5+y/4fEoJTpaXnBjug8Ax4+0UhH?= =?us-ascii?Q?Gsb/cbZGWI0t1IrjBEZI4zPEMjCDOO5lUVWvOl0/AhqogwH0riLzxGasOwIy?= =?us-ascii?Q?MPuUrVL3VqLCq7PwHgw0oHtYH7x7rEFjeNVzG0koCZNh+Qc1M1nIXCnUqQEO?= =?us-ascii?Q?QixlfGM1lnHVvOjVP/KEn5EVj88Pkn0wFh/xdtesuNdGsKEnoUsn0Qz05u+F?= =?us-ascii?Q?dJ1fQCx+lxbvGQOx/yJrQacrzQyC8LlLPtnb62M0JVgNSxDQJJxkgNpx0c7v?= =?us-ascii?Q?q+7hA8JdGZaitkkqIzJGT7N//ffxBCZRWM11XYLdn5rR7YRsQBOD4C0n8TAK?= =?us-ascii?Q?p/yZsWnA48puEcYQUYEa2BWj3ed1EIlzqFOc5vqwSH8vBHgIfEmHa5q5bU60?= =?us-ascii?Q?QwFwGp/LFZy8+7cvyDYhxT4kfp1AfQnWPfNwL10JAexL1D62Y7P0Mcf3j5YP?= =?us-ascii?Q?ebT6au63oFTYWL8nPH5nXKJzsyt5n3Ir2UQxPjs94MSQGPmZhQ1N5/wMyLmH?= =?us-ascii?Q?zKaJw1EkLW3PFM+JndMP3Jlc2bCXj4E2qroA1NMq4TY/R5lw4RhQs4UPhCMX?= =?us-ascii?Q?s+OlAjKAhKz69v9ioQzujh8NWgEIQWwnY3EVVKUmXt4k/zZAn+SldRtZ0KXL?= =?us-ascii?Q?4N8t2/K3pfGoisM7NcOS4T8faCSW01nQywBPmfLBKB8hL7FITI4b29Yjj8Tj?= =?us-ascii?Q?C1oUrZYNzDqS5QHWrZ79PIZLoSzf6kWGsmoxyRQZWP3fnhK7XrrBVEnRNhyk?= =?us-ascii?Q?lkIseQbNJNFNKwC2KD0sDZhHilKWYRGyZjgGI1m0loz9JpFL6SpJcI8M+OR5?= =?us-ascii?Q?O8bLBHMegx02y/CAjGqi7VPhgVzUxErch5TWF2qrhQNooz4IRvJfRT7aEv+r?= =?us-ascii?Q?XVUwX+mWv+dIl7dibbONOw40ySZMjgdyd2G75XCBG3xm+Gge/Npu5SUwT8qb?= =?us-ascii?Q?xlH3Hd+khzZakBB/1zg/fwgr3WIjSwBQqPU1kQUZQSp0pNQahvLBnpi7JdSu?= =?us-ascii?Q?8OsvQhl57Y0Fq/W/Jun73cJknFdMrUwnNxpst3V9jBO2zVqowe+fbqIDWHrF?= =?us-ascii?Q?BRJhe61lxrQtWmzVbY+JDXJJ/s5fgilUFn/ofPxjXhWpkUy8jbCYhnFNON5p?= =?us-ascii?Q?kYH5jh7Jovxb90SRDz/FQxZKdHL8oRJwH63AztTHFglZq/6QODM5jCCMWtpD?= =?us-ascii?Q?d9eGoQ=3D=3D?= X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0: 5ciWwtMPd08dW53npE5YG62qf10k2A3SQSoqIk4zbnflGo6LsBieUOck7+Cr5muliWTzGDvFQNgZsHbh2pb/leQP/ox0cnKo/SYcVzOaCV0FzMKm5eJ/BIvkNs2L624RgYfpuGtpXIH8UZcEn+iXBDdBNxQBp2aQXd1i1xOKmPLHED0RFTjwjLGOUF01juh2H4IxLdEedZrnfND02cHWygj9KJcWXbUGrFHS8qlYSn94EY61KiqUI7UERssKvW1mQ1a6qTq4OradE6rC/PgAG0j5nC71AOCKV8+wuZYMTXw+y2UeUWrNgGCMGjem99Noq5El8fg5UbXPwayJ3Y/OTXMS0UkCM+//2dxIhBza+2yF3obPHXk7hMUxPMBiLfWXZLZkicrBjbUXT1s2Y7DUpHIuit3UQVo1OmRFd7198GP/STi9ThmkJvoaGKD7J1HFkEhkMUSlaaBzP2oOFoDTeEpassymBTblhOxiV639WoVwgSZSJ2WoadTft7ZMBQe8vcaW2ZQMrHgiWcH0IfA1PcbhwX7yyqtusNCZcjdX9kUPE8SZH91+XO6ClHkG50z9h5BI8jYibkEGeidYwSk9nmLpMhzj8YS57RwqXo5UC74= X-OriginatorOrg: oracle.com X-MS-Exchange-CrossTenant-Network-Message-Id: d4b9672a-ec43-4949-ada5-08dcf40abf60 X-MS-Exchange-CrossTenant-AuthSource: BYAPR10MB3366.namprd10.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 24 Oct 2024 09:03:37.9569 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: M/MguuMnc+jsgLfXxKGrzPTaeGfYWKKx9RLn96rXlibNBG1TGP/Pu0k98viKQRqRJ+0HlJCZjQnq+YfsyyXjWz27McGAKbNsjPM1/jIq/fo= X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH7PR10MB6965 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1051,Hydra:6.0.680,FMLib:17.12.62.30 definitions=2024-10-24_08,2024-10-24_01,2024-09-30_01 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 adultscore=0 mlxlogscore=999 phishscore=0 suspectscore=0 mlxscore=0 spamscore=0 bulkscore=0 malwarescore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2409260000 definitions=main-2410240071 X-Proofpoint-GUID: Z_rdO9Pyg-FDrM4v6yIkRa2GzKM_wz8l X-Proofpoint-ORIG-GUID: Z_rdO9Pyg-FDrM4v6yIkRa2GzKM_wz8l X-Rspamd-Queue-Id: 06DC8180015 X-Stat-Signature: hwsrok8zu44bhtdjc9153x6fwikb1y9r X-Rspamd-Server: rspam09 X-Rspam-User: X-HE-Tag: 1729760622-954310 X-HE-Meta: U2FsdGVkX1+4PLyFDokfbYQgbNcZyDx/KPtmRSAYwPbiCyNn91r5AtijDaUOh4KRv/PZdQOaW6i7F8v+ebl1F+acIduz8Q72N9BfwbtW2NydqB6IofVyxE+N/r7RRNSZ7YJEX304cfticFJbgZMA7X30jxKZQBhGirCpHZSwIzefK/82anZXvcO9f83tXXK69U17imRwMQdVcIxaZV+0PS5BpovYzfIVhvaIJ+qSHMpGFmGhDgLIaCtrZns8YJVBmyOQOBqpz85ow4yU44YYl87SlE5ATSTY5Rd5Bz3SLgm8z72oCEvskSWFcjJZftTx36e6BK8DtedkSY5wDIY+EPhS1JE0usc4cDu9LJsm1wjlBDZVdz8TTFQwihq0sTlNX/Kt0YXElff0h/CiSbNdulCb6EE0xXjdnSrKVlK5AXEb+OYUC2boHKxrVaGPcttJyuSXMK+0XhEabK23TOZVSDgya9pbN4KOJLkFnDWOasDqbWbsJFrcvB9xvz67fYLFw1fNUueW4D+vOxlAesiOG9BWk/xIL9tcOSpCVTUHvS6uJFyBvQntzb5DqTdXTldaBUP4I2qh8rdwo8MnwlIY9yuQtxCCSS8S/sMb53GYKP5Kk9pxSg0MvlM8wu6iL80E1HjKkMA0N3Sf64VofO8Pe6QWP3u4lLCvFx64gM+XJbqgs9O0fbAddwGT88keKhkE1J3L3L1Ojp0u0l0NVRGQ7oGpnYJHVVGgP6oQSuUbj4gHR+ZWlYcKbSY2afW8guenAN3yv1hA1FCtxOisKuZGr5CNcXYmisKAztZzGEk7r4XPDTJkHHzZ7I4tLHt0OTOKx8CElww493PeNRsxlqKhh8kKaIDr7N4MQLj4PbudjANzIndj4yQB10aTTkzHpAZoN0+sLSWFHgdgDjUDpXiq08OOPe7dpeA7oUM1KnwSFD3fwLBMSN9ODo7NMWuPDUnmgE/83pNw+WGWA8YIYf/ b8EZuJE8 LE7DTafQydnEvScZzNp62kEN+T+dO8AqFydUo4UEBnUgvn8cQCEIaJYEHXF8d2fXxJhwR1M2aVf7CF6BZVwsI9wgmame5zKijPx2+olhzYZWzTGPXw77q4WvN2LR4LW0jycNay8pSZOmU/v33s9Si66yfpUYfPNv9YLWNIXT1dnMCAtYk6bIlOkF8jaWoV7eG15NmK6kH6L52Tcz52QOtEpM+sNSsRQ+dum+OQej5mRkCcyE2q4bsNjLJQQkBVGf57JlmuZwzgxHRdLhrkcmF4R97/MvO103xXtP9EdOMSh1FYPPy1zGa78nLANbDBM7t5KhFv/Jm/WHxG9k7tIiQnlPRmgOp8clDoWnzehDsX9TKF9i5x3p+slIZvNaam+dZRKrI2mYltaJRu8DR4GF3h5laqYhmlXLth1WVr3iITyyD4eegvxvB9B2qZ5kxd19XjJz5u3YcMWxjIxgJgRZo61EMIB0NfcIB7j8U8mPdhWt6CESOQnyibkwDOfsVxx0oCOy7RhDaCb9i2fLvI6/guZxJty+HKZgdWXMJKmNQ+eVZW1Kpg50DOYVcUlN10MMo//ZxEnMyyoXbLs5ZhcnNRlLHd4aWSVfLjMx7h79pkl6UzeeIRw+T7A1ef8RoPZ9a0VBQ7H9owzj32WnENkorwetMBg== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Thu, Oct 24, 2024 at 08:42:22AM +0000, Wei Yang wrote: > can_merge_right implies can_vma_merge_right() has checked the pgoff. > > Don't need to assign it again. Would prefer a bigger commit message something like: By this point can_vma_merge_right() must have returned true, which implies can_vma_merge_before() also returned true, which already asserts that the pgoff is as expected for a merge with the following VMA, thus this assignment is redundant. > > Signed-off-by: Wei Yang Reviewed-by: Lorenzo Stoakes > CC: Lorenzo Stoakes > --- > mm/vma.c | 2 -- > 1 file changed, 2 deletions(-) > > diff --git a/mm/vma.c b/mm/vma.c > index 4737afcb064c..fb4f1863f88e 100644 > --- a/mm/vma.c > +++ b/mm/vma.c > @@ -915,7 +915,6 @@ struct vm_area_struct *vma_merge_new_range(struct vma_merge_struct *vmg) > unsigned long start = vmg->start; > unsigned long end = vmg->end; > pgoff_t pgoff = vmg->pgoff; > - pgoff_t pglen = PHYS_PFN(end - start); > bool can_merge_left, can_merge_right; > > mmap_assert_write_locked(vmg->mm); > @@ -936,7 +935,6 @@ struct vm_area_struct *vma_merge_new_range(struct vma_merge_struct *vmg) > if (can_merge_right) { > vmg->end = next->vm_end; > vmg->vma = next; > - vmg->pgoff = next->vm_pgoff - pglen; > } > > /* If we can merge with the previous VMA, adjust vmg accordingly. */ > -- > 2.34.1 > > Thanks, nice spot! For the purposes of explaining it on-list this is because: static bool can_vma_merge_right(struct vma_merge_struct *vmg, bool can_merge_left) { if (!vmg->next || vmg->end != vmg->next->vm_start || !can_vma_merge_before(vmg)) return false; ... } And: static bool can_vma_merge_before(struct vma_merge_struct *vmg) { pgoff_t pglen = PHYS_PFN(vmg->end - vmg->start); ... if (vmg->next->vm_pgoff == vmg->pgoff + pglen) return true; ... } Which implies vmg->pgoff == vmg->next->vm_pgoff - pglen. None of these values are changed between the check and prior assignment, so this was an entirely redundant assignment.