From: Avi Kivity <avi@scylladb.com>
To: Yang Shi <shy828301@gmail.com>
Cc: linux-mm <linux-mm@kvack.org>,
Baolin Wang <baolin.wang@linux.alibaba.com>
Subject: Re: Possible regression with file madvise(MADV_COLLAPSE)
Date: Sun, 13 Oct 2024 16:25:52 +0300 [thread overview]
Message-ID: <eb4cef9268d9c7320c3d4556f54c774f1681c43f.camel@scylladb.com> (raw)
In-Reply-To: <9ebd0aad60ca97fd3987fc4730dee0e3e021929c.camel@scylladb.com>
On Sun, 2024-10-13 at 14:04 +0300, Avi Kivity wrote:
> > >
> > > text-hugepage-689146 [023] 200457.073794:
> > > mm_khugepaged_scan_file:
> > > mm=0xffff92fc512aac00, scan_pfn=0x5a4310, filename=text-hugepage,
> > > present=0, swap=0, result=page_compound
> >
> > Aha, it is because v6.10 doesn't support collapse non-PMD order
> > large
> > folios. It has been fixed in v6.12-rc1. The patch series is:
> > https://lore.kernel.org/all/cover.1724140601.git.baolin.wang@linux.
> > al
> > ibaba.com/
> >
> > The subject says "shmem", but it actually works for regular files
> > too.
>
>
>
> Thanks a lot. I will retest when 6.12 reaches Fedora testing.
>
It is available, so I retested it (6.12-rc2). I confirm it works (and
delivers a nice performance improvement).
next prev parent reply other threads:[~2024-10-13 13:26 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-10-09 15:54 Avi Kivity
2024-10-11 6:32 ` Gavin Shan
2024-10-11 22:29 ` Yang Shi
2024-10-12 15:38 ` Avi Kivity
2024-10-12 20:05 ` Yang Shi
2024-10-12 20:24 ` Avi Kivity
2024-10-12 23:50 ` Yang Shi
2024-10-13 11:04 ` Avi Kivity
2024-10-13 13:25 ` Avi Kivity [this message]
2024-10-14 22:06 ` Yang Shi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=eb4cef9268d9c7320c3d4556f54c774f1681c43f.camel@scylladb.com \
--to=avi@scylladb.com \
--cc=baolin.wang@linux.alibaba.com \
--cc=linux-mm@kvack.org \
--cc=shy828301@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox