From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 993E4C27C53 for ; Sun, 16 Jun 2024 13:45:40 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 9A27B6B00B1; Sun, 16 Jun 2024 09:45:39 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 9512D6B00B5; Sun, 16 Jun 2024 09:45:39 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 819196B00DE; Sun, 16 Jun 2024 09:45:39 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id 630756B00B1 for ; Sun, 16 Jun 2024 09:45:39 -0400 (EDT) Received: from smtpin05.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id CCD9E81100 for ; Sun, 16 Jun 2024 13:45:38 +0000 (UTC) X-FDA: 82236874356.05.09B66EF Received: from out30-111.freemail.mail.aliyun.com (out30-111.freemail.mail.aliyun.com [115.124.30.111]) by imf11.hostedemail.com (Postfix) with ESMTP id 89F9140011 for ; Sun, 16 Jun 2024 13:45:35 +0000 (UTC) Authentication-Results: imf11.hostedemail.com; dkim=pass header.d=linux.alibaba.com header.s=default header.b=NYDCgzNb; spf=pass (imf11.hostedemail.com: domain of baolin.wang@linux.alibaba.com designates 115.124.30.111 as permitted sender) smtp.mailfrom=baolin.wang@linux.alibaba.com; dmarc=pass (policy=none) header.from=linux.alibaba.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1718545534; a=rsa-sha256; cv=none; b=yZWutLC54/FpNtOKdkUpfwQ1bRwn3Qj/ChxDl+B5/SN93xEZNyAXZiDiH7FDqS5JCnPCEl pBceyJiqglHCmrNXzbte5aiVe7pcTW0KMqpQZUXvLTyxBKYGE5YAuVooyJFyzRFd8/FDUo PD9qjFPe3VMoZnJZq2d9g20gZlzcmVM= ARC-Authentication-Results: i=1; imf11.hostedemail.com; dkim=pass header.d=linux.alibaba.com header.s=default header.b=NYDCgzNb; spf=pass (imf11.hostedemail.com: domain of baolin.wang@linux.alibaba.com designates 115.124.30.111 as permitted sender) smtp.mailfrom=baolin.wang@linux.alibaba.com; dmarc=pass (policy=none) header.from=linux.alibaba.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1718545534; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=FAPsRudpBPFKShe4Rryv6Xn3KvUyS639w+weoNz/1Ao=; b=NL1VLqkGr19bHXWtPnXDEC9L0rbo5AEyDAMikgFZsfvEoV3E05hnpozcTI7dIHLkXOXQd1 38qq1wRFEaRrf8CA1hQSqcybZXakppf2ou8PsHmPw+yLQbipZCUtXpayYUpCyfug27xMMW mQy7bJgtRr+6ZrwMd08kq2AR58y68sY= DKIM-Signature:v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.alibaba.com; s=default; t=1718545529; h=Message-ID:Date:MIME-Version:Subject:To:From:Content-Type; bh=FAPsRudpBPFKShe4Rryv6Xn3KvUyS639w+weoNz/1Ao=; b=NYDCgzNb1eRMI2xQg29ixJ61d7EZPyvmrOsEjdj3M3JDZa8C7HqEkgrf+84FUgzj67jfG9sjZ4pKobwIw0dM3XBzv5R0MSZmbsO0IYVeXGqlZdzE3Qm4gVej0N8R+ggS/dSeXbw/cjkr2eaXpyUvZfLjHudVUVbI51hmbSQul28= X-Alimail-AntiSpam:AC=PASS;BC=-1|-1;BR=01201311R131e4;CH=green;DM=||false|;DS=||;FP=0|-1|-1|-1|0|-1|-1|-1;HT=maildocker-contentspam033037067111;MF=baolin.wang@linux.alibaba.com;NM=1;PH=DS;RN=4;SR=0;TI=SMTPD_---0W8Vy2Jz_1718545527; Received: from 192.168.0.106(mailfrom:baolin.wang@linux.alibaba.com fp:SMTPD_---0W8Vy2Jz_1718545527) by smtp.aliyun-inc.com; Sun, 16 Jun 2024 21:45:28 +0800 Message-ID: Date: Sun, 16 Jun 2024 21:45:27 +0800 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [linux-next:master 4839/5501] mm/shmem.c:139:24: warning: 'huge_shmem_orders_lock' defined but not used To: kernel test robot Cc: oe-kbuild-all@lists.linux.dev, Linux Memory Management List , Andrew Morton References: <202406152213.CoQNZR6z-lkp@intel.com> From: Baolin Wang In-Reply-To: <202406152213.CoQNZR6z-lkp@intel.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Stat-Signature: rudmyy6a33wohq19aw7fa46tmsn7y8uy X-Rspamd-Queue-Id: 89F9140011 X-Rspam-User: X-Rspamd-Server: rspam10 X-HE-Tag: 1718545535-381673 X-HE-Meta: U2FsdGVkX19n81a16u1vcsPi52y0FOvxds4fGIf0kyZIGdBIt+pQUJx9zfM4ODEz11yncBYYFsZLDIia61eY/jgbufyWFeNOVe5MEelByF+JRRjqK52LkIqk/+kKf30n+PmJRWxlJKg2thiL7J9DXYf3/GYlNjZ5mbpr+5GbESRhfo3RkTTL54aHryoUuVGvGOvsfayvIqM4ezaqnuu+1FdytI+BOqBfuXWHWzzI5WMUV0vYg5EA9axjbx9FdQwJJ2IPEYbf1mHP4lkBNqRFm/3863bHqOEpCH/rp0M0QsAYlIrXs8DTXJpx71ZqHyKVokwR6drbBFVod42xld3D358PC8XrEy4hqaYSf5c6flKpeWO0R8a8ahgzifmbZ9V9+16Qqzw1InUSIZEBGUAmb/8hl2Hc+UuOdjEWPyeKSJMltQYqYOjV0W+x4P9z0441lCDmPfUz4b+VPnK+4HiXc4zb8a+kHEfpvVB7O50eBp1PnpOGk5fNTWd75Vnr1vnwuOzxXOdM5eg2HCLe9J3Kf7QlGkPUo2mwKd17R+k56UAyj9zuyDlbx4ByflXPcaIfh4JSINFaR2d6W+SGrXhFIjmqycdmauVBnq0QnR7XYLL6s+xw6QcUCN7xOl/VzYiwkmaelAdF1b+hgy2zSWxnKFn9Y8NHEMk8jbtlu5U91qyltUQeB7fsKGQ1KOFNT/p69Wy7diTJewnoslF8AMA1bphUwGHlBqU5TDGXAPvMn1o/8yEM5X0GxfEgznMNfhp2KmQVWKNZc3IJe3ClaT16gZANZJYm3y1WTeS3+K0cv4zv2AzIHGi+GuFd5rLha8fz3ENfGGcmBQ/CZNrAJPY9aGqpHOg41xaEBjs/LSXhjGzdZTw8eO/CQHCJc3cKeR5RFqyLQS6r/GB1NNUvXqafcm+JIXIu0bWjPiE1NpDPjBPik8Bx+geJGAQS7SiuSsgQraP+agnmkH6F/ywRify KmqNum1f ZUwu4lmro0O1+UKUUHezq0mBv0MT3a4U3nNDmaoDwVAiMg3xGD70+Tqh91qILXl0CorkSootUbtIylfH+Ye+9SAQ4kg9sC1k/AJHsLloxwg+qAoONO2CVI0Fjhnl8VhIhKczr77+s3XinyE07HCltOdpIXg9wVPrfDsuw6+jxCm8mQpXMJIRSI2wBnfxfdkeNYS5rTbF08wsKfEqpIMqhe2+LewK18sJCngwbL/zX3XJz2ho1teD1aclAuYKD+xlienUvXwOFA04uvxvvExBG7bxEpSndBPbyET4rd92zeOK9NYwaL5F+/rdu7n9pIzagH2S34ZtDN70KTUYqDxh2LH6ELOxWGJRHAsVzoyeI6ANxbmEC4cnuiwqoQtIyLKvfeIEjLShYdnHjS7d5DGDXaxFV70OrrJhS0TY4tBBjr6RLOZGLUd17e5oUxIlrRBnMmIyxvsfuObveVw0= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 2024/6/15 22:15, kernel test robot wrote: > tree: https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git master > head: 6906a84c482f098d31486df8dc98cead21cce2d0 > commit: dfe69b2f4ed49aee4a46f09010f7888ee289083d [4839/5501] mm: shmem: add multi-size THP sysfs interface for anonymous shmem > config: mips-randconfig-r034-20220430 (https://download.01.org/0day-ci/archive/20240615/202406152213.CoQNZR6z-lkp@intel.com/config) > compiler: mips-linux-gcc (GCC) 13.2.0 > reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20240615/202406152213.CoQNZR6z-lkp@intel.com/reproduce) > > If you fix the issue in a separate patch/commit (i.e. not just a new version of > the same patch/commit), kindly add following tags > | Reported-by: kernel test robot > | Closes: https://lore.kernel.org/oe-kbuild-all/202406152213.CoQNZR6z-lkp@intel.com/ > > All warnings (new ones prefixed by >>): > > In file included from include/linux/spinlock.h:89, > from include/linux/wait.h:9, > from include/linux/wait_bit.h:8, > from include/linux/fs.h:6, > from mm/shmem.c:24: >>> mm/shmem.c:139:24: warning: 'huge_shmem_orders_lock' defined but not used [-Wunused-variable] > 139 | static DEFINE_SPINLOCK(huge_shmem_orders_lock); > | ^~~~~~~~~~~~~~~~~~~~~~ > include/linux/spinlock_types.h:43:44: note: in definition of macro 'DEFINE_SPINLOCK' > 43 | #define DEFINE_SPINLOCK(x) spinlock_t x = __SPIN_LOCK_UNLOCKED(x) > | ^ > mm/shmem.c:138:22: warning: 'huge_shmem_orders_within_size' defined but not used [-Wunused-variable] > 138 | static unsigned long huge_shmem_orders_within_size __read_mostly; > | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~ > mm/shmem.c:136:22: warning: 'huge_shmem_orders_madvise' defined but not used [-Wunused-variable] > 136 | static unsigned long huge_shmem_orders_madvise __read_mostly; > | ^~~~~~~~~~~~~~~~~~~~~~~~~ > mm/shmem.c:135:22: warning: 'huge_shmem_orders_always' defined but not used [-Wunused-variable] > 135 | static unsigned long huge_shmem_orders_always __read_mostly; > | ^~~~~~~~~~~~~~~~~~~~~~~~ > > > vim +/huge_shmem_orders_lock +139 mm/shmem.c > > 133 > 134 #ifdef CONFIG_TRANSPARENT_HUGEPAGE > 135 static unsigned long huge_shmem_orders_always __read_mostly; > 136 static unsigned long huge_shmem_orders_madvise __read_mostly; > 137 static unsigned long huge_shmem_orders_inherit __read_mostly; > 138 static unsigned long huge_shmem_orders_within_size __read_mostly; > > 139 static DEFINE_SPINLOCK(huge_shmem_orders_lock); > 140 #endif > 141 Thanks for reporting. I should move the 'huge_shmem_orders_lock' under CONFIG_SYSFS config. @Andrew, please help to squash the following fix into this patch. Thanks. diff --git a/mm/shmem.c b/mm/shmem.c index 4acaf02bfe44..d09c6bf1f28a 100644 --- a/mm/shmem.c +++ b/mm/shmem.c @@ -136,7 +136,6 @@ static unsigned long huge_shmem_orders_always __read_mostly; static unsigned long huge_shmem_orders_madvise __read_mostly; static unsigned long huge_shmem_orders_inherit __read_mostly; static unsigned long huge_shmem_orders_within_size __read_mostly; -static DEFINE_SPINLOCK(huge_shmem_orders_lock); #endif #ifdef CONFIG_TMPFS @@ -4918,6 +4917,7 @@ static ssize_t shmem_enabled_store(struct kobject *kobj, } struct kobj_attribute shmem_enabled_attr = __ATTR_RW(shmem_enabled); +static DEFINE_SPINLOCK(huge_shmem_orders_lock); static ssize_t thpsize_shmem_enabled_show(struct kobject *kobj, struct kobj_attribute *attr, char *buf)