From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id C0939C021B2 for ; Sat, 22 Feb 2025 16:06:39 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id E84E56B009A; Sat, 22 Feb 2025 11:06:38 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id E0EC66B009B; Sat, 22 Feb 2025 11:06:38 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id C87246B009C; Sat, 22 Feb 2025 11:06:38 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id AA6526B009A for ; Sat, 22 Feb 2025 11:06:38 -0500 (EST) Received: from smtpin16.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay04.hostedemail.com (Postfix) with ESMTP id 1667F1A153D for ; Sat, 22 Feb 2025 16:06:38 +0000 (UTC) X-FDA: 83148058476.16.6DE88FC Received: from shelob.surriel.com (shelob.surriel.com [96.67.55.147]) by imf16.hostedemail.com (Postfix) with ESMTP id 46AC818001A for ; Sat, 22 Feb 2025 16:06:36 +0000 (UTC) Authentication-Results: imf16.hostedemail.com; dkim=none; dmarc=none; spf=pass (imf16.hostedemail.com: domain of riel@shelob.surriel.com designates 96.67.55.147 as permitted sender) smtp.mailfrom=riel@shelob.surriel.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1740240396; a=rsa-sha256; cv=none; b=HUxQjhfloQvcUiQUlILMQ9o/KQoMf0aSUtns3Hw4+1LMdoLzwQ1XX9Y3OGfHskuFlbAR9v tYEboKmdLERIxsvIMReKT5RDTLMrb2rs80VUNMUNBneFVP8Q8ss1PEXU1SqUeQnU+0lXOj iZt0TY1QNlyLDP2JHgFkHzzEj3+6hwI= ARC-Authentication-Results: i=1; imf16.hostedemail.com; dkim=none; dmarc=none; spf=pass (imf16.hostedemail.com: domain of riel@shelob.surriel.com designates 96.67.55.147 as permitted sender) smtp.mailfrom=riel@shelob.surriel.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1740240396; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=BXw1/d0rJarfK7wTnPNQifUaKFTxO69ILwaZSymwyjo=; b=6nx1aV1Gc+4bKItiAzMJ9D/twqpa4LKCOfJYLlEODCtvpBCY2ZQVrFgnCKkaX+vErEL/pq Geiz0hgKWtxqSrpUsOv6Y/mzduV9zEFbYqL5jyDUa6gH24PT8G1wPhoAwiT+coG3twYgH5 W/TUPqG4TbhOuXtqSgoLS4Whd08BdUQ= Received: from fangorn.home.surriel.com ([10.0.13.7]) by shelob.surriel.com with esmtpsa (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.97.1) (envelope-from ) id 1tls0b-000000005J6-0BJb; Sat, 22 Feb 2025 11:05:41 -0500 Message-ID: Subject: Re: [PATCH v12 00/16] AMD broadcast TLB invalidation From: Rik van Riel To: Oleksandr Natalenko , x86@kernel.org Cc: linux-kernel@vger.kernel.org, bp@alien8.de, peterz@infradead.org, dave.hansen@linux.intel.com, zhengqi.arch@bytedance.com, nadav.amit@gmail.com, thomas.lendacky@amd.com, kernel-team@meta.com, linux-mm@kvack.org, akpm@linux-foundation.org, jackmanb@google.com, jannh@google.com, mhklinux@outlook.com, andrew.cooper3@citrix.com, Manali.Shukla@amd.com Date: Sat, 22 Feb 2025 11:05:41 -0500 In-Reply-To: <5861243.DvuYhMxLoT@natalenko.name> References: <20250221005345.2156760-1-riel@surriel.com> <5861243.DvuYhMxLoT@natalenko.name> Autocrypt: addr=riel@surriel.com; prefer-encrypt=mutual; keydata=mQENBFIt3aUBCADCK0LicyCYyMa0E1lodCDUBf6G+6C5UXKG1jEYwQu49cc/gUBTTk33A eo2hjn4JinVaPF3zfZprnKMEGGv4dHvEOCPWiNhlz5RtqH3SKJllq2dpeMS9RqbMvDA36rlJIIo47 Z/nl6IA8MDhSqyqdnTY8z7LnQHqq16jAqwo7Ll9qALXz4yG1ZdSCmo80VPetBZZPw7WMjo+1hByv/ lvdFnLfiQ52tayuuC1r9x2qZ/SYWd2M4p/f5CLmvG9UcnkbYFsKWz8bwOBWKg1PQcaYHLx06sHGdY dIDaeVvkIfMFwAprSo5EFU+aes2VB2ZjugOTbkkW2aPSWTRsBhPHhV6dABEBAAG0HlJpayB2YW4gU mllbCA8cmllbEByZWRoYXQuY29tPokBHwQwAQIACQUCW5LcVgIdIAAKCRDOed6ShMTeg05SB/986o gEgdq4byrtaBQKFg5LWfd8e+h+QzLOg/T8mSS3dJzFXe5JBOfvYg7Bj47xXi9I5sM+I9Lu9+1XVb/ r2rGJrU1DwA09TnmyFtK76bgMF0sBEh1ECILYNQTEIemzNFwOWLZZlEhZFRJsZyX+mtEp/WQIygHV WjwuP69VJw+fPQvLOGn4j8W9QXuvhha7u1QJ7mYx4dLGHrZlHdwDsqpvWsW+3rsIqs1BBe5/Itz9o 6y9gLNtQzwmSDioV8KhF85VmYInslhv5tUtMEppfdTLyX4SUKh8ftNIVmH9mXyRCZclSoa6IMd635 Jq1Pj2/Lp64tOzSvN5Y9zaiCc5FucXtB9SaWsgdmFuIFJpZWwgPHJpZWxAc3VycmllbC5jb20+iQE +BBMBAgAoBQJSLd2lAhsjBQkSzAMABgsJCAcDAgYVCAIJCgsEFgIDAQIeAQIXgAAKCRDOed6ShMTe g4PpB/0ZivKYFt0LaB22ssWUrBoeNWCP1NY/lkq2QbPhR3agLB7ZXI97PF2z/5QD9Fuy/FD/jddPx KRTvFCtHcEzTOcFjBmf52uqgt3U40H9GM++0IM0yHusd9EzlaWsbp09vsAV2DwdqS69x9RPbvE/Ne fO5subhocH76okcF/aQiQ+oj2j6LJZGBJBVigOHg+4zyzdDgKM+jp0bvDI51KQ4XfxV593OhvkS3z 3FPx0CE7l62WhWrieHyBblqvkTYgJ6dq4bsYpqxxGJOkQ47WpEUx6onH+rImWmPJbSYGhwBzTo0Mm G1Nb1qGPG+mTrSmJjDRxrwf1zjmYqQreWVSFEt26tBpSaWsgdmFuIFJpZWwgPHJpZWxAZmIuY29tP okBPgQTAQIAKAUCW5LbiAIbIwUJEswDAAYLCQgHAwIGFQgCCQoLBBYCAwECHgECF4AACgkQznneko TE3oOUEQgAsrGxjTC1bGtZyuvyQPcXclap11Ogib6rQywGYu6/Mnkbd6hbyY3wpdyQii/cas2S44N cQj8HkGv91JLVE24/Wt0gITPCH3rLVJJDGQxprHTVDs1t1RAbsbp0XTksZPCNWDGYIBo2aHDwErhI omYQ0Xluo1WBtH/UmHgirHvclsou1Ks9jyTxiPyUKRfae7GNOFiX99+ZlB27P3t8CjtSO831Ij0Ip QrfooZ21YVlUKw0Wy6Ll8EyefyrEYSh8KTm8dQj4O7xxvdg865TLeLpho5PwDRF+/mR3qi8CdGbkE c4pYZQO8UDXUN4S+pe0aTeTqlYw8rRHWF9TnvtpcNzZw== Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable User-Agent: Evolution 3.54.3 (3.54.3-1.fc41) MIME-Version: 1.0 X-Rspamd-Queue-Id: 46AC818001A X-Stat-Signature: 9pq8317y7bgh1f5xzd6cnoe5s6sas17f X-Rspam-User: X-Rspamd-Server: rspam10 X-HE-Tag: 1740240396-386907 X-HE-Meta: U2FsdGVkX18RmzJse7EmWQS4xUjCKZ+bQQHR8t0hKMhYKnGtxEfEHyzusF17EOmhkupanQL1H/ldjUyYQYLECvb2FzVH9+DEm4VaUaxsX9HeMy7vhZT1LCGXoaeWUSYyUreZQvFRXv6VO7jI0EmdjJoi3OK53XZVypOmDiyGQ4tMLPESq8ynslRfvb9H4xwlzvtCXHtPylNS7p01yOAAqaHtfbv8zf3rmhsg8EnRA1a1FiQeNX6zntxn3d3w92aY50mxWLyKZHhlgHBBicEHoUhNQRjI3NaIRajTRhMTl7PTcfKyW1taC6lMl3DNeZAajOnjNwc2sCU8v6HS++H0Abs37U3Cwn/ZKX9vprWydMHAdKShlPeFpm5X+4Y8jPR+9T5fBDJ43mAUBSRgpZEAwKIuD1pOE01LlJ4kCOQPPOfSGr9gcPkWtmucGQjOtCmcf0forynVg21SCS5lzA2Eo9+QSHhtAvuDtjNanI+zpUY7LLH1EelaD/SmJdczRHhJnOyqTIIvh2tvK4Z1dWPaBjybErNLdwIyP8gDEMg+mkaW2MfhLpXAuGf8Uj6WCn1o2e4uu3ga41qnOgo6vqEeHtwpIo9E5Jekmy6QGjGGkhtONwnjypd/OTiE3NsBgFfNeL0GTbGE5CFxJwH/2g3lPl+pjGPrOG5nwohWFhqRlEZoLwv7CGVSsJLc3GP4i4K9CHNwCxA3Amo5KJ2PdAQyoZCxvc8vetC2tU0kNQWhRrEF4WqZhYRbjDogwC6o7GcDIjr1CEEhf/SjriTe4dhgZuGHu1t6y4G7179TDZQa2L/hA7zU54H1Yu1Ci5nHBfOQwbafPj3CEeMiikOb9vxOjDKS22YeOgpdM39KQeQBXewZRwo22i9YmmhpL4VR6O9dLqZrd8n8Xss0R46hRvKtPJdEzCUMTMBea82YzMNdt8LIi2enMx7IX3LLURrnOUBEHqD/25QIw5GbWMQ5dDC OCz6eWOJ Y45q1PvX3M65GTcs+uWviOpD5lr6XCMWKcfA9Ky8UYBGwZpLhwiwOqVotiEeiHayM24YjmQDfbQiV7BfaTw8xWSxs2eeF1bL4yiaGds5BkoPSwE1tVYaH2X8aJNb1iNWFvAyZAuE4frroIHtWDzqGhWiPzDhXI0ehnAK13FfjKFmG7ktrTgw0PLkqQwO8dKOwx/99kPd4C0Vu12VvUq8sAaUm7/kyQDjqo0ZrgwhpXTgPNaNVDmfBhvtFIZn9alP/dbj/Ysb664sT/DAJxc6A2bDV93ogwXrTRsQi+CgouD4diqipb/ASS4D4Y5xTpOHmf+mYzh0inK2dRs+a/UoPFYASSQ== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Sat, 2025-02-22 at 12:29 +0100, Oleksandr Natalenko wrote: >=20 > [=C2=A0=C2=A0 24.381400] RIP: 0010:get_cpu_cap+0x39b/0x4f0 >=20 > $ scripts/faddr2line arch/x86/kernel/cpu/common.o get_cpu_cap+0x39b > get_cpu_cap+0x39b/0x500: > get_cpu_cap at =E2=80=A6/arch/x86/kernel/cpu/common.c:1063 >=20 > 1060=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 if (c->extended_cpui= d_level >=3D 0x80000008) { > 1061=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2= =A0=C2=A0=C2=A0=C2=A0=C2=A0 cpuid(0x80000008, &eax, &ebx, &ecx, &edx); > 1062=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2= =A0=C2=A0=C2=A0=C2=A0=C2=A0 c->x86_capability[CPUID_8000_0008_EBX] =3D ebx; > 1063=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2= =A0=C2=A0=C2=A0=C2=A0=C2=A0 invlpgb_count_max =3D (edx & 0xffff) + 1; > 1064=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 } > ``` >=20 > Any idea what I'm looking at? It's crashing when writing the value to the invlpgb_count_max variable. This would be because: 1) invlpgb_count_max is marked __ro_after_init, making it read-only after the system has finished booting, but 2) get_cpu_cap gets run at resume and CPU hotplug time! Borislav, do you prefer I move the initialization of=C2=A0 invlpgb_count_max back to where it was before, or get rid of the __ro_after_init thing? --=20 All Rights Reversed.