From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id B8D60C61DF4 for ; Fri, 24 Nov 2023 19:57:08 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 498916B00BC; Fri, 24 Nov 2023 14:57:08 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 449626B00C0; Fri, 24 Nov 2023 14:57:08 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 2C2AE6B038F; Fri, 24 Nov 2023 14:57:08 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id 1CAC36B00BC for ; Fri, 24 Nov 2023 14:57:08 -0500 (EST) Received: from smtpin16.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id E2650140701 for ; Fri, 24 Nov 2023 19:57:07 +0000 (UTC) X-FDA: 81493906494.16.394F107 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by imf19.hostedemail.com (Postfix) with ESMTP id 9D08F1A000A for ; Fri, 24 Nov 2023 19:57:05 +0000 (UTC) Authentication-Results: imf19.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=FzoI0IhG; spf=pass (imf19.hostedemail.com: domain of david@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1700855825; a=rsa-sha256; cv=none; b=XoZF7IzD1hK6jxiLzhefyp/FaW0Xo5WAIBB2l8OQY82Ktl4hRZY75TeRqYEhJdEa6Bbmft 6cJPC2WFDUe/Z74q+e4ighXtms6YSLJi5toLKSSAJeoryDyHxZbEMyCVU5EnAbgWnrh8SS RMSAVcFpWa/d/wnMud21CG8bWOkRkyc= ARC-Authentication-Results: i=1; imf19.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=FzoI0IhG; spf=pass (imf19.hostedemail.com: domain of david@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1700855825; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=Ah4fZH2rG3znuoLxPelnFV7M3I6wQ3yjilDYXu8uVGw=; b=LWgzAgokQdTxiAqx5fNayTx1v0H6keQYhfcTjPqiv8WEnvvKjStSp9DVDjTqQMJMn2C01E 7AaG4mYzB4NhRY0vbSNUooucqPu2AXyhpjMonGlBi8EAN7x7tM2dAf2bNRilL9Fn/X+mhO wwOgUjYob4QnIEAJfjvLJIEed5cc4fA= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1700855825; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=Ah4fZH2rG3znuoLxPelnFV7M3I6wQ3yjilDYXu8uVGw=; b=FzoI0IhG3vhYfAWpMghN380rtSqp7bi4VCSOOF2SYpzZNZIgvV37U8nGHy6xwDiks5WSNk BQwQnRo7j2ae6nHfE1dqArAHbUbaZ3UpCFjJRKykBetFtACXxxMEVw6GcVijJkDL/VIaJz NLkluqvDhQ7pWU/qUuw8pMa5FIUe6Rk= Received: from mail-wm1-f72.google.com (mail-wm1-f72.google.com [209.85.128.72]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-5-ZLVaWvymNwuGo38wTohjuA-1; Fri, 24 Nov 2023 14:57:03 -0500 X-MC-Unique: ZLVaWvymNwuGo38wTohjuA-1 Received: by mail-wm1-f72.google.com with SMTP id 5b1f17b1804b1-40b29868c6eso12012615e9.3 for ; Fri, 24 Nov 2023 11:57:03 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1700855822; x=1701460622; h=content-transfer-encoding:in-reply-to:organization:autocrypt:from :references:cc:to:content-language:subject:user-agent:mime-version :date:message-id:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=Ah4fZH2rG3znuoLxPelnFV7M3I6wQ3yjilDYXu8uVGw=; b=ZKRgyJ087U30IXHqafaXCrFhkKssnQSas+WAx/c6N3xZjXSMcUS0kCFSluWg2yUuJP K5fjEMKfaQg6t+F6fNmYnkbN2DEbvCZO3rE32k0H8Vtwy3H3KOqPhj2MaNYIulrvKP41 wDAXR7+74OUnGEn844OLhrKyjznfPrNW914IcLOg/08Friha+nOHsCLDh2xqKxvmECqr OQi7JzdfF8F0pWoExhxnv56rGA6KGPyvGkBH7w8hyD0+FGa8LIv2lDZQsATL5JQk66VY uzD88QNxvXsS/4JyMOG+ERbKgmw1n0LTWmkYOMD1dF6JGJLuP+Vvvgv3L52hcuu2vxwY vmwA== X-Gm-Message-State: AOJu0Yww5deREbJssaKysl9g7bMr745yzsGn/T4z19njCPhp7r+1OBVX bS62g4vTeZb07PQFoDnYCKLYRzihAxTE6LSVbBE3sd+QsKKcRMsgUbZMFBnGM4hcayJ0e44PmZm yxJwXUYdDSzuLTRN4OEc= X-Received: by 2002:a05:600c:19ce:b0:40a:3750:46ff with SMTP id u14-20020a05600c19ce00b0040a375046ffmr3323942wmq.11.1700855822519; Fri, 24 Nov 2023 11:57:02 -0800 (PST) X-Google-Smtp-Source: AGHT+IF1d4T9f+8Iyu5sUe469U00u24oarcwXll3DohGRevtiGHnwrX87OT3cuyRpkpD7jPIlddBhA== X-Received: by 2002:a05:600c:19ce:b0:40a:3750:46ff with SMTP id u14-20020a05600c19ce00b0040a375046ffmr3323936wmq.11.1700855822127; Fri, 24 Nov 2023 11:57:02 -0800 (PST) Received: from ?IPV6:2003:cb:c721:a000:7426:f6b4:82a3:c6ab? (p200300cbc721a0007426f6b482a3c6ab.dip0.t-ipconnect.de. [2003:cb:c721:a000:7426:f6b4:82a3:c6ab]) by smtp.gmail.com with ESMTPSA id f9-20020a0560001b0900b0032196c508e3sm5072190wrz.53.2023.11.24.11.57.00 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 24 Nov 2023 11:57:01 -0800 (PST) Message-ID: Date: Fri, 24 Nov 2023 20:56:59 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH RFC v2 15/27] arm64: mte: Check that tag storage blocks are in the same zone To: Alexandru Elisei , catalin.marinas@arm.com, will@kernel.org, oliver.upton@linux.dev, maz@kernel.org, james.morse@arm.com, suzuki.poulose@arm.com, yuzenghui@huawei.com, arnd@arndb.de, akpm@linux-foundation.org, mingo@redhat.com, peterz@infradead.org, juri.lelli@redhat.com, vincent.guittot@linaro.org, dietmar.eggemann@arm.com, rostedt@goodmis.org, bsegall@google.com, mgorman@suse.de, bristot@redhat.com, vschneid@redhat.com, mhiramat@kernel.org, rppt@kernel.org, hughd@google.com Cc: pcc@google.com, steven.price@arm.com, anshuman.khandual@arm.com, vincenzo.frascino@arm.com, eugenis@google.com, kcc@google.com, hyesoo.yu@samsung.com, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, kvmarm@lists.linux.dev, linux-fsdevel@vger.kernel.org, linux-arch@vger.kernel.org, linux-mm@kvack.org, linux-trace-kernel@vger.kernel.org References: <20231119165721.9849-1-alexandru.elisei@arm.com> <20231119165721.9849-16-alexandru.elisei@arm.com> From: David Hildenbrand Autocrypt: addr=david@redhat.com; keydata= xsFNBFXLn5EBEAC+zYvAFJxCBY9Tr1xZgcESmxVNI/0ffzE/ZQOiHJl6mGkmA1R7/uUpiCjJ dBrn+lhhOYjjNefFQou6478faXE6o2AhmebqT4KiQoUQFV4R7y1KMEKoSyy8hQaK1umALTdL QZLQMzNE74ap+GDK0wnacPQFpcG1AE9RMq3aeErY5tujekBS32jfC/7AnH7I0v1v1TbbK3Gp XNeiN4QroO+5qaSr0ID2sz5jtBLRb15RMre27E1ImpaIv2Jw8NJgW0k/D1RyKCwaTsgRdwuK Kx/Y91XuSBdz0uOyU/S8kM1+ag0wvsGlpBVxRR/xw/E8M7TEwuCZQArqqTCmkG6HGcXFT0V9 PXFNNgV5jXMQRwU0O/ztJIQqsE5LsUomE//bLwzj9IVsaQpKDqW6TAPjcdBDPLHvriq7kGjt WhVhdl0qEYB8lkBEU7V2Yb+SYhmhpDrti9Fq1EsmhiHSkxJcGREoMK/63r9WLZYI3+4W2rAc UucZa4OT27U5ZISjNg3Ev0rxU5UH2/pT4wJCfxwocmqaRr6UYmrtZmND89X0KigoFD/XSeVv jwBRNjPAubK9/k5NoRrYqztM9W6sJqrH8+UWZ1Idd/DdmogJh0gNC0+N42Za9yBRURfIdKSb B3JfpUqcWwE7vUaYrHG1nw54pLUoPG6sAA7Mehl3nd4pZUALHwARAQABzSREYXZpZCBIaWxk ZW5icmFuZCA8ZGF2aWRAcmVkaGF0LmNvbT7CwZgEEwEIAEICGwMGCwkIBwMCBhUIAgkKCwQW AgMBAh4BAheAAhkBFiEEG9nKrXNcTDpGDfzKTd4Q9wD/g1oFAl8Ox4kFCRKpKXgACgkQTd4Q 9wD/g1oHcA//a6Tj7SBNjFNM1iNhWUo1lxAja0lpSodSnB2g4FCZ4R61SBR4l/psBL73xktp rDHrx4aSpwkRP6Epu6mLvhlfjmkRG4OynJ5HG1gfv7RJJfnUdUM1z5kdS8JBrOhMJS2c/gPf wv1TGRq2XdMPnfY2o0CxRqpcLkx4vBODvJGl2mQyJF/gPepdDfcT8/PY9BJ7FL6Hrq1gnAo4 3Iv9qV0JiT2wmZciNyYQhmA1V6dyTRiQ4YAc31zOo2IM+xisPzeSHgw3ONY/XhYvfZ9r7W1l pNQdc2G+o4Di9NPFHQQhDw3YTRR1opJaTlRDzxYxzU6ZnUUBghxt9cwUWTpfCktkMZiPSDGd KgQBjnweV2jw9UOTxjb4LXqDjmSNkjDdQUOU69jGMUXgihvo4zhYcMX8F5gWdRtMR7DzW/YE BgVcyxNkMIXoY1aYj6npHYiNQesQlqjU6azjbH70/SXKM5tNRplgW8TNprMDuntdvV9wNkFs 9TyM02V5aWxFfI42+aivc4KEw69SE9KXwC7FSf5wXzuTot97N9Phj/Z3+jx443jo2NR34XgF 89cct7wJMjOF7bBefo0fPPZQuIma0Zym71cP61OP/i11ahNye6HGKfxGCOcs5wW9kRQEk8P9 M/k2wt3mt/fCQnuP/mWutNPt95w9wSsUyATLmtNrwccz63XOwU0EVcufkQEQAOfX3n0g0fZz Bgm/S2zF/kxQKCEKP8ID+Vz8sy2GpDvveBq4H2Y34XWsT1zLJdvqPI4af4ZSMxuerWjXbVWb T6d4odQIG0fKx4F8NccDqbgHeZRNajXeeJ3R7gAzvWvQNLz4piHrO/B4tf8svmRBL0ZB5P5A 2uhdwLU3NZuK22zpNn4is87BPWF8HhY0L5fafgDMOqnf4guJVJPYNPhUFzXUbPqOKOkL8ojk CXxkOFHAbjstSK5Ca3fKquY3rdX3DNo+EL7FvAiw1mUtS+5GeYE+RMnDCsVFm/C7kY8c2d0G NWkB9pJM5+mnIoFNxy7YBcldYATVeOHoY4LyaUWNnAvFYWp08dHWfZo9WCiJMuTfgtH9tc75 7QanMVdPt6fDK8UUXIBLQ2TWr/sQKE9xtFuEmoQGlE1l6bGaDnnMLcYu+Asp3kDT0w4zYGsx 5r6XQVRH4+5N6eHZiaeYtFOujp5n+pjBaQK7wUUjDilPQ5QMzIuCL4YjVoylWiBNknvQWBXS lQCWmavOT9sttGQXdPCC5ynI+1ymZC1ORZKANLnRAb0NH/UCzcsstw2TAkFnMEbo9Zu9w7Kv AxBQXWeXhJI9XQssfrf4Gusdqx8nPEpfOqCtbbwJMATbHyqLt7/oz/5deGuwxgb65pWIzufa N7eop7uh+6bezi+rugUI+w6DABEBAAHCwXwEGAEIACYCGwwWIQQb2cqtc1xMOkYN/MpN3hD3 AP+DWgUCXw7HsgUJEqkpoQAKCRBN3hD3AP+DWrrpD/4qS3dyVRxDcDHIlmguXjC1Q5tZTwNB boaBTPHSy/Nksu0eY7x6HfQJ3xajVH32Ms6t1trDQmPx2iP5+7iDsb7OKAb5eOS8h+BEBDeq 3ecsQDv0fFJOA9ag5O3LLNk+3x3q7e0uo06XMaY7UHS341ozXUUI7wC7iKfoUTv03iO9El5f XpNMx/YrIMduZ2+nd9Di7o5+KIwlb2mAB9sTNHdMrXesX8eBL6T9b+MZJk+mZuPxKNVfEQMQ a5SxUEADIPQTPNvBewdeI80yeOCrN+Zzwy/Mrx9EPeu59Y5vSJOx/z6OUImD/GhX7Xvkt3kq Er5KTrJz3++B6SH9pum9PuoE/k+nntJkNMmQpR4MCBaV/J9gIOPGodDKnjdng+mXliF3Ptu6 3oxc2RCyGzTlxyMwuc2U5Q7KtUNTdDe8T0uE+9b8BLMVQDDfJjqY0VVqSUwImzTDLX9S4g/8 kC4HRcclk8hpyhY2jKGluZO0awwTIMgVEzmTyBphDg/Gx7dZU1Xf8HFuE+UZ5UDHDTnwgv7E th6RC9+WrhDNspZ9fJjKWRbveQgUFCpe1sa77LAw+XFrKmBHXp9ZVIe90RMe2tRL06BGiRZr jPrnvUsUUsjRoRNJjKKA/REq+sAnhkNPPZ/NNMjaZ5b8Tovi8C0tmxiCHaQYqj7G2rgnT0kt WNyWQQ== Organization: Red Hat In-Reply-To: <20231119165721.9849-16-alexandru.elisei@arm.com> X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Rspamd-Server: rspam08 X-Rspamd-Queue-Id: 9D08F1A000A X-Stat-Signature: 9qn3qnf66ajcmd6non9cjyiynfs5ejy3 X-Rspam-User: X-HE-Tag: 1700855825-246974 X-HE-Meta: U2FsdGVkX186gfPrjzGXnbj4kr0f8rXaY0OWOsMpwk2bxZq33FNcyiT6LgGgrgGyJKhhEhx1Z3vyZXVTkz0REG/9lpgFLIHob0nrJvmIJbFWHlXVw2iMKORqRumPgGbBukyt8XHFrTDGKxbmPxMHZZ13WNWe5QXzB9oBpHSfP451UeaPWaQY1kA+euWpUUbyB+D0Y09jLNUUJj1m6NkgZCrnXxTN8qp13Gy8RoPI11eVDBdss505y3dnAmurKbKdnBo4G1SRKjV5gg3gihY5p8ritPVQ8sa2bTfMkdVGF/y+7kaxymDIVwCy9HY1FlPxWyxFnJyBNYESrgFYwmIHnDFCvlFZ8vLKT4cIukzOc8U0JPVo9L5Df37ft34z/TIAl6fyFoD0An37SUCJcckTuY9zTgZ5GelQONhHYlhs3zPgUiBWogG4rR4CL5MiyvFhBW+8GDNz00jRrnLoMdDJ4QIEfXe4JzspwDM1u8BoxTsQ4oey48wOCzgCVk1tP9tWeuA3XIOKWxp1bY2Akci7ErkoKKTzBDFBhOLJFvcg5xK0RwMnqCVdpYScqJg80pmRXqO28In7WF9uKjel5mIs31sRH98z4uirxbmJJAaI7o1VDGCjFsbsJiohLhOiGIysrr4DmISVRewn8BZoI579XzhOmrqDLOtJANvR2CACoeSVCGH59r/AKoNl3sixukB7pexzObaonlTzFpksUIPLMWaDb9kx/0qSweoLDj2r7kvuLVv+d2zTxVJZnvEL6R41mVdpfzJIAHAZ6BtyL2nFGw/mI9p4/xoB5WIAsjRLU6fW34vVUYsBITrT7C+gtrMv6pwfFiBEwRwOyzsTNiiAFAPRWmlt7HCG4zcBjiWzDywHsgCsH1MHSX4T6LBJYxOvgZYlopcd3HY3pgZhMp28phvDrAFeyBHv4CxYY/qDGKN5j6ycT8Z0TOavcXbYAHohiTzlEnuc9vnR+BmyttN NnaH4Ul5 eUjuWOuaQluGOO7DzXcs/2MkzriU2NdAoz1IcLSy+pVcKFtqW0TuCll5djzeF2VMgo2VCr039wnaCqrXbNSx/dLygQqT4oq70bS0j8fRCk4yNnub15dvf6+NevdtXvsmnL9JmFsN77BStDWxPv7Hgz2QSkeNJJ4K/a0XFvjrkrG83xx18kNCvLm40XsZbYMGq1d8YJQhY5z4JWSemomgti/o1hhCTUPNYJ7Br65lR9WutWfZun2WyuvcIUol0lyzhyE1qAK6/7bjFd9c1H/b8X5Qjc1kiScdHsJpE/gNDz7ooOST3XmAivrWipQI1rtxSPYMCZZV29eGaLOhPpBv7vU10MLdR15SE89Fq7QEM/+tUjeLY4OS98x3Mb61hZiED2gMv2t7QwMToIFh1Y+xguIDXPAFWpLEd/M9pyKgLDOr8ICGLLa5IxNO2ImzgQsWqWdygm9NqMPZDeDe9aoR8WogM+GU5OCyE7O3z X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 19.11.23 17:57, Alexandru Elisei wrote: > alloc_contig_range() requires that the requested pages are in the same > zone. Check that this is indeed the case before initializing the tag > storage blocks. > > Signed-off-by: Alexandru Elisei > --- > arch/arm64/kernel/mte_tag_storage.c | 33 +++++++++++++++++++++++++++++ > 1 file changed, 33 insertions(+) > > diff --git a/arch/arm64/kernel/mte_tag_storage.c b/arch/arm64/kernel/mte_tag_storage.c > index 8b9bedf7575d..fd63430d4dc0 100644 > --- a/arch/arm64/kernel/mte_tag_storage.c > +++ b/arch/arm64/kernel/mte_tag_storage.c > @@ -265,6 +265,35 @@ void __init mte_tag_storage_init(void) > } > } > > +/* alloc_contig_range() requires all pages to be in the same zone. */ > +static int __init mte_tag_storage_check_zone(void) > +{ > + struct range *tag_range; > + struct zone *zone; > + unsigned long pfn; > + u32 block_size; > + int i, j; > + > + for (i = 0; i < num_tag_regions; i++) { > + block_size = tag_regions[i].block_size; > + if (block_size == 1) > + continue; > + > + tag_range = &tag_regions[i].tag_range; > + for (pfn = tag_range->start; pfn <= tag_range->end; pfn += block_size) { > + zone = page_zone(pfn_to_page(pfn)); > + for (j = 1; j < block_size; j++) { > + if (page_zone(pfn_to_page(pfn + j)) != zone) { > + pr_err("Tag storage block pages in different zones"); > + return -EINVAL; > + } > + } > + } > + } > + > + return 0; > +} > + Looks like something that ordinary CMA provides. See cma_activate_area(). Can't we find a way to let CMA do CMA thingies and only be a user of that? What would be required to make the performance issue you spelled out in the cover letter be gone and not have to open-code that in arch code? -- Cheers, David / dhildenb