From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 68351C369B1 for ; Wed, 16 Apr 2025 09:35:51 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id D55086B024F; Wed, 16 Apr 2025 05:35:48 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id D04536B0250; Wed, 16 Apr 2025 05:35:48 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id BA52C6B0252; Wed, 16 Apr 2025 05:35:48 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id 99C5D6B024F for ; Wed, 16 Apr 2025 05:35:48 -0400 (EDT) Received: from smtpin04.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id 18FD3B82C0 for ; Wed, 16 Apr 2025 09:35:50 +0000 (UTC) X-FDA: 83339400060.04.D1112D5 Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.223.130]) by imf12.hostedemail.com (Postfix) with ESMTP id BB8F74000C for ; Wed, 16 Apr 2025 09:35:47 +0000 (UTC) Authentication-Results: imf12.hostedemail.com; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=XPUdgiIg; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=F6cwiYRe; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=XPUdgiIg; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=F6cwiYRe; dmarc=none; spf=pass (imf12.hostedemail.com: domain of jack@suse.cz designates 195.135.223.130 as permitted sender) smtp.mailfrom=jack@suse.cz ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1744796148; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=TgkZ1fRS53uDN5PoxYa4lBptEV1A2yLR4pcQU/oqRBo=; b=MJZJ3tmkbj50yrfIHQCo35MI5wsxAGILP7tQiArELdWEkgxnvWGvEV/w9g2iKpbHr7YRbp dwBk/PXeA4BUMTVpBo4+kjXn/yj+mqgA/wGQPFoE394O1M7AYNPza0vByYi1BwVbKzMsI/ 9JPztOfxvxqpcUGmrOjONnOM0ow1+JE= ARC-Authentication-Results: i=1; imf12.hostedemail.com; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=XPUdgiIg; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=F6cwiYRe; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=XPUdgiIg; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=F6cwiYRe; dmarc=none; spf=pass (imf12.hostedemail.com: domain of jack@suse.cz designates 195.135.223.130 as permitted sender) smtp.mailfrom=jack@suse.cz ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1744796148; a=rsa-sha256; cv=none; b=u/2eZA0zY2sM7eGi9lWGXJf2e49fW0hqpiHIpW6jjn3gFcAVp3IRJ6hE12lAcmy1ZXp3kC 3POEnPjhCiQEh5WZDlrvKR7CK1GKyWmL8nGzqekSAl2my7mvBb0L4KUP8J2B36xjcaBxNP wEOJ4T69NKWTdAQxyd9rO/Ji5pAmq7c= Received: from imap1.dmz-prg2.suse.org (imap1.dmz-prg2.suse.org [IPv6:2a07:de40:b281:104:10:150:64:97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id 20892211A6; Wed, 16 Apr 2025 09:35:46 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_rsa; t=1744796146; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=TgkZ1fRS53uDN5PoxYa4lBptEV1A2yLR4pcQU/oqRBo=; b=XPUdgiIg+vd9UAZXzC5CbUa0OWyGoze5Ue6kRJ6kC+WMZAhmshmFMDWhNLI9XHqxFPnJB4 eDv4Ks5cWaFaKUamQPyMgsb/T9HF0F2KcrRDcowXdKZc08ISzoXNdLlQFEnV8VVs8DiFNX Io2ALXfxUGk97jjT4eSjA8IiptFH6aE= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_ed25519; t=1744796146; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=TgkZ1fRS53uDN5PoxYa4lBptEV1A2yLR4pcQU/oqRBo=; b=F6cwiYRe6I/lwMvFvGCvErEl8mCRRByqT/4zKSeUZcCYY3Azu8v/zvXMcivV2Fd4nChXQz qGcVBpw2Vl/TI2Dw== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_rsa; t=1744796146; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=TgkZ1fRS53uDN5PoxYa4lBptEV1A2yLR4pcQU/oqRBo=; b=XPUdgiIg+vd9UAZXzC5CbUa0OWyGoze5Ue6kRJ6kC+WMZAhmshmFMDWhNLI9XHqxFPnJB4 eDv4Ks5cWaFaKUamQPyMgsb/T9HF0F2KcrRDcowXdKZc08ISzoXNdLlQFEnV8VVs8DiFNX Io2ALXfxUGk97jjT4eSjA8IiptFH6aE= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_ed25519; t=1744796146; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=TgkZ1fRS53uDN5PoxYa4lBptEV1A2yLR4pcQU/oqRBo=; b=F6cwiYRe6I/lwMvFvGCvErEl8mCRRByqT/4zKSeUZcCYY3Azu8v/zvXMcivV2Fd4nChXQz qGcVBpw2Vl/TI2Dw== Received: from imap1.dmz-prg2.suse.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by imap1.dmz-prg2.suse.org (Postfix) with ESMTPS id 1665A13976; Wed, 16 Apr 2025 09:35:46 +0000 (UTC) Received: from dovecot-director2.suse.de ([2a07:de40:b281:106:10:150:64:167]) by imap1.dmz-prg2.suse.org with ESMTPSA id EVZ2BfJ5/2dkdAAAD6G6ig (envelope-from ); Wed, 16 Apr 2025 09:35:46 +0000 Received: by quack3.suse.cz (Postfix, from userid 1000) id C6241A0947; Wed, 16 Apr 2025 11:35:45 +0200 (CEST) Date: Wed, 16 Apr 2025 11:35:45 +0200 From: Jan Kara To: Davidlohr Bueso Cc: jack@suse.cz, tytso@mit.edu, adilger.kernel@dilger.ca, brauner@kernel.org, mcgrof@kernel.org, willy@infradead.org, hare@suse.de, djwong@kernel.org, linux-ext4@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-mm@kvack.org Subject: Re: [PATCH 4/7] fs/ocfs2: use sleeping version of __find_get_block() Message-ID: References: <20250415231635.83960-1-dave@stgolabs.net> <20250415231635.83960-5-dave@stgolabs.net> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20250415231635.83960-5-dave@stgolabs.net> X-Rspamd-Action: no action X-Stat-Signature: 4ta8qd7193ogfpsyecn4775nnpifyesi X-Rspamd-Queue-Id: BB8F74000C X-Rspam-User: X-Rspamd-Server: rspam05 X-HE-Tag: 1744796147-445144 X-HE-Meta: U2FsdGVkX19U6wbbYUnN4wPAsNsD6r2I2xdCicl50HCGtiIjTjtbFCmJlPdUorkhGZUntZb+YdG0rdpGBzO8aXQ6TvIGm+F9R9iHNpZkXbU7RMZANq3PGMHqQuU+Y+Z9AXaYw9RlGR7N4Nd/9pJ9Egsx2+9E1QL0NpJUXfvtR+CtiLbKpoliP8rR/1A1DVVpVtTFTs09wl+SGgbzmGT40UjTyvxfaQef8SfgVN2MLboVwZ3e7BJ5V6wFpDjyFqg5BCp8MgNmpv9amvbGvfqZMi+hSVJ6THmNxfMisjvB4E/kDm6gutDXfOMDcF5x+zP5EfKWn9A/dQM6fJ/8dvoLtJo8LddDejkaV1e4hZJlNTIP0JE6dBQZTciATFOt3tz1+COlxzQQiBffIoDcvJ8tY+OhDS1xGqa5mn25yMkqrW/EmGYnVQoimahOdrQv+lG69SQsoD2kQmsEqx3GxOqzpKJg6ikRh2MjLwIZ4zW9wI17r+WaMDm5EwIXgngSzzEzPEzCEYuwyl4BBfYJYmTim7VhivrUNOUH3zYgbLXruQLfx17YA/3kNLYcFaIeQw8mxHEN4A72envWRiUuBEG+UrZrErRSJ75BL8EUs1iK3T/odgzKFlu7oJGRYNHZCecuPxOUOzaJRmMPWgcUrepoE76G7qgD+5CST8iZXND8SWYsHXlmDfUcyVHzVULFc5DsNeA5FVZNc/kL5kzHmEkJ8AP1DTvUnZuuCAAKr7NQ3OvfmmNCASJEHndAuV83+1ZdVpxyWV6xLVwFAe6LpGbFOK3uO6OMjtmd5NNIIXT2SQckMGFOl4BYRs46sEZqxso/gt5oK8HIUs+8fzVH0nB9TTHC7ghZg5vCNgV0FPRuR5t547Ydd/ai79MPlTklDvocpK9s/9iyuQNHEIPfH8YhOFQGxoIO/7rEAcb0OkVGtV1R5fLzncj9u2INWp1KgyhtLvyUq5Ld42JJfw+uYII b6ka882p YMC5vG7pxnHrWR7O7JLAUO+653Bq7o4FTWXivGRo787//K8z/+nApFu797FYjTfKHtpFl8zubbSmqvekVH/Ueh7N3ZV2B2kh3NuOYOz67KvTu39nNOYEbBxJJt1vgDavB24dZAxL1QTzEs0jeGhGb12GgRiG+p2KgwdIj1OdtMx5NHCVsAnEMPfC/eU1ADBpApzl25Y+Sufx49L3+ZEAO6o9XcQs91iq3okruIezTnZcyJOb8PZ4uxrkH36JNzZ6G9Ew3wfN7AvCjfhMohXV4YXy/xDed9d7j9WPUND8jbl1zq0fpehuUhbEqvJBbJ94pMZ3H8XUxRIVuTotqNYleDcx+Sw/ay77f4llM8e9UifzPtrCrsFBOfhMHtekGb3WDqLxdeY+ltNxQI77e+17qeLs9Xiyuc5BxdxIqqm0yahRWyYGLsBNS52a/3aSVq/DgD43V X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Tue 15-04-25 16:16:32, Davidlohr Bueso wrote: > This is a path that allows for blocking as it does IO. Convert > to the new nonatomic flavor to benefit from potential performance > benefits and adapt in the future vs migration such that semantics > are kept. > > Suggested-by: Jan Kara > Signed-off-by: Davidlohr Bueso One nit below but either way feel free to add: Reviewed-by: Jan Kara > diff --git a/fs/ocfs2/journal.c b/fs/ocfs2/journal.c > index f1b4b3e611cb..c7a9729dc9d0 100644 > --- a/fs/ocfs2/journal.c > +++ b/fs/ocfs2/journal.c > @@ -1249,7 +1249,7 @@ static int ocfs2_force_read_journal(struct inode *inode) > } > > for (i = 0; i < p_blocks; i++, p_blkno++) { > - bh = __find_get_block(osb->sb->s_bdev, p_blkno, > + bh = __find_get_block_nonatomic(osb->sb->s_bdev, p_blkno, This could be using sb_find_get_block_nonatomic(). > osb->sb->s_blocksize); > /* block not cached. */ > if (!bh) -- Jan Kara SUSE Labs, CR