From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 78698C6FD1F for ; Tue, 14 Mar 2023 22:12:50 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 1ABDE6B0072; Tue, 14 Mar 2023 18:12:50 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 15C3F6B0074; Tue, 14 Mar 2023 18:12:50 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 023AC6B0075; Tue, 14 Mar 2023 18:12:49 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id E58BA6B0072 for ; Tue, 14 Mar 2023 18:12:49 -0400 (EDT) Received: from smtpin14.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay03.hostedemail.com (Postfix) with ESMTP id C0D7DA019E for ; Tue, 14 Mar 2023 22:12:49 +0000 (UTC) X-FDA: 80568904458.14.31237A7 Received: from mail-wr1-f50.google.com (mail-wr1-f50.google.com [209.85.221.50]) by imf29.hostedemail.com (Postfix) with ESMTP id E5FE9120010 for ; Tue, 14 Mar 2023 22:12:47 +0000 (UTC) Authentication-Results: imf29.hostedemail.com; dkim=pass header.d=gmail.com header.s=20210112 header.b=dootni8C; spf=pass (imf29.hostedemail.com: domain of lstoakes@gmail.com designates 209.85.221.50 as permitted sender) smtp.mailfrom=lstoakes@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1678831968; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=qrgGQA2tyR+reLrtZ5whteGjP4sWvnWfOZPTVunlkec=; b=ih1j0YbAFuHi7h0fnx90cHh/msF9+ATiF0qj7PtwzpENfuzSTrYovqXnTvYudA28j7WEFD NUWhGhoFcvzwv5dN6ykFXLnN+2Uq79STMosRvMWcgiLS7d/vtPcXHxUmlfXcGUcD3+wBlq we3SoYq5XCszb+F7lrxZSAgSNNrnSRo= ARC-Authentication-Results: i=1; imf29.hostedemail.com; dkim=pass header.d=gmail.com header.s=20210112 header.b=dootni8C; spf=pass (imf29.hostedemail.com: domain of lstoakes@gmail.com designates 209.85.221.50 as permitted sender) smtp.mailfrom=lstoakes@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1678831968; a=rsa-sha256; cv=none; b=hIFbvdVVVuz3LxVcx51uAO6RTicOnAOQpOrGMDYf56jsdaYLeV1VhC4RoJdgaKZ4Y5/8TK 60zWVdmcCf3Uv2HuQiP7s4keTpABWoePUpaEDKLr/kUBfVbIDGgEmxdysr1dZOS3HJOrtx X9fNiAVjc2pIy48wF8TwoBr6BRWJZ/o= Received: by mail-wr1-f50.google.com with SMTP id q16so15702297wrw.2 for ; Tue, 14 Mar 2023 15:12:47 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; t=1678831966; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=qrgGQA2tyR+reLrtZ5whteGjP4sWvnWfOZPTVunlkec=; b=dootni8CEgUsi8N+v99TYqgtssTXuvVp/SJIRgJDBFOVvoKGidWBw5oOLU/rK6wUYZ cBx4OYl7vRuuganKp+xfQJnhf9PvhzTSn8oqx+UwcFdyCrztDVJrGJ0BoRA61QY8n9dB bXtvntpsQFVfiKpejt/sGKe1X6no2rXrbdem1rvGl/XHFUtjsWOwrpmvjDfAgkESqqOP vPVGUCUMFdm8SPYFo+vC36K2c8rg80rhwuO7T0kmx3c3sTAYmhbzwD7QW75zmHiYXKda J2kdWKdWYyMBKkKuiGaS2WSjV4fjOtcq3NuLxGVaGGfoL4cZqZVpDYgM2dKFjLbFo5l9 xkMA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1678831966; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=qrgGQA2tyR+reLrtZ5whteGjP4sWvnWfOZPTVunlkec=; b=qcpYkipfW28NzkDPd0I9uocFihZLbPIbvKKAikrrfrnBHYru9Sxao9Y5WoDSQErcw4 DzAPl5JrGxvHAYQJZcG3VAqiZ4iYb6A6tEI8OrjVVyKKYlxkPkSZ3mwBMDgDhEmBg7Ss jN7zWBDT0pXCM1BQJnTEi+WBCJyyFQTq+AcTgK2RO8vjSp7/n8+dvlW04u8+EkxJvAgc kudDILmFvB/EvvAZbHNRF7L5eD7HPilol4MT8b4g8psA1zyflXJ46dVXR0f5YzmBnE9d YyF/FfHzxDMGxfNrx0LIgTnXPXzhqZEcxzmdTWo9RaSO5+xhL6YgcMrN1FQCmOZPbdgZ zlUQ== X-Gm-Message-State: AO0yUKVLv7uXPqAp1DC/oKRanKiLilEu+boij9fdwtgMI+t2JYDF2014 zS9915E0SgM3uiJFx0i67yU= X-Google-Smtp-Source: AK7set/Oe1mK8ERAeym3Py4UdCVU7k6qkgj+mP/p9KCj/wwe0GCzObLYhzO768PXTzSuipVfAJ9mgw== X-Received: by 2002:a5d:4002:0:b0:2ce:a0c2:d9ed with SMTP id n2-20020a5d4002000000b002cea0c2d9edmr363419wrp.32.1678831966299; Tue, 14 Mar 2023 15:12:46 -0700 (PDT) Received: from localhost (host86-146-209-214.range86-146.btcentralplus.com. [86.146.209.214]) by smtp.gmail.com with ESMTPSA id u7-20020a5d4687000000b002c5544b3a69sm3010241wrq.89.2023.03.14.15.12.45 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 14 Mar 2023 15:12:45 -0700 (PDT) Date: Tue, 14 Mar 2023 22:12:44 +0000 From: Lorenzo Stoakes To: Vlastimil Babka Cc: Christoph Lameter , David Rientjes , Joonsoo Kim , Pekka Enberg , Hyeonggon Yoo <42.hyeyoo@gmail.com>, Roman Gushchin , Andrew Morton , linux-mm@kvack.org, rcu@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org, patches@lists.linux.dev, netdev@vger.kernel.org, linux-doc@vger.kernel.org Subject: Re: [PATCH 3/7] mm, page_flags: remove PG_slob_free Message-ID: References: <20230310103210.22372-1-vbabka@suse.cz> <20230310103210.22372-4-vbabka@suse.cz> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230310103210.22372-4-vbabka@suse.cz> X-Stat-Signature: 9myaqn3du9715psmdx9oonw1enuxwkcn X-Rspam-User: X-Rspamd-Queue-Id: E5FE9120010 X-Rspamd-Server: rspam06 X-HE-Tag: 1678831967-653326 X-HE-Meta: U2FsdGVkX19z+mYjX2InWEwnZHVasw3iVW1kEvtDNgZGe52z1Mw+o80y2V0HmSAoXF/ExazKyylEy4jFcVPH7Dzg0zQBFEuynyBSBsozjrfehjEQynvw00OXIGWRSbQavk0Kmnz/stH2kWDLC5hXdCTTvOo8KHIhvFUjWWyePslgQm7HeV91K6oAK2iOsaheSZgnSBCf36TOGt1BA4dvMYVQEDkapRSCpXNljZFSZlkQOUAF2L3PGsd1aZwD2kwUXp80YQOcEhar6E6X5ClRhmgFACiwlOD85bep/I0HOztDANY5yGBVruqCeId2/+vSrpFiUFAAepcHogWJ/940KERMpfMgR0Zcu6dEqukVibwPUoQf0LxsNnxXUWXckljCpFhyv8sniFbyRKRcUK+EFZKvxeWKy6QWxwF5CE0+FX8pw/F0MXdU6ZMNpODGXoa//gTp1MXDSit/ZIEw4ME3hakTAY9MYNokUVql5+DPN1uW3lSDBilrfFcIYz/gUgIdZFSOay6g5VfEBxG/APagIcfFvu00Gtg+U5WtKeenGcXhfLf+LG4wsE7I/05r+msTzjssq3ilpkemce0rFc5yEUCe9X1HDNYj9TXtb7VZe7vb0iYjRIWGZ+LiRZZeU/Gl8lDIGbjHHbD7hLfo2S16bsdd5wz1j+JpfcchTDpoRx6xMHvk0X0tbdEXchRrF298HhW5idsuw+xyu+072Uu0YHnP6jAVtgD6A8masHC30JFthbMTPojq1OTNiJpNS/YUlUQ6/0L4+lwidYDeJICYwsrLtE6Dyvu0xuAzign3rtgkcTA1fHJOhtxNMrxtGDKLdxChnZhz4X6ocbgK5cNt38QmfmXS9WvmWeqC+BSsIKpEzo8CtsH4Hm8HobKzKtuVNhFmrl2GoDPkBc/Q009qXLJd+shYt1cR9MmEaf56IZicEYT6HUr2vebf3Vi4s/1Bb087OekolUvET6VgauE 5YyMFWaM /OtvvkpaCxdfLU4ofIUUy7ujb/9D5JB9pE6LrrgqwzTYXmGJsOiWCOAYHGK8TgmKV/nUcVPJlJcKitjwOgv2YKkTTTkPsHjgpF0G2WRNQfENNPHT45SQw1FChBlWnmqYAEVesNvKnVruOKwqkUvSeLdcXtKPEHPaTTxjB96IVf+9+F+B2jrpkiffnba0UPFUXZBOEokPgyag1L3+SS3hv3FZ1se50nHTd8WpOm6X8MlTtMxR1PpCLG7isml9YW7Bm2AD/n7DOFTlYO3BSnE8nCCw38PGMkXaToxAkl3Zz2rAGp1Bq92NUEGzvE3G1TT+AehaPdAe3p8l10ayNdJxMCXOvzoRENT7QANwsMkWUaynuNMAkf3igorVWZRhYyfSnNKOnluuxZqeG1BX/X4Hve8FITYRAitK2XJrNtGqiK/zb1JgFcW9H82lcISOqfrEYuA4XqYCLwaIP9HbfG9AhmQ4reexvr0UQuRpLveDVnxMPMwxe7sbfFSvAenOll11yx24jutXpJmT+Yb454qF2A5xL9ghOXIVsZ8yZlGUceOBCg/U= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Fri, Mar 10, 2023 at 11:32:05AM +0100, Vlastimil Babka wrote: > With SLOB removed we no longer need the PG_slob_free alias for > PG_private. Also update tools/mm/page-types. > > Signed-off-by: Vlastimil Babka > --- > include/linux/page-flags.h | 4 ---- > tools/mm/page-types.c | 6 +----- > 2 files changed, 1 insertion(+), 9 deletions(-) > > diff --git a/include/linux/page-flags.h b/include/linux/page-flags.h > index a7e3a3405520..2bdc41cb0594 100644 > --- a/include/linux/page-flags.h > +++ b/include/linux/page-flags.h > @@ -174,9 +174,6 @@ enum pageflags { > /* Remapped by swiotlb-xen. */ > PG_xen_remapped = PG_owner_priv_1, > > - /* SLOB */ > - PG_slob_free = PG_private, > - > #ifdef CONFIG_MEMORY_FAILURE > /* > * Compound pages. Stored in first tail page's flags. > @@ -483,7 +480,6 @@ PAGEFLAG(Active, active, PF_HEAD) __CLEARPAGEFLAG(Active, active, PF_HEAD) > PAGEFLAG(Workingset, workingset, PF_HEAD) > TESTCLEARFLAG(Workingset, workingset, PF_HEAD) > __PAGEFLAG(Slab, slab, PF_NO_TAIL) > -__PAGEFLAG(SlobFree, slob_free, PF_NO_TAIL) > PAGEFLAG(Checked, checked, PF_NO_COMPOUND) /* Used by some filesystems */ > > /* Xen */ > diff --git a/tools/mm/page-types.c b/tools/mm/page-types.c > index 381dcc00cb62..8d5595b6c59f 100644 > --- a/tools/mm/page-types.c > +++ b/tools/mm/page-types.c > @@ -85,7 +85,6 @@ > */ > #define KPF_ANON_EXCLUSIVE 47 > #define KPF_READAHEAD 48 > -#define KPF_SLOB_FREE 49 > #define KPF_SLUB_FROZEN 50 > #define KPF_SLUB_DEBUG 51 > #define KPF_FILE 61 > @@ -141,7 +140,6 @@ static const char * const page_flag_names[] = { > > [KPF_ANON_EXCLUSIVE] = "d:anon_exclusive", > [KPF_READAHEAD] = "I:readahead", > - [KPF_SLOB_FREE] = "P:slob_free", > [KPF_SLUB_FROZEN] = "A:slub_frozen", > [KPF_SLUB_DEBUG] = "E:slub_debug", > > @@ -478,10 +476,8 @@ static uint64_t expand_overloaded_flags(uint64_t flags, uint64_t pme) > if ((flags & BIT(ANON)) && (flags & BIT(MAPPEDTODISK))) > flags ^= BIT(MAPPEDTODISK) | BIT(ANON_EXCLUSIVE); > > - /* SLOB/SLUB overload several page flags */ > + /* SLUB overloads several page flags */ > if (flags & BIT(SLAB)) { > - if (flags & BIT(PRIVATE)) > - flags ^= BIT(PRIVATE) | BIT(SLOB_FREE); > if (flags & BIT(ACTIVE)) > flags ^= BIT(ACTIVE) | BIT(SLUB_FROZEN); > if (flags & BIT(ERROR)) > -- > 2.39.2 > Looks good to me too, Acked-by: Lorenzo Stoakes