From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 759BAC76196 for ; Mon, 10 Apr 2023 17:47:55 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id ECA9E280036; Mon, 10 Apr 2023 13:47:54 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id E523B280031; Mon, 10 Apr 2023 13:47:54 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id C600A280036; Mon, 10 Apr 2023 13:47:54 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id AE5AC280031 for ; Mon, 10 Apr 2023 13:47:54 -0400 (EDT) Received: from smtpin12.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id 7036A12073E for ; Mon, 10 Apr 2023 17:47:54 +0000 (UTC) X-FDA: 80666214468.12.4C4937D Received: from mx0a-00069f02.pphosted.com (mx0a-00069f02.pphosted.com [205.220.165.32]) by imf24.hostedemail.com (Postfix) with ESMTP id F27F2180003 for ; Mon, 10 Apr 2023 17:47:50 +0000 (UTC) Authentication-Results: imf24.hostedemail.com; dkim=pass header.d=oracle.com header.s=corp-2022-7-12 header.b=pxuN1m1n; dkim=pass header.d=oracle.onmicrosoft.com header.s=selector2-oracle-onmicrosoft-com header.b=Ej6OOZzb; arc=pass ("microsoft.com:s=arcselector9901:i=1"); spf=pass (imf24.hostedemail.com: domain of joao.m.martins@oracle.com designates 205.220.165.32 as permitted sender) smtp.mailfrom=joao.m.martins@oracle.com; dmarc=pass (policy=none) header.from=oracle.com ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1681148871; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=cDsBiFy8TMvYzxwy5qtNtKLPKXCmCjQle+bskhBFy+E=; b=r5+183OHBv2ubpaictrW+NulbARMV8Nbg8TZafCLFbXc26JYnTBwaRXV1VwKgjwydaRTvq z6lWIrMClMdeipskIaPdpnwts3wfoFLrusxJ6EwJPCt82c4S98DCKN6YalsYPsb0zcgujE VYT5k2kRQL8BQMuLxwFunY3IP7po/vA= ARC-Authentication-Results: i=2; imf24.hostedemail.com; dkim=pass header.d=oracle.com header.s=corp-2022-7-12 header.b=pxuN1m1n; dkim=pass header.d=oracle.onmicrosoft.com header.s=selector2-oracle-onmicrosoft-com header.b=Ej6OOZzb; arc=pass ("microsoft.com:s=arcselector9901:i=1"); spf=pass (imf24.hostedemail.com: domain of joao.m.martins@oracle.com designates 205.220.165.32 as permitted sender) smtp.mailfrom=joao.m.martins@oracle.com; dmarc=pass (policy=none) header.from=oracle.com ARC-Seal: i=2; s=arc-20220608; d=hostedemail.com; t=1681148871; a=rsa-sha256; cv=pass; b=la37j2UZBgajDAHBerfopqqg9xplGhJsWIDeb2oF6v+tfVXm4gJ6jhioXJPuywQBwftOCT HsnH21t+H/hF+R5URYTYqZoJCxtq607F+pw+5jJjeSEmGSCQT81YKYLhavSumJA8eGxqRn Pe2ntWYHSDB//R4dnqi3CmVndOE0Up8= Received: from pps.filterd (m0246627.ppops.net [127.0.0.1]) by mx0b-00069f02.pphosted.com (8.17.1.19/8.17.1.19) with ESMTP id 33AD6aWc001926; Mon, 10 Apr 2023 17:47:34 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h=message-id : date : subject : to : cc : references : from : in-reply-to : content-type : content-transfer-encoding : mime-version; s=corp-2022-7-12; bh=cDsBiFy8TMvYzxwy5qtNtKLPKXCmCjQle+bskhBFy+E=; b=pxuN1m1nuD5Qkcq6qegVm7fnhPm4hTZNaQKMoIZyzfwtsSyy8b1V38MkcFRw7+WEE4NN vT6K5df7dR844KHKs0lzKhYIMyuKPGlRQ9dd4HgaIfy3jWIMM9/BgJgiIfyvDjy+wIV6 wdPQehk1emdUNQTtaUQbCBdHT/vCLlSkgDcVemgUC/sqjPlqjh3brLgIgKMDFTQjYGy1 AI+5UAeh+teB3xKu2RQ3GWhPyzFTcaiioRUnIGbzwRZpNyQxxXYglaPRnIbPrpI8Agw4 jQ29kwpFef/g8MO9gI4KgJ4J2JAtu9DHZdMpQj1/ciMybPaar1NI2Idhs5i0SmmLJJlI nw== Received: from iadpaimrmta03.imrmtpd1.prodappiadaev1.oraclevcn.com (iadpaimrmta03.appoci.oracle.com [130.35.103.27]) by mx0b-00069f02.pphosted.com (PPS) with ESMTPS id 3pu0hc3e04-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Mon, 10 Apr 2023 17:47:34 +0000 Received: from pps.filterd (iadpaimrmta03.imrmtpd1.prodappiadaev1.oraclevcn.com [127.0.0.1]) by iadpaimrmta03.imrmtpd1.prodappiadaev1.oraclevcn.com (8.17.1.19/8.17.1.19) with ESMTP id 33AG9WAP001724; Mon, 10 Apr 2023 17:47:32 GMT Received: from nam12-bn8-obe.outbound.protection.outlook.com (mail-bn8nam12lp2175.outbound.protection.outlook.com [104.47.55.175]) by iadpaimrmta03.imrmtpd1.prodappiadaev1.oraclevcn.com (PPS) with ESMTPS id 3puwe5j9ew-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Mon, 10 Apr 2023 17:47:32 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=cWScxYgsk0sUtVMu2nxMLyuqMe/dc/UHaxivJAvs0nAXTEP7NK1KpFLY8+ReyyXunMp2vin/wHncYqlZwjTpw+ujS+nkM5ZD9ss475UWbi6eIDJA2B2HkXWSo7sjqmtqFcgKWo/wccuSSDMCJUP6iGPcDGw26tRiDCIZu9CO/fqy2u6mkTjT3fhnCPUaXmUIwd1zRlZGDXYGsj+11tNnwxmfjEQ9H8rNvnUvdqBJ7SXZPF8T27cQAbfzOmKBrKYC6nKFW9v9Wfw2ptm+8veB8KDZNu8W56j826fiTD4V6AcR2R4FadN5QZJaRAqQPEMMi5+MUCcXJKSNb+dqnNzcqQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=cDsBiFy8TMvYzxwy5qtNtKLPKXCmCjQle+bskhBFy+E=; b=ZlB+NvkJJxDq337+JZ0bsFFsuA6QbrDB/Z6kNSWvR5FoQP5Rh/cpNf2x3VIp73SHsaLnLrQl+mND8ur/Avu4/kyZ/OYmL91JgwBRyVJJRZo+VQULdkfjc1mawApm05ed6GztPrHqnTTMkd42zfck7APGXiGMS20FICIA+ccqJdJmwtauvAD/lFG+UAlMmH3cbeaGdaJZzTXS1G4zO8lXtGNmon2DBwWynTsWbeUgTFT7uHyo+AWnKmCK9U93/lCL+1aT1FObmbZn8vzDB+cah1MmO2VE9kgL0JEtbn4XNwbAL6kCLQPQNp27UlbLA8Z4fSJbXYghPURyeoO9+q/k8w== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=oracle.com; dmarc=pass action=none header.from=oracle.com; dkim=pass header.d=oracle.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.onmicrosoft.com; s=selector2-oracle-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=cDsBiFy8TMvYzxwy5qtNtKLPKXCmCjQle+bskhBFy+E=; b=Ej6OOZzbl6/kahLECvstusBuy4Mn5BuKD1DmWzvqNDbMsA9p9L5FfjlSG/j49pMXUeVclJhpMeDIetiuWd+BOHNl/gdpeB6tXdF7XYAbIBiGlcm0jWg/e2ZWgBMTHoEttDnBHG9Hv71qJxaaU/gNFhJPnrEgUfETV8ctZkr7OuI= Received: from BLAPR10MB4835.namprd10.prod.outlook.com (2603:10b6:208:331::11) by MW4PR10MB5726.namprd10.prod.outlook.com (2603:10b6:303:18c::5) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6277.36; Mon, 10 Apr 2023 17:47:30 +0000 Received: from BLAPR10MB4835.namprd10.prod.outlook.com ([fe80::b176:d5b0:55e9:1c2b]) by BLAPR10MB4835.namprd10.prod.outlook.com ([fe80::b176:d5b0:55e9:1c2b%3]) with mapi id 15.20.6277.038; Mon, 10 Apr 2023 17:47:30 +0000 Message-ID: Date: Mon, 10 Apr 2023 18:47:23 +0100 Subject: Re: [PATCH] mm/vmemmap/devdax: Fix kernel crash when probing devdax devices Content-Language: en-US To: Jane Chu Cc: Muchun Song , Dan Williams , Tarun Sahu , linux-mm@kvack.org, "Aneesh Kumar K.V" , akpm@linux-foundation.org References: <20230407122353.12018-1-aneesh.kumar@linux.ibm.com> <87h6tqk76k.fsf@linux.ibm.com> From: Joao Martins In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-ClientProxiedBy: AM4PR05CA0036.eurprd05.prod.outlook.com (2603:10a6:205::49) To BLAPR10MB4835.namprd10.prod.outlook.com (2603:10b6:208:331::11) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: BLAPR10MB4835:EE_|MW4PR10MB5726:EE_ X-MS-Office365-Filtering-Correlation-Id: ee65f414-b7b7-4d70-5948-08db39eba816 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: 3zXhy0TPxfDyEx9XaiJhNetMmTaIEBr7EJUqLx9PKUpVymZm8rr/8PHypbiYJoDCKp2ci0DE8zKip/sZ16yhfMwkqxX7l/aJs21+YP9zow5yhhwLRaY8R85GYKssgU4NfLxXGoKRGngfLycDz5WU/XsixHK0TkVHXaOINOLGtVf9EB8OGXQHue5Alp4rHPUtH29gSnOGD3G+QTLJVE3N9/JyknhPdl/vY4aiRM9qp0/t0eQ82WcUP4xgD7FInDWNqwSkjTbGDobDT+D7Xi5xZlO2LwXwddDFE+rcld1rkSu41IVlyZtOiwBGq5/K6HBxMmx2PTlAvaORcOUi3E5lvPTPDvNIaDQImZL/NwJNlNdEU32tPvbrj9xU1qTR4nuyT1RIkmKfu2pVIVfPSAcii1ovytTfMWvk6421hCgVUA2eEwiRg+68Rn9LpKe0rSl9rsXFpvOL5UlXKlkgvL6kOmYE6NWrZKC95QvaJtr1jb5a46H55VFQ7hZbaTn73W6lTMjCBciF46TaBvqrWseI0LQQ3mhGeetH0/dYOCnjkU7XmBH3kCqwJ4IuUKtIZXO1jY/mxNKRQVkp2g3ezDyrhJdjHFZORBXI8Yg1czOCqoKt7eWxnEC29JD4UN0TQ4vD X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BLAPR10MB4835.namprd10.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230028)(366004)(136003)(376002)(396003)(346002)(39860400002)(451199021)(478600001)(316002)(6636002)(37006003)(6512007)(53546011)(26005)(6506007)(186003)(54906003)(6486002)(6666004)(2906002)(5660300002)(4326008)(66946007)(8936002)(8676002)(6862004)(41300700001)(66476007)(66556008)(38100700002)(86362001)(31696002)(36756003)(83380400001)(2616005)(31686004)(45980500001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?bXI2SnhseWRSWkhqWTdjMWtTdm9HZmN4emVyTzZnQjdWYW81N0FESDVFOWx6?= =?utf-8?B?cjhYU3B5aG5RSGRpc2hZTkM1VlRReWpqRTlyNGowc3RrcEdWVGVvaExEa1FG?= =?utf-8?B?bHN1bHFpRDEvWlhkMVFVajFKOEhyQ3BISlF2Smp1YkZOdnZzWnBaZmQ3YXFM?= =?utf-8?B?MXVRc0xVVjZVeHNkRytFR2lLeFFMQjhpV2NzVGNUK0VKWTNvU2VzeHh1eHVL?= =?utf-8?B?Z041emtBcG1YTFptd0R0ZjNWRVQyOE0yMGxnVkYzb21lbktiODM2MFlSNXRR?= =?utf-8?B?YVZ0RzRaNWM2NEVuakJtRCtlc3VWRVAyZmxmdXQ3M1lmWDJpYmNDL2F6Z2VT?= =?utf-8?B?YWFveFhIUFNXR0srWGNORTNrd3FVOUVhM0sxU3JEZmFkajNjMEk4SitEWEdK?= =?utf-8?B?SERWY2dWMEs0VGRhNEhGemkwNG4wc3Y0RXpxZTRpOGE1ZktMNTg1WkZlN1Y2?= =?utf-8?B?UFRDMWR2dEsvcWdYQ01OUXB1a2MxWWg4aVNzM3JDS21oUDhFUFVadUFqdWlq?= =?utf-8?B?T1h1MEwvK2lLRTFoNEV1Z3V1L3JGV21KTXdMeTc1MklLSGZoTUdINS9TaDlt?= =?utf-8?B?MVVubENuY1l2dVQzWDVCVDh4UDQ5Tk1ZejkwdVEvT0d3UEh5Yk9GN0VOcGEr?= =?utf-8?B?eGJaNGg4UGlwRWtDNWx3SlpnTEIxaFYweDV5aHJRdmcrekFKdU9yNlFWdUpi?= =?utf-8?B?N1BkRGEyUzAyMlYwUDR1R0YzVDN4R0tvN3ZhYWdFVVNpclhSemxkZWE4VnRB?= =?utf-8?B?aDdVa2lmMkpFL2srT2RqR1hxZDFqSHpvU0RGd1BWUFNQaUtpdU1KMjRMQnZE?= =?utf-8?B?NXlLY3Y5UVJXS3ZuRkJYYmVxU1llNGt4VHYwNGU3d2dlQkR6eGNSUzhqS3Zm?= =?utf-8?B?U1NPY01MUkUrczVnejB3NWo3QWVGUm1POEtYeU5YWGcwVG11d1BteVRDdVly?= =?utf-8?B?am00bkprT25kV2pxRWh6QTVXckxweUo2VFZvTFB3TmlPMStFVXZqUWw3YzU4?= =?utf-8?B?azdHVlZDSFBVd0I1bGFVdlZKR3hFb0Y4MVZWYnQrc1I2cmswWVV5T0RsQng2?= =?utf-8?B?SEVZTjlUaTNYanNiYWlJTlZqMDdzeUtMTFRXOXMvOUlmRlNvR092ODVqelA1?= =?utf-8?B?MjlSOVZBSHdrSnFwcngyMXV2UWJMeDY5dENkL0Q5T3NIZFpsS0lIbmxrcW1t?= =?utf-8?B?Z1hOc2ZSL1d6cVVYS01EeW9RbGxyT1U2WHVtNDRqYjB1RHJDZmpkeHlLUUM0?= =?utf-8?B?M2lBU3laR00xMVBpVWorZURjWEVyeFR4WElFYVU4b0JRMVhOZ0ZtYnhvcGNP?= =?utf-8?B?bjA0YmJlS1hpd2FRSXNVaUNyckUwTTduTmx5Z2lZM1pkSTZNTW1SNEpsa3B2?= =?utf-8?B?RVdSdGVGUzc4VVpmTXh3OCs2cWxuMFR4amxGNkdySXFKWTVLN1R2VjlCR2dw?= =?utf-8?B?RTJKNUVYOHFlVkN0Ry8zNGpnMHRheGdMTkdkQmM3a3JIbE5HTFMzTytvcktU?= =?utf-8?B?aXFjTjluUTFjYjFqY0xVQVdpZjVjMU5JWmVZYzlPZ1VQeUpqWTYzcWVLS05p?= =?utf-8?B?OVhCanUrclpLdHpjYXRvNzgza0RKbmRkNFg1KzFDV1l4eHo5RGlPbVBZRmZ6?= =?utf-8?B?YjNHaUFRYzNVOFVWM3dWWUlFck1sVDFZVHNueGFFR1J2Z0krSE1nK25wc2pz?= =?utf-8?B?L2JOK2hUR0dmOUgxSTlBRmJXcGtQOW85Qkh0cGVLeFk2b1JVZ2tGcldyK0tC?= =?utf-8?B?eUV1OE1WTlBYcjM5MmhwTDUzcHBsN21TZXNqVGJ4dW1aSmhMZE1sQUc2VkEx?= =?utf-8?B?dnhJR0N0bWFvUVAwbktLdDYrZ28rL2l3Y2tEdThZSkJCczBTblNmUm05eldK?= =?utf-8?B?Z3cvbnVpRlNzdm9HUCtzREM1R3hBZ2xCaWNmcWJ2RjZVdEFWRVZXY3paSzY0?= =?utf-8?B?L014b3hrRmJDT3FqcFRpUFdBOGY4aW9Zek04OW84NXp2eUxMcVhnYlBnbkM5?= =?utf-8?B?QVZzTit4VkFBNVR1T3hTTmpwSkRzcU1XeDRXeWF5S3VNU0RMTjB1cEtob0Vn?= =?utf-8?B?Y0dlcnUzY1JDM3ZIdlpwL3dIRTFWKzRQbFN5ZTB6S3NBVTdwdTlEdFBaRXdv?= =?utf-8?B?ZDJaZ09rZjlzcTFjL0xGZjlVc1dCdGlzNjY2T1E2WHcrZFNZMFd0cnR1UlQ3?= =?utf-8?B?RkE9PQ==?= X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0: HmrOHPD/DT4UJfZxHhEZd7L5D/CAU0egTLgvHNtpkxTTbA5GZToTJ/pVWd/vzFUUMh59Y+LAlJDki4Hc6FRs8baWjp8HCsMPrY1Rc3gUcTHpVRYDQbwBCEqLN1SoEXi5N61gMrQ9K0wd5mk/6TAq5oe8GvUlbbazCi0ofdHSWZqfi0848YCOm9wqp0vL60txFIuBZ1/htnQR6hZDxBv8LPWpZN2UF5fxSHy0C5ubcsanqPYBRWwnpcwul9XA7Mk5r3QozYkovvUNiF6ZHmr5kU1b5m049QyWt/CB7rU213kpFGqMPWGZJwmA1naz/vJEoHFr6aSLRpcY8HoX8EDy420Wj6jv5qIk+m2LUj326qVfJlBVKFEt6W2WZcPGShXkimkk9i8cikj8rhk2PLlD2cstC9jLarQhINMuGy7QU1CJJCiO620MygHXhF0z3jQvcWXZZ3r2uIrhm4KGN6tmRjhgJetN65NKxxKlOCL5roGBPLD4bXHis7rnFdZLoyHx/jwl+Menwk9knJe6kAVRHGogsgi5rprcq8BCTtBPX8o5fDHP5WPvH+Jxgh9Q1F8GV98Q5EJ314b01li2anFN4Iz6UhEpettiQIBafH/hHZj2MvaL0je19SrjYSqXjoH8i6Uw3dRNha0QFFKrJMVP6oJDK3fRu7m+MEGm8gsn1OF8IkbMwM6S4S031LxeWxpicGaz9kW1+ml/eb4cS59HXqpw4h8a/BTf2ORtum0lCbikt8Ta2DNF++wKgngxTaB92un/PJVMxQIKZEgZQY2RFVLE9VuS21NIR3fohm0U7+XrgiVfkBJmFHRTxLltxvUxMOZ92OfpNmvHGt8+1wJycqSesr9rMLm1c+KsAFjZtVc+CYfwmTvRnfp6Yph9vV5BQxp1S3QCqEzQgvc26Fh9TQ== X-OriginatorOrg: oracle.com X-MS-Exchange-CrossTenant-Network-Message-Id: ee65f414-b7b7-4d70-5948-08db39eba816 X-MS-Exchange-CrossTenant-AuthSource: BLAPR10MB4835.namprd10.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 10 Apr 2023 17:47:30.5565 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: rxRoySrfRo9SjP4wQlmwyIyCVv79K49QP1l/KYrHfIpC4FOiL3jZKWBy62LBdeGXYPI5LRQEimI6o5KoHttg9HR/Qd+m+Fh4Qw1UReil9Bw= X-MS-Exchange-Transport-CrossTenantHeadersStamped: MW4PR10MB5726 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.254,Aquarius:18.0.942,Hydra:6.0.573,FMLib:17.11.170.22 definitions=2023-04-10_13,2023-04-06_03,2023-02-09_01 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 malwarescore=0 phishscore=0 adultscore=0 spamscore=0 suspectscore=0 bulkscore=0 mlxlogscore=999 mlxscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2303200000 definitions=main-2304100153 X-Proofpoint-GUID: ZN4oo-ZfS3T0WOeYCcXkv5jshMr-PHcS X-Proofpoint-ORIG-GUID: ZN4oo-ZfS3T0WOeYCcXkv5jshMr-PHcS X-Rspamd-Server: rspam07 X-Rspamd-Queue-Id: F27F2180003 X-Rspam-User: X-Stat-Signature: b4j7eineqcp4b1pxthrxn5hu491kymex X-HE-Tag: 1681148870-749360 X-HE-Meta: U2FsdGVkX19d8YcfBf099MJlgPxuTla/3RY9Hpw3nXcNgGboRqu3WAx1cxHsgZPUnxm/M66jaH0lHLDFep08vy4iFTD7p7fW+a9TfeI7l//Gl9D8eKvO9hKmp3q1gnhpo8ty9TrjR/99xSzpU+HltsiKktYrKU3QArF0PTw/q2REVssRPGtXZ1JXIksyLlhCNpE6WuKV7cAApomhP1xewM+PHvDuqJbxluQbub3YeXbSZ8HQ5pY41EN59IRBZAlD1XsmyFi6u9wgovGcFlof9cVGFDdLZe5gniZK/h5wLyIp+/N/tfvLhUXQcsqKvFbd2Oo5+jn8D7a0QrjsaNRcFL4ozMaPZpF98kq8xnY1gO8NXlOuvItvoxhgx2IwUzgbM8VSLyMHK5Afdy5zYE3UCSooPYBS5dtEEVuLskGAp9gY96/2hl+a0QYUEahDAp2X0PAJwDJbirXrgRb79TSGgBXtmyElmkSOrQkuw1toeQzstjVmPLyJGa6PUi2/fFKh7jvcTa3LAHVbMnAK3Te1iUBEXCWpCxm/jgYFdmYf2ZsJg97nvPupHl1q2KP4P/ilCzUbjHKwnFyHdfdin+f0eO9bmnjoyYorSz/zyvNcuwqMfyLqqgwzd4ArtGLeVk1yBUEoY4ytOAsnMHiySlyIb6E1ILCGHIDlhiGe6mXwBE+cw0X3EugU97x+TTl4UEFV82X7x58PA0uCy8Gevc4c+pc2gUG1sdVJsRn/4sWoBwZz+0UaHcXVAZud9pcSkcgLLygk89BCr/uLVEiupy/iLiIfx25U5/zVjir0ZwL96GSXg0CB6A/kzDtJ1M5L4pPkrsvE6y/oe0h0vnLeeNXMMy63hkoLsi5V6ikDq+cdxf+jC2Y1c7eNVi+WmYFoespaw8FgoxoAZpW5NwuxfOhKWWHSHVxhW1/r02xh7AF6FNJkmQYT9GgBticuqFoIYGxKnhkKLyhr2jvv1oiPM55 /x+GP6K/ d0nCIKqNMgNII7cRWkkjIm4n32yPrNmtZ5w98C3JSaYQYC4rHpul0JTdiNY4PhFCCSx05flL1vCefE/Q6oePjloZmQcoJFs0juLYL6VX2VaULxn2m4T7aHM20J2S9DXamhHtCTp3cicJPxEAen9aBGx6L2RTsF8gHKeGhwtLMbv9xt8s9Dk64JrzEWAR1YX0amxy9MlBH3KJBt5cooK6Wx8E8J0sL5luQ/0lhzAc0h8nhdinvayaa3HRml4KVjjEzKJW4bDQ3zXhqskUQPxOLmmYk3HtYigQm4RyOIf8UHgnovi5VpnOLyK7EBvRiHlDuX5Yh6nPbRRtdCxVpiDepebukfprRrXVDNFBB+3+J/S9uNBBKnTFPn/dyaNM0IZf3gfRypXhRCa3bNpwjCIf/MO+XjxowH4iATJmXJ8Kzm/bokbyGaMnqYQSUH1lfMaH6SjP8em65mpCmeyo= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 10/04/2023 18:27, Jane Chu wrote: > > On 4/8/2023 3:19 AM, Aneesh Kumar K.V wrote: >> Jane Chu writes: >> >>> On 4/7/2023 5:23 AM, Aneesh Kumar K.V wrote: >>>> diff --git a/mm/Kconfig b/mm/Kconfig >>>> index ff7b209dec05..99f87c1be1e8 100644 >>>> --- a/mm/Kconfig >>>> +++ b/mm/Kconfig >>>> @@ -461,6 +461,9 @@ config SPARSEMEM_VMEMMAP >>>>          pfn_to_page and page_to_pfn operations.  This is the most >>>>          efficient option when sufficient kernel resources are available. >>>>    +config ARCH_WANT_OPTIMIZE_VMEMMAP >>>> +    bool >>>> + >>> >>> Could this devdax specific config switch be added to drivers/dax/Kconfig >>> ? also, how about adding 'DAX' to the config switch name? >> >> I would say we want to make it more generic. ie, both hugetlb and devdax >> can now derive the feature support via ARCH_WANT_OPTIMIZE_VMEMAP > > The two config switches have different purposes, it's better to keep them > separate.  For example, recent hugetlb high granularity mapping (HGM) project > requires to users to make a choice between HGM and hugetlb vmemmap > optimization(at least for now), while one can keep devdax compound page support > enabled. > Is it done by kconfig? If it helps: * there's a static key hugetlb can use to tell if this is enabled or not like how page_fixed_fake_head() uses it: if (!static_branch_unlikely(&hugetlb_optimize_vmemmap_key)) ... * there's a hugetlb page bit for that vmemmap optimized pages with HpageOptimized(page). * there is a separate hugetlb CONFIG_HUGETLB_PAGE_OPTIMIZE_VMEMMAP which is not the same as the ARCH kconfig. But perhaps there's some relevance in the ARCH_HUGETLB specific to HGMv2 that I am unaware. >> >> commit aafb4790ea0250c8d2450e9d23a4be80c663d2ec >> Author: Aneesh Kumar K.V >> Date:   Sat Apr 8 15:41:48 2023 +0530 >> >>      mm/hugetlb: Remove ARCH_WANT_HUGETLB_PAGE_OPTIMIZE_VMEMMAP >>           We can depend on the more generic ARCH_WACH_OPTIMIZE_VMEMAP >>      which is now used to enable both hugetlb and devddax vmemmap optimization. >>           Signed-off-by: Aneesh Kumar K.V >> >> diff --git a/arch/arm64/Kconfig b/arch/arm64/Kconfig >> index d3f5945f0aff..77d9713dcd9c 100644 >> --- a/arch/arm64/Kconfig >> +++ b/arch/arm64/Kconfig >> @@ -100,7 +100,6 @@ config ARM64 >>       select ARCH_WANT_DEFAULT_TOPDOWN_MMAP_LAYOUT >>       select ARCH_WANT_FRAME_POINTERS >>       select ARCH_WANT_HUGE_PMD_SHARE if ARM64_4K_PAGES || (ARM64_16K_PAGES && >> !ARM64_VA_BITS_36) >> -    select ARCH_WANT_HUGETLB_PAGE_OPTIMIZE_VMEMMAP >>       select ARCH_WANT_LD_ORPHAN_WARN >>       select ARCH_WANTS_NO_INSTR >>       select ARCH_WANT_OPTIMIZE_VMEMMAP >> diff --git a/arch/loongarch/Kconfig b/arch/loongarch/Kconfig >> index ce5802066d0e..9cb00f962de1 100644 >> --- a/arch/loongarch/Kconfig >> +++ b/arch/loongarch/Kconfig >> @@ -53,7 +53,6 @@ config LOONGARCH >>       select ARCH_USE_QUEUED_RWLOCKS >>       select ARCH_USE_QUEUED_SPINLOCKS >>       select ARCH_WANT_DEFAULT_TOPDOWN_MMAP_LAYOUT >> -    select ARCH_WANT_HUGETLB_PAGE_OPTIMIZE_VMEMMAP >>       select ARCH_WANT_LD_ORPHAN_WARN >>       select ARCH_WANTS_NO_INSTR >>       select ARCH_WANT_OPTIMIZE_VMEMMAP >> diff --git a/arch/s390/Kconfig b/arch/s390/Kconfig >> index abffccd937b2..df2cd510480a 100644 >> --- a/arch/s390/Kconfig >> +++ b/arch/s390/Kconfig >> @@ -126,7 +126,6 @@ config S390 >>       select ARCH_WANTS_NO_INSTR >>       select ARCH_WANT_DEFAULT_BPF_JIT >>       select ARCH_WANT_IPC_PARSE_VERSION >> -    select ARCH_WANT_HUGETLB_PAGE_OPTIMIZE_VMEMMAP >>       select ARCH_WANT_OPTIMIZE_VMEMMAP >>       select BUILDTIME_TABLE_SORT >>       select CLONE_BACKWARDS2 >> diff --git a/arch/x86/Kconfig b/arch/x86/Kconfig >> index e8d66d834b4f..5269131cc248 100644 >> --- a/arch/x86/Kconfig >> +++ b/arch/x86/Kconfig >> @@ -125,7 +125,6 @@ config X86 >>       select ARCH_WANTS_NO_INSTR >>       select ARCH_WANT_GENERAL_HUGETLB >>       select ARCH_WANT_HUGE_PMD_SHARE >> -    select ARCH_WANT_HUGETLB_PAGE_OPTIMIZE_VMEMMAP    if X86_64 >>       select ARCH_WANT_LD_ORPHAN_WARN >>       select ARCH_WANT_OPTIMIZE_VMEMMAP    if X86_64 >>       select ARCH_WANTS_THP_SWAP        if X86_64 >> diff --git a/fs/Kconfig b/fs/Kconfig >> index e99830c65033..cc07a0cd3172 100644 >> --- a/fs/Kconfig >> +++ b/fs/Kconfig >> @@ -250,16 +250,9 @@ config HUGETLBFS >>   config HUGETLB_PAGE >>       def_bool HUGETLBFS >>   -# >> -# Select this config option from the architecture Kconfig, if it is preferred >> -# to enable the feature of HugeTLB Vmemmap Optimization (HVO). >> -# >> -config ARCH_WANT_HUGETLB_PAGE_OPTIMIZE_VMEMMAP >> -    bool >> - >>   config HUGETLB_PAGE_OPTIMIZE_VMEMMAP >>       def_bool HUGETLB_PAGE >> -    depends on ARCH_WANT_HUGETLB_PAGE_OPTIMIZE_VMEMMAP >> +    depends on ARCH_WANT_OPTIMIZE_VMEMMAP >>       depends on SPARSEMEM_VMEMMAP >>     config HUGETLB_PAGE_OPTIMIZE_VMEMMAP_DEFAULT_ON >> diff --git a/mm/Kconfig b/mm/Kconfig >> index 99f87c1be1e8..09ac60894763 100644 >> --- a/mm/Kconfig >> +++ b/mm/Kconfig >> @@ -460,7 +460,10 @@ config SPARSEMEM_VMEMMAP >>         SPARSEMEM_VMEMMAP uses a virtually mapped memmap to optimise >>         pfn_to_page and page_to_pfn operations.  This is the most >>         efficient option when sufficient kernel resources are available. >> - >> +# >> +# Select this config option from the architecture Kconfig, if it is preferred >> +# to enable the feature of HugeTLB/dev_dax vmemmap optimization. >> +# >>   config ARCH_WANT_OPTIMIZE_VMEMMAP >>       bool >>   > > thanks, > -jane