From: Alejandro Colomar <colomar.6.4.3@gmail.com>
To: John Hubbard <jhubbard@nvidia.com>, Mike Frysinger <vapier@gentoo.org>
Cc: Michael Kerrisk <mtk.manpages@gmail.com>,
linux-man@vger.kernel.org, linux-mm@kvack.org,
Vahid Noormofidi <vnoormof@nvidia.com>,
Matthew Wilcox <willy@infradead.org>,
"Kirill A . Shutemov" <kirill.shutemov@linux.intel.com>,
Andrew Morton <akpm@linux-foundation.org>,
Carsten Grohmann <carstengrohmann@gmx.de>
Subject: Re: [PATCH] man5/tmpfs.5: fix typo in reference to CONFIG_TRANSPARENT_HUGEPAGE
Date: Wed, 19 Jul 2023 21:59:58 +0200 [thread overview]
Message-ID: <eabfcdbb-3035-5593-8ed0-d9a0349b948a@gmail.com> (raw)
In-Reply-To: <20230719020533.1608867-1-jhubbard@nvidia.com>
[-- Attachment #1.1: Type: text/plain, Size: 1836 bytes --]
On 2023-07-19 04:05, John Hubbard wrote:
> In commit 462a385e9a2 ("tmpfs.5: Document current mount options"), there
> is a reference to CONFIG_TRANSPARENT_HUGE_PAGECACHE. However, that
> option was removed from the kernel via commit 396bcc5299c2 ("mm: remove
> CONFIG_TRANSPARENT_HUGE_PAGECACHE"), a couple of years later.
>
> The net effect is that CONFIG_TRANSPARENT_HUGEPAGE is now used in all
> the remaining places in the kernel where
> CONFIG_TRANSPARENT_HUGE_PAGECACHE had previously been used.
>
> This has caused some minor confusion at the man page level, though. So
> let's fix it by updating the man page to also refer to
> CONFIG_TRANSPARENT_HUGEPAGE.
>
> Reported-by: Vahid Noormofidi <vnoormof@nvidia.com>
> Cc: Matthew Wilcox (Oracle) <willy@infradead.org>
> Cc: Kirill A. Shutemov <kirill.shutemov@linux.intel.com>
> Cc: Andrew Morton <akpm@linux-foundation.org>
> Cc: Carsten Grohmann <carstengrohmann@gmx.de>
> Cc: Signed-off-by: Mike Frysinger <vapier@gentoo.org>
Accident here :-)
> Signed-off-by: John Hubbard <jhubbard@nvidia.com>
> ---
> man5/tmpfs.5 | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/man5/tmpfs.5 b/man5/tmpfs.5
> index 09d955898..cdd5f2fd8 100644
> --- a/man5/tmpfs.5
> +++ b/man5/tmpfs.5
> @@ -115,7 +115,7 @@ Set the initial user ID of the root directory.
> .BR huge "=\fIhuge_option\fR (since Linux 4.7.0)"
> .\" commit 5a6e75f8110c97e2a5488894d4e922187e6cb343
> Set the huge table memory allocation policy for all files in this instance (if
> -.B CONFIG_TRANSPARENT_HUGE_PAGECACHE
> +.B CONFIG_TRANSPARENT_HUGEPAGE
> is enabled).
> .IP
> The
>
> base-commit: c654cde5ec9e9fa975d5d041aa069489ab12a4ce
--
<http://www.alejandro-colomar.es/>
GPG key fingerprint: A9348594CE31283A826FBDD8D57633D441E25BB5
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
next prev parent reply other threads:[~2023-07-19 20:00 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-07-19 2:05 John Hubbard
2023-07-19 19:59 ` Alejandro Colomar [this message]
2023-07-19 20:13 ` John Hubbard
2023-07-20 8:03 ` Alejandro Colomar
2023-07-28 19:04 ` Alejandro Colomar
2023-07-28 19:18 ` John Hubbard
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=eabfcdbb-3035-5593-8ed0-d9a0349b948a@gmail.com \
--to=colomar.6.4.3@gmail.com \
--cc=akpm@linux-foundation.org \
--cc=alx@kernel.org \
--cc=carstengrohmann@gmx.de \
--cc=jhubbard@nvidia.com \
--cc=kirill.shutemov@linux.intel.com \
--cc=linux-man@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mtk.manpages@gmail.com \
--cc=vapier@gentoo.org \
--cc=vnoormof@nvidia.com \
--cc=willy@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox