From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1063DD59F53 for ; Wed, 6 Nov 2024 16:23:11 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id A72F06B0085; Wed, 6 Nov 2024 11:23:10 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 9FC096B0089; Wed, 6 Nov 2024 11:23:10 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 877146B0099; Wed, 6 Nov 2024 11:23:10 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id 6078A6B0085 for ; Wed, 6 Nov 2024 11:23:10 -0500 (EST) Received: from smtpin05.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay04.hostedemail.com (Postfix) with ESMTP id 1D92A1A07A9 for ; Wed, 6 Nov 2024 16:23:10 +0000 (UTC) X-FDA: 82756188900.05.466516E Received: from mail-lj1-f179.google.com (mail-lj1-f179.google.com [209.85.208.179]) by imf28.hostedemail.com (Postfix) with ESMTP id EB89FC002B for ; Wed, 6 Nov 2024 16:22:32 +0000 (UTC) Authentication-Results: imf28.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=nZotgtfZ; spf=pass (imf28.hostedemail.com: domain of usamaarif642@gmail.com designates 209.85.208.179 as permitted sender) smtp.mailfrom=usamaarif642@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1730910138; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=HA/d/Z9HyomhTibUVgabDNdZo8diPPOAH/LWnZYh1Vc=; b=zsgH5Jxa2uJg/yKv5p7djHvFDpfEScOzSPFSikD4d315TjzEukPwDKLkymsJnN7kaL1Ui8 JL9fQq9eDmVFzrdbEsoKnPHeU/PdoK0EDpKO1eM1yJmmLQRQIiO8iBEVEkUELSydKKSyU6 VPPZESdPmpcjjmMgDiRfZZWvtZG/qkc= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1730910138; a=rsa-sha256; cv=none; b=PA+2fqs0/SJgQCNlJTjNNZJP1C9ZUr1GNE+y2dXoazabNAmuq3v3pv/FItao07GWfENXsu e3YknxLYVasAg5t35g6YmvExvVIq6B53NFzXso5t5iwtffWvdZ4oXrt3WZ9Sim8Iz90tGl hVJkaOo+u5qXdLipp0HvqsqrFi/lq2Y= ARC-Authentication-Results: i=1; imf28.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=nZotgtfZ; spf=pass (imf28.hostedemail.com: domain of usamaarif642@gmail.com designates 209.85.208.179 as permitted sender) smtp.mailfrom=usamaarif642@gmail.com; dmarc=pass (policy=none) header.from=gmail.com Received: by mail-lj1-f179.google.com with SMTP id 38308e7fff4ca-2fb4af0b6beso106935581fa.3 for ; Wed, 06 Nov 2024 08:23:07 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1730910186; x=1731514986; darn=kvack.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=HA/d/Z9HyomhTibUVgabDNdZo8diPPOAH/LWnZYh1Vc=; b=nZotgtfZ1VEb48CcgQhkis2ldzWvIDqP4+GotQ+kYHcqcSsbc+Fho1FVDX2M/4l1U8 mGU9wmRFMsiCzo+TyYIi8CCTcXBnI6Z1YvFngNrVG6u0azTL7YLKuoFvX/Ks/ClKQlen 9vv/azRGfesKSu6d9q9rugo/Hi813CNnO2Cmvf1zWAeqKerlx132Gn365E9TVGm++HXL ePdeRq21r+D+WLn6CPJTPn9ni+BPcn40tLIrKI51X5/2xh8lEMrN3cGf7Dl2HTX7hNlz Pwotd42BencqTqblNDmDhYoXJz4H3kB5GI/IqIEOXBDroiYyU1+WakwRquIVnHMXRt8P An4Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1730910186; x=1731514986; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=HA/d/Z9HyomhTibUVgabDNdZo8diPPOAH/LWnZYh1Vc=; b=f/V1GlUoRi6N5T+A98Gi6OXmSkSZwqamSeppzCg9snrqPOveiQruxP++e1k7DdLl/c reTZBQcDpBymD65Esua79JJiMgdXSkwR8H7hmPZKSJhaKykJB1pwbm6qbRum3wwd4wCK 9FxGTCxe6ArArvXWcP4QU1NhkANIOmIW8/gHOSf2t3r1WMbLL9qn+PdLGRKdyoEWhXkC dwSs62XJHag3iMx4zvp9WdPJV3mdJ1Okep/GQD+oyBVVTJ7SlAUTpco0YWmZudDXknHq VdcsidbuWL5Gs+Nt/f70/v6Vh+qLrTHs2iYSFz0hQAHFTYNfiPnb2uCrP9+E8uukuK5v 8OIw== X-Forwarded-Encrypted: i=1; AJvYcCVx+n6vlPGKcadFepnrcDhQRSQe6UkBNIvVlnoIfUfLsUUsEfQ0iKmCPGJx8aaWs4eDeEtoYcglUg==@kvack.org X-Gm-Message-State: AOJu0Yy9a5a8y5VSUMPUM47YgcEBetk4FolQp5DyML5mD/tk5aYDygMt ePIcjEbJvhtYhfZu2wRUVuhWr9b32CK5qC/uCNCUSbtsFjSmeZH3 X-Google-Smtp-Source: AGHT+IFw/5Y0f9sdkNhYA7Kkd9XGdFIkkWPI1lJhBpUx2qygFe/jEt9OrweBr+vtfjWEa3sLxLMR+Q== X-Received: by 2002:a2e:a902:0:b0:2fb:4db1:1ab7 with SMTP id 38308e7fff4ca-2fedb82fc9amr178058881fa.39.1730910185806; Wed, 06 Nov 2024 08:23:05 -0800 (PST) Received: from ?IPV6:2a03:83e0:1126:4:eb:d0d0:c7fd:c82c? ([2620:10d:c092:500::4:2454]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-a9eb17fa445sm299452366b.169.2024.11.06.08.23.04 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 06 Nov 2024 08:23:05 -0800 (PST) Message-ID: Date: Wed, 6 Nov 2024 16:23:04 +0000 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH RFC 2/2] zram: support compression at the granularity of multi-pages To: Barry Song <21cnbao@gmail.com> Cc: akpm@linux-foundation.org, axboe@kernel.dk, chrisl@kernel.org, corbet@lwn.net, david@redhat.com, hannes@cmpxchg.org, kanchana.p.sridhar@intel.com, kasong@tencent.com, linux-block@vger.kernel.org, linux-mm@kvack.org, minchan@kernel.org, nphamcs@gmail.com, senozhatsky@chromium.org, surenb@google.com, terrelln@fb.com, v-songbaohua@oppo.com, wajdi.k.feghali@intel.com, willy@infradead.org, ying.huang@intel.com, yosryahmed@google.com, yuzhao@google.com, zhengtangquan@oppo.com, zhouchengming@bytedance.com, bala.seshasayee@linux.intel.com, Johannes Weiner References: <20240327214816.31191-3-21cnbao@gmail.com> <20241021232852.4061-1-21cnbao@gmail.com> Content-Language: en-US From: Usama Arif In-Reply-To: <20241021232852.4061-1-21cnbao@gmail.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Stat-Signature: uchd7okcj7omher8sbga43khwujo43m8 X-Rspam-User: X-Rspamd-Queue-Id: EB89FC002B X-Rspamd-Server: rspam02 X-HE-Tag: 1730910152-617839 X-HE-Meta: U2FsdGVkX18i8QhaWvu+g1qN+Vhnxhkiz/n//Htl9u16EvaEfOomoXSZc638ni0ny/RWk0lrFf+PQxWmm1qzZy8gCtOOXGPCfiBdTRdnV8MGSYqE3t2fhAIswKemlLyO34gDjZybHprgPZ3O2KSxO5+rhb4oKsWkV4oBFEgtnLobcLyQ1iHB9AXTwA3Q0Qo0IKYTszhWdrEpqzNxTT232YUuuwQrpQ/nO8eTwNfPVkwCt5VHB/QJjcdxgNUhErf+db5ia9lrr2d3C341oYJyXt/xfXJKCA0tNLwFGp+qJ+RjHyPBjk6xaO5CIaspq7u1UGnQQ1Uu1mcnbKKS+CHcb8NCKbAL/VILv0oP9N/we8qZMZOiiQxAEF4wy05xY7DMxUaElr6X3uq0/Yo4IzQ9O976VOt1FA7m00dkw9x+Ld/bMIKchZLZbR+t2CuQ+G5q9P7MQWsHu6VDQd4BnkYNWNgdds2eOJFQ3ElQth0v91xvei08rAK7zLjsla0+CYQ/KaNsL6BqFrPgJO1vApQc8w9idvtEP/dNsuBii8ReAYYjf/pkDfn4Aufish0Ff1nFfm9YOz5bZXxZ7yot3FLX/7hPdWaKh5p+3rykK3H6Mw6y08B/lmRxPTowF6QqKBCjKAeJQvGgjWvE2gYHnj1bM0Pt9zhye+668ETJRkUqWU1owqhaz6c83/PUYcYwImJp0pqbjKESyD70W5cm2gG1rsQu8wJ2p/3AN6uvJ5xHWOpup82/mc5yq59KTriEwgVs2YGZDaEH5COX8YnChhghq0Abrh7i3LpglMypWFyWlxNOJE8G8ZYQCZZM1z3yheyj2rqxU5MdNSLIqrnJGYrIx2/M2HnY0t+uMHvKiRe3HFgg5zccJpVRZGmF91kgTKKZnxb8R7orkVerKnLp6Bp3g4TxHWuuQD+ZX+DT5jYOXnPorbvVM4AEsqKK334XBnwXw0KtGxIJn1eOXWfmfI2 xN9K1rEQ YAG2JNTq/X+WRCiGAcGRJl2BkqLIdOx3le4D9REAzmOyZi0oLzEfYvl6GVtuqU7iXELJswT5Af76dZOw3sBvCcBkETJRkrHlteVTMczGYHgfZJr6ftZ7wAqiVOykBJAN1UoOR5plvQuVXIQI1mNxMLcezCVJG4pk8SjN5BtddouDGg6abR0NVMLuk/YcvQHsw1HaREC4mBaUWqaR+x31nE/v33hQP3Om9I662jEnpAr3C8FqmZ8BitA6eLguTEc4TnD5VzNivUTcuO98TUySnJmbqHDwr4ubLKkpReynKmnqHqMNe149gMNYe4jFxnTkEqrUfjA6x4hd+xlpVdZkYs8KjLwfymzilSVsaBcwbkdoec3lyx+M7QtjWXBuCHaPyS4egJj2X1mYE9O2I8AHXVM48QqVnpyhgV46rS0rc9+V+Tb5H8McLNPNXguPDgBEX6XL7Rr9jseG0pDItH0y1t3mSgBPXG/zxofwrWWKPRnhABGei7ZGArqFblg== X-Bogosity: Ham, tests=bogofilter, spamicity=0.002473, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 22/10/2024 00:28, Barry Song wrote: >> From: Tangquan Zheng >> >> +static int zram_bvec_write_multi_pages(struct zram *zram, struct bio_vec *bvec, >> + u32 index, int offset, struct bio *bio) >> +{ >> + if (is_multi_pages_partial_io(bvec)) >> + return zram_bvec_write_multi_pages_partial(zram, bvec, index, offset, bio); >> + return zram_write_page(zram, bvec->bv_page, index); >> +} >> + Hi Barry, I started reviewing this series just to get a better idea if we can do something similar for zswap. I haven't looked at zram code before so this might be a basic question: How would you end up in zram_bvec_write_multi_pages_partial if using zram for swap? We only swapout whole folios. If ZCOMP_MULTI_PAGES_SIZE=64K, any folio smaller than 64K will end up in zram_bio_write_page. Folios greater than or equal to 64K would be dispatched by zram_bio_write_multi_pages to zram_bvec_write_multi_pages in 64K chunks. So for e.g. 128K folio would end up calling zram_bvec_write_multi_pages twice. Or is this for the case when you are using zram not for swap? In that case, I probably dont need to consider zram_bvec_write_multi_pages_partial write case for zswap. Thanks, Usama