From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8D3BCC433F5 for ; Wed, 24 Nov 2021 13:30:09 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 029FD6B0071; Wed, 24 Nov 2021 08:29:54 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id EF52E6B007B; Wed, 24 Nov 2021 08:29:53 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id D709B6B007D; Wed, 24 Nov 2021 08:29:53 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0077.hostedemail.com [216.40.44.77]) by kanga.kvack.org (Postfix) with ESMTP id C4A1E6B0071 for ; Wed, 24 Nov 2021 08:29:53 -0500 (EST) Received: from smtpin09.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay03.hostedemail.com (Postfix) with ESMTP id 8377182499B9 for ; Wed, 24 Nov 2021 13:29:43 +0000 (UTC) X-FDA: 78843906288.09.AB97605 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by imf15.hostedemail.com (Postfix) with ESMTP id 8E133D00009A for ; Wed, 24 Nov 2021 13:29:38 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1637760582; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=xRYVWJ0dHQQi9iTSKLYm90ofCR3wC6pwccxUaAf29nM=; b=e10UOt4SaPoLD4eM0jQWBkL/2kDJAxgYofP1YvwjUa5w23ZIK6twqvV5qLhddHIwW1BYff vK/5rL58lqIINjlqhlvzscN22jIliF7g6lAzXNsQivaZ+eKWqYQWzpshzf+ONe2OUBZhVk PIrLMlDQe/LLDbMvMkGokXypBA1TFCY= Received: from mail-wm1-f70.google.com (mail-wm1-f70.google.com [209.85.128.70]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-585-7OU_Spt3OmOW2rh8kyCfWw-1; Wed, 24 Nov 2021 08:29:41 -0500 X-MC-Unique: 7OU_Spt3OmOW2rh8kyCfWw-1 Received: by mail-wm1-f70.google.com with SMTP id m18-20020a05600c3b1200b0033283ea5facso1723830wms.1 for ; Wed, 24 Nov 2021 05:29:41 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent:subject :content-language:to:cc:references:from:organization:in-reply-to :content-transfer-encoding; bh=xRYVWJ0dHQQi9iTSKLYm90ofCR3wC6pwccxUaAf29nM=; b=kPyQaqPLo+sZE0DXiwUMfLOUWhxHAgeDNqBvMVQon39RWs6/Yxt4HEqvsRyq3gCgHP sI1HxyR4scsoAm4OwWpjrD+Ouo9N5j+JyTKm23UQLqDYSs3x8ISTybEd1nev8PDPrHon Xxett4QX8IvrPLlRNv2IgjN7uEOFNlQB8rmzy3yzOquh/VZktKQbLN2I7+24i1YWYCDH oEQEVKEv5bWznkVJP7CqT44MhmC25y5bKuzUgQeR4034MJ6Lf4w7QijAAM1WvmPXwQVk SEdybGgchAOQ4jV1DYcIDiUDLCT6Ag8Z8Ro4/7jCJEcKK55tnNp5g0i56bfQa+HgL4+/ 8r8w== X-Gm-Message-State: AOAM5312waPTcQgcykfcUKDEU+AxCSCnbL837OredM/Yyr6XSk9T4rw2 ZZp3x4sWqzFAeCIQq2Jcfe4jWbxJfYFw7vBlBgnjin+Mip7o0byu54oaD3axTayASjMZYypUwEL ++QsQOhsuPw8= X-Received: by 2002:a05:600c:4113:: with SMTP id j19mr15740524wmi.48.1637760580119; Wed, 24 Nov 2021 05:29:40 -0800 (PST) X-Google-Smtp-Source: ABdhPJx78FKob78W4FbekErBlR8gszY218GTBoVGEEbXRoGoGY1c2BBkA3PDkq8LVS5+AsJnhYARCQ== X-Received: by 2002:a05:600c:4113:: with SMTP id j19mr15740485wmi.48.1637760579921; Wed, 24 Nov 2021 05:29:39 -0800 (PST) Received: from [192.168.3.132] (p5b0c6380.dip0.t-ipconnect.de. [91.12.99.128]) by smtp.gmail.com with ESMTPSA id j40sm5638552wms.16.2021.11.24.05.29.38 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 24 Nov 2021 05:29:39 -0800 (PST) Message-ID: Date: Wed, 24 Nov 2021 14:29:38 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.2.0 Subject: Re: [PATCH] Increase default MLOCK_LIMIT to 8 MiB To: Jason Gunthorpe Cc: Vlastimil Babka , Jens Axboe , Andrew Dona-Couch , Andrew Morton , Drew DeVault , Ammar Faizi , linux-kernel@vger.kernel.org, linux-api@vger.kernel.org, io_uring Mailing List , Pavel Begunkov , linux-mm@kvack.org References: <20211123132523.GA5112@ziepe.ca> <10ccf01b-f13a-d626-beba-cbee70770cf1@redhat.com> <20211123140709.GB5112@ziepe.ca> <20211123170056.GC5112@ziepe.ca> <20211123235953.GF5112@ziepe.ca> <2adca04f-92e1-5f99-6094-5fac66a22a77@redhat.com> <20211124132353.GG5112@ziepe.ca> <20211124132842.GH5112@ziepe.ca> From: David Hildenbrand Organization: Red Hat In-Reply-To: <20211124132842.GH5112@ziepe.ca> X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Rspamd-Server: rspam10 X-Rspamd-Queue-Id: 8E133D00009A X-Stat-Signature: rhn53rfdban398efjm3i5nih173ic37c Authentication-Results: imf15.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=e10UOt4S; dmarc=pass (policy=none) header.from=redhat.com; spf=none (imf15.hostedemail.com: domain of david@redhat.com has no SPF policy when checking 170.10.129.124) smtp.mailfrom=david@redhat.com X-HE-Tag: 1637760578-102776 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 24.11.21 14:28, Jason Gunthorpe wrote: > On Wed, Nov 24, 2021 at 02:25:09PM +0100, David Hildenbrand wrote: >> On 24.11.21 14:23, Jason Gunthorpe wrote: >>> On Wed, Nov 24, 2021 at 09:57:32AM +0100, David Hildenbrand wrote: >>> >>>> Unfortunately it will only be a band aid AFAIU. I can rewrite my >>>> reproducer fairly easily to pin the whole 2M range first, pin a second >>>> time only a single page, and then unpin the 2M range, resulting in the >>>> very same way to block THP. (I can block some THP less because I always >>>> need the possibility to memlock 2M first, though). >>> >>> Oh! >>> >>> The issue is GUP always pins an entire compound, no matter how little >>> the user requests. >> >> That's a different issue. I make sure to split the compound page before >> pinning anything :) > > ?? Where is that done in GUP? It's done in my reproducer manually. -- Thanks, David / dhildenb