From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0C33CC6FD20 for ; Fri, 24 Mar 2023 21:13:14 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 462006B0072; Fri, 24 Mar 2023 17:13:14 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 40F4F6B0074; Fri, 24 Mar 2023 17:13:14 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 2D6D76B0075; Fri, 24 Mar 2023 17:13:14 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id 1B2D26B0072 for ; Fri, 24 Mar 2023 17:13:14 -0400 (EDT) Received: from smtpin10.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id C7629140AEF for ; Fri, 24 Mar 2023 21:13:13 +0000 (UTC) X-FDA: 80605042266.10.83C455A Received: from madras.collabora.co.uk (madras.collabora.co.uk [46.235.227.172]) by imf17.hostedemail.com (Postfix) with ESMTP id 0006140007 for ; Fri, 24 Mar 2023 21:13:10 +0000 (UTC) Authentication-Results: imf17.hostedemail.com; dkim=pass header.d=collabora.com header.s=mail header.b=JDEQbwqu; spf=pass (imf17.hostedemail.com: domain of usama.anjum@collabora.com designates 46.235.227.172 as permitted sender) smtp.mailfrom=usama.anjum@collabora.com; dmarc=pass (policy=quarantine) header.from=collabora.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1679692391; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=8CF62lCEJdDQYaoRDfuRC+vtPpQ2ITwZpb2iSKXMRJE=; b=DL5D/a5cLfdHgieQ3n7KbwPr2vZ4KrP4Nb6WPtQIwXNjOpiRGkkMHoWTIhu5rVy+fxhtra LUdfAryV3PUrhPlhJ5kedrvEhWW2Ybm+ZWZ/8WoEUKi/9vDaAc4DyYRmOfDikWzGcq80KL qgozPnxejzlJYAqUEj5YCRabeQM1opc= ARC-Authentication-Results: i=1; imf17.hostedemail.com; dkim=pass header.d=collabora.com header.s=mail header.b=JDEQbwqu; spf=pass (imf17.hostedemail.com: domain of usama.anjum@collabora.com designates 46.235.227.172 as permitted sender) smtp.mailfrom=usama.anjum@collabora.com; dmarc=pass (policy=quarantine) header.from=collabora.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1679692391; a=rsa-sha256; cv=none; b=UDLlD91/Gk/apEgtARAE/F7w1fhBPPM2tmt9z08HGIXNQ30SZkmUXoYGk5ye5WI4P7Alx2 Ztp2wcQx3tQclqFyczJwjEgfjZe+B89/R2ZTkUZ9F6E/uveFkkx2TbVo3LwNYTAbUdlSQ+ UaDOhojyBtLSHGqdhBU5SshR3yfZGp8= Received: from [192.168.10.39] (unknown [119.155.2.20]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) (Authenticated sender: usama.anjum) by madras.collabora.co.uk (Postfix) with ESMTPSA id E6490660206A; Fri, 24 Mar 2023 21:13:06 +0000 (GMT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=collabora.com; s=mail; t=1679692389; bh=txaOnhLH2D4ccynBeXElhufAFanFILa3bH1kjnNZJZs=; h=Date:Cc:Subject:To:References:From:In-Reply-To:From; b=JDEQbwquT419PgvuTeM/GUJzyJ9wfI32yh38MsDe1BWnDpI9euwMvGNmXd32pk10x 0qbJ4CDBKFSpSX62yN8dlQOD1FyHPjE9+y86tUm9+F2FrFwpXOPqmtjO/Yn9WzUM7k 6BUhprovL1Av+YDtR/cAWzclrH+XmFQLn9Mbs4cXhf7b0qUgMV4r437skabiA5KL0o myjBLJZjo/02bkjRDweJ8d48cyMb0eenTr7OfJviYfXlRWxKJIp+Tw4icvdbG+jbt+ Lmi4W47lDX8Z6vDxjW0/cQ7elNSDGgckYQZCKT8gL/YPS8V0juzb70A/N6ExKTpptW pPKkAANs5xPqQ== Message-ID: Date: Sat, 25 Mar 2023 02:12:55 +0500 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.9.0 Cc: Muhammad Usama Anjum , damon@lists.linux.dev, linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] mm/damon/sysfs: make more kobj_type structures constant Content-Language: en-US To: =?UTF-8?Q?Thomas_Wei=c3=9fschuh?= , SeongJae Park , Andrew Morton References: <20230324-b4-kobj_type-damon2-v1-1-48ddbf1c8fcf@weissschuh.net> From: Muhammad Usama Anjum In-Reply-To: <20230324-b4-kobj_type-damon2-v1-1-48ddbf1c8fcf@weissschuh.net> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Rspam-User: X-Rspamd-Server: rspam03 X-Stat-Signature: htq3ukcaip151d1emhyr9kpxxdbcub7z X-Rspamd-Queue-Id: 0006140007 X-HE-Tag: 1679692390-824859 X-HE-Meta: U2FsdGVkX1+5QmnKAc3ZxUV8rkT9r7N8ZW2oSioGav+gP54OsaXJFhA0G+Vf0SLftuz2t+7G1xin2deJK8E/n1EEyVKXmi5m6nX44ueZRBzzGw6nebY17r3Dp0v0k1XjR+otH15ZyndDT9vMXXKJeR8DxFGswgu40Js4R5uWRYg63q6VY8ruhEaZbmAnXa82mU5hlO9RqaypK7fiytOUCIXYvsTHAqDUBBJwVOXoAvD/TXSq2jbw/VAVbh+L0o2wxukNvg2Hi1NkHWSg9zykU514pjSPaSwzKIyrUljBbFfKaQAFXARriBcNzj1GrBz9NI+m6Sv3TsBE6wI97fmqhACU6cchaEURPk1vsG96Z4MlFD0rcVLNBURrvHwfSFHmAj0VyADTEPRd4PgMPIYn/shXlne9sGFrPg+gQ6oWQhDe3i5RUe7xZqSAW8E5qWfpi2H1QA5P93nFHxLVCXChbxFABYvBvmBv7eZ2sQC6Wzt4nfog+rPgwqqVLfXVgyjSDwws+Q10qDWfufy1wvy2ZXik3mABXeck4s3fvezqRCrgYxUK1SYLuiCEuonsFWMATOKPJc9/Do+gtiHhujnSuQTQYp9uFXLtgvT9LPtsBwwwCV8tVq176O+4O1cEQeCEZg0YdAxOGkbjdbh4P5IJOTK5p05yVKI5mqVCTjHdPGCW9IAGWnvI6vinNpk/wLKIPgc7lYtutq4I1nB97vGY9pH0tffz9pEwEeepNGq81huyOnnO3mbfQjitT0BqwuvyRXfcGsGLhHM5lVZNTJtYrkkbTuK2LNoZGlXToVOIOwE/IQq3bVkhlkPx1uYxTgpH7JWyd82qlvHP0PsPirW15iD12CxWGENRYRKon9hXhzZ8sWGv46AjDAbp/T+CTyY648fF5UwKU53cXOo5piHSqagAlRqHAKhh6u690O7LBlw/52LRPPZW6RiuvdpNPIqYniaGEhS6ex/7vdx5DlV V8egKu0J FhNFFIv5+pMA6Qe/ffjT49PuJE9gVjuYivt4MIM7nCEKA/ZpH1t8F6ZSU57NBHOsSWdIcQBDrypmtISToH/vCaWstfnnoxmCEokFfJOTOXgYHFloOXR8JmvKAH5X9yhQ0Cf6+UoDu1sIBokLBjkYEsLtd42bQkSU1OHwA5eiqo4TQAroRi26zp9zGit9qnyL6P31Sjrr76locURrJD8cWrOCkECtIbLOHSs+e0P3TK6KTmbGk7RD2I9XC+YfN4I81f9Wlu1OSG2diKmvQ0meSHhWgHspJPZQvAL/wDIexYjaBzXfOU8iqVD5KOYSO8VYmEu/+mqgl47tTF4vjN6L0rMf2WyI1NEbtuhE/cd0P0RmvZkKeHhILYflgaKO+WdxubCUq X-Bogosity: Ham, tests=bogofilter, spamicity=0.000006, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 3/24/23 8:35 PM, Thomas Weißschuh wrote: > Since commit ee6d3dd4ed48 ("driver core: make kobj_type constant.") > the driver core allows the usage of const struct kobj_type. > > Take advantage of this to constify the structure definition to prevent > modification at runtime. > > These structures were not constified in > commit e56397e8c40d ("mm/damon/sysfs: make kobj_type structures constant") > as they didn't exist when that patch was written. > > Signed-off-by: Thomas Weißschuh Reviewed-by: Muhammad Usama Anjum > --- > mm/damon/sysfs-schemes.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/mm/damon/sysfs-schemes.c b/mm/damon/sysfs-schemes.c > index 3cdad5a7f936..50cf89dcd898 100644 > --- a/mm/damon/sysfs-schemes.c > +++ b/mm/damon/sysfs-schemes.c > @@ -384,7 +384,7 @@ static struct attribute *damon_sysfs_scheme_filter_attrs[] = { > }; > ATTRIBUTE_GROUPS(damon_sysfs_scheme_filter); > > -static struct kobj_type damon_sysfs_scheme_filter_ktype = { > +static const struct kobj_type damon_sysfs_scheme_filter_ktype = { > .release = damon_sysfs_scheme_filter_release, > .sysfs_ops = &kobj_sysfs_ops, > .default_groups = damon_sysfs_scheme_filter_groups, > @@ -503,7 +503,7 @@ static struct attribute *damon_sysfs_scheme_filters_attrs[] = { > }; > ATTRIBUTE_GROUPS(damon_sysfs_scheme_filters); > > -static struct kobj_type damon_sysfs_scheme_filters_ktype = { > +static const struct kobj_type damon_sysfs_scheme_filters_ktype = { > .release = damon_sysfs_scheme_filters_release, > .sysfs_ops = &kobj_sysfs_ops, > .default_groups = damon_sysfs_scheme_filters_groups, > > --- > base-commit: 1e760fa3596e8c7f08412712c168288b79670d78 > change-id: 20230324-b4-kobj_type-damon2-0238ee9e8d8c > > Best regards, -- BR, Muhammad Usama Anjum