From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8BF78C433F5 for ; Thu, 14 Oct 2021 15:09:57 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 238AF60F36 for ; Thu, 14 Oct 2021 15:09:57 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 238AF60F36 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=kvack.org Received: by kanga.kvack.org (Postfix) id 9AF58900003; Thu, 14 Oct 2021 11:09:56 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 95E22900002; Thu, 14 Oct 2021 11:09:56 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 82692900003; Thu, 14 Oct 2021 11:09:56 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0130.hostedemail.com [216.40.44.130]) by kanga.kvack.org (Postfix) with ESMTP id 754E9900002 for ; Thu, 14 Oct 2021 11:09:56 -0400 (EDT) Received: from smtpin22.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay03.hostedemail.com (Postfix) with ESMTP id 326EA82499B9 for ; Thu, 14 Oct 2021 15:09:56 +0000 (UTC) X-FDA: 78695377992.22.FAB371A Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by imf09.hostedemail.com (Postfix) with ESMTP id 293843000107 for ; Thu, 14 Oct 2021 15:09:54 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1634224195; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=jTxRkwer/L1jMFbVHe+gmT8Lx5IDhS6y3cTZBhYxWZc=; b=eWI2+ntEGDvxMqgYGHg1UytVzGbsb/ESBu65u6w1058DTE8GcHpTnoTXW8h+3cGUybdRhW zN4iC5wE7lDrr7r+2ck2y20wwx/XvQEl58pQLH0huZ4Tj8f0kceoMfIJoHdQa+Hoziqu5b XodTLSXi6cahZMx3F3cOhhHD9lRc5wA= Received: from mail-wr1-f71.google.com (mail-wr1-f71.google.com [209.85.221.71]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-370-dQ4ThVuTPQSLofIJlVQkqQ-1; Thu, 14 Oct 2021 11:09:53 -0400 X-MC-Unique: dQ4ThVuTPQSLofIJlVQkqQ-1 Received: by mail-wr1-f71.google.com with SMTP id 41-20020adf802c000000b00161123698e0so4779532wrk.12 for ; Thu, 14 Oct 2021 08:09:53 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent:subject :content-language:to:cc:references:from:organization:in-reply-to :content-transfer-encoding; bh=jTxRkwer/L1jMFbVHe+gmT8Lx5IDhS6y3cTZBhYxWZc=; b=Jc/bePGx2Da/kYGwzvopUDxVXK4roq00k0TtMcZzSWsiGtVJZTZVG/JUKjBCNYOVxl 6tt5/J5BgqGCIgwpef/PGyT1E5FsJIXUTLHk56D3EDuFDE67c26RG0DXe2uwnEOlN4PC r1+jDJRe4u4E2a0y1HS84iCj9abaZlTd1n7RZbnr7PERnCL1wiYI8JBoOTsr/746p3YQ 2fZjC/Xhiuq3emc7penctFy6tvLvQzjIq4EcLUfuwWyElY2zHNmZL057McAlUEu6WhJS BkqA5H2wsJBeVlq6ZfaQrQHYPMKNdvmaXHaTqxonFHh4ebz8NtZ5Me43vcts/CrBilH5 jNIw== X-Gm-Message-State: AOAM530wM4zcRwCjPd9yj+WXJj0krMoKH4cve6Q1IbyOLxoe/rJ3CZEP 8g7lB3cU7pGlAikgRyMRrbbMq0hue2OBgv2nRVnnhiDMsTERZyEgVJ7JqjgymOAoqqkpg06MNfI Jbpa3NS/jvqs= X-Received: by 2002:a1c:29c7:: with SMTP id p190mr6271730wmp.65.1634224192157; Thu, 14 Oct 2021 08:09:52 -0700 (PDT) X-Google-Smtp-Source: ABdhPJwwspjmnn2UgF3wC80ffKADbfFGgTEqNvflKbpG+cgCWjua1idvpQ2j9r374S0fE1PxL0yFKA== X-Received: by 2002:a1c:29c7:: with SMTP id p190mr6271697wmp.65.1634224191871; Thu, 14 Oct 2021 08:09:51 -0700 (PDT) Received: from [192.168.3.132] (p5b0c694e.dip0.t-ipconnect.de. [91.12.105.78]) by smtp.gmail.com with ESMTPSA id p25sm7981463wma.2.2021.10.14.08.09.51 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 14 Oct 2021 08:09:51 -0700 (PDT) Message-ID: Date: Thu, 14 Oct 2021 17:09:50 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.1.0 Subject: Re: [PATCH 5/5] brd: Kill usage of page->index To: Kent Overstreet , linux-kernel@vger.kernel.org, linux-mm@kvack.org, akpm@linux-foundation.org, linux-raid@vger.kernel.org, linux-block@vger.kernel.org, axboe@kernel.dk Cc: alexander.h.duyck@linux.intel.com References: <20211013160034.3472923-1-kent.overstreet@gmail.com> <20211013160034.3472923-6-kent.overstreet@gmail.com> From: David Hildenbrand Organization: Red Hat In-Reply-To: <20211013160034.3472923-6-kent.overstreet@gmail.com> X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Rspamd-Queue-Id: 293843000107 X-Stat-Signature: yqc4cnf5iqew4uad1qpcy81enn3iaihf Authentication-Results: imf09.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=eWI2+ntE; dmarc=pass (policy=none) header.from=redhat.com; spf=none (imf09.hostedemail.com: domain of david@redhat.com has no SPF policy when checking 170.10.133.124) smtp.mailfrom=david@redhat.com X-Rspamd-Server: rspam02 X-HE-Tag: 1634224194-779557 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 13.10.21 18:00, Kent Overstreet wrote: > As part of the struct page cleanups underway, we want to remove as much > usage of page->mapping and page->index as possible, as frequently they > are known from context. > > In the brd code, we're never actually reading from page->index except in > assertions, so references to it can be safely deleted. > > Signed-off-by: Kent Overstreet > --- > drivers/block/brd.c | 4 ---- > 1 file changed, 4 deletions(-) > > diff --git a/drivers/block/brd.c b/drivers/block/brd.c > index 58ec167aa0..0a55aed832 100644 > --- a/drivers/block/brd.c > +++ b/drivers/block/brd.c > @@ -72,8 +72,6 @@ static struct page *brd_lookup_page(struct brd_device *brd, sector_t sector) > page = radix_tree_lookup(&brd->brd_pages, idx); > rcu_read_unlock(); > > - BUG_ON(page && page->index != idx); > - > return page; > } > > @@ -108,12 +106,10 @@ static struct page *brd_insert_page(struct brd_device *brd, sector_t sector) > > spin_lock(&brd->brd_lock); > idx = sector >> PAGE_SECTORS_SHIFT; > - page->index = idx; > if (radix_tree_insert(&brd->brd_pages, idx, page)) { > __free_page(page); > page = radix_tree_lookup(&brd->brd_pages, idx); > BUG_ON(!page); > - BUG_ON(page->index != idx); > } else { > brd->brd_nr_pages++; > } > Reviewed-by: David Hildenbrand -- Thanks, David / dhildenb