From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 99C07C38142 for ; Wed, 25 Jan 2023 02:15:50 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 20DE46B0071; Tue, 24 Jan 2023 21:15:50 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 1BDC56B0073; Tue, 24 Jan 2023 21:15:50 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 05F146B0075; Tue, 24 Jan 2023 21:15:50 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id EAD1C6B0071 for ; Tue, 24 Jan 2023 21:15:49 -0500 (EST) Received: from smtpin13.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id B1B20AB2CC for ; Wed, 25 Jan 2023 02:15:49 +0000 (UTC) X-FDA: 80391705618.13.2A6CFF5 Received: from NAM04-DM6-obe.outbound.protection.outlook.com (mail-dm6nam04on2078.outbound.protection.outlook.com [40.107.102.78]) by imf12.hostedemail.com (Postfix) with ESMTP id B459A40005 for ; Wed, 25 Jan 2023 02:15:46 +0000 (UTC) Authentication-Results: imf12.hostedemail.com; dkim=pass header.d=Nvidia.com header.s=selector2 header.b=G4bIQhM8; spf=pass (imf12.hostedemail.com: domain of jhubbard@nvidia.com designates 40.107.102.78 as permitted sender) smtp.mailfrom=jhubbard@nvidia.com; arc=pass ("microsoft.com:s=arcselector9901:i=1"); dmarc=pass (policy=reject) header.from=nvidia.com ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1674612946; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=rl5Wk8y28kza6K/jSY8WPjG+z6+uf1LVB9w9F0IrrAs=; b=rfbxHj6otrtTv7d5FeYKfLhpsDlQqv3FjwNqR8cdnDyoUgdSeYzJ+oAx9TPWWWq+zPTnRI TSPMzJIzmUvNTfP6sb0blT7/ZintejamEf7qdDFD9I41nnzC+dBJqFMtWUJX+nw0zFnkll SBNWcBZYFT84YwSwyYyVKlDOjDlIftM= ARC-Authentication-Results: i=2; imf12.hostedemail.com; dkim=pass header.d=Nvidia.com header.s=selector2 header.b=G4bIQhM8; spf=pass (imf12.hostedemail.com: domain of jhubbard@nvidia.com designates 40.107.102.78 as permitted sender) smtp.mailfrom=jhubbard@nvidia.com; arc=pass ("microsoft.com:s=arcselector9901:i=1"); dmarc=pass (policy=reject) header.from=nvidia.com ARC-Seal: i=2; s=arc-20220608; d=hostedemail.com; t=1674612946; a=rsa-sha256; cv=pass; b=oa9jW627JS6obJWEeyIsWQqtHqrJ5AHFGv+9EStJApkuW8bx2F65X/Wr6BRkNRDH5loS1l XeWsu305+ukJhDe8fbJvD4yPw3o8WfXWavo5gRYymkuIzNIHaXLz2j9ztvCd0/IUe8BUIV jxjwtaeACdyZRiMLxl1BbSkCSh2OTus= ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=WSwqTsfjUNIIUulrFhL3JKJT8mmrGVKD6swOOe0U54c00QyBoTXDRDRZUy97SvWxcCktHAnVb3p92kWxoNysDkZXjCO0QGBXovCZTFqNgQrlFBNK2WWXbwSvd772ey0UmfbexpYNJjcgPfaZIFG3yqsHNeJQ54pje8l/Zf6KrmG98J+dhiMq2iOtTRw0JXdnWN8WXGYZmKKMZWDAFFZnjYkFBbJ7KKtxzWi7XZZPggBNxfvJka5vX3B/JkqpOIVYwKxDCanXLfZP0nVJuYsRLnJwxjkh08Vei5GEcNwuj/ZhKSd+rkyRIFjzOL9UY2+P9GzHdRoIgk+9/wEO3RTogg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=rl5Wk8y28kza6K/jSY8WPjG+z6+uf1LVB9w9F0IrrAs=; b=JD/o4RFyoApcNXe7kBTdgGhepeNgFjFyZq1wkbsE0Jw8KPwA5NkouEvYAuEiA/LcKeQz5cMweJ18cjjTrEehogjIG/qQ70Q7BmKIRl31IcAz7+SDwiCySRnjtxlA11EwMqZJDECdZGKGGS8TF1TZsGSgvL4twlW5A9e5tAKwd11AWyL7udMUa9RQtMr3qh1WI8+r2Luh6jqwCRB2+b9ycrA99yyACy91oYcaWZzXM0OHpUyxvwau7OmhKz3O6sa8b25YxJxvuxx4v2QptsD7Pa1o0iPD6P1AiGc6qyn14Y4MTs3D0cyZPj0fIFMabGcnUkWhUdyUFLC2hJcqIt6QHw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 216.228.117.160) smtp.rcpttodomain=redhat.com smtp.mailfrom=nvidia.com; dmarc=pass (p=reject sp=reject pct=100) action=none header.from=nvidia.com; dkim=none (message not signed); arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=rl5Wk8y28kza6K/jSY8WPjG+z6+uf1LVB9w9F0IrrAs=; b=G4bIQhM82kOAChexU8UX3bGtCI27yrPxHKuEZZYDzo4mAX/aZH6SWc2nfrZa6v2Wf2B9mvbYrIsO1SV5PV4OSO6eWUW+FXMVKO4meLqHaUnG9dcRtpA8heTqsBwnHi1g5Xeujf9S56ExJZQIfPul4KEbQRksOqkgNc9FGNA+v0Q6jcNB2+RltBSgwXfmcqlukCb/2bqe1MVr12pY+6P8G+zSy5lfYEFPTo7irzhtiv98YzJfKeZ78Ngi9ppt/gdQPF4oPFd6uKPC3izMUtl/mv2lRXtFICEdSo2GskgL81u+P3VQ8bEUO879Pl5hNZOY4C/bXE+JvHvONz/x8DhQkg== Received: from MW4P223CA0024.NAMP223.PROD.OUTLOOK.COM (2603:10b6:303:80::29) by IA1PR12MB8405.namprd12.prod.outlook.com (2603:10b6:208:3d8::10) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6002.33; Wed, 25 Jan 2023 02:15:44 +0000 Received: from CO1NAM11FT021.eop-nam11.prod.protection.outlook.com (2603:10b6:303:80:cafe::b2) by MW4P223CA0024.outlook.office365.com (2603:10b6:303:80::29) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6002.33 via Frontend Transport; Wed, 25 Jan 2023 02:15:44 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 216.228.117.160) smtp.mailfrom=nvidia.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=nvidia.com; Received-SPF: Pass (protection.outlook.com: domain of nvidia.com designates 216.228.117.160 as permitted sender) receiver=protection.outlook.com; client-ip=216.228.117.160; helo=mail.nvidia.com; pr=C Received: from mail.nvidia.com (216.228.117.160) by CO1NAM11FT021.mail.protection.outlook.com (10.13.175.51) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6043.17 via Frontend Transport; Wed, 25 Jan 2023 02:15:44 +0000 Received: from rnnvmail201.nvidia.com (10.129.68.8) by mail.nvidia.com (10.129.200.66) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.986.36; Tue, 24 Jan 2023 18:15:29 -0800 Received: from [10.110.48.28] (10.126.231.37) by rnnvmail201.nvidia.com (10.129.68.8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.986.36; Tue, 24 Jan 2023 18:15:28 -0800 Message-ID: Date: Tue, 24 Jan 2023 18:15:28 -0800 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.6.1 Subject: Re: [PATCH v2 04/13] mm/gup: move try_grab_page() to mm/internal.h Content-Language: en-US To: Jason Gunthorpe CC: Alistair Popple , David Hildenbrand , David Howells , Christoph Hellwig , , "Mike Rapoport (IBM)" References: <4-v2-987e91b59705+36b-gup_tidy_jgg@nvidia.com> From: John Hubbard In-Reply-To: <4-v2-987e91b59705+36b-gup_tidy_jgg@nvidia.com> Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: 7bit X-Originating-IP: [10.126.231.37] X-ClientProxiedBy: rnnvmail201.nvidia.com (10.129.68.8) To rnnvmail201.nvidia.com (10.129.68.8) X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: CO1NAM11FT021:EE_|IA1PR12MB8405:EE_ X-MS-Office365-Filtering-Correlation-Id: 7d860de4-f056-41e3-4f13-08dafe7a1091 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: myOKxNQPmZlgFynzn5pWmdWxPRUmNCbN5HgNV2ZcGjd1Q4Imh95lw28lXuvpu7En+mL19NQC2Q2ddOlhWAwExyIQSnvOnaTuvSSska2f1C9RseIlenoIpZlT7yFAcI8WZLEvYm4SozcWVNjvYTwtRb24pvVfTnF7Bx5c/zdJE4CEXuvkgSNNBRXQjhcBk+dwz+tzYjOV1sHSwgGU9M1zgO0+pxNCyis9yFM83WhMnvaCIwT4APA0D0z6LHW+Mqo7kHhJPF+GppQ1r0LJWW0GHhdLDTi7YzcnJd2fXs4AXsw6rT0peGr7WmbtbvbGTk9QEBJqx8a1LB8m9cpegTc7FXHpmpypEKPgjlednEY6MD9LD9OTbreFUtMmZSsx9r1KoEMLGBL4Yr/27fVZyB6cUbgZEBRGDi9Dx6GK1UrZb6ZN4N2tKMcp9sSqapFQJwITNgmyDM5S2Ibs2x+7okRk28RP6x2Uj4UU1BDKDRGpov2nckLWUYIgbeoqMOdU+TZC4CVQ1F7VWcjOj6Jz77kHWjMlE1TrccRrv+MLS8CYMXPm8RCiw9whAVKWD8qJTOMHS6n3XuuFdNYwhRoliKHLQwWcsUHd8QPFvBFUVVfoJJSzmZEmOsUne7pHEKuPRDQIqJanCxnObZ1aTbAHhFh1QzdQhGfVSQL0XbuvvXvMDxhHUcGV5s720ixjkDc2fDvo/gpY/TzBYlIo+X2dwdiF85IL6qtPksZ4W3hivNMrs/Q= X-Forefront-Antispam-Report: CIP:216.228.117.160;CTRY:US;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:mail.nvidia.com;PTR:dc6edge1.nvidia.com;CAT:NONE;SFS:(13230025)(4636009)(136003)(376002)(396003)(346002)(39860400002)(451199018)(36840700001)(46966006)(40470700004)(82310400005)(6636002)(82740400003)(6862004)(4326008)(86362001)(41300700001)(36756003)(2906002)(70206006)(40460700003)(70586007)(186003)(31686004)(8676002)(37006003)(26005)(40480700001)(47076005)(16526019)(426003)(54906003)(336012)(53546011)(16576012)(5660300002)(2616005)(7636003)(8936002)(83380400001)(356005)(478600001)(31696002)(316002)(36860700001)(43740500002);DIR:OUT;SFP:1101; X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 25 Jan 2023 02:15:44.2676 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 7d860de4-f056-41e3-4f13-08dafe7a1091 X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=43083d15-7273-40c1-b7db-39efd9ccc17a;Ip=[216.228.117.160];Helo=[mail.nvidia.com] X-MS-Exchange-CrossTenant-AuthSource: CO1NAM11FT021.eop-nam11.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: IA1PR12MB8405 X-Rspam-User: X-Rspamd-Server: rspam04 X-Rspamd-Queue-Id: B459A40005 X-Stat-Signature: dgqo8i95xhwfeb1jm3kewzmjosqxhdsq X-HE-Tag: 1674612946-542623 X-HE-Meta: U2FsdGVkX1+BhH3724jSY2N9S5Ae+mR4EPNL2JQuyWN6r5yqj+C7dY7cmxEDqwoWaGmShfsEQKtLHqHnH7ofsCYPAaeD05vBE3J0S51SRgz/kiluMOSmJyLcMO8IOa+ZGAxKoDEOUCYZVNbwdHtpN1ZMMnZEgJtfDY/x+1qXy75yhOhRme52fQDRm5vWJDBhZtmeVMW2BnsmtNLDQiDNgVl6eCSBV2bjqOf5MOwtii3xGRmY1/ftPLuZtmR3CDH3SdiSStux6uDEksUV408DNbkmaN8ZE7o8UJfdzIySyl4ov0QLt1V6kW1HMazdVJWlcFRxv486gBf0o4rcihAd64wLbv8wWSxbGpvlhcJLv2ws6vnuyXgDoX0V1Ys06f4QRCedn7Z6Pl6Q90P/1IfadkStNm7kb6MNSJeD6tYX14RN5/Q8Q0ax7J8efKQs4DZWQaAsQDR0lk2t0dnnIrOma4zR31JmpwglcBrlv/IYS3IGO2iEPD8ZfPPElA5qZTbhzGdytrq2V0e7FbJCmKsFYwH2rbgtT7g1y5jQtkT3IStPOxb3MP/cwtWmDtqQ3kOUe9Ym9FBT+/9Bv6xNR3UYzGUt69CYI0r1FsoI+5ZUvMFb0N1onEm7TgQQl0ecR+EbphVrb2uaZ1bqBCTkDnMdNqLcal/rQ+RVr2W3a3e4U5iuLTZK/XUX9aw8NHTU5pVknNGtloGwo9g5VphHdHsZjhOs8KtGe3y4OBBu0EhAQCMrY9Z+jzlTLucnl9g2zXmji2S1ed+GuXOEZr7mJaO6dYQHD0wgSRR5+rn2jrjwStH5zfv287ZOqyB3PdOKQEXPY6YB0pghvgt1EeS/le2G+kZsEPAyhYr/SWW+WU/4U9WR1mcGDcI6Yfr//8//XDSpwss2Osgm1wdbSTaodubUE35BFbU74l1U4jI+UIssbFzbcD4no4MED33xiobCAv24pTqZwzCoU+emWlURwk4 r/mwqmhx sfB0jyYKjzcsZM6z2ZRP9VmcThAJ3nRf6EOnXGlIO4zb7uqFo85mPqN+8PUQRLzvJ6v7+2mmWJv1Kb2oLg5Q4ypY/zP40VbhjCL3Mj1NPcMq2Zy76KLG1sAYTRu3dgPEonyr+toLA55G4Te3Sn+6AAtSjTL/pD7IpLz+CvOqqXyhvfEviiZ+BY9OTDgzCqMFjZCwD5GFHah7dJxmiqjlI40PGBsRQXDy73eEwqjii6LCNWnsohNBAT+JoUZJ4YmuTM1an3JwTiMsTwwR2CUmzaZVh1ya1FXxKcvoyE522yrP1bqClsTYijfKaQnq7RGRNqKNhT1Wp9rucBSOqY7yCZIKbPjofGy4SBrU48f6TBwusEv02fZcBOF7q1IRA61h/A+1Q/bzxedRK/1g= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 1/24/23 12:34, Jason Gunthorpe wrote: > This is part of the internal function of gup.c and is only non-static so > that the parts of gup.c in the huge_memory.c and hugetlb.c can call it. > > Put it in internal.h beside the similarly purposed try_grab_folio() > > Signed-off-by: Jason Gunthorpe > --- > include/linux/mm.h | 2 -- > mm/internal.h | 1 + > 2 files changed, 1 insertion(+), 2 deletions(-) Reviewed-by: John Hubbard thanks, -- John Hubbard NVIDIA > > diff --git a/include/linux/mm.h b/include/linux/mm.h > index c9db257f09b307..dfc2a88bc4a8ed 100644 > --- a/include/linux/mm.h > +++ b/include/linux/mm.h > @@ -1173,8 +1173,6 @@ static inline void get_page(struct page *page) > folio_get(page_folio(page)); > } > > -int __must_check try_grab_page(struct page *page, unsigned int flags); > - > static inline __must_check bool try_get_page(struct page *page) > { > page = compound_head(page); > diff --git a/mm/internal.h b/mm/internal.h > index ce462bf145b441..0f035bcaf133f5 100644 > --- a/mm/internal.h > +++ b/mm/internal.h > @@ -852,6 +852,7 @@ int migrate_device_coherent_page(struct page *page); > * mm/gup.c > */ > struct folio *try_grab_folio(struct page *page, int refs, unsigned int flags); > +int __must_check try_grab_page(struct page *page, unsigned int flags); > > extern bool mirrored_kernelcore; >