From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-18.0 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_CR_TRAILER,INCLUDES_PATCH,MAILING_LIST_MULTI,NICE_REPLY_A, SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 97264C433B4 for ; Fri, 14 May 2021 14:02:46 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 3FC4961463 for ; Fri, 14 May 2021 14:02:46 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 3FC4961463 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id AAA7B6B006E; Fri, 14 May 2021 10:02:45 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id A80146B0070; Fri, 14 May 2021 10:02:45 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 947CB6B0071; Fri, 14 May 2021 10:02:45 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0206.hostedemail.com [216.40.44.206]) by kanga.kvack.org (Postfix) with ESMTP id 6270E6B006E for ; Fri, 14 May 2021 10:02:45 -0400 (EDT) Received: from smtpin23.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay04.hostedemail.com (Postfix) with ESMTP id F1ACA98A5 for ; Fri, 14 May 2021 14:02:44 +0000 (UTC) X-FDA: 78140002248.23.0B5FF0D Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by imf30.hostedemail.com (Postfix) with ESMTP id 10DD0E0011F1 for ; Fri, 14 May 2021 14:02:41 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1621000963; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=Mql0q91ECxfqC6RVy/aAHYne20fUi8i8dudlG8TCa1w=; b=CFD0utF5PFkFzrQTYMhe4lS6JWxh6gqGLdvLzlLR357bXytiuRMaHESSyQvlyptJ+lDXAb aHczIC/N2qHeKyEPya93JMV/JeLKF8lU6Dj4abZqXnT4SD3BeRHrCDYNxT2Gs2pp5EjKaU we6bgSkm+ix+mTfMR3AqERi4WTt0XCs= Received: from mail-ed1-f71.google.com (mail-ed1-f71.google.com [209.85.208.71]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-546-LJRpccGUNUCgu6FRM_Pn8A-1; Fri, 14 May 2021 10:02:40 -0400 X-MC-Unique: LJRpccGUNUCgu6FRM_Pn8A-1 Received: by mail-ed1-f71.google.com with SMTP id n6-20020a0564020606b029038cdc241890so2922437edv.20 for ; Fri, 14 May 2021 07:02:39 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:organization :message-id:date:user-agent:mime-version:in-reply-to :content-language:content-transfer-encoding; bh=Mql0q91ECxfqC6RVy/aAHYne20fUi8i8dudlG8TCa1w=; b=ExuKwF6AgumKhZZXrqC/6TqKekjqLkFnioxZklCXsXpA2WL7AOEt7azv9Knwfz6mue btEePjWJJ6NSUCsUKlH3X35rQuxe390s2rm7iBi36jjgxo5DAGwsZoEiLxc9u95CAaXm +521W24hZK8nn0LTnsgZCP5Q28w6wVqjbztxGKcV7lHPA9aav9fAJJF1utQsGcXQjSrP 1xHYx4TQZXtjSrWY1ZLQITEZtMk5MRgyBwrMxG2T77VqSgAMqpvSX6KzQgy4bLaKkhnb tr6s9N+GPLLMk4T/1uIP0i3qFJuI54iAOmIt4S+EXOe4t6HUXJsh84qSM2rsSX+t1Ytx xHSA== X-Gm-Message-State: AOAM531/5iKWoYl+zm9WosN5eUB9JDgyKIuFx76omeT29Uw1DWenjsy6 olMpP/w3BcgJej6uSr2iMH2uhzv516MLPORRxlFP9sW3Rlu3/9doTzhi1w5BmwSyIjU8JBPGvnY NK4x1tzAsGq4= X-Received: by 2002:a05:6402:17d9:: with SMTP id s25mr24831505edy.337.1621000959033; Fri, 14 May 2021 07:02:39 -0700 (PDT) X-Google-Smtp-Source: ABdhPJycqL708KNoHKpLFYbO+zZJI/n5h5okb1IMaDhgZfYIUL7lAvWQGfraW3B17JyJgzWq/5E1yA== X-Received: by 2002:a05:6402:17d9:: with SMTP id s25mr24831467edy.337.1621000958793; Fri, 14 May 2021 07:02:38 -0700 (PDT) Received: from [192.168.3.132] (p5b0c6501.dip0.t-ipconnect.de. [91.12.101.1]) by smtp.gmail.com with ESMTPSA id c5sm4547748eds.94.2021.05.14.07.02.38 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 14 May 2021 07:02:38 -0700 (PDT) Subject: Re: [PATCH] mm/shuffle: fix section mismatch warning To: Arnd Bergmann , Andrew Morton , Nathan Chancellor , Nick Desaulniers Cc: Arnd Bergmann , Wei Yang , Dan Williams , linux-mm@kvack.org, linux-kernel@vger.kernel.org, clang-built-linux@googlegroups.com References: <20210514135952.2928094-1-arnd@kernel.org> From: David Hildenbrand Organization: Red Hat Message-ID: Date: Fri, 14 May 2021 16:02:37 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.8.1 MIME-Version: 1.0 In-Reply-To: <20210514135952.2928094-1-arnd@kernel.org> X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-Rspamd-Queue-Id: 10DD0E0011F1 Authentication-Results: imf30.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=CFD0utF5; dmarc=pass (policy=none) header.from=redhat.com; spf=none (imf30.hostedemail.com: domain of david@redhat.com has no SPF policy when checking 170.10.133.124) smtp.mailfrom=david@redhat.com X-Rspamd-Server: rspam03 X-Stat-Signature: 4yiji47e7wcztn89xnebneg6xq7edk6j X-HE-Tag: 1621000961-540109 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 14.05.21 15:59, Arnd Bergmann wrote: > From: Arnd Bergmann > > clang sometimes decides not to inline shuffle_zone(), but it calls > a __meminit function. Without the extra __meminit annotation we get > this warning: > > WARNING: modpost: vmlinux.o(.text+0x2a86d4): Section mismatch in reference from the function shuffle_zone() to the function .meminit.text:__shuffle_zone() > The function shuffle_zone() references > the function __meminit __shuffle_zone(). > This is often because shuffle_zone lacks a __meminit > annotation or the annotation of __shuffle_zone is wrong. > > shuffle_free_memory() did not show the same problem in my tests, but > it could happen in theory as well, so mark both as __meminit. > > Signed-off-by: Arnd Bergmann > --- > mm/shuffle.h | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/mm/shuffle.h b/mm/shuffle.h > index 71b784f0b7c3..cec62984f7d3 100644 > --- a/mm/shuffle.h > +++ b/mm/shuffle.h > @@ -10,7 +10,7 @@ > DECLARE_STATIC_KEY_FALSE(page_alloc_shuffle_key); > extern void __shuffle_free_memory(pg_data_t *pgdat); > extern bool shuffle_pick_tail(void); > -static inline void shuffle_free_memory(pg_data_t *pgdat) > +static inline void __meminit shuffle_free_memory(pg_data_t *pgdat) > { > if (!static_branch_unlikely(&page_alloc_shuffle_key)) > return; > @@ -18,7 +18,7 @@ static inline void shuffle_free_memory(pg_data_t *pgdat) > } > > extern void __shuffle_zone(struct zone *z); > -static inline void shuffle_zone(struct zone *z) > +static inline void __meminit shuffle_zone(struct zone *z) > { > if (!static_branch_unlikely(&page_alloc_shuffle_key)) > return; > Reviewed-by: David Hildenbrand -- Thanks, David / dhildenb