From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id BB4A4C02198 for ; Wed, 12 Feb 2025 15:12:49 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 3E1D66B0085; Wed, 12 Feb 2025 10:12:49 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 3916C6B0088; Wed, 12 Feb 2025 10:12:49 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 232A66B0089; Wed, 12 Feb 2025 10:12:49 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id 0303C6B0085 for ; Wed, 12 Feb 2025 10:12:48 -0500 (EST) Received: from smtpin22.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id 4B23FB34A8 for ; Wed, 12 Feb 2025 15:12:48 +0000 (UTC) X-FDA: 83111634816.22.B171591 Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.223.131]) by imf05.hostedemail.com (Postfix) with ESMTP id AD491100005 for ; Wed, 12 Feb 2025 15:12:45 +0000 (UTC) Authentication-Results: imf05.hostedemail.com; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=NUf4jfeV; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=gORug0Bn; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=KwnHRs8z; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=FwkFeDEs; spf=pass (imf05.hostedemail.com: domain of vbabka@suse.cz designates 195.135.223.131 as permitted sender) smtp.mailfrom=vbabka@suse.cz; dmarc=none ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1739373166; a=rsa-sha256; cv=none; b=Z/+45Mv+tgXvxYOp2dmy1Ld5Mo6WR+2/wFKjiHNLzwVVaVSZ6zpnXyvY8NlZoTalt8hq5X 2HIcSV68wZjOkSmG+yqlbWhcuGwI7f/nFhF6NHNE/xHDgShI/D831rS1BdrzbJ2uXDmUVy smnjsk4ZyO2B0XYfDC5T96ytSFuyxjw= ARC-Authentication-Results: i=1; imf05.hostedemail.com; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=NUf4jfeV; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=gORug0Bn; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=KwnHRs8z; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=FwkFeDEs; spf=pass (imf05.hostedemail.com: domain of vbabka@suse.cz designates 195.135.223.131 as permitted sender) smtp.mailfrom=vbabka@suse.cz; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1739373166; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=KaBr7AUYFXyg5gP7lASMau8rIKyqar+e3APe/nWwAX0=; b=jpTxDG2ea7iIBegZwYf1lTE4KZSQD+KnI9EG8EV5SuG7q6AZW3LTdInB1LlpDxcxQb/4TI ztFvlmyHutERXZLTPJZaZxJf/90jK2JefvNewyPxtV5zDjBzNpD3u4kWlvJ+AutItopyzz oEsy5ACmFQf8758+9OjLEJEES3FUTvQ= Received: from imap1.dmz-prg2.suse.org (imap1.dmz-prg2.suse.org [IPv6:2a07:de40:b281:104:10:150:64:97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id EDE321FB41; Wed, 12 Feb 2025 15:12:43 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_rsa; t=1739373164; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=KaBr7AUYFXyg5gP7lASMau8rIKyqar+e3APe/nWwAX0=; b=NUf4jfeVO3E+2ctI6PhrJ1uJj9Jt9JEy/+VBt08aMhD1uO/0JmNOlte3l/q0Z36fwqHyqF 7I9lK1v8PmnzIvu4sWzI8HJDa1kgr1IyxbJj1cCxxkUVEmhp2tF8CO1+7ffe+9n0sczPoQ 3BP43aYEHwCvLeO/UCondd4htBxFzlc= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_ed25519; t=1739373164; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=KaBr7AUYFXyg5gP7lASMau8rIKyqar+e3APe/nWwAX0=; b=gORug0BnU+b9unsDYLQTEfWHRZq8Lsd/Jt72vLbhaK2PJ2cw180iNGw6NjXIWpQ53Syku+ 5eZvGj5dX3NSCqBA== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_rsa; t=1739373163; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=KaBr7AUYFXyg5gP7lASMau8rIKyqar+e3APe/nWwAX0=; b=KwnHRs8zxD3PSzbP464uf787fnulHT/AKSW2bm1+FEnUOe4u9OjmH6WvPDAMg7V3pcw07g yVwQgP+2NUP9W7rM1nESYxWLow73EhLW3H7bD2cKUCw0X9KbJOsZHFoAtdcDX5+SgBZ4Se pUkiQeoch0Jl2uIlKj/75NEpmLunQdc= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_ed25519; t=1739373163; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=KaBr7AUYFXyg5gP7lASMau8rIKyqar+e3APe/nWwAX0=; b=FwkFeDEsQo/y9C1ZtVaReRiO4GIgOnbP8quomN4CIYdYaet4ZM6aQsl3drKANfSO82uMUb No2yf3gQggdzpPDw== Received: from imap1.dmz-prg2.suse.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by imap1.dmz-prg2.suse.org (Postfix) with ESMTPS id C7F0913AEF; Wed, 12 Feb 2025 15:12:43 +0000 (UTC) Received: from dovecot-director2.suse.de ([2a07:de40:b281:106:10:150:64:167]) by imap1.dmz-prg2.suse.org with ESMTPSA id /Fd8MGu6rGcZQgAAD6G6ig (envelope-from ); Wed, 12 Feb 2025 15:12:43 +0000 Message-ID: Date: Wed, 12 Feb 2025 16:12:43 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v3 0/2] Refine kmalloc caches randomization in kvmalloc Content-Language: en-US To: GONG Ruiqi , Christoph Lameter , Pekka Enberg , David Rientjes , Joonsoo Kim , Andrew Morton , Kees Cook Cc: Tamas Koczka , Roman Gushchin , Hyeonggon Yoo <42.hyeyoo@gmail.com>, Xiu Jianfeng , linux-mm@kvack.org, linux-hardening@vger.kernel.org, linux-kernel@vger.kernel.org References: <20250212081505.2025320-1-gongruiqi1@huawei.com> From: Vlastimil Babka Autocrypt: addr=vbabka@suse.cz; keydata= xsFNBFZdmxYBEADsw/SiUSjB0dM+vSh95UkgcHjzEVBlby/Fg+g42O7LAEkCYXi/vvq31JTB KxRWDHX0R2tgpFDXHnzZcQywawu8eSq0LxzxFNYMvtB7sV1pxYwej2qx9B75qW2plBs+7+YB 87tMFA+u+L4Z5xAzIimfLD5EKC56kJ1CsXlM8S/LHcmdD9Ctkn3trYDNnat0eoAcfPIP2OZ+ 9oe9IF/R28zmh0ifLXyJQQz5ofdj4bPf8ecEW0rhcqHfTD8k4yK0xxt3xW+6Exqp9n9bydiy tcSAw/TahjW6yrA+6JhSBv1v2tIm+itQc073zjSX8OFL51qQVzRFr7H2UQG33lw2QrvHRXqD Ot7ViKam7v0Ho9wEWiQOOZlHItOOXFphWb2yq3nzrKe45oWoSgkxKb97MVsQ+q2SYjJRBBH4 8qKhphADYxkIP6yut/eaj9ImvRUZZRi0DTc8xfnvHGTjKbJzC2xpFcY0DQbZzuwsIZ8OPJCc LM4S7mT25NE5kUTG/TKQCk922vRdGVMoLA7dIQrgXnRXtyT61sg8PG4wcfOnuWf8577aXP1x 6mzw3/jh3F+oSBHb/GcLC7mvWreJifUL2gEdssGfXhGWBo6zLS3qhgtwjay0Jl+kza1lo+Cv BB2T79D4WGdDuVa4eOrQ02TxqGN7G0Biz5ZLRSFzQSQwLn8fbwARAQABzSBWbGFzdGltaWwg QmFia2EgPHZiYWJrYUBzdXNlLmN6PsLBlAQTAQoAPgIbAwULCQgHAwUVCgkICwUWAgMBAAIe AQIXgBYhBKlA1DSZLC6OmRA9UCJPp+fMgqZkBQJkBREIBQkRadznAAoJECJPp+fMgqZkNxIQ ALZRqwdUGzqL2aeSavbum/VF/+td+nZfuH0xeWiO2w8mG0+nPd5j9ujYeHcUP1edE7uQrjOC Gs9sm8+W1xYnbClMJTsXiAV88D2btFUdU1mCXURAL9wWZ8Jsmz5ZH2V6AUszvNezsS/VIT87 AmTtj31TLDGwdxaZTSYLwAOOOtyqafOEq+gJB30RxTRE3h3G1zpO7OM9K6ysLdAlwAGYWgJJ V4JqGsQ/lyEtxxFpUCjb5Pztp7cQxhlkil0oBYHkudiG8j1U3DG8iC6rnB4yJaLphKx57NuQ PIY0Bccg+r9gIQ4XeSK2PQhdXdy3UWBr913ZQ9AI2usid3s5vabo4iBvpJNFLgUmxFnr73SJ KsRh/2OBsg1XXF/wRQGBO9vRuJUAbnaIVcmGOUogdBVS9Sun/Sy4GNA++KtFZK95U7J417/J Hub2xV6Ehc7UGW6fIvIQmzJ3zaTEfuriU1P8ayfddrAgZb25JnOW7L1zdYL8rXiezOyYZ8Fm ZyXjzWdO0RpxcUEp6GsJr11Bc4F3aae9OZtwtLL/jxc7y6pUugB00PodgnQ6CMcfR/HjXlae h2VS3zl9+tQWHu6s1R58t5BuMS2FNA58wU/IazImc/ZQA+slDBfhRDGYlExjg19UXWe/gMcl De3P1kxYPgZdGE2eZpRLIbt+rYnqQKy8UxlszsBNBFsZNTUBCACfQfpSsWJZyi+SHoRdVyX5 J6rI7okc4+b571a7RXD5UhS9dlVRVVAtrU9ANSLqPTQKGVxHrqD39XSw8hxK61pw8p90pg4G /N3iuWEvyt+t0SxDDkClnGsDyRhlUyEWYFEoBrrCizbmahOUwqkJbNMfzj5Y7n7OIJOxNRkB IBOjPdF26dMP69BwePQao1M8Acrrex9sAHYjQGyVmReRjVEtv9iG4DoTsnIR3amKVk6si4Ea X/mrapJqSCcBUVYUFH8M7bsm4CSxier5ofy8jTEa/CfvkqpKThTMCQPNZKY7hke5qEq1CBk2 wxhX48ZrJEFf1v3NuV3OimgsF2odzieNABEBAAHCwXwEGAEKACYCGwwWIQSpQNQ0mSwujpkQ PVAiT6fnzIKmZAUCZAUSmwUJDK5EZgAKCRAiT6fnzIKmZOJGEACOKABgo9wJXsbWhGWYO7mD 8R8mUyJHqbvaz+yTLnvRwfe/VwafFfDMx5GYVYzMY9TWpA8psFTKTUIIQmx2scYsRBUwm5VI EurRWKqENcDRjyo+ol59j0FViYysjQQeobXBDDE31t5SBg++veI6tXfpco/UiKEsDswL1WAr tEAZaruo7254TyH+gydURl2wJuzo/aZ7Y7PpqaODbYv727Dvm5eX64HCyyAH0s6sOCyGF5/p eIhrOn24oBf67KtdAN3H9JoFNUVTYJc1VJU3R1JtVdgwEdr+NEciEfYl0O19VpLE/PZxP4wX PWnhf5WjdoNI1Xec+RcJ5p/pSel0jnvBX8L2cmniYnmI883NhtGZsEWj++wyKiS4NranDFlA HdDM3b4lUth1pTtABKQ1YuTvehj7EfoWD3bv9kuGZGPrAeFNiHPdOT7DaXKeHpW9homgtBxj 8aX/UkSvEGJKUEbFL9cVa5tzyialGkSiZJNkWgeHe+jEcfRT6pJZOJidSCdzvJpbdJmm+eED w9XOLH1IIWh7RURU7G1iOfEfmImFeC3cbbS73LQEFGe1urxvIH5K/7vX+FkNcr9ujwWuPE9b 1C2o4i/yZPLXIVy387EjA6GZMqvQUFuSTs/GeBcv0NjIQi8867H3uLjz+mQy63fAitsDwLmR EP+ylKVEKb0Q2A== In-Reply-To: <20250212081505.2025320-1-gongruiqi1@huawei.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Rspamd-Action: no action X-Stat-Signature: kx3yes56n3ixk5ebzqjea7xkpjkeidwt X-Rspamd-Server: rspam06 X-Rspamd-Queue-Id: AD491100005 X-Rspam-User: X-HE-Tag: 1739373165-297638 X-HE-Meta: U2FsdGVkX18mkyTeyeJiqjtXgQHbiDgLIhL5KVEtZU6aM9Vr3CCo7sC2kfv85n8Z+eZs4LhoTMrH+iEYRws9s+wpuY7xQS770nwJqqE1IaEMB9gNqcYWbBVqxo2yD0BTNgrhuds24zGvyrwMHCl76iK5OXWwf3FPOxgs/4fQZK1B9GyeFRHBvufxS+5XlmowzQ5rEQLLUaRPRDKeU8otFHz6Y3BeuIepqUztvxz2yGd2nmaVjVG0SAXZsW5Quwduiix8E4tdEmRaMjkJ4Vu0UGdCWWSDP60+qeL+cEXv90cuctBfoYc2zf2+EpDYPhBmSx5YMKkHszAxPZIDrv6fc9WEbuMolBzh9mnmZ/2hnT8dfRGyrkxQDgq2SEy1t7UmcamoFOV6gM9SP2+x+hsTpfRfXekZRwXoCA7PR9hftcvfv6D8bUMbUrHOlmFHzcMp1qx+vh67npl0GCjtV0vbGb7iV7gWfIWj5sIXShG3zEBSWsXZ+XsK8xwjprgSphu7R0NvjtmH0t1vFNe6ZVce5uoUWaDpPx0aQYDcZdbn6KtPh8ISOklrIJk580kOziAni44B/fUcDfmLhM61HECMKbqmPg6WvVCoyqXVwICXQvsoZNVWrhVotglZPuyf348fxJAd0QMHVZL+ZgNAGE2ju5RskYNdRTkBaq6fNSNc3f+4vTjRC9eeKdyXEtBoV4FihnZ9EQHa6S249cvoe10Rb51Ig7TtPptlP9WAECWM3CEyMD9weKSS/wqf9Bb+2K101O6Qim/81c7tlP82N66O+hhVPkZ8ijxvxpblxOp1TY8ao4olzM82ZOobvvMThzm0yeClDU5Cad34mCowP8G1MOKEfoYzE3FhH2oy+fFmyEIGCkqIdnTVLoNdrcrQI3H4giz1rcjZNic0q6DkhlHsRxjwUjalFqOcGhTRSjpEQ4JxYU6wHwRFTZwJV6LkOFs+xmE/JNkqlYAf8Kl4Pil J0or1p+z ODgFp5j8NNAGguIS8tQHQTPd1uz+pusMuOIEIdJG1N9jM4NVd2JxJRB5+pfkJFmltR0yMmaZ2FaWsv5zxOgGqukhhmIqN0IHCf+gSI5jGW3lE4sA51MUGHPIZzUk6VV0sVuaGZPQQA7XuiMZXV2UQLqfTc9pvg+05MQNdCwnOnCJtFCQWlsOaGClo21TDMCZxKyEqgCa2KLvlqVfKQErsSsCyfwGldVZx3nanzFYBkwqgcy2Sw/4E7XLaVRoSX5eqTpCWKg50yAq3qkGFunZJXTbvC/u5maUWah2t78VbMEMquRcfOa+a4ADbFa56yjgaE4pkEL08cEfSyKQNzjquaj/AU+LOeKpeg29m4AbGPwbZ0XKvIAWe8Z04xtNrDDHYmWo38PgVHfAw9glOUIh6o12zjOzomhhUbuXbNKmdhO9j2kP/LcmAYkKrn6RH4D3oNy1/Sf5D4+xCPMw= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 2/12/25 09:15, GONG Ruiqi wrote: > Hi, > > v3: > - move all the way from kmalloc_gfp_adjust to kvrealloc_noprof into > mm/slub.c > - some rewording for commit logs > v2: https://lore.kernel.org/all/20250208014723.1514049-1-gongruiqi1@huawei.com/ > - change the implementation as Vlastimil suggested > v1: https://lore.kernel.org/all/20250122074817.991060-1-gongruiqi1@huawei.com/ > > Tamás reported [1] that kmalloc cache randomization doesn't actually > work for those kmalloc invoked via kvmalloc. For more details, see the > commit log of patch 2. > > The current solution requires a direct call from __kvmalloc_node_noprof > to __do_kmalloc_node, a static function in a different .c file. As > suggested by Vlastimil [2], it's achieved by simply moving > __kvmalloc_node_noprof from mm/util.c to mm/slub.c, together with some > other functions of the same family. > > Link: https://github.com/google/security-research/blob/908d59b573960dc0b90adda6f16f7017aca08609/pocs/linux/kernelctf/CVE-2024-27397_mitigation/docs/exploit.md?plain=1#L259 [1] > Link: https://lore.kernel.org/all/62044279-0c56-4185-97f7-7afac65ff449@suse.cz/ [2] > > GONG Ruiqi (2): > slab: Adjust placement of __kvmalloc_node_noprof > slab: Achieve better kmalloc caches randomization in kvmalloc Applied to slab/for-next, thanks! > > mm/slub.c | 162 ++++++++++++++++++++++++++++++++++++++++++++++++++++++ > mm/util.c | 162 ------------------------------------------------------ > 2 files changed, 162 insertions(+), 162 deletions(-) >