From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3EB53C3DA59 for ; Mon, 15 Jul 2024 10:41:11 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id C7D366B00A0; Mon, 15 Jul 2024 06:41:10 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id C2DE36B00A2; Mon, 15 Jul 2024 06:41:10 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id AF5386B00A4; Mon, 15 Jul 2024 06:41:10 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id 8FFE36B00A0 for ; Mon, 15 Jul 2024 06:41:10 -0400 (EDT) Received: from smtpin09.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay04.hostedemail.com (Postfix) with ESMTP id 2B23D1A15B6 for ; Mon, 15 Jul 2024 10:41:10 +0000 (UTC) X-FDA: 82341644700.09.E5BDC25 Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by imf03.hostedemail.com (Postfix) with ESMTP id 2D0A020009 for ; Mon, 15 Jul 2024 10:41:07 +0000 (UTC) Authentication-Results: imf03.hostedemail.com; dkim=none; spf=pass (imf03.hostedemail.com: domain of ryan.roberts@arm.com designates 217.140.110.172 as permitted sender) smtp.mailfrom=ryan.roberts@arm.com; dmarc=pass (policy=none) header.from=arm.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1721040030; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=pGw2gwANqbfDl1WFbA/N5CEy95sKTCOrUTrhD84EtyM=; b=hUSChUaqlC9F17oq1cqWVAla6nsxCEwox7uJ5YglJhtWWu03q0aMPQqFzyJiVhc8kApmVn qego/Kp3Vh14s7ikq6Jijyc21/iN2OlsrqiUdbI+XXNZD6iX+PViecf+ae2euWfMas+7tj avrIlJfEMOADKJhEpleF2Y5z4jHOpuk= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1721040030; a=rsa-sha256; cv=none; b=LB8fA0kPVPE0YtV3kMjeX4+Jm9+Zc+2vXLHhlOfi9Nqks/BARBhvEsv05AXCgYMAce6GI4 kwXUSXN4kOq2VVcmywx72WzYOhsKyeUpWmXB/c3yC1G1PXP2Qj68Cv5fAMjs3EmD7jH9/U jZ5M/rVaiydAOXnIV1cOwjCKq1FWmSo= ARC-Authentication-Results: i=1; imf03.hostedemail.com; dkim=none; spf=pass (imf03.hostedemail.com: domain of ryan.roberts@arm.com designates 217.140.110.172 as permitted sender) smtp.mailfrom=ryan.roberts@arm.com; dmarc=pass (policy=none) header.from=arm.com Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 78E89DA7; Mon, 15 Jul 2024 03:41:32 -0700 (PDT) Received: from [10.57.75.89] (unknown [10.57.75.89]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 72ED03F766; Mon, 15 Jul 2024 03:41:05 -0700 (PDT) Message-ID: Date: Mon, 15 Jul 2024 11:41:03 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2] mm/huge_memory: Avoid PMD-size page cache if needed Content-Language: en-GB To: Gavin Shan , linux-mm@kvack.org Cc: linux-kernel@vger.kernel.org, akpm@linux-foundation.org, david@redhat.com, willy@infradead.org, baohua@kernel.org, peterx@redhat.com, ziy@nvidia.com, william.kucharski@oracle.com, baolin.wang@linux.alibaba.com, ddutile@redhat.com, shan.gavin@gmail.com References: <20240715000423.316491-1-gshan@redhat.com> From: Ryan Roberts In-Reply-To: <20240715000423.316491-1-gshan@redhat.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Stat-Signature: 48kncedu6hiz9d8i6sqpenjr3zz95p5c X-Rspamd-Queue-Id: 2D0A020009 X-Rspam-User: X-Rspamd-Server: rspam08 X-HE-Tag: 1721040067-18831 X-HE-Meta: U2FsdGVkX18YfIJALXeprSP3WgnKdJpaY6ez8qUfFVIQ/W0b6+nmPpNUthjGERFOIoVN8LArzYElVoEw62/S0sqLVvf7UslHK/sK0mu2BMVno9wzbNV/u/8aAUmAk3dCkeP4Zej6INxfz+lcjn7dvHW8ZrkBhHxtQ1SON7Sm/obQRXV6EBtkZF0hYyDEgWRkWMBqSeHy0WxhDgbE205wv2f0Qzr/F9zUnRpcUuFiNKwEkYXR3HGV36d0Uu1iNsWj8AaTJ8iPNotyifr81qQfbQI7G0Zrx+QKQU1U9dq8KdCDATYIp4qFovOFmYxr1kXblxiIBrq1950dtvfpz/ep+gBl2w7gNewawpKoDfY9lhTrjWFYyWLMkqVKpi8aX92+cYJwQd9i2qk2NKQzontKGUxn5RdZeMob7iJEyluyKFbCWnHmkW+nkQ1ZCYaWsibDiOm5xOl800JeTRAWZ41Kte0b+luoVffIl0eZdOuUy37etbC7c8S6wyoUuCm/DnkJDBjD8fcoKADiFzw1ep8xRSdF/CWkVAVPFK3QJ8fVeIp5SEn99pdZ+WUjWlABd7bXmcjAJ2YniC7kGcpu3xH5d2Ag3YrGk6EMjVQZ7GBMHQPI87+sYtH8s7NZyzsHJP496aBdpLGDyPPUofGpM72j1LFLAc+nAm0+VqbaoLtYpm4afjKbqc8O37ZRLvEFZCHsf3464m9wG/+TVdDs5HWqQLaRcH/U9/b9co/TA+76owpw3HgMEBLSn1BcnPL85FD0sEAW+ATAteSSGKJAhTbYnkhw/qEXz4/H3ObMm0uQUPEI9WBokLjzRlaE+Xyv0O3pSa/1nsHU6DuggAd3qgkkrx869JSRy8zrWKBRQTQE/GQdJiBSFneMW+4HTuXOCPwamsB+9My3d4cAjYXRe/Uu0o7Zag8NfJetlp1rmePIM5mAh9C3lAlmhsebBDdtHe/pfQNr9r9TMoGWVVWU98v q3FjVgwr rnBzoo3MCjLA1E+3QIC9V1Me5uPT1pCf4pdiauIw8B00JGXVznGwnUFx/VfEeT3TiQoFa2TbBKJE7zpItyM8HPfu+TY4l5gUgcdDOquwHCnTo3u0iFK+ej1/8Y/kJIxk2f3hC1QMe3slu24DRelou4QbR9HQZxZtp1UOrfWu0uN3YTrTd7pOt+Wk6n2OKNRzqfdKfDlDF440wa4FIZe9ZTtyskRvKT1Qtwd57PfdkHaOHIK/0f3nd9h9KD+1SX6WdZPHP8x1wY6EA5tQ= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: [...] > diff --git a/include/linux/huge_mm.h b/include/linux/huge_mm.h > index 2aa986a5cd1b..c73ad77fa33d 100644 > --- a/include/linux/huge_mm.h > +++ b/include/linux/huge_mm.h > @@ -72,14 +72,20 @@ extern struct kobj_attribute shmem_enabled_attr; > #define THP_ORDERS_ALL_ANON ((BIT(PMD_ORDER + 1) - 1) & ~(BIT(0) | BIT(1))) > > /* > - * Mask of all large folio orders supported for file THP. > + * Mask of all large folio orders supported for file THP. Folios in a DAX > + * file is never split and the MAX_PAGECACHE_ORDER limit does not apply to > + * it. > */ > -#define THP_ORDERS_ALL_FILE (BIT(PMD_ORDER) | BIT(PUD_ORDER)) > +#define THP_ORDERS_ALL_FILE_DAX \ > + (BIT(PMD_ORDER) | BIT(PUD_ORDER)) Appologies if this was already discussed, but if changing _FILE_DEFAULT to advertise all orders 1-MAX_PAGECACHE_ORDER, shouldn't we also change _FILE_DAX to advertise all orders 1-PUD_ORDER ? Or is DAX literally limited to PTE/PMD/PUD? > +#define THP_ORDERS_ALL_FILE_DEFAULT \ > + ((BIT(MAX_PAGECACHE_ORDER + 1) - 1) & ~BIT(0)) > > /* > * Mask of all large folio orders supported for THP. > */ > -#define THP_ORDERS_ALL (THP_ORDERS_ALL_ANON | THP_ORDERS_ALL_FILE) > +#define THP_ORDERS_ALL \ > + (THP_ORDERS_ALL_ANON | THP_ORDERS_ALL_FILE_DAX | THP_ORDERS_ALL_FILE_DEFAULT) > > #define TVA_SMAPS (1 << 0) /* Will be used for procfs */ > #define TVA_IN_PF (1 << 1) /* Page fault handler */ > diff --git a/mm/huge_memory.c b/mm/huge_memory.c > index 2120f7478e55..4690f33afaa6 100644 > --- a/mm/huge_memory.c > +++ b/mm/huge_memory.c > @@ -88,9 +88,17 @@ unsigned long __thp_vma_allowable_orders(struct vm_area_struct *vma, > bool smaps = tva_flags & TVA_SMAPS; > bool in_pf = tva_flags & TVA_IN_PF; > bool enforce_sysfs = tva_flags & TVA_ENFORCE_SYSFS; > + unsigned long supported_orders; > + > /* Check the intersection of requested and supported orders. */ > - orders &= vma_is_anonymous(vma) ? > - THP_ORDERS_ALL_ANON : THP_ORDERS_ALL_FILE; > + if (vma_is_anonymous(vma)) > + supported_orders = THP_ORDERS_ALL_ANON; > + else if (vma_is_dax(vma)) > + supported_orders = THP_ORDERS_ALL_FILE_DAX; > + else > + supported_orders = THP_ORDERS_ALL_FILE_DEFAULT; > + > + orders &= supported_orders; > if (!orders) > return 0; >