From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8F3F0C3ABC3 for ; Mon, 12 May 2025 13:10:08 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id AE2796B012A; Mon, 12 May 2025 09:10:07 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id A698F6B012C; Mon, 12 May 2025 09:10:07 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 8E3CD6B012D; Mon, 12 May 2025 09:10:07 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id 6A56A6B012A for ; Mon, 12 May 2025 09:10:07 -0400 (EDT) Received: from smtpin02.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id 6ECF914116C for ; Mon, 12 May 2025 13:10:07 +0000 (UTC) X-FDA: 83434288854.02.F2F0742 Received: from mail-wm1-f47.google.com (mail-wm1-f47.google.com [209.85.128.47]) by imf26.hostedemail.com (Postfix) with ESMTP id 63D5E140014 for ; Mon, 12 May 2025 13:10:05 +0000 (UTC) Authentication-Results: imf26.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=BoWx1KgM; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (imf26.hostedemail.com: domain of asml.silence@gmail.com designates 209.85.128.47 as permitted sender) smtp.mailfrom=asml.silence@gmail.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1747055405; a=rsa-sha256; cv=none; b=vDqzjST7k9PFgyoP3njQ66cRx4L/67nR3Yd/LrWhs85J86QYqNIInhGAXzyyQ2Lu7a4bQ+ McSBpFb9inV6aAROoMp7I2trqXG/8lUSfffkDYpZUHr3rqlv2rgs5yNpug8ZBv0FGPNpwx Esm3bnhJcTCIxvaPrlfOCiVdCJbkHu8= ARC-Authentication-Results: i=1; imf26.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=BoWx1KgM; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (imf26.hostedemail.com: domain of asml.silence@gmail.com designates 209.85.128.47 as permitted sender) smtp.mailfrom=asml.silence@gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1747055405; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=IY2m0GqQSOITuTvG/dP0HT4pwHEgB9sgpCG5AtHDLbM=; b=mQnRnxtuIQczu1jeAbrQ6DuQZSF+kZcV/Sl6u1SH3Fc139PzLgOnD/HtlhqdNccU0m2FMm E0Dist2SPpXxkxh7jD+ObZYfS/srGD3e6qgKeg1CfZnOTwcuR1XKXmnSb01lo2YidK20Mr Mloz5+xGIdc84i6svrGati0ogcCDmBQ= Received: by mail-wm1-f47.google.com with SMTP id 5b1f17b1804b1-43cf257158fso30113885e9.2 for ; Mon, 12 May 2025 06:10:05 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1747055404; x=1747660204; darn=kvack.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=IY2m0GqQSOITuTvG/dP0HT4pwHEgB9sgpCG5AtHDLbM=; b=BoWx1KgM3IiTUdFxhanaf1O2xKVWN4aQrefYn+6XeQXs6WTRnYk+wEThEOFXbP1qW3 vTGMu5v3qgH2J8CC+mG/V2XDqJUOBNTP6eRKtLXvfe1wEoMtl4cbPMtaDnQa3i+6XiHg 1AEdfPegYhf4+42ghSLWf1in8t8EdJyBlAhQDQvjeOPNc2F2JnmNorEvsgdNfUnu14HX kDIe7ax6jkkfmGmECdfifkTpyOUXXPSCppZa1jizTNTzEO7svmlRGHepL0/Iil+oK9Sp GKSv3VaQoGXpwxgB1zmQfavI4/Rz7Ta97Ap5dTgehK3n0qvvl0HiXz7AhpHbuHiFbbC9 JgJA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1747055404; x=1747660204; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=IY2m0GqQSOITuTvG/dP0HT4pwHEgB9sgpCG5AtHDLbM=; b=n09s4BNhTkxU2XGnNjywNg102X+nBmHg0ARUtMFuUxmdq4Np1EbIFuLYZJ9Os5jhtu BFW1LnUctq9F0UrLVdCre9Ps8JvnPFBBYPmgvn21UBEBLNEadwZkgPvHTa2vnFiHIQxG wLgGmIK6fr53mpUmFDktnyhKO8Td10QLTbwHphXMOG0tCaBj9I2/eevwGyHm4JFYyApt L+ymQTpaKBHtoRNojOLQnOumAWV9/neS/78WgIUo6TjO38JMWkPVYgokGSTGYnzBgUFA mAevDDJhnpcN6vpdAojxZyYMrUIJN9lGWRZ6eFt+f0H64tv6YspP9tIHY00X3VqIiKv9 t6LQ== X-Forwarded-Encrypted: i=1; AJvYcCXBwExyI+fAAxOHenrvO5IOxPKbRS6DpvHz54IZELiWuHfvp6LVBBt+43gdG7daEQsz1yuwuG4WIQ==@kvack.org X-Gm-Message-State: AOJu0YxzimB+STF/gKVfyd5S0OrPa80opGPC+88FXfqehiaPFvjkJGaM tUzMjkLsqO+5AEKvjZNaxhfTbVyx5YA4Fvff7Gs8LDf1bPnmQn1J X-Gm-Gg: ASbGncvfYdkcoVTgr+09JSKm+T7+sDgCh4knVLXPxiO4xCTYhdBJNvvNmnytlTmAu52 qPCbkiUl8YfRuEZM1+mxeFASDmurH06epyNnN076ph6aWiKS62qFrN9UXavThsmbZTwCaUYrGEN EpV315AcngYxfyYAV/us8uv0sNMqQtSl5zfkkPyAsStsoltBCAO8Q8Tg/hnRfLpi6FyXF0JAfNQ 8zSfUnER5LDQ0U1pbdvgObJXpreYA0xqOSL5jZspYPiAQ+VdzEgd12idwv4TKnX9tw6QpLaQEdQ 4dO/FdadFf4vsTRv0/J8suPRPQqPl0zAvJe5t7vBJrCwBZRUxgfs9PAJdTI3qg== X-Google-Smtp-Source: AGHT+IG8LzaCUnCFaL0QXI6cC07KregUkp2uAZHkmluC00AMh0WUsjnsDUWnXZTRgi/pvFAAjvNlPA== X-Received: by 2002:a05:600c:c04a:b0:43d:4e9:27ff with SMTP id 5b1f17b1804b1-442d89ca284mr78221485e9.7.1747055403514; Mon, 12 May 2025 06:10:03 -0700 (PDT) Received: from [192.168.8.100] ([148.252.146.237]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-442e9f1d1bbsm5872215e9.25.2025.05.12.06.10.01 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 12 May 2025 06:10:02 -0700 (PDT) Message-ID: Date: Mon, 12 May 2025 14:11:13 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [RFC 01/19] netmem: rename struct net_iov to struct netmem_desc To: Byungchul Park , willy@infradead.org, netdev@vger.kernel.org Cc: linux-kernel@vger.kernel.org, linux-mm@kvack.org, kernel_team@skhynix.com, kuba@kernel.org, almasrymina@google.com, ilias.apalodimas@linaro.org, harry.yoo@oracle.com, hawk@kernel.org, akpm@linux-foundation.org, ast@kernel.org, daniel@iogearbox.net, davem@davemloft.net, john.fastabend@gmail.com, andrew+netdev@lunn.ch, edumazet@google.com, pabeni@redhat.com, vishal.moola@gmail.com References: <20250509115126.63190-1-byungchul@sk.com> <20250509115126.63190-2-byungchul@sk.com> Content-Language: en-US From: Pavel Begunkov In-Reply-To: <20250509115126.63190-2-byungchul@sk.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Rspamd-Server: rspam12 X-Rspamd-Queue-Id: 63D5E140014 X-Rspam-User: X-Stat-Signature: ijcap7gumy81sh3kzwgud6mdwe85hqcu X-HE-Tag: 1747055405-773387 X-HE-Meta: U2FsdGVkX1/qOwdVquTD17y/5DFoLxdwkzUyQLyoseL2PGN/EjpK9ZGr2FvmJvrDQ3SLuk03c8/5kcgVtvkvxP/Cc66HP0M2cES+si/fTVP1ed1Lwb5AOeuAEZOvvY7pWMXPiPjXgI+WDjSNZO0Cf5/2C0I1qh8uVDak9svw96vvJo+KGsB8Zcex3foRlGfoA1E/dVquJf2MqEJRVpktyqwRBoOL5xCjwruO5EGaLx5SHuhjjQ14H2k3gXVBxoKS6LC+JsWR6bxDt/7FJEOkI7XVPKmk1aDUSiUkuXAjIuYM/gMh6E5mI9Msbr4ubiVpeQUZ0u0PPmOvENRZTe2LgUrB3i0RaWC2TzNoByyKtoQPu/GC7TgM3iX7o1pHfsj4IrQYYqT8w0+Dj8oZBIAP4m3Ap6V+AKnWrPNn/UPfeYOAe/p4qzJNdrmhU27lHGj9JL6Lr4JtrhgpKxH9J1Y2WRPFKDwb8e8PuN3RrH2atLEMuIwktKox1FzexlEX9fyFPG43oo5/8PNgYi1McfZW8ZJLueUrUAT/BfFeBmtCU0OmmIWUaVioq23HrDklCa8cCkodzPmcmp1LoVWffNcZBDa+eCxdQ1WJLIcKfWzo1dgLrbLXXx6BdGyj9nS5524bU68RCn9g86mTvuOPBJ5lkrWkNs9q1MLTppAsy05yEKjMcTb0oE76v0wLvnF1KPZslpsD3paGTO9LfcJ4UXhUfnq+18FRnOqfVjzy7bW6huFCdFIliB2A+D1mZEKah7z82/TOoKXCwZ3i7DF0kqbefSUTw63ww7DlvDgtAeZZbgUUSDqAJ/5EclPujenu2mKWxCYRcrVhBbsQ0USrWGEdfc/bp3qjXh7dlHuph1r2H1L7XnkyN/WCa50AIFgBPwgvZAt61B1z2ofKkV84DO7QrP4OTWEYgjIeMMX31lP++XPlMi1ULD71HYN8yBE5JTysHexsgDNwc37UyfRpJW/ ZHJkeOso G2/pKpkaO7nsoERSSMrJgsEN50WI6FYkutFHE59EKI4ZObeh7ETmfh1lsdmqIgt8NnBY6M3krqBCYu7fB7GaWx17ogwChIJHAAj7IQkjWlebTIvA75pKOQEFunUCuXTGjLaVhX6kkC0dEORiSIMZGplZud34tpjvQpoeVY5Rdka+MT0Itg3681LAPnHXmWzEmkQGVaWux9yD7gk7/x+AtG2hCoHoDpjLarjik4/sjXZvSkmGeu3MunAVOjHSN9jFwUJ1EODQaRPaqBdy6pbOGOhXaPAPqFcnkOubcJWKPLznYu1D1YHN7lDpp23l0X99Xj7Ems8K7KOaPF2gLLXPkXOI18t/qOwNDe36jsOHSkj0rNz78BMjgLaRaEtupK701+uVcRtSdU5PrSa/eFU2iaJ2gMKFlG98LNvTk9zK49ECIA3/rWDl3hQPfXUB6e4lgH6bo8Qkyy9JhoGuZiEeEET+NeMl5kjP0avqa1kwAC+1VIt7nxA/H1VEIwEqXynmlrkdpL4ejYNLQvSprMKQArLMFu8e/KcZ50GssH0gufODpBzF19HDojKB+aUVwe6quHHxmbZV4mP50XUq/jaO11VpBfuRuIM9AVETtAe4f7Ms+ifM= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 5/9/25 12:51, Byungchul Park wrote: > To simplify struct page, the page pool members of struct page should be > moved to other, allowing these members to be removed from struct page. > > Reuse struct net_iov for also system memory, that already mirrored the > page pool members. > > Signed-off-by: Byungchul Park > --- > include/linux/skbuff.h | 4 +-- > include/net/netmem.h | 20 ++++++------ > include/net/page_pool/memory_provider.h | 6 ++-- > io_uring/zcrx.c | 42 ++++++++++++------------- You're unnecessarily complicating it for yourself. It'll certainly conflict with changes in the io_uring tree, and hence it can't be taken normally through the net tree. Why are you renaming it in the first place? If there are good reasons, maybe you can try adding a temporary alias of the struct and patch io_uring later separately. -- Pavel Begunkov