From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 73985C001B0 for ; Tue, 15 Aug 2023 13:41:35 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id AD85A94001A; Tue, 15 Aug 2023 09:41:34 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id A88718D0001; Tue, 15 Aug 2023 09:41:34 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 928CB94001A; Tue, 15 Aug 2023 09:41:34 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id 839A78D0001 for ; Tue, 15 Aug 2023 09:41:34 -0400 (EDT) Received: from smtpin23.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id 4E018C065E for ; Tue, 15 Aug 2023 13:41:34 +0000 (UTC) X-FDA: 81126451308.23.3D48341 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by imf19.hostedemail.com (Postfix) with ESMTP id ADDC41A0024 for ; Tue, 15 Aug 2023 13:41:31 +0000 (UTC) Authentication-Results: imf19.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=dkrIve3w; dmarc=pass (policy=none) header.from=redhat.com; spf=pass (imf19.hostedemail.com: domain of david@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=david@redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1692106891; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=EMyH+V5f7erV6J8zylTxk3b5SVUBFgCYhMVhPcFeR54=; b=ey1REcnAv4GvuS4BthnW3VAj/87wk4DGdqVHkFZKfygtG+bJll2wGM62olGTJh1nje0KO6 iDfqFwJqqRx0QkojNWrMiuIZpGx+EYddZqKOV2HOPAizj9L9J2rGPo0qnMZ1q3ctfR/bbC zTfWTDpj/W6k+3Wi0jdmOFj/gw2wZ44= ARC-Authentication-Results: i=1; imf19.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=dkrIve3w; dmarc=pass (policy=none) header.from=redhat.com; spf=pass (imf19.hostedemail.com: domain of david@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=david@redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1692106891; a=rsa-sha256; cv=none; b=rnuX9ml7x/lcpJkbSTxwJoSO6qpL1w96S4X0RoIeRttGIn6OgOmY3XfTqhscMFtXsn4CKS WoBlfs6q4Ko4gKBQirmGFoER0FEaMLvoD5t4t9oIyQMTUybYvHVJ/FBokcIo7/inoJRJm+ RzNKwXOiC/ZOZ57nCnojSZ5QvjEmw9E= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1692106890; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=EMyH+V5f7erV6J8zylTxk3b5SVUBFgCYhMVhPcFeR54=; b=dkrIve3wcO/TLPfg4vM3mYHrOrajaqxTEq2SJX6HFo4nT1Esg2EBzLHELhxAPnZQVQglEH +QfT4/u8F4cMrxE5dBnmsTcNSe2TMX4HxRkn88w+rU/ZZ+UPHjV7VdQAYoFHA1lVRg+w9o uOxO8Yyk52kozTGasc9W3JrcfBgiXhs= Received: from mail-wm1-f69.google.com (mail-wm1-f69.google.com [209.85.128.69]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-312-5ifPm0mVNuqmT7UCYEfv-Q-1; Tue, 15 Aug 2023 09:41:29 -0400 X-MC-Unique: 5ifPm0mVNuqmT7UCYEfv-Q-1 Received: by mail-wm1-f69.google.com with SMTP id 5b1f17b1804b1-3fe57d0e11eso34229075e9.1 for ; Tue, 15 Aug 2023 06:41:29 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1692106888; x=1692711688; h=content-transfer-encoding:in-reply-to:subject:organization:from :references:to:content-language:user-agent:mime-version:date :message-id:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=EMyH+V5f7erV6J8zylTxk3b5SVUBFgCYhMVhPcFeR54=; b=SGENcts8lXLyoVQ2+R3UZbhQkBGPQqxeMDZhu4DyKCHMxzctjezwfZbS2WAc0NRos5 RZlSN0NH0RUKjjV9obR2Jxn+gcQUyE9DdGQn2NhCbm2+pu9y+FVzj+bf9Whq6zrXJYa0 lAXCrqpfn5ef2d1DWhz3RZtBGC+tCTEd/0TnGz6XSMXt86tXmYk9R4WiqQOZFJPauZfS wP2jthrjlAwq2fOVwwJqu5O0ZFcsB1R1SuErWxj/IOOtMeWwy+35cRwXRglIIouS5Fyt QNBS+NdFVmpXYk3pVfyaix4po3Zr8I28lJhrnn29SU/qi7aiSdDCRQW8ClYNntxNWp1t Cn7g== X-Gm-Message-State: AOJu0Yzt6Zci8zRPi692SYXUIa+OZUuZoa9MIWnmm1Sr4UCIvVx0URN0 z0IwqgnmIouZafeYnZCspZ8IohjqnjWl5+guxV9medk8EG6sHVL+BZW+HOn+08XTyc6ImFiDIDL XF1OvfCad4j4= X-Received: by 2002:a1c:7703:0:b0:3fe:159d:422b with SMTP id t3-20020a1c7703000000b003fe159d422bmr9555534wmi.32.1692106888412; Tue, 15 Aug 2023 06:41:28 -0700 (PDT) X-Google-Smtp-Source: AGHT+IEohMgclqjLk6u/tJ5HN7LY7eEaXKoQw8K3cOI+vkgVvaQG0WQtFBe8lnw+0331qIMdGjV0lg== X-Received: by 2002:a1c:7703:0:b0:3fe:159d:422b with SMTP id t3-20020a1c7703000000b003fe159d422bmr9555519wmi.32.1692106888039; Tue, 15 Aug 2023 06:41:28 -0700 (PDT) Received: from ?IPV6:2003:cb:c701:3100:c642:ba83:8c37:b0e? (p200300cbc7013100c642ba838c370b0e.dip0.t-ipconnect.de. [2003:cb:c701:3100:c642:ba83:8c37:b0e]) by smtp.gmail.com with ESMTPSA id i8-20020a5d4388000000b0030647449730sm18174992wrq.74.2023.08.15.06.41.26 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 15 Aug 2023 06:41:27 -0700 (PDT) Message-ID: Date: Tue, 15 Aug 2023 15:41:26 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.13.0 To: Daniel Gomez , Yin Fengwei , "linux-mm@kvack.org" , "linux-kernel@vger.kernel.org" , "stable@vger.kernel.org" , "akpm@linux-foundation.org" , "willy@infradead.org" , "vishal.moola@gmail.com" , "wangkefeng.wang@huawei.com" , "minchan@kernel.org" , "yuzhao@google.com" , "ryan.roberts@arm.com" , "shy828301@gmail.com" References: <20230808020917.2230692-1-fengwei.yin@intel.com> <20230808020917.2230692-4-fengwei.yin@intel.com> <4jvrmdpyteny5vaqmcrctzrovap2oy2zuukybbhfqyqbbb5xmy@ufgxufss2ngw> From: David Hildenbrand Organization: Red Hat Subject: Re: [PATCH v2 3/3] madvise:madvise_free_pte_range(): don't use mapcount() against large folio for sharing check In-Reply-To: <4jvrmdpyteny5vaqmcrctzrovap2oy2zuukybbhfqyqbbb5xmy@ufgxufss2ngw> X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Rspam-User: X-Rspamd-Server: rspam12 X-Rspamd-Queue-Id: ADDC41A0024 X-Stat-Signature: z3f4xbet18s5y8ttnzz786pq468571xq X-HE-Tag: 1692106891-441865 X-HE-Meta: U2FsdGVkX18348pZplXqK44tnYDlTyenwxmEJ/wLKwFVBP4BBszoEx3KkdfcL3Bw+7T6Gbjk8A0HbN2OjfkmwqtRc95g5+e1CfVRyLaloqoAdWDQgfiC1/JgxIYYKSQIOBagGetwvmw1OaGOERqZsr/GqkkLX/jD2ndtE/kdi8uQOVsbDbmB61a1akbMd3CKhAvvm7ZuGafO9lSc07Fu3ryK7Xgn0TW/yKJmeujzdCJuSnkSTG1JapkC9bAxUAJrVzsY5U74+/+++tJk0WvsZgcSnQSX4HIvvdolbISi+twg/tSMiJykJhjMJpD+/qElue3q2ZYFEmvo8gEhq89S+Nw3Cs9Jymloypb/Ir6+V9AWk+4498GKUJpOXSSo9BluXNMoX75DI6Qh7A1rEDw7gqsPtnoG2QOvqwgWnM5bMMFPSYiYfhsf+zqs4ScpxP1GA3phoPbdyfsI7d3fMuj8F2ZOiNHqsy2xUz7oIDPnUTCXW/HkJcifH0CC+CV1w66MqP4Ak0m9yxLkIFq2c3U4kWd6fGnpOAeYyEwd+KxecYsw1mII/JQ7IDCoosYIX7kYejWkigbHR5iKjEh5nGzOMziMC/M4ChZD7/WZ4vmQisZo5OXcQUucHAe3Xrvos2baykLYlaMRh9tAgVYQQqX1572CryriEI/NuGAI95LPpDms67+fFadsoob2BhaGEbR6D9k8zRtCjRGrXtSzq9XP80TgF4Vj46WuZuOWx6sMi5+9jPChOZCr4DXQGtqRCywvkrs6Egt5ho9HwR68a6aRLdMzobG3G1v1XT5FkgedcQG0IO/2NIXMASTQ3H8AZgZtD+NbAH1dgw7M6yoe0fbbvBPRDFwDx8HaOOA1BBY+99qjuVhy3lxOIfJSyhN6ZdNnjQQQhBKbw5eTnXpa5uRRWV3e2hNlsSDcboOZMzQcC0xHtJUO0BaiFJMNpeELEe1ziG3gvLSqnEAQR+aQzoj f0naXwch DQDNFJ8slU+9SoNVEXywhCGF/C02Xnibz7Icm9lFejW6A8DboeS0D+QiUcCvm2YKj3F9kwIzXMDNUPYetw6t+H0SWIc1N//HkKNn1yKGLCUrOjys1fq+SwnnK5TqIFnbKHlOXKOJrcBXGxIj+G2gW7BIMl4B4Q/PTxw1FlqNsxMHNohzTPW3/msps+SgAGanlIyE3Uov1507t3T4sNuioNE1S65PK7N5+75zYRQ8FXT+IcLEtIhez4DmSDResXltpgX896qZ3heqi10rszvmb+yjSrfdFQ2+z2tmrRd0JLOGD+MX511cyXNKWCwG2P+peJMalzZluRInO+QHQNaZsZIjBed1eZRadDO3r2qU0iprmrOMg+3bSAptB74LcVt2B/C31ulV74YRHlEYjHdMhN08qeGS7sxqsAgXK3NSYlRrxMVRiho4XIIUTcx4sINdnhNbnVUmZSNID9hOYl6KRf8jRkzgBM0krIz0ZjmZ0yLxYC88zLlMG2tLMdKonYsDSkCV60O06uHigucLebRwusI2CgneGjXImYWPS X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 15.08.23 15:25, Daniel Gomez wrote: > Hi Yin, > On Tue, Aug 08, 2023 at 10:09:17AM +0800, Yin Fengwei wrote: >> Commit 98b211d6415f ("madvise: convert madvise_free_pte_range() to use a >> folio") replaced the page_mapcount() with folio_mapcount() to check >> whether the folio is shared by other mapping. >> >> It's not correct for large folios. folio_mapcount() returns the total >> mapcount of large folio which is not suitable to detect whether the folio >> is shared. >> >> Use folio_estimated_sharers() which returns a estimated number of shares. >> That means it's not 100% correct. It should be OK for madvise case here. > > I'm trying to understand why it should be ok for madvise this change, so > I hope it's okay to ask you few questions. > > folio_mapcount() calculates the total maps for all the subpages of a > folio. However, the folio_estimated_sharers does it only for the first > subpage making it not true for large folios. Then, wouldn't this change > drop support for large folios? It's all a mess right now. 1) page_mapcount(page): how often it this page mapped For a THP: entire mapcount of the THP (PMD-mapping) + mapcount of *this very subpage* (PTE-mapping) only 2) folio_mapcount(): how often is this folio mapped For a THP: entire mapcount of the THP (PMD-mapping) + mapcount of *all* subpages (PTE-mapping) of the folio 3) folio_estimated_sharers(): how often is the first page mapped For a THP: entire mapcount of the THP (PMD-mapping) + mapcount of *the first subpage* (PTE-mapping) only For the time being, folio_estimated_sharers() is better then folio_mapcount(), because for a PTE-mapped THP folio_mapcount() > 1. I'm looking into a replacement for folio_estimated_sharers() that is more precise ("folio_mapped_shared()"), but it's all a bit tricky. :) -- Cheers, David / dhildenb