From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6BD9FC5478C for ; Tue, 27 Feb 2024 12:43:03 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id BC7E0280008; Tue, 27 Feb 2024 07:43:02 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id B7868280007; Tue, 27 Feb 2024 07:43:02 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id A6696280008; Tue, 27 Feb 2024 07:43:02 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id 968C2280007 for ; Tue, 27 Feb 2024 07:43:02 -0500 (EST) Received: from smtpin13.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay04.hostedemail.com (Postfix) with ESMTP id DDF8B1A0B28 for ; Tue, 27 Feb 2024 12:43:01 +0000 (UTC) X-FDA: 81837548562.13.04C27C0 Received: from mout-p-101.mailbox.org (mout-p-101.mailbox.org [80.241.56.151]) by imf02.hostedemail.com (Postfix) with ESMTP id 2FCC580004 for ; Tue, 27 Feb 2024 12:42:59 +0000 (UTC) Authentication-Results: imf02.hostedemail.com; dkim=pass header.d=pankajraghav.com header.s=MBO0001 header.b=bmCpLI8D; spf=pass (imf02.hostedemail.com: domain of kernel@pankajraghav.com designates 80.241.56.151 as permitted sender) smtp.mailfrom=kernel@pankajraghav.com; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1709037780; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=vzWE63jayd8rqFmT5PVGSy+IQrBduhwjKTDvdq/SGYI=; b=t0x/C+MTpkr8vmpf6ysjcTZ/GmYHcVZevMfNuysqsmU2/tD67f4o54LyUDmRD+U1D4oviJ Whzf7NEiNCufCLxV83BJ4dbORTMiIRVPONXFpDttPhLxTk2n84GjBpiWyi9nau0Z/wtTRJ oSshJP4yhZ4VVtOntegmuMYlbGexG+8= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1709037780; a=rsa-sha256; cv=none; b=DvfL+tRMKzA9PsiD6YxGs1DVz/wKUPM9cJUQguq+YhfZzVaG/35XiwHClTcBeQKVl0R8m7 XHGymtoip9Ls8gQG1jeHGPqxMFhzxE6HsIbYSzD/WXCTJRiaMUqjStSa3jPcQvY7/bJvWe 0aB2n9woI65mKWTtGNhY5Gcoh1cgmmE= ARC-Authentication-Results: i=1; imf02.hostedemail.com; dkim=pass header.d=pankajraghav.com header.s=MBO0001 header.b=bmCpLI8D; spf=pass (imf02.hostedemail.com: domain of kernel@pankajraghav.com designates 80.241.56.151 as permitted sender) smtp.mailfrom=kernel@pankajraghav.com; dmarc=none Received: from smtp102.mailbox.org (smtp102.mailbox.org [10.196.197.102]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by mout-p-101.mailbox.org (Postfix) with ESMTPS id 4Tkcb342yWz9sT0; Tue, 27 Feb 2024 13:42:55 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=pankajraghav.com; s=MBO0001; t=1709037775; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=vzWE63jayd8rqFmT5PVGSy+IQrBduhwjKTDvdq/SGYI=; b=bmCpLI8DVlTJaSBUTzBoNBYewMYGQqXIdD2NU8qTG+8Wy0mrD9Y/Fs9os5sYeT+qJlQ/r8 dmzr9lH8TqWKJq0viwA408RQdgTmzvt7uGAYlDdCd969TIgZmWwIxDsLRIFjcUfAJEg29s 2LTSx0R42roQmkJA48rGjI1sHH4zv7gvOq2r4ujM2Lzf721doGMXfMtiZGOKa52UAUwwTV 3HjBZrsHVjqFbasZtHhhCMEQ3XW6sXIv5m1YiKvB2ZfWWMj5UbAwWE53lTdQ0QFaFtQPLz N712VSaQukeFA5XWPqHl2YHZhrZHZMVVLcEkA6x8IkYDW7kpX/IoU8Xq0Z9O6A== Date: Tue, 27 Feb 2024 13:42:51 +0100 From: "Pankaj Raghav (Samsung)" To: Matthew Wilcox Cc: linux-xfs@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org, david@fromorbit.com, chandan.babu@oracle.com, akpm@linux-foundation.org, mcgrof@kernel.org, ziy@nvidia.com, hare@suse.de, djwong@kernel.org, gost.dev@samsung.com, linux-mm@kvack.org, Pankaj Raghav Subject: Re: [PATCH 05/13] readahead: set file_ra_state->ra_pages to be at least mapping_min_order Message-ID: References: <20240226094936.2677493-1-kernel@pankajraghav.com> <20240226094936.2677493-6-kernel@pankajraghav.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Rspamd-Queue-Id: 2FCC580004 X-Rspam-User: X-Rspamd-Server: rspam11 X-Stat-Signature: rc3u53oiw5xiwzakdgkccs3ojpuec57f X-HE-Tag: 1709037779-69380 X-HE-Meta: U2FsdGVkX18+KaqJt0rlWZMsbhWYeaNI6TwN4qnPPtZQ3sbKtE6lIaKP3ggMqD/6Pw9/WeuQxkKLnMJ+m7lGBzXjagZGUnoaPwQnFYCMLLBbKEufQeUPtrzUmpHi+axPjdD65cCySy2n5i0lYC7Ij0GX9S9d49brdrwmAn6jqkKyxpsHltWJZMiIl1yJQ10ihmc+mNPc/0xjj2bO6ex99St314PK1CrENzIMoXGW7Aq/aOpE0v8elkrAy3WvR8E7C9cMIBiwIyCFJ0t/rACBGhf33XAQetWRzBmc7t3YGqxDYLCjyqSCt06/w+Wiq1SId92Hy3vE7awBpr+ZkX8XYSWPSM5wdXu7gfn5wI6vqvKO1ixKeEO3Xwf3iVJjb0EPcqu1+sPFrdDsjzx4+hKeszu1qE82suI1Dglbw7032dGXKU9OvW9X6PdHCi7nll4T2GcWZ/drBpk9Hm+dGNFHT+PFZweYRjnBtvVQ4usZyC/EIRgVOJBqPXBDqEjs3LfQBqNdiBg1LDhOW5xqWBNeE/7lDmrsUENSJB8xuBaYxFEtZrPG94kdWsFs6hCgrSW4BPYbQG2a1xLKZU4ZGacYEJknkXK6lmPqHM5GEIpmJvfr/RG11oBEPAX+EARpOBOwv6qG04SeTfdjRWFIJsW3/qbyVQdsnY8WyzWjq/J4mxbKFWdiRIl0BcN0MS8egHkNmekwx4k8bRq9e3rgxz6gv5YBoNeQE49bCa561bErEoq1/ZxtmK8w4SMuyhvwj22fVQ82O3I9klMDvZWndmZBRTF5jECJ2Lg81uqNmIphQSiyzROqwE/lmB1c+dW4nBgtwjnSP+DgWn0eixtV/duOaY+h/0Wy47I7tTrjLxCDPjbazyXYXMPOr7NfZn29nFcz1st+1sBBCd0= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Mon, Feb 26, 2024 at 02:49:04PM +0000, Matthew Wilcox wrote: > On Mon, Feb 26, 2024 at 10:49:28AM +0100, Pankaj Raghav (Samsung) wrote: > > From: Luis Chamberlain > > > > Set the file_ra_state->ra_pages in file_ra_state_init() to be at least > > mapping_min_order of pages if the bdi->ra_pages is less than that. > > Don't we rather want to round up to a multiple of mapping_min_nrpages? Hmm. That will definitely be more explicit. We might be doing multiple of min_nrpages now anyway, going beyond the ra_pages(if it is not a multiple of min_nrpages). I will do this instead: diff --git a/mm/readahead.c b/mm/readahead.c index 73aef3f080ba..4e3a6f763f5c 100644 --- a/mm/readahead.c +++ b/mm/readahead.c @@ -138,11 +138,8 @@ void file_ra_state_init(struct file_ra_state *ra, struct address_space *mapping) { - unsigned int min_nrpages = mapping_min_folio_nrpages(mapping); - - ra->ra_pages = inode_to_bdi(mapping->host)->ra_pages; - if (ra->ra_pages < min_nrpages) - ra->ra_pages = min_nrpages; + ra->ra_pages = round_up(inode_to_bdi(mapping->host)->ra_pages, + mapping_min_folio_nrpages(mapping)); ra->prev_pos = -1; } > > > file_ra_state_init(struct file_ra_state *ra, struct address_space *mapping) > > { > > + unsigned int min_nrpages = mapping_min_folio_nrpages(mapping); > > + > > ra->ra_pages = inode_to_bdi(mapping->host)->ra_pages; > > + if (ra->ra_pages < min_nrpages) > > + ra->ra_pages = min_nrpages; > > ra->prev_pos = -1;