From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id CDF02C25B78 for ; Thu, 30 May 2024 09:21:52 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 630066B009B; Thu, 30 May 2024 05:21:52 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 5E1A16B009C; Thu, 30 May 2024 05:21:52 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 4CE9E6B009D; Thu, 30 May 2024 05:21:52 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id 30DFE6B009B for ; Thu, 30 May 2024 05:21:52 -0400 (EDT) Received: from smtpin13.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay03.hostedemail.com (Postfix) with ESMTP id DCFB6A0EA5 for ; Thu, 30 May 2024 09:21:51 +0000 (UTC) X-FDA: 82174520022.13.D8D6D29 Received: from szxga02-in.huawei.com (szxga02-in.huawei.com [45.249.212.188]) by imf14.hostedemail.com (Postfix) with ESMTP id 5828F10000E for ; Thu, 30 May 2024 09:21:49 +0000 (UTC) Authentication-Results: imf14.hostedemail.com; dkim=none; dmarc=pass (policy=quarantine) header.from=huawei.com; spf=pass (imf14.hostedemail.com: domain of linyunsheng@huawei.com designates 45.249.212.188 as permitted sender) smtp.mailfrom=linyunsheng@huawei.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1717060909; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=iMttH6GUoOQyy4PaE3+U+t0yyJI+3nWK17YGGEeKOSE=; b=zpk6kUw10HOZVoi3d0pXYO+9GXVvMavKctHBadLRxCwIAGXb6rNBIjwFqCafAy7eGZ0kHA ra4Fhb3uecMRV0XVf9aShDMFAXHOfyM5nrMQK8bGiaoGOg8TgH4VcbdvaddGEmzM1zumPT l27fC9d+AoYK7RsXv9oFjfXPjJh0fUM= ARC-Authentication-Results: i=1; imf14.hostedemail.com; dkim=none; dmarc=pass (policy=quarantine) header.from=huawei.com; spf=pass (imf14.hostedemail.com: domain of linyunsheng@huawei.com designates 45.249.212.188 as permitted sender) smtp.mailfrom=linyunsheng@huawei.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1717060909; a=rsa-sha256; cv=none; b=wcUSOYgm38FZr204NkTa2nq5hH26wOwMC1FHSkYFbOOI09BgVOWGZpI6mIgFqqzUStUm5C gcIS0lSxu5gHO2pC2GewECIZYyB1noI0FlFGnk1ZpWMBrt+fULVTHEp8wuRaoq940OMyqX 0nNMYHOs1jyrnjVgTlgarFDDI/wmu1c= Received: from mail.maildlp.com (unknown [172.19.163.48]) by szxga02-in.huawei.com (SkyGuard) with ESMTP id 4Vqgcx5YB5zmX11; Thu, 30 May 2024 17:17:21 +0800 (CST) Received: from dggpemm500005.china.huawei.com (unknown [7.185.36.74]) by mail.maildlp.com (Postfix) with ESMTPS id C675318007F; Thu, 30 May 2024 17:21:45 +0800 (CST) Received: from [10.69.30.204] (10.69.30.204) by dggpemm500005.china.huawei.com (7.185.36.74) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.35; Thu, 30 May 2024 17:21:45 +0800 Subject: Re: [PATCH net-next v5 10/13] mm: page_frag: introduce prepare/probe/commit API To: , , CC: , , Alexander Duyck , Andrew Morton , References: <20240528125604.63048-1-linyunsheng@huawei.com> <20240528125604.63048-11-linyunsheng@huawei.com> From: Yunsheng Lin Message-ID: Date: Thu, 30 May 2024 17:21:45 +0800 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:52.0) Gecko/20100101 Thunderbird/52.2.0 MIME-Version: 1.0 In-Reply-To: <20240528125604.63048-11-linyunsheng@huawei.com> Content-Type: text/plain; charset="utf-8" Content-Language: en-US Content-Transfer-Encoding: 7bit X-Originating-IP: [10.69.30.204] X-ClientProxiedBy: dggems701-chm.china.huawei.com (10.3.19.178) To dggpemm500005.china.huawei.com (7.185.36.74) X-Rspamd-Queue-Id: 5828F10000E X-Stat-Signature: thcoz9pmadai8fszw5zyqc1yw89rejg7 X-Rspam-User: X-Rspamd-Server: rspam11 X-HE-Tag: 1717060909-106542 X-HE-Meta: U2FsdGVkX18lo6/xNIGPON9Cmhb2yPF61vKFrOlkpOR9EZpqr5Y1sbxn0zUZNGK9jbCcfXJ6GVG+2qoi52bLl2itphKVQHugKcgwH9apVrJ1zWftho/sw0tjKhAX8WI23zOhNP44jFaMnjkoJw02ma4nRWH8UxCkAj5uVd/LRZ3CKXh7byDxrRK6vR7wiq6S0z55uEqEvz6BT636FV4kEkrEc+kjO0u0TjjnCRHDMRnq/fbQ9TIAtZgPHQ7JtMJ56THG77xpBwtea6oB1NpZSZVF2xr2wu0IGfTiF4Vr9IcXXLXrrfmPYR7E9YCQd/mKgG7e+fTpz4gy3dp5IyKwGjmrdn5btpZ6N0tJjLQen63RJv1xu6T5DcnidskPOwuSqk0oeRaC++virDSf6O0XPc02rkz6NlB7d7TAipWkMtvwwH5SWkpm4mPFWqz3sOXCJYQwExEZWWxwOC/aTtwuOlBg6GbFTxyU/Gb4Ry4LSXM8wHmf6udFj5KCuyzeIVG8xGa59/T95UmLH9Y0bqD212a5GmJLlAnQwG5EN2I1JRnTQg2Af9cuL8Cm0B5ltJ8t5QTz/INhtx0Qh7AyuWXEcXLQFafy/NVWLD4fY4ka0oV4U6TU1Ec+ZkKUVBknFGNGC3fJZZ1obQIm7NYpC12xyu91Jvo21N5U1h7SzqwBPaBSMEWbxsLtohWWjdLVi04XqXqjuo4QD3q3xb9nbJwjugrOiVZ7wILk9k9Z4vvPj+/fREpLLp8c7MxaaDG9WHo/QnUSzjT3ond+8ksSAmQVV6pj+vAbaBkIIOOsknsQ18DR5t611xQ8hKdxYJi3DgFieVj1/PDRIVKqqzbT7BEk1UD7axU0SR8Tr4y17XPP1WvhDg/vw2foHSv8diILJ/jUuC4FkE/3KUksSz7mD+yfQl13dA6b6HDT4xm4Q0Cpi4RkIs9+CDBYL1AkW50Lo5BOtaYKtFfQ3qwU/tzTcOk mRmcj2Aj lEtA9qvl+x6CUNbkT8jmNwovCJ1KXFVAMqLXqqWWiwdz3P0x2cqRHwktglEon9Gt3+qXgt18FaiLYC8A/t2rj4TqSd090OoA2249cRvUgbe2TXPO0cYb98vr86/0DiPcp0gEMPoPRJVTcBxyqzMVZeJrVhudUF5ZMMbj54eGELIChRiVsAnTsqwMntYnSO0yfEQTtb2N5bljB6d3qkEFFYTrsayx+oiLTz4P8AiSXuvN6iMucKHv053ASI6t4/4az7buWJo2O+XmyK8Q7rSZrdEzRrw== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 2024/5/28 20:56, Yunsheng Lin wrote: > +#define page_frag_alloc_probe(nc, offset, fragsz, va) \ > +({ \ > + struct page *__page = NULL; \ > + \ > + VM_BUG_ON(!*(fragsz)); \ The above above marco seems to need to include mmdebug.h explicitly to avoid compile error for x86 system. > + if (likely((nc)->remaining >= *(fragsz))) \ > + __page = virt_to_page(__page_frag_alloc_probe(nc, \ > + offset, \ > + fragsz, \ > + va)); \ > + \ > + __page; \ > +})