From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id E0858CDDE70 for ; Wed, 23 Oct 2024 11:40:37 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 769696B0088; Wed, 23 Oct 2024 07:40:37 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 719666B0089; Wed, 23 Oct 2024 07:40:37 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 5934D6B008A; Wed, 23 Oct 2024 07:40:37 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id 391746B0088 for ; Wed, 23 Oct 2024 07:40:37 -0400 (EDT) Received: from smtpin12.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id 34CAD160952 for ; Wed, 23 Oct 2024 11:40:17 +0000 (UTC) X-FDA: 82704674010.12.21C34AD Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by imf13.hostedemail.com (Postfix) with ESMTP id 0004B2000F for ; Wed, 23 Oct 2024 11:40:16 +0000 (UTC) Authentication-Results: imf13.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b="dbxoYB/j"; spf=pass (imf13.hostedemail.com: domain of david@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1729683483; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=00UCNvVaA8//wqC/c8pBb7Q5oEvjUZfwZTPKlOZTKjk=; b=qtnKbsnDBAH/PqBPTaTW/QhOkOZanFa1Tin4oRMknEtdSPK3I9pyDHqEtT7V95Fn8zIfG9 eezx/yqzFV4pZCZ1ijGJsV2Dj9q7UbK2JOpInvsV7oFLd3f7X0wn/VQOt+TeAKpmO/keK2 OfLUvDw1FeIbOznwrJDCvc/a7qmsfGo= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1729683483; a=rsa-sha256; cv=none; b=h+ZTIoD9eAdyp5+PrTfRxaAe3AG8pGBS9trkEo+smt6tb8plF0q6vzLD1BW2+SVkR/p+ux 39f54s4uNW9hk0xD6i+RkyRuMHonhLmY1lHWZ5ev3jJEhj+i9LH+iAyC3i25n21IVF3kyD Jq9N93ivq4MSymqLZyGmG/v1Mu26W3k= ARC-Authentication-Results: i=1; imf13.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b="dbxoYB/j"; spf=pass (imf13.hostedemail.com: domain of david@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=none) header.from=redhat.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1729683634; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=00UCNvVaA8//wqC/c8pBb7Q5oEvjUZfwZTPKlOZTKjk=; b=dbxoYB/jIsehnWfniKq2YR6EWtHxpJvMoTonkCWj0wHxDdYaBMxfKOHXO/1kxC9PQsoKHu uJydXzgCQmvDhEyoQoInbh1KtSR/O5wB/QTkn2qlyYBlGJYkA0gwFQkshCdZiI/FVu+yvt lOf77oHo3dzhrfX66Is+QRdtIEYnlfY= Received: from mail-wr1-f69.google.com (mail-wr1-f69.google.com [209.85.221.69]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-2-JhEun7MEPRGC2yRiOUednw-1; Wed, 23 Oct 2024 07:40:32 -0400 X-MC-Unique: JhEun7MEPRGC2yRiOUednw-1 Received: by mail-wr1-f69.google.com with SMTP id ffacd0b85a97d-37d533a484aso387482f8f.0 for ; Wed, 23 Oct 2024 04:40:32 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1729683631; x=1730288431; h=content-transfer-encoding:in-reply-to:organization:autocrypt :content-language:from:references:cc:to:subject:user-agent :mime-version:date:message-id:x-gm-message-state:from:to:cc:subject :date:message-id:reply-to; bh=00UCNvVaA8//wqC/c8pBb7Q5oEvjUZfwZTPKlOZTKjk=; b=pHTOHJR1ppHXQWgZczyu+TEpNNsJ2IRY2Kq5P7Cr0P63GDKb6iQ/VxFOP4XPXvaj1n iqcVAIJqCMhkZBluUNmBFwskv+KTx5Vf0kbzWtnY86yoc9v4iO83nUpckjMx8KdGS68n o/AIUyYrD5QsagaW6nfBAfn4NYpp1LrvWJTPkpVTWpon87tt3G6kHOSRxRm930pqR59M u0V1c7Pm/5g0PnldNODNJ0sSXmpZ4Xff6EzJQWe+v6kt3nsDjf00PqP2vyL2V0A1/rr4 hA2szuqfCW6cuvJBCPdEccNRYsS0vveIIWo85BTsQI2GIN30GLodSHOZw9RzDmX0bXs8 qlEQ== X-Forwarded-Encrypted: i=1; AJvYcCWWnQJjx4aR3EfwDhe6YIe9EKhY4FIVhYdB2K/uZtlAVQTuc6DEAzWuUOpDAn5EbXk5DH8omA4pdA==@kvack.org X-Gm-Message-State: AOJu0YxBz2juDeJy/T4s3IshffXbjyNDqzFNf8/pA58TP8zfB9ohb2lD 56kaBAmv8m3CNJu40fplRRuMtjc23cqibMEI7ERM6OEXtRP5otgMlJgLjhplAut/rPo+OwTCgNn bi1VV9ihaUvIpFxqThC3NNv1pe5ZrdsrggGNtIReZiJeGgXIh X-Received: by 2002:a5d:4a4d:0:b0:37c:c9bc:1be6 with SMTP id ffacd0b85a97d-37ef129b361mr4100767f8f.16.1729683631041; Wed, 23 Oct 2024 04:40:31 -0700 (PDT) X-Google-Smtp-Source: AGHT+IEW/dkEjuTqFrwhQpZgX5jH8kZSNf0J+pFAwbbQ54WdTktIpiRwr9kETKI5k036+gyFSEmZNg== X-Received: by 2002:a5d:4a4d:0:b0:37c:c9bc:1be6 with SMTP id ffacd0b85a97d-37ef129b361mr4100754f8f.16.1729683630543; Wed, 23 Oct 2024 04:40:30 -0700 (PDT) Received: from ?IPV6:2003:cb:c70c:cd00:c139:924e:3595:3b5? (p200300cbc70ccd00c139924e359503b5.dip0.t-ipconnect.de. [2003:cb:c70c:cd00:c139:924e:3595:3b5]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-43186c3a44asm13874535e9.36.2024.10.23.04.40.28 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 23 Oct 2024 04:40:30 -0700 (PDT) Message-ID: Date: Wed, 23 Oct 2024 13:40:28 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v1 04/17] mm: let _folio_nr_pages overlay memcg_data in first tail page To: "Kirill A. Shutemov" Cc: linux-kernel@vger.kernel.org, linux-mm@kvack.org, cgroups@vger.kernel.org, x86@kernel.org, linux-fsdevel@vger.kernel.org, Andrew Morton , "Matthew Wilcox (Oracle)" , Tejun Heo , Zefan Li , Johannes Weiner , =?UTF-8?Q?Michal_Koutn=C3=BD?= , Jonathan Corbet , Andy Lutomirski , Thomas Gleixner , Ingo Molnar , Borislav Petkov , Dave Hansen References: <20240829165627.2256514-1-david@redhat.com> <20240829165627.2256514-5-david@redhat.com> From: David Hildenbrand Autocrypt: addr=david@redhat.com; keydata= xsFNBFXLn5EBEAC+zYvAFJxCBY9Tr1xZgcESmxVNI/0ffzE/ZQOiHJl6mGkmA1R7/uUpiCjJ dBrn+lhhOYjjNefFQou6478faXE6o2AhmebqT4KiQoUQFV4R7y1KMEKoSyy8hQaK1umALTdL QZLQMzNE74ap+GDK0wnacPQFpcG1AE9RMq3aeErY5tujekBS32jfC/7AnH7I0v1v1TbbK3Gp XNeiN4QroO+5qaSr0ID2sz5jtBLRb15RMre27E1ImpaIv2Jw8NJgW0k/D1RyKCwaTsgRdwuK Kx/Y91XuSBdz0uOyU/S8kM1+ag0wvsGlpBVxRR/xw/E8M7TEwuCZQArqqTCmkG6HGcXFT0V9 PXFNNgV5jXMQRwU0O/ztJIQqsE5LsUomE//bLwzj9IVsaQpKDqW6TAPjcdBDPLHvriq7kGjt WhVhdl0qEYB8lkBEU7V2Yb+SYhmhpDrti9Fq1EsmhiHSkxJcGREoMK/63r9WLZYI3+4W2rAc UucZa4OT27U5ZISjNg3Ev0rxU5UH2/pT4wJCfxwocmqaRr6UYmrtZmND89X0KigoFD/XSeVv jwBRNjPAubK9/k5NoRrYqztM9W6sJqrH8+UWZ1Idd/DdmogJh0gNC0+N42Za9yBRURfIdKSb B3JfpUqcWwE7vUaYrHG1nw54pLUoPG6sAA7Mehl3nd4pZUALHwARAQABzSREYXZpZCBIaWxk ZW5icmFuZCA8ZGF2aWRAcmVkaGF0LmNvbT7CwZgEEwEIAEICGwMGCwkIBwMCBhUIAgkKCwQW AgMBAh4BAheAAhkBFiEEG9nKrXNcTDpGDfzKTd4Q9wD/g1oFAl8Ox4kFCRKpKXgACgkQTd4Q 9wD/g1oHcA//a6Tj7SBNjFNM1iNhWUo1lxAja0lpSodSnB2g4FCZ4R61SBR4l/psBL73xktp rDHrx4aSpwkRP6Epu6mLvhlfjmkRG4OynJ5HG1gfv7RJJfnUdUM1z5kdS8JBrOhMJS2c/gPf wv1TGRq2XdMPnfY2o0CxRqpcLkx4vBODvJGl2mQyJF/gPepdDfcT8/PY9BJ7FL6Hrq1gnAo4 3Iv9qV0JiT2wmZciNyYQhmA1V6dyTRiQ4YAc31zOo2IM+xisPzeSHgw3ONY/XhYvfZ9r7W1l pNQdc2G+o4Di9NPFHQQhDw3YTRR1opJaTlRDzxYxzU6ZnUUBghxt9cwUWTpfCktkMZiPSDGd KgQBjnweV2jw9UOTxjb4LXqDjmSNkjDdQUOU69jGMUXgihvo4zhYcMX8F5gWdRtMR7DzW/YE BgVcyxNkMIXoY1aYj6npHYiNQesQlqjU6azjbH70/SXKM5tNRplgW8TNprMDuntdvV9wNkFs 9TyM02V5aWxFfI42+aivc4KEw69SE9KXwC7FSf5wXzuTot97N9Phj/Z3+jx443jo2NR34XgF 89cct7wJMjOF7bBefo0fPPZQuIma0Zym71cP61OP/i11ahNye6HGKfxGCOcs5wW9kRQEk8P9 M/k2wt3mt/fCQnuP/mWutNPt95w9wSsUyATLmtNrwccz63XOwU0EVcufkQEQAOfX3n0g0fZz Bgm/S2zF/kxQKCEKP8ID+Vz8sy2GpDvveBq4H2Y34XWsT1zLJdvqPI4af4ZSMxuerWjXbVWb T6d4odQIG0fKx4F8NccDqbgHeZRNajXeeJ3R7gAzvWvQNLz4piHrO/B4tf8svmRBL0ZB5P5A 2uhdwLU3NZuK22zpNn4is87BPWF8HhY0L5fafgDMOqnf4guJVJPYNPhUFzXUbPqOKOkL8ojk CXxkOFHAbjstSK5Ca3fKquY3rdX3DNo+EL7FvAiw1mUtS+5GeYE+RMnDCsVFm/C7kY8c2d0G NWkB9pJM5+mnIoFNxy7YBcldYATVeOHoY4LyaUWNnAvFYWp08dHWfZo9WCiJMuTfgtH9tc75 7QanMVdPt6fDK8UUXIBLQ2TWr/sQKE9xtFuEmoQGlE1l6bGaDnnMLcYu+Asp3kDT0w4zYGsx 5r6XQVRH4+5N6eHZiaeYtFOujp5n+pjBaQK7wUUjDilPQ5QMzIuCL4YjVoylWiBNknvQWBXS lQCWmavOT9sttGQXdPCC5ynI+1ymZC1ORZKANLnRAb0NH/UCzcsstw2TAkFnMEbo9Zu9w7Kv AxBQXWeXhJI9XQssfrf4Gusdqx8nPEpfOqCtbbwJMATbHyqLt7/oz/5deGuwxgb65pWIzufa N7eop7uh+6bezi+rugUI+w6DABEBAAHCwXwEGAEIACYCGwwWIQQb2cqtc1xMOkYN/MpN3hD3 AP+DWgUCXw7HsgUJEqkpoQAKCRBN3hD3AP+DWrrpD/4qS3dyVRxDcDHIlmguXjC1Q5tZTwNB boaBTPHSy/Nksu0eY7x6HfQJ3xajVH32Ms6t1trDQmPx2iP5+7iDsb7OKAb5eOS8h+BEBDeq 3ecsQDv0fFJOA9ag5O3LLNk+3x3q7e0uo06XMaY7UHS341ozXUUI7wC7iKfoUTv03iO9El5f XpNMx/YrIMduZ2+nd9Di7o5+KIwlb2mAB9sTNHdMrXesX8eBL6T9b+MZJk+mZuPxKNVfEQMQ a5SxUEADIPQTPNvBewdeI80yeOCrN+Zzwy/Mrx9EPeu59Y5vSJOx/z6OUImD/GhX7Xvkt3kq Er5KTrJz3++B6SH9pum9PuoE/k+nntJkNMmQpR4MCBaV/J9gIOPGodDKnjdng+mXliF3Ptu6 3oxc2RCyGzTlxyMwuc2U5Q7KtUNTdDe8T0uE+9b8BLMVQDDfJjqY0VVqSUwImzTDLX9S4g/8 kC4HRcclk8hpyhY2jKGluZO0awwTIMgVEzmTyBphDg/Gx7dZU1Xf8HFuE+UZ5UDHDTnwgv7E th6RC9+WrhDNspZ9fJjKWRbveQgUFCpe1sa77LAw+XFrKmBHXp9ZVIe90RMe2tRL06BGiRZr jPrnvUsUUsjRoRNJjKKA/REq+sAnhkNPPZ/NNMjaZ5b8Tovi8C0tmxiCHaQYqj7G2rgnT0kt WNyWQQ== Organization: Red Hat In-Reply-To: X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Rspamd-Queue-Id: 0004B2000F X-Stat-Signature: kuukor1dxeeobbpu38px7x1nqgpdzemi X-Rspamd-Server: rspam09 X-Rspam-User: X-HE-Tag: 1729683616-997038 X-HE-Meta: U2FsdGVkX1/uv+yOp6oUqxkzF7lR6vqosgZVWOaY0VgzgVLCSKQLiPmZpaAg+EEmnayuetbLMJV7crIhe+HPO8dfJp3oPDwrPIF7DBqFLyQrH+8DHS2Pgkhre+Yx7urLrY5yx7vHO4XgfdR2xS0blJ3gn86grnKBjkAmKmOsb0+5jCsOBL8YIfvsacchL/WWLbrYq6QBnOJa7OEuDUcl6tdexQSQKSQIt/hE0tKJQ01Iw/n+gE5jd9xzjmim/hMtweCc8SvnPU5KuiIvVY67gStP8KSk3MRbO+MQinqwPhyum3oD21tpNezAtRdmk9rLEwUgwKTxHoqCT7IyhtdhV+p3NJvE/7aSA47Iy7IONFRajRyA8Jzjq26q1EBauAPYkIP8o4G0bpn/S/f07lzKegP43z52bk/rU9F0TbW5ZMDUYKSsklk0npxiiIR9bX1Wc+e75Rk4m4XKvyC8RKm/1SskEHNEKe0SjAOn3lp7yMhoY3NomI0oFwLoDtHJenWNeHznsQoos4JMaaqkrJr+tEliFF3w0h9eqy21Tqzk4R8FiB3zGE9h5SNptGIfRNvWavwWV2ewFtS2E6jsJzr2N+gdrsI1w2E8qXGt9qq8AgcnijXDNNKHxPq5A3yPxhm70XPPLycp3G9s38z5ayXBmMhmUbENV4kEONOgQ6/q3qdUh71KcF9O5j4x06fJ9aiJrgjJy58P52ejizzIpxnVI58n9yFB/oatsYoAoAQTprJaecmM4YtUxyJfUqSjOzVnt4vCH3+sn+Ajt+sfrz/VZCWem/P77NTK8P4O8vUO0qVhoJyW6NS5Von/Xz1M3p3DZlFm8ArgsXRalN0EWTlbQPbzzOi88zLH/U+iPigL//j6BwXs4ddYQPyOA79rCyYO/SSZrWbwDRhvZse+GM5TYOrrHuMNtl+9hCwhFU7UJO6uSw3zBWaLukRqMG+Xpuk8z3/WrlvavPHLVskJohI FJmwoNMO zmqvV8o91vfrDfhmJa1wRDBpYfo4x1xotRaaFHIS9ImtmBNVSA9/ed/MYKwRf02Q8BoSSj8M2//i/yFt8aPs3y87/f5G2Mo80kkf+WE3qktfs5O3luAk6lQLUmByri5hoLWP2e7cJEnfyum87WyAd1ok66gjOmaMclwJ9ec4ARqW18qUcamPsWQfoNu/ISwt4qjIK2+8ebW0N0Mc1tTyR2xI7Gq5MLHRxG3IS6hhNawOaOf/wwAZbc5MfTACkE+78b+YGwFuygosWAzY5nkAe06gUyVnS0qwITI9uKBM5uTvRA6jSKvT/36I3jlQZIJm18emTtat/tmdiJOeIg/tgLt5N7cd6queVHqgp/cqZ2PDxkbezt4y1jR2oVgnvjpiyuQcjdOKlHS8Xg9GLNFqQjXx0WuMeRWCaqbon+LmZ1spKVkqt4E9ZMKjD30dWWa12e8cXRjUjqA1Tdw9YZEU8ugIHEgx2z3cnvlI9vymIux8fqzDiL80qaN787A== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 23.10.24 13:38, Kirill A. Shutemov wrote: > On Thu, Aug 29, 2024 at 06:56:07PM +0200, David Hildenbrand wrote: >> Let's free up some more of the "unconditionally available on 64BIT" >> space in order-1 folios by letting _folio_nr_pages overlay memcg_data in >> the first tail page (second folio page). Consequently, we have the >> optimization now whenever we have CONFIG_MEMCG, independent of 64BIT. >> >> We have to make sure that page->memcg on tail pages does not return >> "surprises". page_memcg_check() already properly refuses PageTail(). >> Let's do that earlier in print_page_owner_memcg() to avoid printing >> wrong "Slab cache page" information. No other code should touch that >> field on tail pages of compound pages. >> >> Reset the "_nr_pages" to 0 when splitting folios, or when freeing them >> back to the buddy (to avoid false page->memcg_data "bad page" reports). >> >> Note that in __split_huge_page(), folio_nr_pages() would stop working >> already as soon as we start messing with the subpages. >> >> Most kernel configs should have at least CONFIG_MEMCG enabled, even if >> disabled at runtime. 64byte "struct memmap" is what we usually have >> on 64BIT. >> >> While at it, rename "_folio_nr_pages" to "_nr_pages". >> >> Signed-off-by: David Hildenbrand > > Reviewed-by: Kirill A. Shutemov > > BTW, have anybody evaluated how much (if anything) do we gain we a > separate _nr_pages field in struct folio comparing to calculating it > based on the order in _flags_1? Mask+shift should be pretty cheap. I recall that Willy did, and it's mostly getting rid of a single instruction in loads of places. $ git grep folio_nr_pages | wc -l 254 [my first intuition was also to just remove it, but this way seems easy to just maintain it for now] -- Cheers, David / dhildenb