From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8629DC001DE for ; Tue, 15 Aug 2023 17:52:56 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 13BA8940024; Tue, 15 Aug 2023 13:52:56 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 0EC5D8D0001; Tue, 15 Aug 2023 13:52:56 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id EF63A940024; Tue, 15 Aug 2023 13:52:55 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id DB58A8D0001 for ; Tue, 15 Aug 2023 13:52:55 -0400 (EDT) Received: from smtpin15.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay04.hostedemail.com (Postfix) with ESMTP id AB4EA1A09FB for ; Tue, 15 Aug 2023 17:52:55 +0000 (UTC) X-FDA: 81127084710.15.8578E6A Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by imf24.hostedemail.com (Postfix) with ESMTP id 5DE4118000B for ; Tue, 15 Aug 2023 17:52:53 +0000 (UTC) Authentication-Results: imf24.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=VsUbTZ+K; spf=pass (imf24.hostedemail.com: domain of david@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1692121973; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=HVQ3sb9xVMcL/Jj/o9MHbLWoxuzHNOB7Lrqi8OAIuDg=; b=qURw1DNgeeeCZMp5z2R4HUvyp00hL7HVu9hxYRWUJwgAY8KkEjlEwqxK7C+RabgtZ7YQLf SD+27jLa0JX5Csha+hKSiUDTohjGsGPe2q4U7cwR1psmfOljCMZwEeUWIIDTkEbMWdHKRQ 0ENwJgqZN9v/i3OuafFBArgQ/E9Guyw= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1692121973; a=rsa-sha256; cv=none; b=VNsVEUCE4scb2E48RrDSO+gPG/Z2KaV1BrKveY0jTvvo+61GndyqMY1dFnMQIuwQQ1yWYJ SCZI3eCUomAhruKzJIgrrKxMLy4UWibkjm5yiMLV5VKjWvMO5avNFHjjuof9xKIyR7/MOo Q8LDiHCM6DQgdgBbgM/2jkf051hKxfg= ARC-Authentication-Results: i=1; imf24.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=VsUbTZ+K; spf=pass (imf24.hostedemail.com: domain of david@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=none) header.from=redhat.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1692121972; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=HVQ3sb9xVMcL/Jj/o9MHbLWoxuzHNOB7Lrqi8OAIuDg=; b=VsUbTZ+Kb4yJjSed2X8B6EaO8YzBQvtnVEiFoNpsspDVGogj5mY5oeeKVE+s0JQs4x6K0B T5o7R9ej2BC2dZlOWhFHLVnnDAj2NeOFA6wlU2kzTGk0Hw48V3nVfT/OCNy9reQAERB/Tn PAYQ4dk7zrDt4Z0f60b5xiWvlt8k0AM= Received: from mail-wm1-f69.google.com (mail-wm1-f69.google.com [209.85.128.69]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-487-rLE-0h08PLmPjU1mX8-2Lg-1; Tue, 15 Aug 2023 13:52:51 -0400 X-MC-Unique: rLE-0h08PLmPjU1mX8-2Lg-1 Received: by mail-wm1-f69.google.com with SMTP id 5b1f17b1804b1-3fe2516e624so27905055e9.1 for ; Tue, 15 Aug 2023 10:52:50 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1692121970; x=1692726770; h=content-transfer-encoding:in-reply-to:organization:from:references :cc:to:content-language:subject:user-agent:mime-version:date :message-id:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=HVQ3sb9xVMcL/Jj/o9MHbLWoxuzHNOB7Lrqi8OAIuDg=; b=cc+P6Kk+fpHzF+0gl8yjysOAn0vdJtQXdT+w2ahFliBnKjFxJFu6NcBcaW9ej2DBP0 9ILBvsYyNR+7lEHl7u8LWiqd+QeBxC0lRSkMQtqprtjFl/Vmw5je72Xf5VmEGdmQTTPQ PWeasH5poDD6tqiBn7unhe8ajr2ii005tBLn7xQL/cPvSBijY9ebWojoiY2veq2gr5Sg swd+Os2prk3pJrRayGNulreC7KH6kSew2v9lr2FJvHEyaz7mmmDFc14gmE0UjDLKLrWc n92eoxeq0KSLXp2q/xPEv/OTypClkivsf+7Q9tUu0KkwU4prveNEVgXLHUguVtPENnWu CV9A== X-Gm-Message-State: AOJu0YyI+0DxNempvCPQsy+XX6VfpmgAz8fD74lRFCscw4zSMnW3ScHZ dC93KSTuAokSzdemOGbCi+/mgGOpdVmATQjQEXkkQC/NOuTmydsyxfDhpNf2sr3TBruGvIpNgLd E7l9FVi4b5Uyxib1T7zk= X-Received: by 2002:a05:600c:4444:b0:3fe:21f1:aba8 with SMTP id v4-20020a05600c444400b003fe21f1aba8mr2049388wmn.12.1692121969937; Tue, 15 Aug 2023 10:52:49 -0700 (PDT) X-Google-Smtp-Source: AGHT+IGGwOSu+t9TGNZbyeOtEGVbD6aZZJCbyTZyAsgHlDRI/h/8rHIpPiY8Ko2pF8wnkyhG30kILA== X-Received: by 2002:a05:600c:4444:b0:3fe:21f1:aba8 with SMTP id v4-20020a05600c444400b003fe21f1aba8mr2049371wmn.12.1692121969574; Tue, 15 Aug 2023 10:52:49 -0700 (PDT) Received: from ?IPV6:2003:cb:c701:3100:c642:ba83:8c37:b0e? (p200300cbc7013100c642ba838c370b0e.dip0.t-ipconnect.de. [2003:cb:c701:3100:c642:ba83:8c37:b0e]) by smtp.gmail.com with ESMTPSA id f14-20020adffcce000000b00317a04131c5sm18593268wrs.57.2023.08.15.10.52.48 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 15 Aug 2023 10:52:49 -0700 (PDT) Message-ID: Date: Tue, 15 Aug 2023 19:52:48 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.13.0 Subject: Re: [PATCH 2/3] mm,thp: fix nodeN/meminfo output alignment To: Hugh Dickins , Andrew Morton Cc: Alexey Dobriyan , linux-kernel@vger.kernel.org, linux-mm@kvack.org References: From: David Hildenbrand Organization: Red Hat In-Reply-To: X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Rspamd-Queue-Id: 5DE4118000B X-Rspam-User: X-Rspamd-Server: rspam11 X-Stat-Signature: dq19665tbrx5snwe4o1at6kzrgy517xq X-HE-Tag: 1692121973-580329 X-HE-Meta: U2FsdGVkX19EMA7lbcG3dVkNP5p9GNKP2nexQVq4LK8qrfKf97Wt6tjfeT467/w5vEqB6eBTVMojYvPAtRKjc+RhNgk2aCfWKtZOAzUPp4yMXklhT7LiWTcR9BZkcDVxXzouMeR0DmS32+lJpZ6FzXHwtQpjfgbPHHnNJvx9ZCHCyLF0o/zTQSKZBmgkf48C00GygzV6ID0FCIj0xApuEh41FOagukMtltPOE+jwDI9of1vnpiP7ybL4lTw9KU3moI6zo9aLJC+gsOO6PgDdyUbOczllkR9VJbr8M0wR6rIIXyDrt4NfeLk+EG+M5qZMpOlS7TKuq5fW5E8iU1Ig2N8YymhtqeJLc+DZ6I1oZxVhlKxyY/+xRJMA4kpgTU4IzwPMhs3PG0bGe/w9oljFzZiGIYLk9YLYukxMBH9aygrXY+Ef+Gc9XCNAyq1fogDUNStnl2EnlyVnernddArWYt+AUjgwGFJzYGM5ld/PIRFdc1AxlDKfmd3YsiKS6Y9PE2pTgRYOD2bqvQBN8qtZ2AccgRrO703jnq7/gtdvTG9urX3ZBFT3AEKyaPJD+yZdDt+Jkl9orXsg6nyN6kzI4X+M8J0JDFo49xg+pGbEHdbEk6uMdos78pHthzqb1dANsY+ctFn6brTDLQ/rIJM6+D+5TPq6PNgw2WhbhPdGAb11uFUeJ5sqxomrshc9l2y2EgL/oU5x7D6FbqOQQWo4wSfasqsNKEDnBFnbSTAn3quy9I7XfBJYZ6QrUVBDaK01XkvPjxOnexoh1SX+tsmiOFBLEBfDJ8NPPoV5lTc1biSvso8M32119/vaG/nMJ3gkArS1OWeJM3PQDJ9ouUFtompK+/LF9l49OSIhYtcCz35gPjVXzvdJMF4R8EPRAbtrO3vUs6o7hpSWfviiyUErLV1Er17ympsiaOMjVFi14westKHBvtFbYusDJWjRrKeRkCWlLt5VjqcFLNx9qVl G1ANoC90 SzUORamd0cg3g+czIlfWFc1EmOP5h/qCQnoAfCp+k2NYj0TsZiEfCG0ENoyPPH1cs8svYs9rvbxflZR+Najaxreigym/gv+7JBqrbzhtiNPpKysYpB33y1TPtFPBXUuipSyRwUgw0oTV94Sy/nVjBk0Rh0/RDik/KvGEYxns3OkSP1jCWw6KjbRXoce6HcUWEzNo+ucMDu7KG5IUf+O4sn3cR/nxT4UyhcSS9m/lh+sErcsBOBDGskvNp4+seYeYfqDp0Rg3dPo3x4itElQ/uGJF3BQSPvkABR6+H3fw0cKmVlRmjCocNpN5dP76rP/oOENiVYHvo6KgCQGeCulvKzwsCQtc/hY/UQbiQnkfsoUbfPD4ICUaumaQee3CXFy1i2iYsXIcr0XJvWZ9ib/dNDQ9VAsTJBo2rjaZOcIJZP0mcE2Q= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 14.08.23 22:01, Hugh Dickins wrote: > Add one more space to FileHugePages and FilePmdMapped, so the output > is aligned with other rows in /sys/devices/system/node/nodeN/meminfo. > > Signed-off-by: Hugh Dickins > --- > drivers/base/node.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/base/node.c b/drivers/base/node.c > index 9de524e56307..8e871ba9162f 100644 > --- a/drivers/base/node.c > +++ b/drivers/base/node.c > @@ -446,8 +446,8 @@ static ssize_t node_read_meminfo(struct device *dev, > "Node %d AnonHugePages: %8lu kB\n" > "Node %d ShmemHugePages: %8lu kB\n" > "Node %d ShmemPmdMapped: %8lu kB\n" > - "Node %d FileHugePages: %8lu kB\n" > - "Node %d FilePmdMapped: %8lu kB\n" > + "Node %d FileHugePages: %8lu kB\n" > + "Node %d FilePmdMapped: %8lu kB\n" > #endif > #ifdef CONFIG_UNACCEPTED_MEMORY > "Node %d Unaccepted: %8lu kB\n" Reviewed-by: David Hildenbrand -- Cheers, David / dhildenb