From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 06A38D216A3 for ; Tue, 15 Oct 2024 13:26:21 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 6AFEE6B0089; Tue, 15 Oct 2024 09:26:21 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 6600B6B008A; Tue, 15 Oct 2024 09:26:21 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 527A26B008C; Tue, 15 Oct 2024 09:26:21 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id 2EA196B0089 for ; Tue, 15 Oct 2024 09:26:21 -0400 (EDT) Received: from smtpin05.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay03.hostedemail.com (Postfix) with ESMTP id 89920A15CD for ; Tue, 15 Oct 2024 13:26:04 +0000 (UTC) X-FDA: 82675910352.05.4FD0964 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by imf14.hostedemail.com (Postfix) with ESMTP id 9C3AF100014 for ; Tue, 15 Oct 2024 13:26:10 +0000 (UTC) Authentication-Results: imf14.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=FrKsNHUr; dmarc=pass (policy=quarantine) header.from=kernel.org; spf=pass (imf14.hostedemail.com: domain of broonie@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=broonie@kernel.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1728998732; a=rsa-sha256; cv=none; b=tYtHloOpWu10A2rgsY27dA0Ej9ELXIFvScQSdrTCpGi1bF+1oPts4VjFogLn5cNAY9iEE7 MlO8QDtxND2wFpvr8v1l4U5XCMDFbJjwcZ8U19jbtFMhxbHMqAVmgp0Cwb1WcbTWEMp4zC vaW4Mbgr/vEDqmRndI3l5vGn39pKhIE= ARC-Authentication-Results: i=1; imf14.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=FrKsNHUr; dmarc=pass (policy=quarantine) header.from=kernel.org; spf=pass (imf14.hostedemail.com: domain of broonie@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=broonie@kernel.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1728998732; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=OLL/FHpOgdkgTUSJ+XP8UQ6hU/ajTm9thb2i8HtEvvY=; b=7THcZKyx8ESF1Dvd9CfC9QrqFmMb/QD92nkHKZz64UfxbJ9l4q0kmiepKxd9rmN9SuKOyK bSRxDE/8ZstsReYzM0xhoFdT0fn0jZSbb8wLamVgjL+7wg/lST1ISCCPF5zDabA9wq5Fvt hO2zIJhmONRQxTR4I/V3dq/LqBtgTzM= Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by dfw.source.kernel.org (Postfix) with ESMTP id 9B8535C5C6C; Tue, 15 Oct 2024 13:26:13 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 3B3CCC4CECE; Tue, 15 Oct 2024 13:26:12 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1728998777; bh=oFFPT5mvvt/DlJJSCGR58VuLSdcKbAv5xgnJpcGR0tY=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=FrKsNHUrBSbtPVikj1FML7vlz2mzC3ZXIoGIfrjrUd5GNlvj7byXhK69OID1comZ3 ERsc0zdXy2HK9A2Z7G99T+h/RV2RmGFRkCXOSx8aShAqDswaIjUsafckOOSl1skiEU I2tf+OBx0u4OvVcY4HsF2UpTQUhJbpZzsK31x/FIIThfUQgmq8SNCnsUS81S2+rnJn JbezWxhO8+rA32VdG2XOwewpI/bX783q2XyJgeqNS477KHazRAG5kVkrecFNa/Tgu6 T9M85n1LAvOk5DzGVWzOFVwwmW+vDtjPlBvN5IHs9Pu+Y+jgPolGy/RrDmde4Rw9M3 Bn4LSqGCTRfig== Date: Tue, 15 Oct 2024 14:26:09 +0100 From: Mark Brown To: Joey Gouly Cc: Will Deacon , Kevin Brodsky , linux-arm-kernel@lists.infradead.org, nd@arm.com, akpm@linux-foundation.org, aneesh.kumar@kernel.org, aneesh.kumar@linux.ibm.com, anshuman.khandual@arm.com, bp@alien8.de, catalin.marinas@arm.com, christophe.leroy@csgroup.eu, dave.hansen@linux.intel.com, hpa@zytor.com, linux-fsdevel@vger.kernel.org, linux-mm@kvack.org, linuxppc-dev@lists.ozlabs.org, maz@kernel.org, mingo@redhat.com, mpe@ellerman.id.au, naveen.n.rao@linux.ibm.com, npiggin@gmail.com, oliver.upton@linux.dev, shuah@kernel.org, skhan@linuxfoundation.org, szabolcs.nagy@arm.com, tglx@linutronix.de, x86@kernel.org, kvmarm@lists.linux.dev, linux-kselftest@vger.kernel.org Subject: Re: [PATCH v5 19/30] arm64: add POE signal support Message-ID: References: <20240822151113.1479789-1-joey.gouly@arm.com> <20240822151113.1479789-20-joey.gouly@arm.com> <47e1537f-5b60-4541-aed1-a20e804c137d@arm.com> <20241009144301.GA12453@willie-the-truck> <20241014171023.GA18295@willie-the-truck> <20241015095911.GA3777204@e124191.cambridge.arm.com> <20241015114116.GA19334@willie-the-truck> <20241015122529.GA3820764@e124191.cambridge.arm.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="VY579BsplRjShns6" Content-Disposition: inline In-Reply-To: <20241015122529.GA3820764@e124191.cambridge.arm.com> X-Cookie: New customers only. X-Rspam-User: X-Rspamd-Queue-Id: 9C3AF100014 X-Rspamd-Server: rspam01 X-Stat-Signature: pffj79aj3uxuant3i9st9cgqcxikuhe1 X-HE-Tag: 1728998770-571726 X-HE-Meta: U2FsdGVkX1/8uo2/NEMScucYZJtA73AkDKOkJpqlljUyDX80JFfi60dWi2hemlpH9BGPkLH1dDL1y8kIonzwGP+pOkd0q0M/8k29egghAS2rXNuMoaUnhUfeke8WO86MZBDmmDmOpFZ++SwQ6ObG6WAJGKNTtJKM4NqP36tC/ZrDq2gkXYFUkxZp9zXq/eNX4n1r8T6nKlzJ2FYYQENeC6FLXjKRB1ilBTCTeKLyNxBATeY81OoD/A5GVwoiH1rOKd1rWKikRMqpawkBgQUOzmCVWPhkI4pKOBcUJqXchzdboiOtk8qjK/A798ntIzhRxEmMBQ3qJumRwFMZ6oY2gea18amzc43gKymMdV+rTUGak1BP1+NkXQal+avI7sO1xd40V/FP8eYiZESt1FeqJhWLU/l0/AQ1dvISIRUXPUP/3KHJZdnMbXT4jvAD6wF03gReJtkqwGAKxMZ/3HQAbKg4JGs8gxt+0ag6FGxwkYsaHwU2XulFrhbShWQEOfOy+0Cbg/9Y0EFMYdrilVR5hm6Cc9SnYJ8EuoYIEY2WR0Tf/5BuO4lsj5NQBPJ5Nnj2fYQ10WYXfznXXhxgu0afhkx12JhkgTHcdnY5iKUUpLt1PgYOMyDbjudqXWgVnBDsdwJl9Er+iVuu1hyPmyLWzCeDEQvOx5vwJGhmuc2lD2PLQ7ZT9yDDQAxlZz8Ix2nwAo/RfTPkCScASgj6QzybPqi/hzNLXdm4v6cKHjAxAX9Dd8abf67cjIEbkvXsjMisdZxNEPLwzZt3T4b+tkyxz9TajWlpLfdnT2V9gzgTDbm30dF28wF4XqCDs+F1uxnKXwzwe+aaRiaJ3v4aNpWKosl5FF+wsfCpGK2AfLOVyxICuUlwBeoaNueMqV349G1SSdRAWXnxVxmgKiTKgIgTr7qgil+mo9+uRDY8fPAYfrCyj0iOHvswGRDDJYt+8r+0U6cy0No5RvBap8PcvEw wyzEmQvM 1/+Def9jXEIjmFUfYa9ButWVnvOxdpN/yHTxjtQcghvwzV8lTQLcOKicZJrSxNNTSRe1c/NtmRbiNBbjdrdnjdtAqNGmV/IHCPePhVyfda5HfE5F2H8haqs9dskks0HdQSZpoz1Ld33RFiCvhNOpfEe7JQQvCCQNPH7ieNUULinzQsyR+0ArligoeGLbni2ss16I1m9+UEeEryQALxg6QLXiG9iZRNv+g1gm63WweZjxN2pBClNASLrAS4+k3ld0eSsVpaZ4bhgozVlHxPF0YwSDyYXc4ELJb7xdX8SUe/VTOUme4uqHhSAdEUw== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: --VY579BsplRjShns6 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Tue, Oct 15, 2024 at 01:25:29PM +0100, Joey Gouly wrote: > On Tue, Oct 15, 2024 at 12:41:16PM +0100, Will Deacon wrote: > > if (system_supports_poe() && err == 0 && user->poe_offset) { > > ... > > which gives the wrong impression that the POR is somehow optional, even > > if the CPU supports POE. So we should drop that check of > > 'user->poe_offset' as it cannot be NULL here. > That was cargo culted (by me) from the rest of the function (apart from TPIDR2 > and FPMR). I think Kevin is planning on sending his signal changes still, but > is on holiday, maybe he can remove the last part of the condition as part of > his series. That's there because the decisions about "should we save this thing" are taken in setup_sigframe_layout() and for a bunch of the extensions we suppress the saving if they're in some sort of default state (eg, when we don't have TIF_SVE set we don't output the SVE sigframe). --VY579BsplRjShns6 Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAABCgAdFiEEreZoqmdXGLWf4p/qJNaLcl1Uh9AFAmcObXAACgkQJNaLcl1U h9Buxgf7B6JxtnaQV7bcQdxU3W/45vjVnsJAj4oq+mBBFjqBV2314SqKcMSBrcJ1 xE3cGR9A04qVmbrPzOkCkiHLXWFD6I/JAZP9eAZGwJXU0Jr8fJWBnXFqDEUdWstw XRJtiGFQkpdq/e0ijRt5DymHm18i/lEE/eg6Zi2o621Abzx9QNS+LMKkn9WpTOk8 W/xOE+DMhh2zpccEJ8VU2HgFJxZ/EcqC/fgkBlJTTApUuvHNdhue2DyBAgzIIsoq 2UYiKeiDTIkN07oUwJ7pRlftHSrLAZyM6WfK8+SZ2rQ1QzhTX8KUz5WzBw3BBpz5 7nn2tj3oFNHFeCRd88yFJnu0JH0lIw== =yrSH -----END PGP SIGNATURE----- --VY579BsplRjShns6--