From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id A0A7CE77188 for ; Sat, 11 Jan 2025 02:10:14 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 1A9636B00A1; Fri, 10 Jan 2025 21:10:14 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 157546B00A2; Fri, 10 Jan 2025 21:10:14 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id F3A466B00A3; Fri, 10 Jan 2025 21:10:13 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id D01C96B00A1 for ; Fri, 10 Jan 2025 21:10:13 -0500 (EST) Received: from smtpin14.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay04.hostedemail.com (Postfix) with ESMTP id 7D83C1A1028 for ; Sat, 11 Jan 2025 02:10:13 +0000 (UTC) X-FDA: 82993541106.14.9A8F474 Received: from mail-pl1-f181.google.com (mail-pl1-f181.google.com [209.85.214.181]) by imf11.hostedemail.com (Postfix) with ESMTP id 85F5740005 for ; Sat, 11 Jan 2025 02:10:11 +0000 (UTC) Authentication-Results: imf11.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b="H/C9HPnz"; spf=pass (imf11.hostedemail.com: domain of zhijianli88.lz@gmail.com designates 209.85.214.181 as permitted sender) smtp.mailfrom=zhijianli88.lz@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1736561411; a=rsa-sha256; cv=none; b=xmdqZDyGjG+wB9rEw6D6w6e/fQ/ZDaG+tc+BxCPr11yRhnAp0rcB34SNexad4BD+2gzq0M zvqYCmf3TuE5oFFAmXUvHD7LJwNEPaia5zvzkFblfcWdBzSxpHKphiVJKOXtWztZnZ0b57 Q0zW3FhlJn68gU5C07lxxIYT+0upiD0= ARC-Authentication-Results: i=1; imf11.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b="H/C9HPnz"; spf=pass (imf11.hostedemail.com: domain of zhijianli88.lz@gmail.com designates 209.85.214.181 as permitted sender) smtp.mailfrom=zhijianli88.lz@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1736561411; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=Ikx4Vevw+NcJa3tECh//u5K0h78SO2S3IuvFw1IpZWY=; b=y58fGi7mCpaR0/P6JlXat8Yiu1fmHpxIVJZ2QxjHLzUTsMOFY03DlWrkf9iUXq7GkMQpYZ JkUsqlKP4UoUYb6qAVcKSzciSltbYViQtLMIwF1rhXKEfhEIHNGafrwqFZKDoU0quXk/rD nwtej5grPzzEUYejTlUCdqg5ZFMw5CY= Received: by mail-pl1-f181.google.com with SMTP id d9443c01a7336-21634338cfdso15527385ad.2 for ; Fri, 10 Jan 2025 18:10:11 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1736561410; x=1737166210; darn=kvack.org; h=content-transfer-encoding:in-reply-to:references:cc:to:subject:from :user-agent:mime-version:date:message-id:from:to:cc:subject:date :message-id:reply-to; bh=Ikx4Vevw+NcJa3tECh//u5K0h78SO2S3IuvFw1IpZWY=; b=H/C9HPnzUp+DaYO16BwRY7dVXBoL0A6RlRSNoBd7PJJHJz5IJjfmHi4FU3TUJjtcmK I/IuC7PapoW3yyPWBCtAu3afdn90aDB9Zs0ubMmyH4rssws4m1RGBjT3vE5EGizlvNam Is/4tW2y+75JLjBcfYTrowedjQ4UvQXL3YUJJBn++bRP2ZbGZFZvFOxvhij9rAdQUU48 QHutbpdca8K7PFqIqpfAVGSJBcCDeSA5ER/TsrDqDR3vThHk1u0VJyXnbelpEJTZSTHS dHljYxt6k1tq4xwtUJNhvrRukmm1w9jdhxYPqUfhdjWybfyIQVbHjhFgf2UgUtFYeRsM y3rQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1736561410; x=1737166210; h=content-transfer-encoding:in-reply-to:references:cc:to:subject:from :user-agent:mime-version:date:message-id:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=Ikx4Vevw+NcJa3tECh//u5K0h78SO2S3IuvFw1IpZWY=; b=ouqQ/grrvcojp9NefZZoZkS40KJXVl8yME5sCloAq3xI2ghYCesm2lxLYJtVgRBKTo eAZ9PD46xtBtUlW9I6XCntpzWhhe0TjOIUwYnWuBEGc9BtbcIbraUQ1aFHBDCmqBxjLp GuRCHSdFUK6Y0Dtyu6dBZcNzn1YHu9CgmoQcfyJdxm5arzlwZ9vG+lfGhXXhH3CZQ6XO QHwGc5VSMgDXoxSTeP8qtnF9NqPcULUl+ZhKAicLy/0BuogKVtTQ0wta0tpEkqyAH6aa 8cMMm171dGXmupgpKo706FVmfjKmGUNuyhsz6mWK1diWzn3dHfWLgno6dOVAWdegaAXf Kv9g== X-Forwarded-Encrypted: i=1; AJvYcCVVG+jbMX8cUpgMmvifv8RAXkUkE0y5wRBhx74RbL3OTIJgP78KTqDTbyDAz2JjeT+YpFgtXe0SkQ==@kvack.org X-Gm-Message-State: AOJu0Yz30JsSy6nzAqkW5iE6Y4lBFgIAwopRwRQSKtYsG4wiYyHtQjj4 4P50L5+o5DtKTAac4IT3lhxiObh3MLaCUYNf74Rjlpn5P5YFS1kG X-Gm-Gg: ASbGnctNGjydbCWa55eDHwO9Vw1XgjkxLu7j8pkEl8KXo3CSkq2Ua9fdbGlf6NFIMee fL7CLQE9FG8jTm/xbSQdyHD7wFPaOqmk08/pb+Zoroae482808SQuk1MUUkokmjltLVQo6fbyLf Nce4DDuLgH9xc1iRKsa57r6jMsydhhQfna/doIS6H5vHcM7T6L8G/Hxkcrh7A9Ei3fQbg1jXI6u u6LyLzy8r9jIEWE6NjJQsWonrmYbXo9eQTgPtFjOBfFtQdasb5ximn81PmJJvxhahar2V+q1/lv PW8LMIgZ/YtV64BoJl78YieFKhZbB2L2lAE= X-Google-Smtp-Source: AGHT+IHleCSawmwVue3HvJfgQ5KvS3wZN5VyhLE1UzPaCRAs7QMUtn7RS2J+206biBhBK28kucIBeQ== X-Received: by 2002:a05:6a00:3c83:b0:71e:4296:2e with SMTP id d2e1a72fcca58-72d21f4bc9emr17796023b3a.11.1736561410185; Fri, 10 Jan 2025 18:10:10 -0800 (PST) Received: from ?IPV6:240e:3af:e05:c460:74c2:d24d:3e6:13f6? ([240e:3af:e05:c460:74c2:d24d:3e6:13f6]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-72d4067edf0sm2189684b3a.133.2025.01.10.18.10.05 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 10 Jan 2025 18:10:09 -0800 (PST) Message-ID: Date: Sat, 11 Jan 2025 10:10:05 +0800 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101 Thunderbird/91.3.0 From: Li Zhijian Subject: Re: [PATCH] mm: vmscan : pgdemote vmstat is not getting updated when MGLRU is enabled. To: donettom@linux.ibm.com Cc: akpm@linux-foundation.org, aneesh.kumar@kernel.org, hannes@cmpxchg.org, kaiyang2@cs.cmu.edu, linux-kernel@vger.kernel.org, linux-mm@kvack.org, mhocko@kernel.org, muchun.song@linux.dev, rientjes@google.com, ritesh.list@gmail.com, roman.gushchin@linux.dev, shakeel.butt@linux.dev, weixugc@google.com, yuzhao@google.com References: <20250109060540.451261-1-donettom@linux.ibm.com> In-Reply-To: <20250109060540.451261-1-donettom@linux.ibm.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Rspamd-Queue-Id: 85F5740005 X-Stat-Signature: z8x18hgoqc6dy7nkghbj8i47esjswpir X-Rspam-User: X-Rspamd-Server: rspam09 X-HE-Tag: 1736561411-183322 X-HE-Meta: U2FsdGVkX18h1CKb/3xkn6np1WWsMNS4pQCzTUX2bEKYw9TTmtCdpY7/MH/TUcPkjYz4CgtBoIicjZ760AMKMiJpSkNcK+18Gj8kosza12qNYl2/bFa3rRTOuDX4NCfNzKY5vH247IBMZgGytgVYPfwf/Csfu8SSgltuX5zJxBZZ1aHfYrHVgv2lP7140ER+pQhUS5HD2ox3GFQ89WS64zp6Ycw0zUQRATEIxqAUvUB6IrP7rWrb+zbb+YUclvSPtFOWHEPbQ8S83WdvPJnY/zd4uwiz42vZ1YfeyBXTD2adp5s7q/zwoOrMsry9BPl7o+/to31Gge1fTT+Tz3QF9lhef6u11FiVlkgIUNpfKtcBhekfb5p301xJ49C5iPcOS8a/iXhopk1OgfC8pIRZGH2ouBPYmx9C1qLVHv84A3jH4negsE4Pl3dzq1btU+13Dc4BlHfc0JrqeEr2MGfd5znCQfP7XQHWfRcqLLWFG65W58P2nclKiTZqZ/bsjDAzjdK7wa9USxcdhEH/Ev0kocH1lFC6mXLQGpgK5ajuYm2x5pt8XubTcR+1g47IVI+Yv3KasNtk9C6gl37EAGXXOhNZZINZXZQHIqvBEJhdUDGMAKOOcckl2MzcJQ+TMJ3HszZ6hxwwx4YPGrj0k1pOElmHaLFN9QaSbsgavXc4RXXOsh4+FfHyKMmMPycJ5vnCmZEmtHpdJ3bsCelaaInRYv7uWx2orTq9R6bia+0vzffpGmHxLoI+noq61dgrAnMuT9+AuGUZoYEWTyRqpsFBsxpCRsWaF//P2hfPkMa94d1w9QGFPxE09NQab+87W9Au+TW3MveGSBUvybTdC1VU7ChlOheJh0O1GHA6i4HjEWVYsz5EIg3svbVzChwe0JaNCYnnlt+vPRcgg9QDbv+RZoLjS247OTt5o5BOYBEaL6UpO09R/xwAUHHy6FFtHZEJk+7x55ky8FgoDvxki7f XfBdpR61 f2cnyf70CGVF+uAHXNCJzeDoYso9Qm7e7I9OdDR2BxnDJZIeey2Owo7cA0dlUEQDLTfkK7JA90iWzzWjZoY22jTAeEOVsdVwbIUj0NAvxKVBiTJxdrTOSHmdSR3XK5FTjwQKaCJ0UDGRQiE363wUcVwKxLA23TtkIseJMdrvvY910mpo+acntQWBXEogLZtfiRZ4qffySJSxvR3Ek+7KO+AQO1Gn4p0fOEObu6GiRrE8AcNLHLIWqLHya2wFqDSSq7k8e7z264SfTRjWYpyCVha+CXzUhYf712hYg+DA41FtZlaiPXh4JoNvJccapku+otKltSJh4orjvsoghPtk9XmuJZ0NLJ4yCrP0JdS/v9iy4108mMegQBM/PpMpTc43D/5CmTcdKDkw5RbD/OqDIy4POtWLzKv9hwY3yLJiffFv2T70C8qt9UVYxF9d58Xm55q0kQg3ufsfZ7sMFCbNSXKvkClG+EuoPdKpoctuNdKYZPrW5od3ls0YugQvVCppuy0OYJDFbe5kpHPaG5ohBTMRJqGDLdhnm0gL8 X-Bogosity: Ham, tests=bogofilter, spamicity=0.001468, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: > When MGLRU is enabled, the pgdemote_kswapd, pgdemote_direct, and > pgdemote_khugepaged stats in vmstat are not being updated. > 'Commit f77f0c751478 ("mm,memcg: provide per-cgroup counters for > NUMA balancing operations")' moved the pgdemote vmstat update > from demote_folio_list() to shrink_inactive_list(), which is in > the normal LRU path. As a result, the pgdemote stats are updated > correctly for the normal LRU but not for MGLRU. > To address this, we have added the pgdemote stat update in the > evict_folios() function, which is in the MGLRU path. With this > patch, the pgdemote stats will now be updated correctly when MGLRU > is enabled. > Without this patch vmstat output when MGLRU is enabled > ====================================================== > pgdemote_kswapd 0 > pgdemote_direct 0 > pgdemote_khugepaged 0 > With this patch vmstat output when MGLRU is enabled > =================================================== > pgdemote_kswapd 43234 > pgdemote_direct 4691 > pgdemote_khugepaged 0 > Fixes: f77f0c751478 ("mm,memcg: provide per-cgroup counters for NUMA balancing operations") > Signed-off-by: Donet Tom Great minds think alike, It's excatly same with mine[0] :) There is another bug[1] as well. [0] https://lore.kernel.org/linux-mm/20250110122133.423481-2-lizhijian@fujitsu.com/ [1] https://lore.kernel.org/linux-mm/20250110122133.423481-1-lizhijian@fujitsu.com/ Feel free to add vvv if your patch is accepted at last. Tested-by: Li Zhijian Reviewed-by: Li Zhijian > --- > mm/vmscan.c | 3 +++ > 1 filechanged , 3 insertions(+) > diff --git a/mm/vmscan.c b/mm/vmscan.c index 9a859b7d18d7..b1ec5ece067e 100644 --- a/mm/vmscan.c +++ b/mm/vmscan.c @@ -4642,6 +4642,9 @@ static int evict_folios(struct lruvec *lruvec, struct scan_control *sc, int swap reset_batch_size(walk); > } > + __mod_lruvec_state(lruvec, PGDEMOTE_KSWAPD + reclaimer_offset(), + stat.nr_demoted); + item = PGSTEAL_KSWAPD + reclaimer_offset(); > if (!cgroup_reclaim(sc)) > __count_vm_events(item, reclaimed); > --