From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 61FB8C7EE29 for ; Fri, 9 Jun 2023 14:13:41 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id AE48F8E0002; Fri, 9 Jun 2023 10:13:40 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id A94566B0074; Fri, 9 Jun 2023 10:13:40 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 95C438E0002; Fri, 9 Jun 2023 10:13:40 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id 85E4B6B0072 for ; Fri, 9 Jun 2023 10:13:40 -0400 (EDT) Received: from smtpin05.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay05.hostedemail.com (Postfix) with ESMTP id 4C02C4023E for ; Fri, 9 Jun 2023 14:13:40 +0000 (UTC) X-FDA: 80883402600.05.37A7E91 Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.220.29]) by imf07.hostedemail.com (Postfix) with ESMTP id 46EFF40025 for ; Fri, 9 Jun 2023 14:13:36 +0000 (UTC) Authentication-Results: imf07.hostedemail.com; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=mWfd2jGP; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=i6XCCETL; dmarc=none; spf=pass (imf07.hostedemail.com: domain of vbabka@suse.cz designates 195.135.220.29 as permitted sender) smtp.mailfrom=vbabka@suse.cz ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1686320017; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=EtCyiVu2vrNYD7+a3LLENhPd+fG3ceJq5lPu0t9scBU=; b=3EtVbnOdE9tqtFPhvqKJDyzL96kfsV+jIsflUkWk/DVvS9lengNm5ZsLATvQdpefg9+i52 Z8Kbfpjy4rN9KbIgEsqc1t49tYOnw48OUElIxE2tRN36IuAzaxPy3zUqddX9MOn73sv9ri GL1JjN7IPn/yraSf/QGFXCmDZi6Ycw4= ARC-Authentication-Results: i=1; imf07.hostedemail.com; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=mWfd2jGP; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=i6XCCETL; dmarc=none; spf=pass (imf07.hostedemail.com: domain of vbabka@suse.cz designates 195.135.220.29 as permitted sender) smtp.mailfrom=vbabka@suse.cz ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1686320017; a=rsa-sha256; cv=none; b=t5oN8561dx37zVbZ6trYEzBndr/fDHCEEgbx6B41PIJbFo9dBv+R3xCrGI+Xx49f6QmuMM +A4EatfTDmUIu9BUx+IW2X6VW4tEFjGVHSwJGlSLg/M3ZZGHQXtgziz6Uvn37wO85sv3+y TvKu0RVxYwr5Gj7gMcewXCtAo7YC3uQ= Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id 75EF11F8D9; Fri, 9 Jun 2023 14:13:35 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_rsa; t=1686320015; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=EtCyiVu2vrNYD7+a3LLENhPd+fG3ceJq5lPu0t9scBU=; b=mWfd2jGP/o7si/6LC2qem858XLbwEj939oXQ4YZD7I6QsbCg9XQ1klwDbMA3G69OjB2snM Hv/xd5Z1oL/CUNkPXdP3e3yvJjGpOMwt9N4DRwkgPraSBSp8j9NYOZnojJbztT8dDb0ZbK AlB+45Tw8xXsVM55Cz5EDDoCJ09d3do= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_ed25519; t=1686320015; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=EtCyiVu2vrNYD7+a3LLENhPd+fG3ceJq5lPu0t9scBU=; b=i6XCCETL3BB4gNqqNNqvquozkaBKpm7qMaB7Tl6R3CyKeJQgTYewmRGVgsvZuRCuI6nIG9 mgVSjYpZrsOVCvCA== Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 21FBF139C8; Fri, 9 Jun 2023 14:13:35 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id nX2JB48zg2S4ZwAAMHmgww (envelope-from ); Fri, 09 Jun 2023 14:13:35 +0000 Message-ID: Date: Fri, 9 Jun 2023 16:13:34 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.11.2 Subject: Re: [PATCH v6 01/17] mm/slab: Decouple ARCH_KMALLOC_MINALIGN from ARCH_DMA_MINALIGN Content-Language: en-US To: Catalin Marinas Cc: Linus Torvalds , Christoph Hellwig , Robin Murphy , Arnd Bergmann , Greg Kroah-Hartman , Will Deacon , Marc Zyngier , Andrew Morton , Herbert Xu , Ard Biesheuvel , Isaac Manjarres , Saravana Kannan , Alasdair Kergon , Daniel Vetter , Joerg Roedel , Mark Brown , Mike Snitzer , "Rafael J. Wysocki" , Jonathan Cameron , linux-mm@kvack.org, iommu@lists.linux.dev, linux-arm-kernel@lists.infradead.org References: <20230531154836.1366225-1-catalin.marinas@arm.com> <20230531154836.1366225-2-catalin.marinas@arm.com> From: Vlastimil Babka In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Rspamd-Queue-Id: 46EFF40025 X-Rspam-User: X-Rspamd-Server: rspam04 X-Stat-Signature: rezompgr9exynb459g9drucmncatnkdr X-HE-Tag: 1686320016-274186 X-HE-Meta: U2FsdGVkX19RTaNHw29B4fiTGfBPdlsk+8nNfg0dxsQ/8RAsq+z5efLAnRnq/fLe4pYGWoIpfG1wQtQtNBYn69SEIHZtUqxdOjrQKfmdQp6JPnu26MPiQOfI0QVK7lwu3qt1Vsmp+uUYk6XHW7iMI/oNlOp4wuzKsB2+Mn5V11oeHosYQxeFGHKrQ8eum3OAsFg2OlS8UKd661QCXQhJbNN+Ue0Nh6v8jx2fIQaOr6D48mqM6f4IMdBOTW7QevuQQSiwLRvuMWDwYVOzSS5G/bNkk3kyaNnfBW7QF5MiemxUZ53qdikekktl+yr+4FZRQJ0332QmjuhA9e/yv/FD2WyI3aGa305D+0EIFXPgXKGotfWtIrGjtrIIV3aMP6hKpw00S0GHwFJ/Dxo7qVHf6b1Fno4zHLeiRFYVvbZWKJNK+Evhn9jl5TMVdFEI0oe/1+M82IajHpYeo4ITaFgzTNoc7AsPoRgNgsCPBMnuJx/JAvR7KGa8zvjwy/+KSw4Q0pi2Ggc89dE+1l7AP8uNRx8i6ofyv0B5oXECWkxhhGV+0tEuU5Z8fD8PZinWKIScgKbEJTuZNDTM+b3GGoQG1vwq//1yVeg8MvCBr2san0LP0B301uS4ZEb7QA2oqbCvFlnxxyUiEZx395b/EY2iVIToTWt6TmOlb8xWzxukE3+nk429cA3OBVFp9C/BpkCVcK62bL8p1O9o0YOqAaYZflvvBTsHBmxR4R0l2WNeIsSYCnEp3W92Cu3KL0oblu17Levgx9FSuDX10QnEHo+vMdeiG0sFsv0Okmcp+NQl1+iiMAXaGQlT+gOWLV+jw+01I8OQmV98GI1dFXFT1rJq1clbp+j1EBEc5eyXXiYEfzmJvzgOU6vuwmofAM0CGDbnUA0LUIxmk401qoR9NQLU0PTwIuvy45BUdxsQujP1dxlw+iKw9r/yy1G/qICc3iScZFnc5rBPUjzQnUxHNFF 8MSRyWHk 8FhgWmMF+FyjrZBlJNqBDDtwudLM/5b3C2Lp0hpEAurkviNpZ15uEkzU2dkoh+xildg37VAxZ3M1Y9Znve0RUa6iMc1MU6WM8hQ8/262dVIQpMa+Kxwtf7yXGG6iSLc8/KesPO3QHt5Vx+NIkpmEuU7mWGJU4Slv1TBg3m2Y+ajF5exs03gv8Q/tlZb43kxHXza8OVoxqPSskapT8XXssFjs0Kmyvng5vvjbpqqwiupqKO9FSI++syVJXWw== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 6/9/23 15:57, Catalin Marinas wrote: > On Fri, Jun 09, 2023 at 02:44:01PM +0100, Catalin Marinas wrote: >> On Fri, Jun 09, 2023 at 02:32:57PM +0200, Vlastimil Babka wrote: >> > On 5/31/23 17:48, Catalin Marinas wrote: >> > > diff --git a/include/linux/dma-mapping.h b/include/linux/dma-mapping.h >> > > index 0ee20b764000..3288a1339271 100644 >> > > --- a/include/linux/dma-mapping.h >> > > +++ b/include/linux/dma-mapping.h >> > > @@ -545,7 +545,7 @@ static inline int dma_set_min_align_mask(struct device *dev, >> > > >> > > static inline int dma_get_cache_alignment(void) >> > > { >> > > -#ifdef ARCH_DMA_MINALIGN >> > > +#ifdef ARCH_HAS_DMA_MINALIGN >> > > return ARCH_DMA_MINALIGN; >> > > #endif >> > > return 1; >> > > diff --git a/include/linux/slab.h b/include/linux/slab.h >> > > index 6b3e155b70bf..50dcf9cfbf62 100644 >> > > --- a/include/linux/slab.h >> > > +++ b/include/linux/slab.h >> > > @@ -235,12 +235,20 @@ void kmem_dump_obj(void *object); >> > > * alignment larger than the alignment of a 64-bit integer. >> > > * Setting ARCH_DMA_MINALIGN in arch headers allows that. >> > > */ >> > > -#if defined(ARCH_DMA_MINALIGN) && ARCH_DMA_MINALIGN > 8 >> > > +#ifdef ARCH_DMA_MINALIGN >> > > +#define ARCH_HAS_DMA_MINALIGN >> > > +#if ARCH_DMA_MINALIGN > 8 && !defined(ARCH_KMALLOC_MINALIGN) >> > > #define ARCH_KMALLOC_MINALIGN ARCH_DMA_MINALIGN >> > > -#define KMALLOC_MIN_SIZE ARCH_DMA_MINALIGN >> > > -#define KMALLOC_SHIFT_LOW ilog2(ARCH_DMA_MINALIGN) >> > > +#endif >> > > #else >> > > +#define ARCH_DMA_MINALIGN __alignof__(unsigned long long) >> > > +#endif >> > >> > It seems weird to make slab.h responsible for this part, especially for >> > #define ARCH_HAS_DMA_MINALIGN, which dma-mapping.h consumes. Maybe it would >> > be difficult to do differently due to some dependency hell, but minimally I >> > don't see dma-mapping.h including slab.h so the result is >> > include-order-dependent? Maybe it's included transitively, but then it's >> > fragile and would be better to do explicitly? >> >> True, there's a risk that it doesn't get included with some future >> header refactoring. >> >> What about moving ARCH_DMA_MINALIGN to linux/cache.h? Alternatively, I >> could create a new linux/dma-minalign.h file but I feel since this is >> about caches, having it in cache.h makes more sense. asm/cache.h is also >> where most archs define the constant (apart from mips, sh, microblaze). > > Something like this (still compiling): Yeah that would be great!