From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9E67CC001B0 for ; Mon, 7 Aug 2023 15:36:53 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 2AA006B0074; Mon, 7 Aug 2023 11:36:53 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 259746B0075; Mon, 7 Aug 2023 11:36:53 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 0F9FD8D0001; Mon, 7 Aug 2023 11:36:53 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id F381E6B0074 for ; Mon, 7 Aug 2023 11:36:52 -0400 (EDT) Received: from smtpin04.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id 9156C160765 for ; Mon, 7 Aug 2023 15:36:52 +0000 (UTC) X-FDA: 81097711464.04.D1E90B0 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by imf02.hostedemail.com (Postfix) with ESMTP id 2D2F380011 for ; Mon, 7 Aug 2023 15:36:49 +0000 (UTC) Authentication-Results: imf02.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=dlHOSv66; spf=pass (imf02.hostedemail.com: domain of david@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1691422610; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=wCM0LSVABzEid+9ZFB8RVu58baVBQ5wmkVT334cAYKs=; b=4SBJX663p8oGb2aA2jgSIIh78HOWpEbujoF0nzASE28GQV8kiMbGRKFbpy1k4q8cXXC+/d 3sNljbGA0btoE2iJ8RqogaxHWpqK9XdKf/7/djbGVoqxLgx+CdyP11CMmsL7DXAGyHedgA wefwMmRokPEoreUbVXN9al04MrO+6nw= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1691422610; a=rsa-sha256; cv=none; b=iXcdDqWdMXT3z3KPchXQgfYdlx6TrOSOCs5rifI5C+VuU3SIeZL4YwsBXVIdSern5pFduO S9hdAJTekB7DnaMfZCKuG+rXr1BuhHFtCqP23XK/RMWZaAaC9uBesxa/hfr8LUMoWJtWVV 1f0QF8fOzS4yHqkPHqimX33nXLadlNc= ARC-Authentication-Results: i=1; imf02.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=dlHOSv66; spf=pass (imf02.hostedemail.com: domain of david@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=none) header.from=redhat.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1691422609; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=wCM0LSVABzEid+9ZFB8RVu58baVBQ5wmkVT334cAYKs=; b=dlHOSv6650uKMK7y6IFub5qerDl7w/6oHXuqCiC2rXK7mXr0JaPfo+E0c0YD8ioIr4HVmD Wl46VYkPR4tWQsXn+AIpaqy3XaIATCi2jUq7G4GuJ6ctQVWbQmfcPq7ObIiTPefN+sRH7z AfSheYF0HQNqc6MtYoAU+1yfNmHdYk0= Received: from mail-wr1-f71.google.com (mail-wr1-f71.google.com [209.85.221.71]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-265-yoJmkRnoMwqwg-GBjBeT7w-1; Mon, 07 Aug 2023 11:36:48 -0400 X-MC-Unique: yoJmkRnoMwqwg-GBjBeT7w-1 Received: by mail-wr1-f71.google.com with SMTP id ffacd0b85a97d-3176549261aso2508591f8f.3 for ; Mon, 07 Aug 2023 08:36:47 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1691422607; x=1692027407; h=content-transfer-encoding:in-reply-to:organization:from:references :cc:to:content-language:subject:user-agent:mime-version:date :message-id:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=wCM0LSVABzEid+9ZFB8RVu58baVBQ5wmkVT334cAYKs=; b=VOyeA72VBnAc7G7yfycJQ//cNBFkMgmdHQUDAjCHjzfbA2F8TOtc61kND2zYDz9Uxd xUiv2aYyFYvddfbxN8hDN56fxxsb3Ppv18Ab/ryexLO9C03qywT3aAhge5NlTP7K+r6R BOIKYqGYiEx0lfzaQaR+/pEuuk8mvWrisxLCS4hS/Q+gZ7NmBfOKH6D3TVv3oLhlqsh0 aN3RuqMKUbDZmrhgMaYCq8oOL3Zx9UgCIqnQGt0WNTjFgxE5xj8rmDpcleY4Zun6U7MN pMXctUi+Qi/lyh/VckqzvfK12ziDiHNf5gtA7uc6gAmP0PKg4bbqQen0aJ0p0yL+bJoG Cpzw== X-Gm-Message-State: AOJu0YxVCevTQ8PaDKrFKYrZPJ1LCnpEsJufRw68pqSE6YIEe7PYP9yc /qK0iBbfUhs6tfwB3kWnX7uGCzxSkH35GAQ2T6G/qArzoCpiaM+Vq9elxT7qz+ia/jUq8WAMDNT oZd548fPUvuLjB8LfWQs= X-Received: by 2002:a5d:4085:0:b0:315:96ca:dcab with SMTP id o5-20020a5d4085000000b0031596cadcabmr7337369wrp.35.1691422607007; Mon, 07 Aug 2023 08:36:47 -0700 (PDT) X-Google-Smtp-Source: AGHT+IFazJ0hQvyp0w7nVsyclbNvRXnBSHlJEwsegobzfYo7VP5sfkvDEV8yiWkWqkqGh7ZbhT/yBw== X-Received: by 2002:a5d:4085:0:b0:315:96ca:dcab with SMTP id o5-20020a5d4085000000b0031596cadcabmr7337347wrp.35.1691422606590; Mon, 07 Aug 2023 08:36:46 -0700 (PDT) Received: from [192.168.3.108] (p4ff234da.dip0.t-ipconnect.de. [79.242.52.218]) by smtp.gmail.com with ESMTPSA id s1-20020adff801000000b00314417f5272sm10811517wrp.64.2023.08.07.08.36.45 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 07 Aug 2023 08:36:46 -0700 (PDT) Message-ID: Date: Mon, 7 Aug 2023 17:36:44 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.13.0 Subject: Re: [PATCH v3 7/7] selftest/mm: ksm_functional_tests: Add PROT_NONE test To: linux-kernel@vger.kernel.org, Andrew Morton Cc: linux-mm@kvack.org, linux-fsdevel@vger.kernel.org, kvm@vger.kernel.org, linux-kselftest@vger.kernel.org, Linus Torvalds , liubo , Peter Xu , Matthew Wilcox , Hugh Dickins , Jason Gunthorpe , John Hubbard , Mel Gorman , Shuah Khan , Paolo Bonzini References: <20230803143208.383663-1-david@redhat.com> <20230803143208.383663-8-david@redhat.com> From: David Hildenbrand Organization: Red Hat In-Reply-To: <20230803143208.383663-8-david@redhat.com> X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Rspamd-Queue-Id: 2D2F380011 X-Rspam-User: X-Rspamd-Server: rspam11 X-Stat-Signature: iqbaxw7gzacjw88wa65x68q4y57ekoc5 X-HE-Tag: 1691422609-92789 X-HE-Meta: U2FsdGVkX18NH4/K6bpH7mUxHHSgPMowNrJYjBx6DlSHQu2Nq3SbwDfqYteov/rlL0ZBBaT8xM/3bZmkIvL+IOIapDGFtca8/Ibv0nn2avVgGEuBerywy7yJU+WfCHR/QZwtYVuCi2lguXJFUwg3FTbC4sny0r2J5Wr5AAjgBMW2jmigNgTkTF4EywdIBcfWUhevsu1kYLViypfDtAJH1Lx2OoLSbQ2E40VtL8g7hRikEUFFlqPgC2ielH/sItHgJA1DRameqywm95yjTy5VqSrofMgXEbBPB6p+ufzdufVw4bZ07nQu2ZNZGXFFOn93bdL3Q2nE3W1tUBxc+vFjWyDn/qXBUO3RhxWCAUqOPyVzfpBWCArEwpWgqvizbnOOaouW/eEKLCw6qKl9yn/QDnvI5QlVtUyLvkNJg1088nYoNoGFlFAU50b3rD3tA2XqX808cKXXKiZ1CzcWfiJVp9cgi9lR7aD45JwlZ/VlqIvnHt+wsgm9wZO2nPq1alqWW0tQmF/16qoWpqOL/BRQs6aL/Gm8Kb0PfW5GcFCtf+yCLAUO6aslk7XrORcyhJjr+V6Qqt85Vels0/AUr+b4cEkYX2hDPRaSqJ8aVdOHq18hDu5TE0twmSzqfkwutWLHebuMjmKJ9wsImpATW8dMlLvtrwMGwpZtYAwGF8iQXDpqo/4iCSL+emlFdFC8BuHD0+qrALy9pJ/HWgz+TQUNdcHNgL5qYkioE+OItOje82elNHBeDQPkor11KP9yS2UwmPwzkitxFBE7f8z0r747n08UXrJKyMF0l/bG10vnljeL4aAoxyPe+iL9AIOEJDu+EJSVrYac8j3S4NP9k37UhsQtu44xQ1rwGgnPKwK5Vwllthbm6zThiMPo5RP7uUGZ5j+qo7Fre5c5bLSAapEHu0da0vO6oBvV1pwx1qiRYSzRat/q7AAdUfNYdP5xOz0Je/P9ve5acog2hEcWK6C HES8fDoz GaoYjSPDYzrLNSk+OnaDIvtV22DEjPLwUaB42bruET0RE4DpSmIwuSKnk/pSJ7sPRmSc50D/fPSbW/yGP6/3RULD/gXjKr9fNIHTu96RzOmrJDC3TE1hCWXr8qeJmpr2KYMkn68X20Xc5nwAZFXPEwHZ06k8ZMBeqKx/xTH/5gQUivGV3lurtAokXgzDAEHSFbhWbmxLozx8CFX/zEwihvmkelsCG2qeV/RR2Lav3NjIFGlw3yDdfgb24tzJ9/86e6Be8PMzFSEJ72JfiJ/1x8pPUE7iYyiog2O2EDQGKGJcMuDbJ3II7itcILYZUt991hlS5gfl/2yDmFxa/jQXZZq39CqfJV/i0t9wbKocBCh2szDdXzNK5BY/ZssDZ0EWjF2e1TgNQOmmoCjdN4B3c3EJcwa6yHBKWr8BpRyHTKIbp9sq9fpRmdZ/qb2HjyOtdkiQzxJA2B/KxxB4iiyzayJ9NMpxpUCDiO4GL X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 03.08.23 16:32, David Hildenbrand wrote: > Let's test whether merging and unmerging in PROT_NONE areas works as > expected. > > Pass a page protection to mmap_and_merge_range(), which will trigger > an mprotect() after writing to the pages, but before enabling merging. > > Make sure that unsharing works as expected, by performing a ptrace write > (using /proc/self/mem) and by setting MADV_UNMERGEABLE. > > Note that this implicitly tests that ptrace writes in an inaccessible > (PROT_NONE) mapping work as expected. > > Signed-off-by: David Hildenbrand > --- Andrew, can you squash the following? From c2be7c02cb96b9189a52a5937821600ef4e259bd Mon Sep 17 00:00:00 2001 From: David Hildenbrand Date: Mon, 7 Aug 2023 17:33:54 +0200 Subject: [PATCH] Fixup: selftest/mm: ksm_functional_tests: Add PROT_NONE test As noted by Peter, we should be using sizeof(i) in test_prot_none(). Signed-off-by: David Hildenbrand --- tools/testing/selftests/mm/ksm_functional_tests.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tools/testing/selftests/mm/ksm_functional_tests.c b/tools/testing/selftests/mm/ksm_functional_tests.c index 8fa4889ab4f3..901e950f9138 100644 --- a/tools/testing/selftests/mm/ksm_functional_tests.c +++ b/tools/testing/selftests/mm/ksm_functional_tests.c @@ -516,7 +516,7 @@ static void test_prot_none(void) /* Store a unique value in each page on one half using ptrace */ for (i = 0; i < size / 2; i += pagesize) { lseek(mem_fd, (uintptr_t) map + i, SEEK_SET); - if (write(mem_fd, &i, sizeof(size)) != sizeof(size)) { + if (write(mem_fd, &i, sizeof(i)) != sizeof(i)) { ksft_test_result_fail("ptrace write failed\n"); goto unmap; } -- 2.41.0 -- Cheers, David / dhildenb