From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id F280FC001DC for ; Wed, 26 Jul 2023 19:20:51 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 270206B0071; Wed, 26 Jul 2023 15:20:51 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 1FEE58D0001; Wed, 26 Jul 2023 15:20:51 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 04A566B0074; Wed, 26 Jul 2023 15:20:50 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id E54B96B0071 for ; Wed, 26 Jul 2023 15:20:50 -0400 (EDT) Received: from smtpin01.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id ABCBCC03A4 for ; Wed, 26 Jul 2023 19:20:50 +0000 (UTC) X-FDA: 81054730260.01.170A6C8 Received: from mail-wm1-f52.google.com (mail-wm1-f52.google.com [209.85.128.52]) by imf23.hostedemail.com (Postfix) with ESMTP id A6519140005 for ; Wed, 26 Jul 2023 19:20:48 +0000 (UTC) Authentication-Results: imf23.hostedemail.com; dkim=pass header.d=gmail.com header.s=20221208 header.b=eoqi2tQD; spf=pass (imf23.hostedemail.com: domain of ttoukan.linux@gmail.com designates 209.85.128.52 as permitted sender) smtp.mailfrom=ttoukan.linux@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1690399248; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=SU5w/Qd+Q2s6pTNTUx/bglHlSYRuAA+mciT7JmjRh4Q=; b=4F6tf6ISAAbxx49ZqVS12y3daUl8+edab0hgezOa7RrRJzjwNR07GpEZurhEQFfJL04pOY 8UR09HEPAWQefEFb8YawnnMQeQUC9X4wFpqmOQzFPvNYetfKsdnJfaV9ybIdsdXd68s/1G Xlc7yw+nCRPVb2hqQkat6CD7suckw24= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1690399248; a=rsa-sha256; cv=none; b=FqahD1RTSHCrQSv86a8AbyrLXnd6mFBozmVT8Qtt3HYdW95r/j7ie4NUAjJ7J+A8PHbt1r jemxbUF2+t6E8q433c1OceJoROhedyokRqiSpXHFksbxGz5t4jXCifPdCmy1MW93dM8ltP eAfz6zN6zjZk/sblX4OR+T4NJs4sFFo= ARC-Authentication-Results: i=1; imf23.hostedemail.com; dkim=pass header.d=gmail.com header.s=20221208 header.b=eoqi2tQD; spf=pass (imf23.hostedemail.com: domain of ttoukan.linux@gmail.com designates 209.85.128.52 as permitted sender) smtp.mailfrom=ttoukan.linux@gmail.com; dmarc=pass (policy=none) header.from=gmail.com Received: by mail-wm1-f52.google.com with SMTP id 5b1f17b1804b1-3fbfcc6daa9so818735e9.3 for ; Wed, 26 Jul 2023 12:20:48 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1690399247; x=1691004047; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=SU5w/Qd+Q2s6pTNTUx/bglHlSYRuAA+mciT7JmjRh4Q=; b=eoqi2tQD/6t5XYrmp8b4wsx9lND/kXSpo3WDzgeBYvmGmX8P0Qbv9v7pDii13+pyfd ER0K4tqBLphE04ZvAen5YdS1W0X1OBqgYPjwYZNF9l4seZ+oVg3f3Wvoofn7LEg6K6En /CdCtVnq50U+RI2LK6KD1tvDN5gfFJCL9qy+DBqSF9Ug8+PG0K0ekDURaqkHa3eAJoSq aSFL4/zvZxnGjG0iXbDYoPJ8Pw2hA+1skJ+X+eOS0HgX5l6DwLaWRT8BDboDgh/LOhh3 ufkWtTbCRp5fKH7T3EtwgN0c9JqUb+re9tVFoOESHeVAXxYlwkIGDrBn9wel/6xHfbOt AU8A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1690399247; x=1691004047; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=SU5w/Qd+Q2s6pTNTUx/bglHlSYRuAA+mciT7JmjRh4Q=; b=QbhgwERBzvq5U3P/htOoqaA3vULmEDzbk5mSJ6ai++ScWR5vPLbmnZfvs3Yvruz8pl TN+mah1/Sm9cO3AtkEsmNZgcqVFVT8iju3O7VkxbvVGaDQqSFkNz1PulUrJgMvk1pI9/ IQTj3u+GkEvJxIlW2g+DAu6L+o+T+Bn0HQIUMVIpKKp9KFxf/Zc9/OT0ACo4RfvfLHEu U6sqOiDWwczvbuZtf/+N2RSC7WG+Y4+iA77xoAZ6at/VTZyUVH7e6hEhiQcS17DFNDsS I+wGDPXhX6pr++q3ydv4QUBD6RL2dWfg/bCeV8U+/+XqmeXG9r5hnQINCNz85dZs9KuH LKAw== X-Gm-Message-State: ABy/qLbZS4AdvyTACbaoLS3YBgRBhp6sV/dpr7AbHwS0vbLYBOtKly5C i7iW6mETbX1aYakitECgxng= X-Google-Smtp-Source: APBJJlHBRtroaMd2u/pxowsVAjxlt8UGtzJgYXLG5mldxeUG4NiXgFfvruege631QAMLsz2xk70BvA== X-Received: by 2002:a05:600c:2181:b0:3fa:98c3:7dbd with SMTP id e1-20020a05600c218100b003fa98c37dbdmr10406wme.41.1690399246785; Wed, 26 Jul 2023 12:20:46 -0700 (PDT) Received: from [192.168.0.103] ([77.126.7.132]) by smtp.gmail.com with ESMTPSA id c22-20020a7bc856000000b003fbd0c50ba2sm2782413wml.32.2023.07.26.12.20.43 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 26 Jul 2023 12:20:46 -0700 (PDT) Message-ID: Date: Wed, 26 Jul 2023 22:20:42 +0300 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.13.0 Subject: Re: [PATCH net-next v10 08/16] tls: Inline do_tcp_sendpages() Content-Language: en-US To: Jakub Kicinski Cc: David Howells , netdev@vger.kernel.org, "David S. Miller" , Eric Dumazet , Paolo Abeni , Willem de Bruijn , David Ahern , Matthew Wilcox , Al Viro , Christoph Hellwig , Jens Axboe , Jeff Layton , Christian Brauner , Chuck Lever III , Linus Torvalds , linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org, Boris Pismenny , John Fastabend , Gal Pressman , ranro@nvidia.com, samiram@nvidia.com, drort@nvidia.com, Tariq Toukan References: <4c49176f-147a-4283-f1b1-32aac7b4b996@gmail.com> <20230522121125.2595254-1-dhowells@redhat.com> <20230522121125.2595254-9-dhowells@redhat.com> <2267272.1686150217@warthog.procyon.org.uk> <5a9d4ffb-a569-3f60-6ac8-070ab5e5f5ad@gmail.com> <776549.1687167344@warthog.procyon.org.uk> <7337a904-231d-201d-397a-7bbe7cae929f@gmail.com> <20230630102143.7deffc30@kernel.org> <20230705091914.5bee12f8@kernel.org> <20230725173036.442ba8ba@kernel.org> From: Tariq Toukan In-Reply-To: <20230725173036.442ba8ba@kernel.org> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Rspamd-Queue-Id: A6519140005 X-Rspam-User: X-Rspamd-Server: rspam11 X-Stat-Signature: uwmzymnd6crzddwjxj91id69f764q7ru X-HE-Tag: 1690399248-901948 X-HE-Meta: U2FsdGVkX1/nFVlsug3T9dIGPJPQY/PjcH30nOejJ4yeyErqrsPe/YBsa+X5Ovsn8tHSJyN7XzEi2NXc22njaBOPaU8LiibWwt2urxFI/E7qvD54GewXv7Q90rIJrKw3rVX3wueTQ9Y5eq1LyY53FGY6bmvd/ZFxQicJFJ1Jv4cWm+tNs+FVKQQzdoeX8ifu+BNyiR+5SSlTco/NVI+vVPHo9ge3xh4NtNSi6CkQek4wfyltaADt2jtprAx8EdksbYDSlh2jh7CtqmHreOtiZT5b4pYQ3my7Uvib/UJmSyfBVk7b+i5WWz615Nte+I44I+F5dhZMuNSsL6UZqdYzJexMYrMQSm7RjU5UJ06cvsKLYxv3y+GFjC3ARakb7Aig2oLQte7OcSBpz6I2Er2cpuwqRRoL2UfonESGHgQPOkjyu+NADyB1OVq3Qfud1N4DXK8cTcwNEarQ1wf3vIeJZcnPIj27lxQIPv5negMFM/EZKER+d6eqgrIN1k/wR9USdiVCtO1WGfb6xdkDzNK+tsnVDTGoeDIVGYwmlyrZ4iLoO487BfdhHLrLIg8LO1f+li8pOQwdL3S50mM7ZDztpOxmNfyz30xTdATjhz9adJ67Af4j4TAwy54Tz/kxMTqxxRO8Yjdc3rKAClatLaVo90/EkOVWZPnl+YPBCVYEfi7n3KLLTSnXBiz8a7sm8rFLiWyHHmXcMofxesdlveiOdxDyc18t6Dkn9SkVlaWcBbNCsG+K+Jh684X2uw2wj5Re1P8VppL/0v5bMNNPh6q9T6gW2UEL9yqSv0mzY5HhK3WKXf/3Nedt9jzf5yCCKJK9vChTJmdDCINIy3Ymqrtr0geCBoTZf0DxVK+KJAWSkiHE4VIyQ2DETWKSOeYtoWJ4LoyKIpjtb+UAO82rxJUTYjC6lWqG13GJSg91JOVXNdb+sjqKNK4/nrFGfF1v9jQm3BIw3kiBWvGU3f+Q7wJ 5+fVGAoZ cu64VXx2S8XUkXNqeWp0mxQQpUD/3izA/8872eLsF4E5D7OHSM6xxEkyb6E+ic+fS+4AA2mr7Cy5iaAPHOmTA0YTpYb55lW48soAxo3yjDTbyGCHxzAPES1v5UL/Cw0MDSI1+PWkVzC8pJWDUQyEnZLu+fMkigm67OPBwkkjZKtsQUoke9iIfs83a8iBXiViuLD7c5Kc+DPrgdWJUWIixT7SALAMQ0KbhLeHfzA9h9TBnUmDS1ICKtwf5iRO244/wuGWe7bR1UskniiCCIzp73fIZ5ORVWW8fwFPtNwiNa0wrM8bJN38olgU7nTamXWRxs/z1dXhhb9QBKkdmK0iNhYCIizky+L9V9vydYHBcYjM9dUyttbVCyVeNTLUJ5Oa3KxSdxfwTT3d1dBxejjh/w/n4Uji2ySn9+rteYx1b+hdP6gWzDNcQNug3whNBBK0Kv5kZRPaSTOup1fM9qQfwTAfPRdGa9qoaPoJF1YdSkaAcN2SSs/5BQf3c9v4TzMr09UuhJu4OjCcfhuK1ZKRHl5ouOPFOOz/aUfgBNgtOF1+7fnwp3fuEng1C+xfRly35bQ2s7jh52p0jxvOC6kvQAWxVv98vKB/oNmXU+nP/b7tAxqFM3fo+fjb0phOZdQRn6rc6PhdNoRIJqdOFd8T27Ornt2Lc38G1az+86hGuesNbLWJKi5laPWH0qF5XGIUgq3m9fcHGwHjFV8HUqi+aLPNMrI45r1L94lywaQZJKQq4gvJF7GI+XddHmBUZ9Bc6028kSbx9r40gpgJc1FgflkS+1qSH+lZzxsJFeUusIs//jN4wciOAlNx5LM2jPR1SBh87/fOV0yOo0eA3ilwWwAWzGA== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 26/07/2023 3:30, Jakub Kicinski wrote: > On Sun, 23 Jul 2023 09:35:56 +0300 Tariq Toukan wrote: >> Hi Jakub, David, >> >> We repro the issue on the server side using this client command: >> $ wrk -b2.2.2.2 -t4 -c1000 -d5 --timeout 5s >> https://2.2.2.3:20443/256000b.img >> >> Port 20443 is configured with: >> ssl_ciphers ECDHE-RSA-AES128-GCM-SHA256; >> sendfile off; >> >> >> Important: >> 1. Couldn't repro with files smaller than 40KB. >> 2. Couldn't repro with "sendfile on;" >> >> In addition, we collected the vmcore (forced by panic_on_warn), it can >> be downloaded from here: >> https://drive.google.com/file/d/1Fi2dzgq6k2hb2L_kwyntRjfLF6_RmbxB/view?usp=sharing > > This has no symbols :( > Uh.. :/ I'll try to fix this and re-generate. > There is a small bug in this commit, we should always set SPLICE. > But I don't see how that'd cause the warning you're seeing. > Does your build have CONFIG_DEBUG_VM enabled? No. # CONFIG_DEBUG_VM is not set # CONFIG_DEBUG_VM_PGTABLE is not set > > -->8------------------------- > > From: Jakub Kicinski > Date: Tue, 25 Jul 2023 17:03:25 -0700 > Subject: net: tls: set MSG_SPLICE_PAGES consistently > > We used to change the flags for the last segment, because > non-last segments had the MSG_SENDPAGE_NOTLAST flag set. > That flag is no longer a thing so remove the setting. > > Since flags most likely don't have MSG_SPLICE_PAGES set > this avoids passing parts of the sg as splice and parts > as non-splice. > > ... tags ... > Signed-off-by: Jakub Kicinski > --- > net/tls/tls_main.c | 3 --- > 1 file changed, 3 deletions(-) > > diff --git a/net/tls/tls_main.c b/net/tls/tls_main.c > index b6896126bb92..4a8ee2f6badb 100644 > --- a/net/tls/tls_main.c > +++ b/net/tls/tls_main.c > @@ -139,9 +139,6 @@ int tls_push_sg(struct sock *sk, > > ctx->splicing_pages = true; > while (1) { > - if (sg_is_last(sg)) > - msg.msg_flags = flags; > - > /* is sending application-limited? */ > tcp_rate_check_app_limited(sk); > p = sg_page(sg); I'll test this anyway tomorrow and update. Regards, Tariq