From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 415B7C54E92 for ; Wed, 21 May 2025 12:11:57 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id BCBF96B00C7; Wed, 21 May 2025 08:11:56 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id BA3A56B00C8; Wed, 21 May 2025 08:11:56 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id A933C6B00C9; Wed, 21 May 2025 08:11:56 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id 868DB6B00C7 for ; Wed, 21 May 2025 08:11:56 -0400 (EDT) Received: from smtpin02.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id 372DE120216 for ; Wed, 21 May 2025 12:11:56 +0000 (UTC) X-FDA: 83466801432.02.214E29E Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by imf02.hostedemail.com (Postfix) with ESMTP id AB49E80015 for ; Wed, 21 May 2025 12:11:53 +0000 (UTC) Authentication-Results: imf02.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=OHspPPpb; dmarc=pass (policy=quarantine) header.from=redhat.com; spf=pass (imf02.hostedemail.com: domain of david@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=david@redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1747829514; a=rsa-sha256; cv=none; b=7kzGaxoEe4AFQ/F1RPSDbUzE5SF7YPZbsufoTkZpvD6/a1/4hSr9kRVmSj+xlymDKZZPl2 lIFfCoOXo6xYIvPH9W6nAltrr7OreEjFhSwxPaHpT00TrDQyBWGI1ToVyQwQNZrih28wd4 Z5/9/yMqbtAeTElyGKstFGTcs9xA4fk= ARC-Authentication-Results: i=1; imf02.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=OHspPPpb; dmarc=pass (policy=quarantine) header.from=redhat.com; spf=pass (imf02.hostedemail.com: domain of david@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=david@redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1747829514; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=Qtu6GUo320eRV2cAmSsW0wFq6T2qjgs2wh7OnZ36KOY=; b=C3o0gwFH2pB9CaodHZtW+w7JDZiaxW411C6O3JiXHyvkwj67daABIS0v60QDTdkwj5szgS xPG8ORsKvDVZPmOJBdAA4Sn0EtUFwT2Y7rHRR8Uaz1cSXOChrLniyBVWTLVe7eQBI9Je3R TcpfyHOkH6v846XN8Km5fXzoAxUpQqs= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1747829513; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=Qtu6GUo320eRV2cAmSsW0wFq6T2qjgs2wh7OnZ36KOY=; b=OHspPPpbhuTmz+ap2u6Bwm6KlbKZ2E58hqD90r7xaPARWIg3eSK3O5HlVZUB9aEXFntT4m 1UkMpCPWWsbK/83jBji3jVgcddr2eo+KlgjHCdNpEesG4l1IzyoLzXRr9h94wd8aRSB9EF a2K/rN07HB+nsN0UkgiCwu+AIqnzXUc= Received: from mail-wr1-f72.google.com (mail-wr1-f72.google.com [209.85.221.72]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-473-_ogfrbWkPDaFMs6okHzr-w-1; Wed, 21 May 2025 08:11:49 -0400 X-MC-Unique: _ogfrbWkPDaFMs6okHzr-w-1 X-Mimecast-MFC-AGG-ID: _ogfrbWkPDaFMs6okHzr-w_1747829509 Received: by mail-wr1-f72.google.com with SMTP id ffacd0b85a97d-3a379218f6cso965495f8f.0 for ; Wed, 21 May 2025 05:11:49 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1747829509; x=1748434309; h=content-transfer-encoding:in-reply-to:organization:autocrypt :content-language:from:references:cc:to:subject:user-agent :mime-version:date:message-id:x-gm-message-state:from:to:cc:subject :date:message-id:reply-to; bh=Qtu6GUo320eRV2cAmSsW0wFq6T2qjgs2wh7OnZ36KOY=; b=U0/GH6NRG4dUt7qvLx1H+bQ7yDaUG4wC13CpJ5Zb8rp3Fb99t76GKZP7TyyM6RrLQd WJnvzUhCBkdP+dsaTwnHt4Oq810A/eYgWuyVox0tDopL1XuR2xggUE3BQDQHZ8I+1D6x gPlMMyaR3I+hp6BzBXyzI+YGzuRA+m8JbiQwluW3RHbdMKSYHHwNnzaAEvQnjrdRMnxv e+sCwzywwy0ZTbCcMoi9FNT5stFKVbJRJJe16GMJ+cQ2ixnldvIQZXBSbT0GjfcUIeua eOYEb1QSdFMjs+M/dhQqid2HKE9lpdD+R4PQTIlWrlVQ/3rHqz8yuKSo0wKEBMLeVszn Y6PQ== X-Forwarded-Encrypted: i=1; AJvYcCXZJjE+Kz6OVe+EqCtcT5DbgTeJSEHlzqvHFAaTbiZP7yHCPdZDNxjj1DX1ezwgKh6hV2iphMsd1g==@kvack.org X-Gm-Message-State: AOJu0YycwcftDDdCsAzAlUYMeL90NY5nXwKnk4LoaedMP0pPaMiDRBPu adaniCPfVwGUC6yA8Mav2UDkYMsqXY5pI7pJyJpE6KUgALh0JQvW+ASx4SgBWjAI+LrIkIFfBz8 SRC33R23hyqlRfVvHhmszZtGKX8/0wYcz4VyDm+OLyQILJglA+67E X-Gm-Gg: ASbGncu+0uJYuJYNFVdm07xDVxC0vIJyymYYyUYAu+W5u+mymVbXK2DP/Yn7i2S/bnA EjB8MhzpQk4Y4tCOKSAufg/FN0tGvxdDKZjwDB6thY0GupqDW1wrUKkR6YB7rY6ICcJtFvvTMQV ine0ixtfqngplybWRIC9j+3+AvNdC5Hy+9A2BjllmoNDDPgfYo7VxFxzsiradYo8lpDMJAkc0yp 9M0BRsz9TpLWO0YTdVBV8QobHUX23SKTqr2N9clIb/+LqguVj1qXqLfDkcu744Hovq1DqBhQNSL nU7/Y8I/04Qlj66LC9Thtr0xaWI/7Yw2awM35rpn0YLg4sdLxDkaalV2U+61sAGy19iB2ku9IFF ic8uW2OfGpDZL1LjhaH87Hw5Y9ZBF4bN8W08utHE= X-Received: by 2002:a05:6000:2012:b0:3a1:f68b:60a8 with SMTP id ffacd0b85a97d-3a35c834d65mr19052434f8f.10.1747829508644; Wed, 21 May 2025 05:11:48 -0700 (PDT) X-Google-Smtp-Source: AGHT+IG+ZKeGiYGqyqeDF1EYsM8B1nfBMl2gn9cmf015VaeDSfD4MFj90rpEUX9BD5N9Z+M+QVCd2w== X-Received: by 2002:a05:6000:2012:b0:3a1:f68b:60a8 with SMTP id ffacd0b85a97d-3a35c834d65mr19052394f8f.10.1747829508173; Wed, 21 May 2025 05:11:48 -0700 (PDT) Received: from ?IPV6:2003:d8:2f25:9c00:e2c7:6eb5:8a51:1c60? (p200300d82f259c00e2c76eb58a511c60.dip0.t-ipconnect.de. [2003:d8:2f25:9c00:e2c7:6eb5:8a51:1c60]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-447f6b29619sm72162355e9.7.2025.05.21.05.11.46 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 21 May 2025 05:11:47 -0700 (PDT) Message-ID: Date: Wed, 21 May 2025 14:11:44 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v4 1/4] mm/page_isolation: make page isolation a standalone bit. To: Zi Yan Cc: Oscar Salvador , Johannes Weiner , linux-mm@kvack.org, Andrew Morton , Vlastimil Babka , Baolin Wang , "Kirill A . Shutemov" , Mel Gorman , Suren Baghdasaryan , Michal Hocko , Brendan Jackman , Richard Chang , linux-kernel@vger.kernel.org References: <20250509200111.3372279-1-ziy@nvidia.com> <20250509200111.3372279-2-ziy@nvidia.com> <506798aa-0280-4f63-9c0e-d5f2f5d58c3c@redhat.com> <166E73A3-02CE-4023-AE0E-022C9C618C33@nvidia.com> From: David Hildenbrand Autocrypt: addr=david@redhat.com; keydata= xsFNBFXLn5EBEAC+zYvAFJxCBY9Tr1xZgcESmxVNI/0ffzE/ZQOiHJl6mGkmA1R7/uUpiCjJ dBrn+lhhOYjjNefFQou6478faXE6o2AhmebqT4KiQoUQFV4R7y1KMEKoSyy8hQaK1umALTdL QZLQMzNE74ap+GDK0wnacPQFpcG1AE9RMq3aeErY5tujekBS32jfC/7AnH7I0v1v1TbbK3Gp XNeiN4QroO+5qaSr0ID2sz5jtBLRb15RMre27E1ImpaIv2Jw8NJgW0k/D1RyKCwaTsgRdwuK Kx/Y91XuSBdz0uOyU/S8kM1+ag0wvsGlpBVxRR/xw/E8M7TEwuCZQArqqTCmkG6HGcXFT0V9 PXFNNgV5jXMQRwU0O/ztJIQqsE5LsUomE//bLwzj9IVsaQpKDqW6TAPjcdBDPLHvriq7kGjt WhVhdl0qEYB8lkBEU7V2Yb+SYhmhpDrti9Fq1EsmhiHSkxJcGREoMK/63r9WLZYI3+4W2rAc UucZa4OT27U5ZISjNg3Ev0rxU5UH2/pT4wJCfxwocmqaRr6UYmrtZmND89X0KigoFD/XSeVv jwBRNjPAubK9/k5NoRrYqztM9W6sJqrH8+UWZ1Idd/DdmogJh0gNC0+N42Za9yBRURfIdKSb B3JfpUqcWwE7vUaYrHG1nw54pLUoPG6sAA7Mehl3nd4pZUALHwARAQABzSREYXZpZCBIaWxk ZW5icmFuZCA8ZGF2aWRAcmVkaGF0LmNvbT7CwZgEEwEIAEICGwMGCwkIBwMCBhUIAgkKCwQW AgMBAh4BAheAAhkBFiEEG9nKrXNcTDpGDfzKTd4Q9wD/g1oFAl8Ox4kFCRKpKXgACgkQTd4Q 9wD/g1oHcA//a6Tj7SBNjFNM1iNhWUo1lxAja0lpSodSnB2g4FCZ4R61SBR4l/psBL73xktp rDHrx4aSpwkRP6Epu6mLvhlfjmkRG4OynJ5HG1gfv7RJJfnUdUM1z5kdS8JBrOhMJS2c/gPf wv1TGRq2XdMPnfY2o0CxRqpcLkx4vBODvJGl2mQyJF/gPepdDfcT8/PY9BJ7FL6Hrq1gnAo4 3Iv9qV0JiT2wmZciNyYQhmA1V6dyTRiQ4YAc31zOo2IM+xisPzeSHgw3ONY/XhYvfZ9r7W1l pNQdc2G+o4Di9NPFHQQhDw3YTRR1opJaTlRDzxYxzU6ZnUUBghxt9cwUWTpfCktkMZiPSDGd KgQBjnweV2jw9UOTxjb4LXqDjmSNkjDdQUOU69jGMUXgihvo4zhYcMX8F5gWdRtMR7DzW/YE BgVcyxNkMIXoY1aYj6npHYiNQesQlqjU6azjbH70/SXKM5tNRplgW8TNprMDuntdvV9wNkFs 9TyM02V5aWxFfI42+aivc4KEw69SE9KXwC7FSf5wXzuTot97N9Phj/Z3+jx443jo2NR34XgF 89cct7wJMjOF7bBefo0fPPZQuIma0Zym71cP61OP/i11ahNye6HGKfxGCOcs5wW9kRQEk8P9 M/k2wt3mt/fCQnuP/mWutNPt95w9wSsUyATLmtNrwccz63XOwU0EVcufkQEQAOfX3n0g0fZz Bgm/S2zF/kxQKCEKP8ID+Vz8sy2GpDvveBq4H2Y34XWsT1zLJdvqPI4af4ZSMxuerWjXbVWb T6d4odQIG0fKx4F8NccDqbgHeZRNajXeeJ3R7gAzvWvQNLz4piHrO/B4tf8svmRBL0ZB5P5A 2uhdwLU3NZuK22zpNn4is87BPWF8HhY0L5fafgDMOqnf4guJVJPYNPhUFzXUbPqOKOkL8ojk CXxkOFHAbjstSK5Ca3fKquY3rdX3DNo+EL7FvAiw1mUtS+5GeYE+RMnDCsVFm/C7kY8c2d0G NWkB9pJM5+mnIoFNxy7YBcldYATVeOHoY4LyaUWNnAvFYWp08dHWfZo9WCiJMuTfgtH9tc75 7QanMVdPt6fDK8UUXIBLQ2TWr/sQKE9xtFuEmoQGlE1l6bGaDnnMLcYu+Asp3kDT0w4zYGsx 5r6XQVRH4+5N6eHZiaeYtFOujp5n+pjBaQK7wUUjDilPQ5QMzIuCL4YjVoylWiBNknvQWBXS lQCWmavOT9sttGQXdPCC5ynI+1ymZC1ORZKANLnRAb0NH/UCzcsstw2TAkFnMEbo9Zu9w7Kv AxBQXWeXhJI9XQssfrf4Gusdqx8nPEpfOqCtbbwJMATbHyqLt7/oz/5deGuwxgb65pWIzufa N7eop7uh+6bezi+rugUI+w6DABEBAAHCwXwEGAEIACYCGwwWIQQb2cqtc1xMOkYN/MpN3hD3 AP+DWgUCXw7HsgUJEqkpoQAKCRBN3hD3AP+DWrrpD/4qS3dyVRxDcDHIlmguXjC1Q5tZTwNB boaBTPHSy/Nksu0eY7x6HfQJ3xajVH32Ms6t1trDQmPx2iP5+7iDsb7OKAb5eOS8h+BEBDeq 3ecsQDv0fFJOA9ag5O3LLNk+3x3q7e0uo06XMaY7UHS341ozXUUI7wC7iKfoUTv03iO9El5f XpNMx/YrIMduZ2+nd9Di7o5+KIwlb2mAB9sTNHdMrXesX8eBL6T9b+MZJk+mZuPxKNVfEQMQ a5SxUEADIPQTPNvBewdeI80yeOCrN+Zzwy/Mrx9EPeu59Y5vSJOx/z6OUImD/GhX7Xvkt3kq Er5KTrJz3++B6SH9pum9PuoE/k+nntJkNMmQpR4MCBaV/J9gIOPGodDKnjdng+mXliF3Ptu6 3oxc2RCyGzTlxyMwuc2U5Q7KtUNTdDe8T0uE+9b8BLMVQDDfJjqY0VVqSUwImzTDLX9S4g/8 kC4HRcclk8hpyhY2jKGluZO0awwTIMgVEzmTyBphDg/Gx7dZU1Xf8HFuE+UZ5UDHDTnwgv7E th6RC9+WrhDNspZ9fJjKWRbveQgUFCpe1sa77LAw+XFrKmBHXp9ZVIe90RMe2tRL06BGiRZr jPrnvUsUUsjRoRNJjKKA/REq+sAnhkNPPZ/NNMjaZ5b8Tovi8C0tmxiCHaQYqj7G2rgnT0kt WNyWQQ== Organization: Red Hat In-Reply-To: X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: hu55wRpjsEFqjI1yWOInltPIKPeASAFi_QjYiHVwkMM_1747829509 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Stat-Signature: yr8cj51fc3o8qxc4axu3c1sp984fcow4 X-Rspam-User: X-Rspamd-Queue-Id: AB49E80015 X-Rspamd-Server: rspam06 X-HE-Tag: 1747829513-496868 X-HE-Meta: U2FsdGVkX1+UHFMgwU8eQDbs8Ixunb0tUqElutobv6kEPjDne3XNHneY2vd1/l8SYQ6Xy3nYEfWfvJBumw9L4ucZEzpwzO/ct52XlxEzp7EkHIGks4aUFAFnnxMiYS8Y5nmaM8Fe4dNAqbgDbeIA3fo2FwMpra+2yAoljInIPC+EtynJpoRwD9QVv/3ezLB4/IS59LAywixlh3X6DSkhhngh/A3YgtBzHRqGTmhu/ggrAGh0hKgJ9+RDyxLnKha7tnCSmWP+O34DYburW76uEMvysEyPRhNZF1MQR5pptxboacdH5njGDlrfmrHpjie5x3BDzJ5NjLE1zD30x5rvu52OFOqh0/IQask0GzeAOjBIi+JBPdFyzrb2Trq++uB3Sa18UKu9dhOsq8bbFMPLAM64hL2wjYw0+KZ1TPVj7Jj0IFMB07P/Yg4kxIMLcJQ3pGy5JNed/jKy7NrgmM5WIDhhT1mxtpCksPlgn+jH+FQ12W5hiYdb3ozTwCHICsd39M8gqB5248s+cegXLrPenSW5JMm60icM0rla7Zel2aay4L5mAELhb92y+q0bYk4SnaaPXpMfVbpfpeWtuG7nBdI4Uad+RMfrBnf5Ux5W3OwbL1LQwMw+4YmKoENERToEbT0J3fpW205jGI90WE2c8X5ozn3LQhJun5DpKinpqPT5QjFhUYH7DxMHvY2qlIyP6FdpoVSCF5Y2OdG2UpGtPf5S+colO9R9qb0MHluX7NE55DVIs/3RwJcZ6BJndh3KkP93EsoOS1qAs3KQvciLKbH4YzXi2ky/BHbkG72imKD0XRet46e/4ZVB0NXCgmr9n64p/+xrjZZm76D09DXwWVhHcotVCd8sXocheYeyxAGBAPyO/3iBYShGK9hkWPderezzpxPCmAlPeYSxOZWiTBCq1CKox8e7hi4FdrlhY0j+IIBlO1E9QD68VPbA/UFcqKR6ydttt46J8laHNzk JuA4kt9t cGxjXtYRxMF9YqUK51Luz1O8P9eB1OGEETZSPZAydAJGNlsOp/CNg2Ee60i/8mW/z8EYisrvmHU0dKVo4nyF+XeT6SahftJPQ/rw4HL6bYb18/WUp3UrOX11LPrB5u379kJov X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 21.05.25 14:00, Zi Yan wrote: > On 21 May 2025, at 7:57, David Hildenbrand wrote: > >> On 21.05.25 13:16, Zi Yan wrote: >>> On 19 May 2025, at 12:42, David Hildenbrand wrote: >>> >>>>>>> +#ifdef CONFIG_MEMORY_ISOLATION >>>>>>> + if (flags & PB_migrate_isolate_bit) >>>>>>> + return MIGRATE_ISOLATE; >>>>>>> +#endif >>>>>> >>>>>> If you call get_pfnblock_flags_mask() with MIGRATETYPE_MASK, how could you ever get PB_migrate_isolate_bit? >>>>> >>>>> MIGRATETYPE_MASK is ((BIT(PB_migratetype_bits) - 1) | PB_migrate_isolate_bit), >>>>> so it gets PB_migrate_isolate_bit. >>>>> >>>> >>>> Oh ... that's confusing. >>>> >>>>>> >>>>>> >>>>>> I think what we should do is >>>>>> >>>>>> 1) Rename get_pfnblock_flags_mask() to get_pfnblock_flags() >>>>>> >>>>>> 2) Remove the mask parameter >>>>>> >>>>>> 3) Perform the masking in all callers. >>>>> >>>>> get_pfnblock_flags_mask() is also used by get_pageblock_skip() to >>>>> get PB_migrate_skip. I do not think we want to include PB_migrate_skip >>>>> in the mask to confuse readers. >>>> >>>> The masking will be handled in the caller. >>>> >>>> So get_pageblock_skip() would essentially do a >>>> >>>> return get_pfnblock_flags() & PB_migrate_skip_bit; >>>> >>>> etc. >>>> >>>>> >>>>>> >>>>>> >>>>>> >>>>>> Maybe, we should convert set_pfnblock_flags_mask() to >>>>>> >>>>>> void set_clear_pfnblock_flags(struct page *page, unsigned long >>>>>> set_flags, unsigned long clear_flags); >>>>>> >>>>>> And better, splitting it up (or providing helpers) >>>>>> >>>>>> set_pfnblock_flags(struct page *page, unsigned long flags); >>>>>> clear_pfnblock_flags(struct page *page, unsigned long flags); >>>>>> >>>>>> >>>>>> This implies some more code cleanups first that make the code easier to extend. >>>>>> >>>>> >>>>> The same due to PB_migrate_skip. >>>>> >>>>> Based on your suggestion, we could make {set,get}_pfnblock_flags_mask() >>>>> internal APIs by prepending "__". They are only used by the new >>>>> {get, set, clear}_pfnblock_flags() and {get, set, clear}_pageblock_{skip, isolate}(). >>>>> Then use {get, set, clear}_pfnblock_flags() for all migratetype operations. >>>>> >>>>> WDYT? >>>> >>>> In general, lgtm. I just hope we can avoid the "_mask" part and just handle it in these functions directly? >>> >>> After implementing {get, set, clear}_pfnblock_flags(), I find that >>> get_pfnblock_flags() is easy like you wrote above, but set and clear are not, >>> since migratetype and skip/isolate bits are in the same word, meaning >>> I will need to first read them out, change the field, then write them back. >> >> Like existing set_pfnblock_flags_mask() I guess, with the try_cmpxchg() loop. > > Are you saying I duplicate the code in set_pfnblock_flags_mask() to implement > set_pfnblock_flags()? Or just replace set_pfnblock_flags_mask() entirely? The latter as possible. > >> >>> But it will cause inconsistency if there is a parallel writer to the same >>> word. So for set and clear, mask is required. >>> >>> I can try to implement {get, set, clear}_pfnblock_bits(page,pfn, bits) to >>> only handle standalone bits by using the given @bits as the mask and >>> {set,get}_pageblock_migratetype() still use the mask. >> >> We'd still have to do the try_cmpxchg() when dealing with multiple bits, right? >> >> For single bits, we could just use set_bit() etc. > > Mel moved from set_bit() to try_cmpxchg() a word for performance reason. I am > not sure we want to move back. In e58469bafd05 we moved from multiple set_bit etc to a cmpxchange. - for (; start_bitidx <= end_bitidx; start_bitidx++, value <<= 1) - if (flags & value) - __set_bit(bitidx + start_bitidx, bitmap); - else - __clear_bit(bitidx + start_bitidx, bitmap); However, when only setting/clearing a single bit (e.g., isolated), set_bit etc should be much cheaper. For multiple bits, the existing try_cmpxchg should be kept IMHO. -- Cheers, David / dhildenb