From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2F628C3DA61 for ; Wed, 24 Jul 2024 14:14:20 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id B95F56B0085; Wed, 24 Jul 2024 10:14:19 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id AF7816B0088; Wed, 24 Jul 2024 10:14:19 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 9237E6B0089; Wed, 24 Jul 2024 10:14:19 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id 6EA796B0085 for ; Wed, 24 Jul 2024 10:14:19 -0400 (EDT) Received: from smtpin19.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id 196A3140805 for ; Wed, 24 Jul 2024 14:14:19 +0000 (UTC) X-FDA: 82374841038.19.A70BB93 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by imf11.hostedemail.com (Postfix) with ESMTP id CFB4640017 for ; Wed, 24 Jul 2024 14:14:16 +0000 (UTC) Authentication-Results: imf11.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=fq3yIbDy; spf=pass (imf11.hostedemail.com: domain of david@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1721830408; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=ZfbnMjKn+Ou5xciqWaM2b9lfq0I+PXMBIRspEzGa++I=; b=XORCuHkllNQ9nPjm2lO7DdWkCzoa8al3Kui0G39P75pWO8nPX3F02KyT6m+iEjOhCkfl8x PeffvX98FdU637PZNWWaZvdzfCEU19lNYIEQuJ6kPbdA4mb++CU/f9Wjp8rsOcltPPaB9t 0eSg7N0qmo+dO6FtzHVwYLK3c1QOAcI= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1721830408; a=rsa-sha256; cv=none; b=z6dBGTOcboD5RBNsZ6gIxXaZdjQ3peMyzd04bG6Rjh5S6uZ870VvPwtJYRVE/SQfn81Glp jwr2WyHxe+ROd1835mERlIgoEwxWhmGX0XF5gc2lKB3kwNX9ZPI5AhHEJcfdlqx+X9mQ4+ tAi7QPEomWHa3uixVJRe3Ox2GNCMYSg= ARC-Authentication-Results: i=1; imf11.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=fq3yIbDy; spf=pass (imf11.hostedemail.com: domain of david@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=none) header.from=redhat.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1721830456; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=ZfbnMjKn+Ou5xciqWaM2b9lfq0I+PXMBIRspEzGa++I=; b=fq3yIbDy/dHiCQ/hB051ZPpJ+8utJdnR3sZDjxcilFpQknJ/WU/nImRb+rcI0dTot/mtyd hvsFikxGtnY1iegSxdQjz8eL2nOjcY/b4lTwOaKClX5vMWoRXcVXMrbcP590brbaKhLeiM jwfE8cHzMWEC/bOkC8WpUMdW3S88gL0= Received: from mail-wm1-f72.google.com (mail-wm1-f72.google.com [209.85.128.72]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-394-lPSpx31MMzCVH2sLxZRG2Q-1; Wed, 24 Jul 2024 10:14:14 -0400 X-MC-Unique: lPSpx31MMzCVH2sLxZRG2Q-1 Received: by mail-wm1-f72.google.com with SMTP id 5b1f17b1804b1-4279c75c44dso48840685e9.2 for ; Wed, 24 Jul 2024 07:14:14 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1721830453; x=1722435253; h=content-transfer-encoding:in-reply-to:organization:autocrypt:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=ZfbnMjKn+Ou5xciqWaM2b9lfq0I+PXMBIRspEzGa++I=; b=vW126Ejwvt83uGvVeZLYqhUg4Rca2WUa9G2tM5mH/XKpdyki0Qq5I/srDqNGB5IO0C ZDdghT+NUE/vV9C18tvc1jMqFXy+iAlvl1l5SzGt/zgv925GD3nHQqSVMN33EhjjLf3b 8oHvNB9lk0KU+NBE8Qlxn7pYx5mAJV4Q5jSaDamhssixi/jP8+bjXsRUWkez74RcGR08 bHL8OUVeMOAokEWeYfWRbWs1arByWKrLejzNp4Sc7UnEjnMzlfTeqU3iM11G/KeZoCLm FPrHl6MJrpSH4GwW1AZxTowfl0IrhtjuNEX3fwiucclEKz1Q6JvCXGbhg9PpFwWuyWh4 xbUQ== X-Forwarded-Encrypted: i=1; AJvYcCWjCQtzWKWYCazC64GC7bAoj1Vhc66Bv5lZ6e7zPx0QarX62/eQBIwqVkqasur1USfnsXOvl//FgmENPH70i6inr1w= X-Gm-Message-State: AOJu0YwggJWaRlmRUMikrJE75/V916T09ZRxTdrUjpUa5mbah1n/JhaY 4nbEywjCC+CtpYGfXLP+GD4HQGj5THzwGlQptGVABiWT8PjS7N+Z4YRPHgXA2pcTrFBb1r7XjDO 8gkmVn1r5/lklWtOM/n7tK4gpN9uQ2QRMqCJVD73w8zZez8Og X-Received: by 2002:a05:6000:1291:b0:368:5b80:b8d with SMTP id ffacd0b85a97d-369f09b600cmr1946162f8f.21.1721830453167; Wed, 24 Jul 2024 07:14:13 -0700 (PDT) X-Google-Smtp-Source: AGHT+IEtlfF/4HJ9++sJPlr8qtuUlJiLPxaAiImPf5nhKWxysXeLXnCclTR9m6j5oaMuw9XBvi9vRw== X-Received: by 2002:a05:6000:1291:b0:368:5b80:b8d with SMTP id ffacd0b85a97d-369f09b600cmr1946147f8f.21.1721830452732; Wed, 24 Jul 2024 07:14:12 -0700 (PDT) Received: from ?IPV6:2003:cb:c739:bb00:201f:378f:5564:caeb? (p200300cbc739bb00201f378f5564caeb.dip0.t-ipconnect.de. [2003:cb:c739:bb00:201f:378f:5564:caeb]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-368786949f5sm14462571f8f.57.2024.07.24.07.14.11 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 24 Jul 2024 07:14:12 -0700 (PDT) Message-ID: Date: Wed, 24 Jul 2024 16:14:11 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v3 3/3] memory tiering: count PGPROMOTE_SUCCESS when mem tiering is enabled. To: Zi Yan , Andrew Morton , linux-mm@kvack.org Cc: "Huang, Ying" , Baolin Wang , Kefeng Wang , Lorenzo Stoakes , linux-kernel@vger.kernel.org References: <20240724130115.793641-1-ziy@nvidia.com> <20240724130115.793641-4-ziy@nvidia.com> From: David Hildenbrand Autocrypt: addr=david@redhat.com; keydata= xsFNBFXLn5EBEAC+zYvAFJxCBY9Tr1xZgcESmxVNI/0ffzE/ZQOiHJl6mGkmA1R7/uUpiCjJ dBrn+lhhOYjjNefFQou6478faXE6o2AhmebqT4KiQoUQFV4R7y1KMEKoSyy8hQaK1umALTdL QZLQMzNE74ap+GDK0wnacPQFpcG1AE9RMq3aeErY5tujekBS32jfC/7AnH7I0v1v1TbbK3Gp XNeiN4QroO+5qaSr0ID2sz5jtBLRb15RMre27E1ImpaIv2Jw8NJgW0k/D1RyKCwaTsgRdwuK Kx/Y91XuSBdz0uOyU/S8kM1+ag0wvsGlpBVxRR/xw/E8M7TEwuCZQArqqTCmkG6HGcXFT0V9 PXFNNgV5jXMQRwU0O/ztJIQqsE5LsUomE//bLwzj9IVsaQpKDqW6TAPjcdBDPLHvriq7kGjt WhVhdl0qEYB8lkBEU7V2Yb+SYhmhpDrti9Fq1EsmhiHSkxJcGREoMK/63r9WLZYI3+4W2rAc UucZa4OT27U5ZISjNg3Ev0rxU5UH2/pT4wJCfxwocmqaRr6UYmrtZmND89X0KigoFD/XSeVv jwBRNjPAubK9/k5NoRrYqztM9W6sJqrH8+UWZ1Idd/DdmogJh0gNC0+N42Za9yBRURfIdKSb B3JfpUqcWwE7vUaYrHG1nw54pLUoPG6sAA7Mehl3nd4pZUALHwARAQABzSREYXZpZCBIaWxk ZW5icmFuZCA8ZGF2aWRAcmVkaGF0LmNvbT7CwZgEEwEIAEICGwMGCwkIBwMCBhUIAgkKCwQW AgMBAh4BAheAAhkBFiEEG9nKrXNcTDpGDfzKTd4Q9wD/g1oFAl8Ox4kFCRKpKXgACgkQTd4Q 9wD/g1oHcA//a6Tj7SBNjFNM1iNhWUo1lxAja0lpSodSnB2g4FCZ4R61SBR4l/psBL73xktp rDHrx4aSpwkRP6Epu6mLvhlfjmkRG4OynJ5HG1gfv7RJJfnUdUM1z5kdS8JBrOhMJS2c/gPf wv1TGRq2XdMPnfY2o0CxRqpcLkx4vBODvJGl2mQyJF/gPepdDfcT8/PY9BJ7FL6Hrq1gnAo4 3Iv9qV0JiT2wmZciNyYQhmA1V6dyTRiQ4YAc31zOo2IM+xisPzeSHgw3ONY/XhYvfZ9r7W1l pNQdc2G+o4Di9NPFHQQhDw3YTRR1opJaTlRDzxYxzU6ZnUUBghxt9cwUWTpfCktkMZiPSDGd KgQBjnweV2jw9UOTxjb4LXqDjmSNkjDdQUOU69jGMUXgihvo4zhYcMX8F5gWdRtMR7DzW/YE BgVcyxNkMIXoY1aYj6npHYiNQesQlqjU6azjbH70/SXKM5tNRplgW8TNprMDuntdvV9wNkFs 9TyM02V5aWxFfI42+aivc4KEw69SE9KXwC7FSf5wXzuTot97N9Phj/Z3+jx443jo2NR34XgF 89cct7wJMjOF7bBefo0fPPZQuIma0Zym71cP61OP/i11ahNye6HGKfxGCOcs5wW9kRQEk8P9 M/k2wt3mt/fCQnuP/mWutNPt95w9wSsUyATLmtNrwccz63XOwU0EVcufkQEQAOfX3n0g0fZz Bgm/S2zF/kxQKCEKP8ID+Vz8sy2GpDvveBq4H2Y34XWsT1zLJdvqPI4af4ZSMxuerWjXbVWb T6d4odQIG0fKx4F8NccDqbgHeZRNajXeeJ3R7gAzvWvQNLz4piHrO/B4tf8svmRBL0ZB5P5A 2uhdwLU3NZuK22zpNn4is87BPWF8HhY0L5fafgDMOqnf4guJVJPYNPhUFzXUbPqOKOkL8ojk CXxkOFHAbjstSK5Ca3fKquY3rdX3DNo+EL7FvAiw1mUtS+5GeYE+RMnDCsVFm/C7kY8c2d0G NWkB9pJM5+mnIoFNxy7YBcldYATVeOHoY4LyaUWNnAvFYWp08dHWfZo9WCiJMuTfgtH9tc75 7QanMVdPt6fDK8UUXIBLQ2TWr/sQKE9xtFuEmoQGlE1l6bGaDnnMLcYu+Asp3kDT0w4zYGsx 5r6XQVRH4+5N6eHZiaeYtFOujp5n+pjBaQK7wUUjDilPQ5QMzIuCL4YjVoylWiBNknvQWBXS lQCWmavOT9sttGQXdPCC5ynI+1ymZC1ORZKANLnRAb0NH/UCzcsstw2TAkFnMEbo9Zu9w7Kv AxBQXWeXhJI9XQssfrf4Gusdqx8nPEpfOqCtbbwJMATbHyqLt7/oz/5deGuwxgb65pWIzufa N7eop7uh+6bezi+rugUI+w6DABEBAAHCwXwEGAEIACYCGwwWIQQb2cqtc1xMOkYN/MpN3hD3 AP+DWgUCXw7HsgUJEqkpoQAKCRBN3hD3AP+DWrrpD/4qS3dyVRxDcDHIlmguXjC1Q5tZTwNB boaBTPHSy/Nksu0eY7x6HfQJ3xajVH32Ms6t1trDQmPx2iP5+7iDsb7OKAb5eOS8h+BEBDeq 3ecsQDv0fFJOA9ag5O3LLNk+3x3q7e0uo06XMaY7UHS341ozXUUI7wC7iKfoUTv03iO9El5f XpNMx/YrIMduZ2+nd9Di7o5+KIwlb2mAB9sTNHdMrXesX8eBL6T9b+MZJk+mZuPxKNVfEQMQ a5SxUEADIPQTPNvBewdeI80yeOCrN+Zzwy/Mrx9EPeu59Y5vSJOx/z6OUImD/GhX7Xvkt3kq Er5KTrJz3++B6SH9pum9PuoE/k+nntJkNMmQpR4MCBaV/J9gIOPGodDKnjdng+mXliF3Ptu6 3oxc2RCyGzTlxyMwuc2U5Q7KtUNTdDe8T0uE+9b8BLMVQDDfJjqY0VVqSUwImzTDLX9S4g/8 kC4HRcclk8hpyhY2jKGluZO0awwTIMgVEzmTyBphDg/Gx7dZU1Xf8HFuE+UZ5UDHDTnwgv7E th6RC9+WrhDNspZ9fJjKWRbveQgUFCpe1sa77LAw+XFrKmBHXp9ZVIe90RMe2tRL06BGiRZr jPrnvUsUUsjRoRNJjKKA/REq+sAnhkNPPZ/NNMjaZ5b8Tovi8C0tmxiCHaQYqj7G2rgnT0kt WNyWQQ== Organization: Red Hat In-Reply-To: <20240724130115.793641-4-ziy@nvidia.com> X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Stat-Signature: fjiu56uuqu3d951sjpjpmfyjqgeaiqfe X-Rspamd-Queue-Id: CFB4640017 X-Rspam-User: X-Rspamd-Server: rspam08 X-HE-Tag: 1721830456-614396 X-HE-Meta: U2FsdGVkX1+S6yACbNfkVOTYgu1KXDs4fBOEpAbD9MS+BHn+TZzaXgrXDdNnGbhHQl7bbhawbHsXrge55qbgEOUSlloaak11bEc71kcRARCCAiw2O5fcIvdyHfzhttATDcO4biLuttcuT5uHvK46DEA3oWPl2p66htx6d1Cbkxl2dlf3+7WbtiM6MafNaOeZJm6B34kZc8dALdYu/AWCfmI+2dHLy1DbRsrzSi9Rc0UkEejvmcJjhwa204EEpdXzwQg0zaZkloKE+J/QfA59G2XI29BoUkJKi7Je/HYPmaiCzSLo40eeVOrwkwhnne/NI6BfvJMquJ2WN44xZ9eCLqXoaEQkDkKpXN+/6trB5HPE/TRJJaNU4vO6G4cBbiUgzpwHw5maFV6K2zN+WeZMNrnVtCbn2JXHcOPvweG7wc4BNqn6T+vTmavlzVpWkRHZGB33h23zV1PWF5LqL4hTpPvXUADGLNuSUVYVBdVVwB9XV8guB36JoRv10FEVsYO2POMG/FCYPlOcJsSREq2ogyWCSOWS/S+cORMG/f1apznFW1gatgGQP86rJOOOBP3wa7QLIRLEvU1+vuxTijTU7q+UuW01ULpjIqiihYNiOKSNDqbP85YnI/lKHW6ZjPK+xHWZNa9JDcZ9tleVbwT8Q0IMiCxR30kybl/3bOl2Sn39WfsJ+MGyHbbC9s0zlvmI3WMzukJMaUu+3RioC9mOUMuvE3+V47aWvZZL+MQGUZCw7Sf9XEqVxpVPYkiVOC1t17x/8+iZREh4pcLK/Kbx9xaoql/2JKVavoALtVE2Dzzcksy1JH1dQb+qrfc8z4P1KZ5Qd6Lj6PYRVLW60bmqrIWX/JZ8FJrYpVvUASdMryLlwkGurjSRmLWKp1bNR8s5xPpuCso7gXleEIKvBM5yy4OHapn7422Q/Y5xF4Nzumgcu0i8Kx+ioNFTi8eTuwaoXmZ9Yst0gB9B5pan12f FpYWSTuI 09vgkpRLo1xPTmj0IYayJ2SHKavxrqF6Bj7aPhgTxxLEHM0CXo5VixnH3tmPaSRTB3Z5hk8CMH8+mSANmrOwt0DBCtSCHMcnBKJrIeBY7Mw3/E91Yor7lLIjgBqwpQXXPGbZdrMw/wJm/P1KnCJeUAhV/IxFYzcX+6k/iWuMaIHo1uuCye97m8mY6pI+121EraAwGCNoDJxPvRbkrou9MAsmhSMnLTHJMjRo709vfyS/lgvP4Slaij1fFQ/j8KbSiOAzfA/2ffTkIBY1FDd7Jj5lU/u7aCCfzHs5JUhzwYryo8er4DDTiZ0pb5zC6h6F7CrDEIHXpHaZHAZXn7dIpay06mDbeni9HquKq4vAsQG2wOq1ZNtdbtA3iDLQGSVfL0laIDiPVLhEYab/V3u3c1WieobBA4Pp+NU93tiER+c62EwNb9T6p7JihMYUdjx+gEodH0U86BRrs+JYZfKWazV9sm7rqYAnX16/+JeN1SRHA6HzPhvvRfT1qt0zIYw0QpshdsOjomU3eoqzqMthPMkebSBkBYmFVznNjsR5IL5oXA/E= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 24.07.24 15:01, Zi Yan wrote: > memory tiering can be enabled/disabled at runtime and > sysctl_numa_balancing_mode & NUMA_BALANCING_MEMORY_TIERING is used to check > it. In migrate_misplaced_folio(), the check is missing when > PGPROMOTE_SUCCESS is incremented. Add the missing check. > > Reported-by: Kefeng Wang > Closes: https://lore.kernel.org/linux-mm/f4ae2c9c-fe40-4807-bdb2-64cf2d716c1a@huawei.com/ > Fixes: 33024536bafd ("memory tiering: hot page selection with hint page fault latency") > Signed-off-by: Zi Yan > --- > mm/migrate.c | 4 +++- > 1 file changed, 3 insertions(+), 1 deletion(-) > > diff --git a/mm/migrate.c b/mm/migrate.c > index e7296c0fb5d5..826afb82ca56 100644 > --- a/mm/migrate.c > +++ b/mm/migrate.c > @@ -2630,7 +2630,9 @@ int migrate_misplaced_folio(struct folio *folio, struct vm_area_struct *vma, > putback_movable_pages(&migratepages); > if (nr_succeeded) { > count_vm_numa_events(NUMA_PAGE_MIGRATE, nr_succeeded); > - if (!node_is_toptier(folio_nid(folio)) && node_is_toptier(node)) > + if ((sysctl_numa_balancing_mode & NUMA_BALANCING_MEMORY_TIERING) > + && !node_is_toptier(folio_nid(folio)) > + && node_is_toptier(node)) > mod_node_page_state(pgdat, PGPROMOTE_SUCCESS, > nr_succeeded); > } Acked-by: David Hildenbrand -- Cheers, David / dhildenb