From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-11.7 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 100FAC4338F for ; Mon, 16 Aug 2021 08:23:59 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 9402061B04 for ; Mon, 16 Aug 2021 08:23:58 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 9402061B04 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=kvack.org Received: by kanga.kvack.org (Postfix) id 30FB16B0071; Mon, 16 Aug 2021 04:23:58 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 2BF408D0001; Mon, 16 Aug 2021 04:23:58 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 1AEB06B0073; Mon, 16 Aug 2021 04:23:58 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0072.hostedemail.com [216.40.44.72]) by kanga.kvack.org (Postfix) with ESMTP id F2E3D6B0071 for ; Mon, 16 Aug 2021 04:23:57 -0400 (EDT) Received: from smtpin12.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay05.hostedemail.com (Postfix) with ESMTP id 82F6F181AEF2A for ; Mon, 16 Aug 2021 08:23:57 +0000 (UTC) X-FDA: 78480255714.12.03ADB70 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by imf02.hostedemail.com (Postfix) with ESMTP id 343D770080D2 for ; Mon, 16 Aug 2021 08:23:57 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1629102236; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=XePXIUWQuyu3Re8GYDCaNWiGT+mm8bsw0DIVjtODpjc=; b=MYlZ5edUjyKyytgJ/IJ6H+tq0qAPXCCvJe1idX/6qVR7I7UKXfqa3yQCF+CDQJGORM1Dzg SDsRkgiMtBqJnQbajtcgNvh20Z+uahTiw1GufsuCjxrMHUmTLb4FKDE3Bv4NNH6Qxz9UEM 6uVmI4R9BdMmm5OTjqQXNtF1Du1KlSQ= Received: from mail-wr1-f69.google.com (mail-wr1-f69.google.com [209.85.221.69]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-390-EfYBdhZyNY2NdSfMygEraQ-1; Mon, 16 Aug 2021 04:23:52 -0400 X-MC-Unique: EfYBdhZyNY2NdSfMygEraQ-1 Received: by mail-wr1-f69.google.com with SMTP id q11-20020a5d61cb0000b02901550c3fccb5so5213284wrv.14 for ; Mon, 16 Aug 2021 01:23:52 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:organization :message-id:date:user-agent:mime-version:in-reply-to :content-language:content-transfer-encoding; bh=XePXIUWQuyu3Re8GYDCaNWiGT+mm8bsw0DIVjtODpjc=; b=DxMMT+ADGQUGQGjKYTSDICyi0Y+72X6DKqZXA22S8/s9/uMrThDTxC1oZzPmORv56j HLDgzGoEeSkTnOV2d29+6Y3U2Oiv6UjaDm7I+xl+pZxEQwk/7o9PdD6O7aj5ATze9BUK yUcczdZZ9b1piR/KqBC9UUCDpSZK1PlQDVHfsu9V49VOqMfLiFNMLfaPv2+6yphrZa4S sH85Lh9rppvCNnWSUPuG9+Cj2HJOBP2mVuBVMAXmjK5jM49hcIu6A0fBPyFvEcnpgGA/ klQYwNC9qnKovmlRQaBq9PqKiF5iX9XJcpvF7miXeN6e1Dyy8UwC3A9+tDGh5lubkrXO 8NIw== X-Gm-Message-State: AOAM533yEqJRp7uDf4IOZspyZ6aX5rXMXH+YHxD5/DAfwz/URr/On1tJ qFaSPFzv0SK9gWb5yGMG8IDlxw68bK0OVFz3UajBHbv3LTHMb02FKeE3vkZH77JzX5Heq5dW6Kh OurF7qL7x394= X-Received: by 2002:a05:600c:3793:: with SMTP id o19mr9444753wmr.53.1629102231133; Mon, 16 Aug 2021 01:23:51 -0700 (PDT) X-Google-Smtp-Source: ABdhPJy9uZFJbVvynlFhQEDIq3zra3/5Kbt66ggKycJUWqI8INp/MnDFkNfFDWBzlOsQRtE/e01TPQ== X-Received: by 2002:a05:600c:3793:: with SMTP id o19mr9444730wmr.53.1629102230872; Mon, 16 Aug 2021 01:23:50 -0700 (PDT) Received: from [192.168.3.132] (p5b0c67f1.dip0.t-ipconnect.de. [91.12.103.241]) by smtp.gmail.com with ESMTPSA id k17sm10494178wmj.0.2021.08.16.01.23.50 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 16 Aug 2021 01:23:50 -0700 (PDT) Subject: Re: [PATCH] mm, slub: add cpus_read_lock/unlock() for slab_mem_going_offline_callback() To: Stephen Rothwell Cc: qiang.zhang@windriver.com, vbabka@suse.cz, akpm@linux-foundation.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org References: <20210816074605.30336-1-qiang.zhang@windriver.com> <20210816181751.17f98cc2@canb.auug.org.au> From: David Hildenbrand Organization: Red Hat Message-ID: Date: Mon, 16 Aug 2021 10:23:49 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.11.0 MIME-Version: 1.0 In-Reply-To: <20210816181751.17f98cc2@canb.auug.org.au> X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=windows-1252; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-Rspamd-Queue-Id: 343D770080D2 Authentication-Results: imf02.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=MYlZ5edU; dmarc=pass (policy=none) header.from=redhat.com; spf=none (imf02.hostedemail.com: domain of david@redhat.com has no SPF policy when checking 170.10.133.124) smtp.mailfrom=david@redhat.com X-Rspamd-Server: rspam04 X-Stat-Signature: 8zni19sxp338wjibt8jmgm6ad6m7gdz7 X-HE-Tag: 1629102237-107200 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 16.08.21 10:17, Stephen Rothwell wrote: > Hi David, > > On Mon, 16 Aug 2021 10:04:13 +0200 David Hildenbrand wrote: >> >> On 16.08.21 09:46, qiang.zhang@windriver.com wrote: >>> From: "Qiang.Zhang" >>> >>> The flush_all_cpus_locked() should be called with cpus_read_lock/unlock(), >>> ensure flush_cpu_slab() can be executed on schedule_on CPU. >>> >>> Fixes: 1c84f3c91640 ("mm, slub: fix memory and cpu hotplug related lock ordering issues") >> >> Which branch contains this commit? At least not linux.git or linux-next > > It is Andrew's mmotm which is included in linux-next but gets rebased Maybe I am blind or need more coffee: https://www.ozlabs.org/~akpm/mmotm/series > often, so, for example, that SHA1 is no longer valid in linux-next > today (is is now fd917c6407fb). > > This (unfortunately) make Fixes tags less useful for mmotm :-( Right, and it somewhat makes sense, because Andrew will actually squash patches before sending them further upstream. Ideally, such fixes should be discussed in the respective patch series, because before they go upstream, they are still under development. -- Thanks, David / dhildenb