From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7F3A1C54F30 for ; Tue, 27 May 2025 16:52:17 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id F09796B00E1; Tue, 27 May 2025 12:52:16 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id E92EC6B00E2; Tue, 27 May 2025 12:52:16 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id D80C66B00E3; Tue, 27 May 2025 12:52:16 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id B61926B00E1 for ; Tue, 27 May 2025 12:52:16 -0400 (EDT) Received: from smtpin16.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id 31E19160A75 for ; Tue, 27 May 2025 16:52:16 +0000 (UTC) X-FDA: 83489280672.16.D3397CF Received: from szxga01-in.huawei.com (szxga01-in.huawei.com [45.249.212.187]) by imf17.hostedemail.com (Postfix) with ESMTP id A11094000C for ; Tue, 27 May 2025 16:52:13 +0000 (UTC) Authentication-Results: imf17.hostedemail.com; dkim=none; spf=pass (imf17.hostedemail.com: domain of pulehui@huawei.com designates 45.249.212.187 as permitted sender) smtp.mailfrom=pulehui@huawei.com; dmarc=pass (policy=quarantine) header.from=huawei.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1748364734; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=sCj8Gb7URTcvjWHe90QxsokUC+c33PXn+cwR7I8NsAQ=; b=blA89uqVT4iRjfWUKNY3d6qgl3/NZY94qnreC/gY/dpI9/vrksf16Wg1AnLksKqnpAW7oo evteztrNj1m/d/5IgJN+46aQozdjBWi2WshDWIv8GAVAGw8KkVOUExsVLqNpJc7ETcWlRs hurCuaxQi4yoifL6Q1cUkTqOjz5seCg= ARC-Authentication-Results: i=1; imf17.hostedemail.com; dkim=none; spf=pass (imf17.hostedemail.com: domain of pulehui@huawei.com designates 45.249.212.187 as permitted sender) smtp.mailfrom=pulehui@huawei.com; dmarc=pass (policy=quarantine) header.from=huawei.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1748364734; a=rsa-sha256; cv=none; b=LOKeGe5hqrP8iSZA48cN+59OKHJpY0JKtYp+ZM4r/6rPqc1mvzljGyeHkyHRkMon1IZwMk SfupmkEWB8WxbKUhRzzdPfMIDEDnGOZfANKn/31e+PRtbjY9tnR/aXnqTDuj0o+B0dXbA7 QaXGuX5OA/TmxQelHpDRt9bwJw3ox0o= Received: from mail.maildlp.com (unknown [172.19.163.252]) by szxga01-in.huawei.com (SkyGuard) with ESMTP id 4b6JTX6R3RzvWs5; Wed, 28 May 2025 00:47:44 +0800 (CST) Received: from kwepemf100007.china.huawei.com (unknown [7.202.181.221]) by mail.maildlp.com (Postfix) with ESMTPS id 5974F180B61; Wed, 28 May 2025 00:52:09 +0800 (CST) Received: from [10.67.109.184] (10.67.109.184) by kwepemf100007.china.huawei.com (7.202.181.221) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1544.11; Wed, 28 May 2025 00:52:08 +0800 Message-ID: Date: Wed, 28 May 2025 00:52:08 +0800 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [RFC PATCH v2 1/2] mm/mremap: Fix uprobe anon page be overwritten when expanding vma during mremap Content-Language: en-US To: Lorenzo Stoakes , Pu Lehui CC: Oleg Nesterov , , , , , , , , , References: <20250527132351.2050820-1-pulehui@huaweicloud.com> <20250527132351.2050820-2-pulehui@huaweicloud.com> <20250527142314.GA8333@redhat.com> <3f0f86a3-6ac4-47b5-8626-162b117dce0f@lucifer.local> From: Pu Lehui In-Reply-To: <3f0f86a3-6ac4-47b5-8626-162b117dce0f@lucifer.local> Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: 8bit X-Originating-IP: [10.67.109.184] X-ClientProxiedBy: kwepems500002.china.huawei.com (7.221.188.17) To kwepemf100007.china.huawei.com (7.202.181.221) X-Rspamd-Server: rspam05 X-Rspamd-Queue-Id: A11094000C X-Stat-Signature: 94ntd4wezyh1epwfip8qrnbgstxipkta X-Rspam-User: X-HE-Tag: 1748364733-155687 X-HE-Meta: U2FsdGVkX1/9llXui0AmANAs5+2qMtcI5Ls8pJy/hWbhimtukVBLTBBdqf89uPU9zDnZXSylx6wlTMeUTuAjySA9CZc2uG6dw/p/M9Mq45mkJXrijaalW04hQDvyz2wPGPwD/ZWQxazIUg2hMGztQZwNYCyqfu+U5Noy2MYL5CpmQklmZ1NWsHC27fuMTeFqSD/9hjIv3YZoePC2vKmiPP5ejRYaALROYqsulIExnNkpdO8yb9OJFRugDYrgYtvsdbvCTQrWT0lMRaZ09EKtJcyD0RLsJ+CIlCMd6r8mDYMPj8FDm5uX1emW2LXCjF7TNO8Fh3sZ/f13BFoh30OvIbJ+Hl1h/vZn0u/EH5w395A/HfD0DtC5PHJ/VE/i0iyRr0vWKLTTGq1OtSSddqAbPen/cxi/rt97fQm5rQ+9vbzp+PFNzoOg55W55Ig/Oabpqvvg2M1lBc2TG/YiLS/R56cn9tveK6KITg+/Fancj54NKZcx+p69WxBAs1Mo57zF0UfHccYP9LI6yj1zJV8wnN0gBK5GQY3CaqtA+OS01n05MeTTj/BSpWOa302AdhhTkwyZiaP8yq7OCDnJp6Q2kP+fhtQP61enKcaD9j+ppmV5b3JVDFgA9oLfLQXX9C93oeCkqRxrEhXXBpTHOXf6nxlIwGq8I+iJLCdmrHtaMMn8FfJOfQODWe6nB4M5Ejs2uFj2YsWMwqMPIdnlrCyJqPU/MphNq0hP5EZSJZqLZm2+mSbeK3iiMK1cGC152/6g/JAqHD2Raqj+KgCc7ECSdoMzmXn0ubuGn2DfSPfbYazO2PQXR5Lw72SDSF5OVdZ8AfVTjIdzr6/qIdQ9Y7jU22qAMWjsTcoM+dmpbdkedKZyZukA79qBLbDE1FumjIEj5zUX9JI31yn25Gs7kx7w7Oz5XXoK9nJCCsxlqDapWnQsE2OgQSEIZsFzJnd0g8AlJe1LhQLoOCOtuEmAJUq 3fuRhkS+ u/BaQXrf9+o9rD/9pNFIuTFAOD6mYCNU+jBrv8x9YhIAmNcyRxwqTp5VR1+yCPsbi9xy0iYVq1sZXj1ixFyOuSTo42w8/96kuoeRifduWlpj3MBhgS70UPA5GnvJIyU5dCLnJHvLEcwpUGabQt+JtdHrp2qBuKpsR0Ak+PxqLS8mzBnapFso/u/TPG6VvOKA738TX3p4eEZ1bS78FLqt5LffRDaa9TfYzT/IRvaPWDKSh1pl/7rMXbqmuEQ== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 2025/5/28 0:37, Lorenzo Stoakes wrote: > On Wed, May 28, 2025 at 12:32:57AM +0800, Pu Lehui wrote: >> >> On 2025/5/27 22:23, Oleg Nesterov wrote: >>> Well, I leave this to you / Lorenzo / David, but... >>> >>> On 05/27, Pu Lehui wrote: >>>> >>>> Fixes: 78a320542e6c ("uprobes: Change valid_vma() to demand VM_MAYEXEC rather than VM_EXEC") >>> >>> I don't think that commit could cause this problem. >> >> Hi Oleg, >> >> Me too! I was test that before and after commit 78a320542e6c, so call it the >> `directly related commit`. In fact, I think the issue was introduced in the >> original commit 2b1444983508 ("uprobes, mm, x86: Add the ability to install >> and remove uprobes breakpoints") # v3.5-rc1. > > Yeah I missed this! I concure that the cited fixes commit is probably not it :P > > Your repro is delightfully consistent so could you bisect to be sure? OK, I will try that tomorrow. PS: It is hard to work repro that for the so old kernel.😅 > > BTW did you just say v3.5... Good Lord :) > >> >>> >>> Oleg. >> >