From: Pu Lehui <pulehui@huawei.com>
To: Lorenzo Stoakes <lorenzo.stoakes@oracle.com>,
Pu Lehui <pulehui@huaweicloud.com>
Cc: Oleg Nesterov <oleg@redhat.com>, <mhiramat@kernel.org>,
<peterz@infradead.org>, <akpm@linux-foundation.org>,
<Liam.Howlett@oracle.com>, <vbabka@suse.cz>, <jannh@google.com>,
<pfalcato@suse.de>, <linux-mm@kvack.org>,
<linux-kernel@vger.kernel.org>
Subject: Re: [RFC PATCH v2 1/2] mm/mremap: Fix uprobe anon page be overwritten when expanding vma during mremap
Date: Wed, 28 May 2025 00:52:08 +0800 [thread overview]
Message-ID: <e9a85a82-750e-4ab8-aa1a-d760efd6a818@huawei.com> (raw)
In-Reply-To: <3f0f86a3-6ac4-47b5-8626-162b117dce0f@lucifer.local>
On 2025/5/28 0:37, Lorenzo Stoakes wrote:
> On Wed, May 28, 2025 at 12:32:57AM +0800, Pu Lehui wrote:
>>
>> On 2025/5/27 22:23, Oleg Nesterov wrote:
>>> Well, I leave this to you / Lorenzo / David, but...
>>>
>>> On 05/27, Pu Lehui wrote:
>>>>
>>>> Fixes: 78a320542e6c ("uprobes: Change valid_vma() to demand VM_MAYEXEC rather than VM_EXEC")
>>>
>>> I don't think that commit could cause this problem.
>>
>> Hi Oleg,
>>
>> Me too! I was test that before and after commit 78a320542e6c, so call it the
>> `directly related commit`. In fact, I think the issue was introduced in the
>> original commit 2b1444983508 ("uprobes, mm, x86: Add the ability to install
>> and remove uprobes breakpoints") # v3.5-rc1.
>
> Yeah I missed this! I concure that the cited fixes commit is probably not it :P
>
> Your repro is delightfully consistent so could you bisect to be sure?
OK, I will try that tomorrow. PS: It is hard to work repro that for the
so old kernel.😅
>
> BTW did you just say v3.5... Good Lord :)
>
>>
>>>
>>> Oleg.
>>
>
next prev parent reply other threads:[~2025-05-27 16:52 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-05-27 13:23 [RFC PATCH v2 0/2] Fix uprobe anon page be overwritten " Pu Lehui
2025-05-27 13:23 ` [RFC PATCH v2 1/2] mm/mremap: Fix uprobe anon page be overwritten when expanding vma " Pu Lehui
2025-05-27 13:34 ` Lorenzo Stoakes
2025-05-27 15:17 ` Oleg Nesterov
2025-05-27 15:27 ` Lorenzo Stoakes
2025-05-27 15:29 ` Lorenzo Stoakes
2025-05-27 16:29 ` Pu Lehui
2025-05-27 14:23 ` Oleg Nesterov
2025-05-27 16:32 ` Pu Lehui
2025-05-27 16:37 ` Lorenzo Stoakes
2025-05-27 16:52 ` Pu Lehui [this message]
2025-05-27 17:20 ` Oleg Nesterov
2025-05-29 15:09 ` Pu Lehui
2025-05-29 15:12 ` Lorenzo Stoakes
2025-05-27 15:30 ` Oleg Nesterov
2025-05-27 15:33 ` Lorenzo Stoakes
2025-05-27 15:52 ` Oleg Nesterov
2025-05-27 16:41 ` Pu Lehui
2025-05-27 16:35 ` Pu Lehui
2025-05-27 13:23 ` [RFC PATCH v2 2/2] mm/mremap: Expose abnormal new_pte during move_ptes Pu Lehui
2025-05-27 14:24 ` Oleg Nesterov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=e9a85a82-750e-4ab8-aa1a-d760efd6a818@huawei.com \
--to=pulehui@huawei.com \
--cc=Liam.Howlett@oracle.com \
--cc=akpm@linux-foundation.org \
--cc=jannh@google.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=lorenzo.stoakes@oracle.com \
--cc=mhiramat@kernel.org \
--cc=oleg@redhat.com \
--cc=peterz@infradead.org \
--cc=pfalcato@suse.de \
--cc=pulehui@huaweicloud.com \
--cc=vbabka@suse.cz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox