* [PATCH] mm/hmm/test: Fix an error code in dmirror_allocate_chunk()
@ 2020-10-10 20:08 Dan Carpenter
2020-10-11 20:58 ` Ralph Campbell
0 siblings, 1 reply; 2+ messages in thread
From: Dan Carpenter @ 2020-10-10 20:08 UTC (permalink / raw)
To: Jérôme Glisse
Cc: Stephen Rothwell, Ralph Campbell, Jason Gunthorpe, Dan Williams,
Andrew Morton, linux-mm, kernel-janitors
This is supposed to return false on failure, not a negative error code.
Fixes: 170e38548b81 ("mm/hmm/test: use after free in dmirror_allocate_chunk()")
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
---
I messed this up earlier... My devel version of Smatch prints too much
garbage so I missed the warning when I first wrote the patch. :/
Sorry.
lib/test_hmm.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/lib/test_hmm.c b/lib/test_hmm.c
index e151a7f10519..80a78877bd93 100644
--- a/lib/test_hmm.c
+++ b/lib/test_hmm.c
@@ -461,7 +461,7 @@ static bool dmirror_allocate_chunk(struct dmirror_device *mdevice,
devmem = kzalloc(sizeof(*devmem), GFP_KERNEL);
if (!devmem)
- return -ENOMEM;
+ return false;
res = request_free_mem_region(&iomem_resource, DEVMEM_CHUNK_SIZE,
"hmm_dmirror");
--
2.28.0
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH] mm/hmm/test: Fix an error code in dmirror_allocate_chunk()
2020-10-10 20:08 [PATCH] mm/hmm/test: Fix an error code in dmirror_allocate_chunk() Dan Carpenter
@ 2020-10-11 20:58 ` Ralph Campbell
0 siblings, 0 replies; 2+ messages in thread
From: Ralph Campbell @ 2020-10-11 20:58 UTC (permalink / raw)
To: Dan Carpenter, Jérôme Glisse
Cc: Stephen Rothwell, Jason Gunthorpe, Dan Williams, Andrew Morton,
linux-mm, kernel-janitors
On 10/10/20 1:08 PM, Dan Carpenter wrote:
> This is supposed to return false on failure, not a negative error code.
>
> Fixes: 170e38548b81 ("mm/hmm/test: use after free in dmirror_allocate_chunk()")
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
> ---
> I messed this up earlier... My devel version of Smatch prints too much
> garbage so I missed the warning when I first wrote the patch. :/
> Sorry.
>
> lib/test_hmm.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/lib/test_hmm.c b/lib/test_hmm.c
> index e151a7f10519..80a78877bd93 100644
> --- a/lib/test_hmm.c
> +++ b/lib/test_hmm.c
> @@ -461,7 +461,7 @@ static bool dmirror_allocate_chunk(struct dmirror_device *mdevice,
>
> devmem = kzalloc(sizeof(*devmem), GFP_KERNEL);
> if (!devmem)
> - return -ENOMEM;
> + return false;
>
> res = request_free_mem_region(&iomem_resource, DEVMEM_CHUNK_SIZE,
> "hmm_dmirror");
Thanks for fixing this.
Reviewed-by: Ralph Campbell <rcampbell@nvidia.com>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2020-10-11 20:58 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-10-10 20:08 [PATCH] mm/hmm/test: Fix an error code in dmirror_allocate_chunk() Dan Carpenter
2020-10-11 20:58 ` Ralph Campbell
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox