From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id CCD17C433EF for ; Wed, 29 Sep 2021 09:03:15 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 63D21613A6 for ; Wed, 29 Sep 2021 09:03:15 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 63D21613A6 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=kvack.org Received: by kanga.kvack.org (Postfix) id EFDEE940016; Wed, 29 Sep 2021 05:03:14 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id EAD76940011; Wed, 29 Sep 2021 05:03:14 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id D9D3C940016; Wed, 29 Sep 2021 05:03:14 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0037.hostedemail.com [216.40.44.37]) by kanga.kvack.org (Postfix) with ESMTP id CB49B940011 for ; Wed, 29 Sep 2021 05:03:14 -0400 (EDT) Received: from smtpin38.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay04.hostedemail.com (Postfix) with ESMTP id 7CE73256E1 for ; Wed, 29 Sep 2021 09:03:14 +0000 (UTC) X-FDA: 78640021908.38.E314F45 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by imf03.hostedemail.com (Postfix) with ESMTP id 061C230000B1 for ; Wed, 29 Sep 2021 09:03:13 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1632906193; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=7W9Fc0fF86WyXYecPV/lI8dmSptGKk8vSEWO1VbX84s=; b=VgUT5Wkwz6V88ZQWns3PibHMln4HGhgp//Lqv9xtWWLTUU31B+jaqn1HXLjgQC/QydaJh8 NDkadZGDpMr/7/xCagBYELPHCNxaXtcFe2exkJT+esc+RwifmAL59hZ6W7hNVbT8JgYUIs S8u2Og2LtVssz/7JezgZKEYnn+I6IDY= Received: from mail-wr1-f72.google.com (mail-wr1-f72.google.com [209.85.221.72]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-182-DjtlJRNlNQmZRJCsC36JkQ-1; Wed, 29 Sep 2021 05:03:12 -0400 X-MC-Unique: DjtlJRNlNQmZRJCsC36JkQ-1 Received: by mail-wr1-f72.google.com with SMTP id e12-20020a056000178c00b001606927de88so391420wrg.10 for ; Wed, 29 Sep 2021 02:03:11 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:subject:from:to:cc:references:organization :message-id:date:user-agent:mime-version:in-reply-to :content-language:content-transfer-encoding; bh=7W9Fc0fF86WyXYecPV/lI8dmSptGKk8vSEWO1VbX84s=; b=aVHjnNXBaL7+xF9biqPDV7IYYyHFhovYz0cSTLilHc162YhMUzBwZjwT0Yls1LtNKf E8IQtVJrutkyIwPn9EIrITm42GXGLASVzIlMZH2IhMZ7zXy5RultIpi8NWjkxAxHDF0E JtNimtTOjoX6tacRgfrdjdH57iqHzrlaAO+gDTiuZYZA3fAiffo+ffFqYe118Ntopu+y +OSo9cxNsQeEHl6OKBMzptBZj7yLWVAr+vMwRPHkDCwGiqhgsnq5mZyu0tj8Hf9Fg3zn 2iSnPvqt4oJ/Z8IzuHiSF2ryRkUyiGq5BZ5sUzo4faZ/AKYIKJW7M1kSAnm9q68Omjo+ Vm3Q== X-Gm-Message-State: AOAM530XlAJmSGD3EhDBghj23ahAKIR09l7tYEm2PXSpwRrlxliVmO29 JNBsE6DmQZBq3PveNhifR7sJg5bcKuKL5US5bVdYqmELwLv5PZJ0nXsI2Fj4G2mq8M3cU0bDMxn F5qaosXeGDG+kQUHNIY0YYOm/s5HlNzOdU0hi2JROZnh+IueHa4ZqhmVvJXs= X-Received: by 2002:a7b:c219:: with SMTP id x25mr9238918wmi.125.1632906191056; Wed, 29 Sep 2021 02:03:11 -0700 (PDT) X-Google-Smtp-Source: ABdhPJyAVvczz8jUTCdMNZ0BC5qvezoqKUBOcf5OajF0CWmKLmPAPf0K3OR8WEfpMUG5vsV5dclhgg== X-Received: by 2002:a7b:c219:: with SMTP id x25mr9238872wmi.125.1632906190770; Wed, 29 Sep 2021 02:03:10 -0700 (PDT) Received: from [192.168.3.132] (p4ff23c3b.dip0.t-ipconnect.de. [79.242.60.59]) by smtp.gmail.com with ESMTPSA id t11sm1548498wrz.65.2021.09.29.02.03.09 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 29 Sep 2021 02:03:10 -0700 (PDT) Subject: Re: [PATCH v1 2/8] x86/xen: simplify xen_oldmem_pfn_is_ram() From: David Hildenbrand To: Boris Ostrovsky , linux-kernel@vger.kernel.org Cc: Andrew Morton , Thomas Gleixner , Ingo Molnar , Borislav Petkov , "H. Peter Anvin" , Juergen Gross , Stefano Stabellini , "Michael S. Tsirkin" , Jason Wang , Dave Young , Baoquan He , Vivek Goyal , Michal Hocko , Oscar Salvador , Mike Rapoport , "Rafael J. Wysocki" , x86@kernel.org, xen-devel@lists.xenproject.org, virtualization@lists.linux-foundation.org, kexec@lists.infradead.org, linux-fsdevel@vger.kernel.org, linux-mm@kvack.org References: <20210928182258.12451-1-david@redhat.com> <20210928182258.12451-3-david@redhat.com> <4ab2f8c2-c3d5-30b3-a670-a8b38e218b6e@oracle.com> Organization: Red Hat Message-ID: Date: Wed, 29 Sep 2021 11:03:09 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.11.0 MIME-Version: 1.0 In-Reply-To: X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Authentication-Results: imf03.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=VgUT5Wkw; spf=none (imf03.hostedemail.com: domain of david@redhat.com has no SPF policy when checking 170.10.133.124) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=none) header.from=redhat.com X-Rspamd-Server: rspam04 X-Rspamd-Queue-Id: 061C230000B1 X-Stat-Signature: 1186abq6x8cutc4cys1kh6kki79jhzz3 X-HE-Tag: 1632906193-639791 Content-Transfer-Encoding: quoted-printable X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 29.09.21 10:45, David Hildenbrand wrote: >> >> How about >> >> =C2=A0=C2=A0=C2=A0 return a.mem_type !=3D HVMMEM_mmio_dm; >> >=20 > Ha, how could I have missed that :) >=20 >> >> Result should be promoted to int and this has added benefit of not req= uiring changes in patch 4. >> >=20 > Can we go one step further and do >=20 >=20 > @@ -20,24 +20,11 @@ static int xen_oldmem_pfn_is_ram(unsigned long pfn) > struct xen_hvm_get_mem_type a =3D { > .domid =3D DOMID_SELF, > .pfn =3D pfn, > + .mem_type =3D HVMMEM_ram_rw, > }; > - int ram; > =20 > - if (HYPERVISOR_hvm_op(HVMOP_get_mem_type, &a)) > - return -ENXIO; > - > - switch (a.mem_type) { > - case HVMMEM_mmio_dm: > - ram =3D 0; > - break; > - case HVMMEM_ram_rw: > - case HVMMEM_ram_ro: > - default: > - ram =3D 1; > - break; > - } > - > - return ram; > + HYPERVISOR_hvm_op(HVMOP_get_mem_type, &a); > + return a.mem_type !=3D HVMMEM_mmio_dm; > } > #endif >=20 >=20 > Assuming that if HYPERVISOR_hvm_op() fails that > .mem_type is not set to HVMMEM_mmio_dm. >=20 Okay we can't, due to "__must_check" ... --=20 Thanks, David / dhildenb