From: Randy Dunlap <rdunlap@infradead.org>
To: zhaimingbing <zhaimingbing@cmss.chinamobile.com>,
willy@infradead.org, James.Bottomley@hansenpartnership.com
Cc: akpm@linux-foundation.org, linux-mm@kvack.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] mm: fix multiple typos in multiple files
Date: Fri, 27 Oct 2023 00:19:53 -0700 [thread overview]
Message-ID: <e969ed08-3492-4bac-8f4f-a7e3a59da6f0@infradead.org> (raw)
In-Reply-To: <20231027064345.2434-1-zhaimingbing@cmss.chinamobile.com>
Hi--
On 10/26/23 23:43, zhaimingbing wrote:
> nommu.c: Fix typo 'privatize'
> io-mapping.c: Fix typo 'pre-validation'
>
> Signed-off-by: zhaimingbing <zhaimingbing@cmss.chinamobile.com>
> ---
> mm/io-mapping.c | 2 +-
> mm/nommu.c | 2 +-
> 2 files changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/mm/io-mapping.c b/mm/io-mapping.c
> index 01b362799..486598ba4 100644
> --- a/mm/io-mapping.c
> +++ b/mm/io-mapping.c
> @@ -21,7 +21,7 @@ int io_mapping_map_user(struct io_mapping *iomap, struct vm_area_struct *vma,
> if (WARN_ON_ONCE((vma->vm_flags & expected_flags) != expected_flags))
> return -EINVAL;
>
> - /* We rely on prevalidation of the io-mapping to skip track_pfn(). */
> + /* We rely on pre-validation of the io-mapping to skip track_pfn(). */
Not needed. The hyphen seems to be optional from what I see on the internet.
> return remap_pfn_range_notrack(vma, addr, pfn, size,
> __pgprot((pgprot_val(iomap->prot) & _PAGE_CACHE_MASK) |
> (pgprot_val(vma->vm_page_prot) & ~_PAGE_CACHE_MASK)));
> diff --git a/mm/nommu.c b/mm/nommu.c
> index 7f9e9e5a0..40842b080 100644
> --- a/mm/nommu.c
> +++ b/mm/nommu.c
> @@ -776,7 +776,7 @@ static int validate_mmap_request(struct file *file,
> if (!(capabilities & NOMMU_MAP_DIRECT))
> return -ENODEV;
>
> - /* we mustn't privatise shared mappings */
> + /* we mustn't privatize shared mappings */
We accept British spellings. :)
> capabilities &= ~NOMMU_MAP_COPY;
> } else {
> /* we're going to read the file into private memory we
Thanks.
--
~Randy
next prev parent reply other threads:[~2023-10-27 7:20 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-10-27 6:43 zhaimingbing
2023-10-27 7:19 ` Randy Dunlap [this message]
2023-10-27 8:04 ` David Hildenbrand
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=e969ed08-3492-4bac-8f4f-a7e3a59da6f0@infradead.org \
--to=rdunlap@infradead.org \
--cc=James.Bottomley@hansenpartnership.com \
--cc=akpm@linux-foundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=willy@infradead.org \
--cc=zhaimingbing@cmss.chinamobile.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox