From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-19.9 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_CR_TRAILER,INCLUDES_PATCH,MAILING_LIST_MULTI,NICE_REPLY_A, SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id CD46CC432BE for ; Thu, 2 Sep 2021 12:13:53 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 6EBE0610CC for ; Thu, 2 Sep 2021 12:13:53 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 6EBE0610CC Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=kvack.org Received: by kanga.kvack.org (Postfix) id 0FE606B006C; Thu, 2 Sep 2021 08:13:53 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 0AED06B0071; Thu, 2 Sep 2021 08:13:53 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id EE0F88D0001; Thu, 2 Sep 2021 08:13:52 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0160.hostedemail.com [216.40.44.160]) by kanga.kvack.org (Postfix) with ESMTP id DEA1D6B006C for ; Thu, 2 Sep 2021 08:13:52 -0400 (EDT) Received: from smtpin05.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay04.hostedemail.com (Postfix) with ESMTP id 92A56DB52 for ; Thu, 2 Sep 2021 12:13:52 +0000 (UTC) X-FDA: 78542524704.05.BC1011C Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by imf02.hostedemail.com (Postfix) with ESMTP id 044467001776 for ; Thu, 2 Sep 2021 12:13:51 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1630584831; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=rqPSPzSUaCvr89fYf7X2rIuK0UXpdRDiuT57nCVYGHk=; b=JMlRGokq85YQgKfGk5X6VmdGq2O9hBGxaeLrmoNt1fxFyxGDh/23Y5pEedEzRMWMILLzXS VBedVR0zhxLoUwcI//G8LmI5o7H5MWyreQ2qA6vTErkRVXVTx4ytFxwbrSdlUh4RBc+a6V nTK1ziGU5D/N5vJMxOBwmdmKSOQQMlY= Received: from mail-wm1-f72.google.com (mail-wm1-f72.google.com [209.85.128.72]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-590-Tnwr9sjsNB-Jw5pIihyvDg-1; Thu, 02 Sep 2021 08:13:50 -0400 X-MC-Unique: Tnwr9sjsNB-Jw5pIihyvDg-1 Received: by mail-wm1-f72.google.com with SMTP id g3-20020a1c2003000000b002e751c4f439so912567wmg.7 for ; Thu, 02 Sep 2021 05:13:50 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:organization :message-id:date:user-agent:mime-version:in-reply-to :content-language:content-transfer-encoding; bh=rqPSPzSUaCvr89fYf7X2rIuK0UXpdRDiuT57nCVYGHk=; b=T3I2B1GekXrtzGLp7zPkosR7wJm7rit/FienYXLpUvu6099RWYCgGhP0vmPY7m0F+i OE3r8EjZoysdgn9YCKD1WFp4f5Q/StapgZM+uPdGlJcxnKblVhlEoa/l38TbAJ4gjWB2 E86Vi+CpWv7hbXN9hccmJHeyNmpY+/UptgQnBuPIyPEYLJt2hL2jfsswuIvsII61d/Sd D8l1KGoT5PZJLGkSIBCObk+mmy1kx/YLdNDS1xaq1WisBfS1W5UJYjnLUy6G3IBSbnLo Ep3VcE/i91XWQGiVEvaYm+4VxD9PXZa16kjzNC8oVvZA0M4Fm8+xF7xMnIlQU2cAR/UB e7gQ== X-Gm-Message-State: AOAM533N04OAoY4awlrAJmzKMXwNESOxvYr2tldlArmTuNirkbZY3Vm7 YMUy+bIBtKy8OddwhEDbMGJqwRR6VxwTOt1/Ijbq4/ASmtpF6UBDWwWO8lugzjQXnm/rZ4gnR1P 8spVVXX+bmVM= X-Received: by 2002:a05:600c:35d6:: with SMTP id r22mr2853101wmq.44.1630584829392; Thu, 02 Sep 2021 05:13:49 -0700 (PDT) X-Google-Smtp-Source: ABdhPJzgdVixWXxgjrfce5Mk0e7FJX9/rSNhRkjtXGLRgv9FnrjAuox4WemEHgxgvGClZv8hv3p6lw== X-Received: by 2002:a05:600c:35d6:: with SMTP id r22mr2853074wmq.44.1630584829124; Thu, 02 Sep 2021 05:13:49 -0700 (PDT) Received: from [192.168.3.132] (p5b0c60bd.dip0.t-ipconnect.de. [91.12.96.189]) by smtp.gmail.com with ESMTPSA id m3sm2107274wrg.45.2021.09.02.05.13.48 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 02 Sep 2021 05:13:48 -0700 (PDT) Subject: Re: [PATCH v2] mm/page_alloc.c: avoid accessing uninitialized pcp page migratetype To: Miaohe Lin , akpm@linux-foundation.org Cc: vbabka@suse.cz, peterz@infradead.org, mgorman@techsingularity.net, linux-mm@kvack.org, linux-kernel@vger.kernel.org References: <20210902115447.57050-1-linmiaohe@huawei.com> From: David Hildenbrand Organization: Red Hat Message-ID: Date: Thu, 2 Sep 2021 14:13:48 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.11.0 MIME-Version: 1.0 In-Reply-To: <20210902115447.57050-1-linmiaohe@huawei.com> X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Authentication-Results: imf02.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=JMlRGokq; spf=none (imf02.hostedemail.com: domain of david@redhat.com has no SPF policy when checking 170.10.133.124) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=none) header.from=redhat.com X-Rspamd-Server: rspam02 X-Rspamd-Queue-Id: 044467001776 X-Stat-Signature: knxr91i9xxf756wa3jkfq4u1o9abxt8u X-HE-Tag: 1630584831-558683 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 02.09.21 13:54, Miaohe Lin wrote: > If it's not prepared to free unref page, the pcp page migratetype is > unset. Thus We will get rubbish from get_pcppage_migratetype() and > might list_del &page->lru again after it's already deleted from the > list leading to grumble about data corruption. > > Fixes: df1acc856923 ("mm/page_alloc: avoid conflating IRQs disabled with zone->lock") > Signed-off-by: Miaohe Lin > Acked-by: Mel Gorman > Cc: > --- > mm/page_alloc.c | 4 +++- > 1 file changed, 3 insertions(+), 1 deletion(-) > > diff --git a/mm/page_alloc.c b/mm/page_alloc.c > index 9c09dcb24149..a3c6acafa478 100644 > --- a/mm/page_alloc.c > +++ b/mm/page_alloc.c > @@ -3420,8 +3420,10 @@ void free_unref_page_list(struct list_head *list) > /* Prepare pages for freeing */ > list_for_each_entry_safe(page, next, list, lru) { > pfn = page_to_pfn(page); > - if (!free_unref_page_prepare(page, pfn, 0)) > + if (!free_unref_page_prepare(page, pfn, 0)) { > list_del(&page->lru); > + continue; > + } > > /* > * Free isolated pages directly to the allocator, see > Reviewed-by: David Hildenbrand -- Thanks, David / dhildenb