From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id ACFF8C04FF6 for ; Tue, 16 Apr 2024 08:16:31 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 46BFA6B0098; Tue, 16 Apr 2024 04:16:31 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 41CA76B009B; Tue, 16 Apr 2024 04:16:31 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 2E4F96B009D; Tue, 16 Apr 2024 04:16:31 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id 125456B0098 for ; Tue, 16 Apr 2024 04:16:31 -0400 (EDT) Received: from smtpin26.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id CD754160978 for ; Tue, 16 Apr 2024 08:16:30 +0000 (UTC) X-FDA: 82014688140.26.38E2BE8 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by imf17.hostedemail.com (Postfix) with ESMTP id 937234000E for ; Tue, 16 Apr 2024 08:16:28 +0000 (UTC) Authentication-Results: imf17.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=cXem7K2i; dmarc=pass (policy=none) header.from=redhat.com; spf=pass (imf17.hostedemail.com: domain of david@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=david@redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1713255388; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=GjxDFmTv83GTdla1FKDv4tnI7NcoldxshbtNwzLPCnk=; b=1dYrwEZRDiieT9ixcqJtAinx0fzx7HOMS4z7fP5fUUCTYSPvRR7UiKAmK8Dk5mZpsHZ/eS 9uWAP03ZTvGKSeR2CHz8Tv8n3cpqtEVoXzb7cNo4chz/U9vkfiTtrLXGbAeB9KaNgzx3vH lA6Qv7fSlxiC7SLwjQBSM8IiwS+j434= ARC-Authentication-Results: i=1; imf17.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=cXem7K2i; dmarc=pass (policy=none) header.from=redhat.com; spf=pass (imf17.hostedemail.com: domain of david@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=david@redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1713255388; a=rsa-sha256; cv=none; b=HwMAN+ShsQr4gBCWweCyX3Dy88AKc1LGZPhobjyO7XM4D96PIFsAFLSNcdG545Udrm6mdJ F68k+wp8Tq8BH4sNhZ/TTKpszxL6ERJJy8jnT4n0zEo/ttYmn0PznjIi2pj9zhxUnOyJAJ fnLG0ywax0sXlGn8nOmxsPMnhJGy5v8= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1713255388; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=GjxDFmTv83GTdla1FKDv4tnI7NcoldxshbtNwzLPCnk=; b=cXem7K2iGvakJdEfRDky4DDBPoZzcNmPr5pdGqA9oArHshUBkHASQDhIYo66zvV1+3w2aR M4CzzeqGwRvA0fSigh2AZxkVNeONRs5VpGK9SG4SIwVIu1SmgpPgq+FugV1UQqzurcneHQ oSO3YWRx8bgkeGsZRUrXVVaCYnxL7P4= Received: from mail-lf1-f69.google.com (mail-lf1-f69.google.com [209.85.167.69]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-613-iNjHSok1NY-d8wTm7a4PEg-1; Tue, 16 Apr 2024 04:16:26 -0400 X-MC-Unique: iNjHSok1NY-d8wTm7a4PEg-1 Received: by mail-lf1-f69.google.com with SMTP id 2adb3069b0e04-51898448979so2892697e87.0 for ; Tue, 16 Apr 2024 01:16:26 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1713255385; x=1713860185; h=content-transfer-encoding:in-reply-to:organization:autocrypt:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=GjxDFmTv83GTdla1FKDv4tnI7NcoldxshbtNwzLPCnk=; b=wzF3NeuGMzeV5of+EZvI3lLP69zZvsE2MOiqfoOaN3jz0PWU/Bz3RhWIjFAR5Qylqf iJwzQha2OHbj4HQ+WEz/HbnOY6EAbK/H1DLzFKG8GxENhDmCYeWCSrxiQCS1UXJyIt/u zpINi+l/nNCrq1wlWBQklc/2CCsVyMKXQr6/TG8Y5VIA8pwCu3pDg/TgelB8oFtvOa7e 3SBm/1KPlkkzTiT/1in20aU/6Rn8maSdQ5oMGPD5K2CT25gnH4SCIPySQvAW17vlUmWS X/bhun1/hjilzL1E2RIGoerzKVJO5Hty4GkHtRiNYpfgH1dk9rVPMsY7gkUd/+rtGtDy WphQ== X-Forwarded-Encrypted: i=1; AJvYcCUFvQUUa/0C8XjNvf6u6zjPvZpidnB/wHMxxv4+Zmi8B4fxEGk917DUXA/pyQIMp3lHISRHR+rGnSkQgUzcKGsL6js= X-Gm-Message-State: AOJu0YxxkqR+5cVSpt2rwOUDVfTKibL/VCpAcrAHj47kV7k23hK7msJJ ZS8pZa2qKjFJI6pfKgzX8U6JnJzi3CA+ij9hxS13S9lInNcbebnNe+tit7mSkUaMO4hCH9yIyxZ qG2A0bYM83DDKzUx0ZdvEtJFvASxHv/L20p37bMitihxycgNl X-Received: by 2002:ac2:46c9:0:b0:516:fe8c:ef9b with SMTP id p9-20020ac246c9000000b00516fe8cef9bmr6936136lfo.57.1713255385071; Tue, 16 Apr 2024 01:16:25 -0700 (PDT) X-Google-Smtp-Source: AGHT+IF8jl71f1UcNhTc3sFovRvdhxM/4PWvun8WCOVeM1+zuNgEVuoagRbMkwsdRpbKFXV8cFEHVw== X-Received: by 2002:ac2:46c9:0:b0:516:fe8c:ef9b with SMTP id p9-20020ac246c9000000b00516fe8cef9bmr6936114lfo.57.1713255384697; Tue, 16 Apr 2024 01:16:24 -0700 (PDT) Received: from ?IPV6:2003:cb:c718:6400:7621:b88a:e99e:2fa8? (p200300cbc71864007621b88ae99e2fa8.dip0.t-ipconnect.de. [2003:cb:c718:6400:7621:b88a:e99e:2fa8]) by smtp.gmail.com with ESMTPSA id d8-20020a5d5388000000b0034335f13570sm14158800wrv.116.2024.04.16.01.16.23 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 16 Apr 2024 01:16:24 -0700 (PDT) Message-ID: Date: Tue, 16 Apr 2024 10:16:23 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v6 4/4] mm: correct the docs for thp_fault_alloc and thp_fault_fallback To: Barry Song <21cnbao@gmail.com>, akpm@linux-foundation.org, linux-mm@kvack.org Cc: cerasuolodomenico@gmail.com, chrisl@kernel.org, kasong@tencent.com, linux-kernel@vger.kernel.org, peterx@redhat.com, ryan.roberts@arm.com, surenb@google.com, v-songbaohua@oppo.com, willy@infradead.org, yosryahmed@google.com, yuzhao@google.com, corbet@lwn.net References: <20240412114858.407208-1-21cnbao@gmail.com> <20240412114858.407208-5-21cnbao@gmail.com> From: David Hildenbrand Autocrypt: addr=david@redhat.com; keydata= xsFNBFXLn5EBEAC+zYvAFJxCBY9Tr1xZgcESmxVNI/0ffzE/ZQOiHJl6mGkmA1R7/uUpiCjJ dBrn+lhhOYjjNefFQou6478faXE6o2AhmebqT4KiQoUQFV4R7y1KMEKoSyy8hQaK1umALTdL QZLQMzNE74ap+GDK0wnacPQFpcG1AE9RMq3aeErY5tujekBS32jfC/7AnH7I0v1v1TbbK3Gp XNeiN4QroO+5qaSr0ID2sz5jtBLRb15RMre27E1ImpaIv2Jw8NJgW0k/D1RyKCwaTsgRdwuK Kx/Y91XuSBdz0uOyU/S8kM1+ag0wvsGlpBVxRR/xw/E8M7TEwuCZQArqqTCmkG6HGcXFT0V9 PXFNNgV5jXMQRwU0O/ztJIQqsE5LsUomE//bLwzj9IVsaQpKDqW6TAPjcdBDPLHvriq7kGjt WhVhdl0qEYB8lkBEU7V2Yb+SYhmhpDrti9Fq1EsmhiHSkxJcGREoMK/63r9WLZYI3+4W2rAc UucZa4OT27U5ZISjNg3Ev0rxU5UH2/pT4wJCfxwocmqaRr6UYmrtZmND89X0KigoFD/XSeVv jwBRNjPAubK9/k5NoRrYqztM9W6sJqrH8+UWZ1Idd/DdmogJh0gNC0+N42Za9yBRURfIdKSb B3JfpUqcWwE7vUaYrHG1nw54pLUoPG6sAA7Mehl3nd4pZUALHwARAQABzSREYXZpZCBIaWxk ZW5icmFuZCA8ZGF2aWRAcmVkaGF0LmNvbT7CwZgEEwEIAEICGwMGCwkIBwMCBhUIAgkKCwQW AgMBAh4BAheAAhkBFiEEG9nKrXNcTDpGDfzKTd4Q9wD/g1oFAl8Ox4kFCRKpKXgACgkQTd4Q 9wD/g1oHcA//a6Tj7SBNjFNM1iNhWUo1lxAja0lpSodSnB2g4FCZ4R61SBR4l/psBL73xktp rDHrx4aSpwkRP6Epu6mLvhlfjmkRG4OynJ5HG1gfv7RJJfnUdUM1z5kdS8JBrOhMJS2c/gPf wv1TGRq2XdMPnfY2o0CxRqpcLkx4vBODvJGl2mQyJF/gPepdDfcT8/PY9BJ7FL6Hrq1gnAo4 3Iv9qV0JiT2wmZciNyYQhmA1V6dyTRiQ4YAc31zOo2IM+xisPzeSHgw3ONY/XhYvfZ9r7W1l pNQdc2G+o4Di9NPFHQQhDw3YTRR1opJaTlRDzxYxzU6ZnUUBghxt9cwUWTpfCktkMZiPSDGd KgQBjnweV2jw9UOTxjb4LXqDjmSNkjDdQUOU69jGMUXgihvo4zhYcMX8F5gWdRtMR7DzW/YE BgVcyxNkMIXoY1aYj6npHYiNQesQlqjU6azjbH70/SXKM5tNRplgW8TNprMDuntdvV9wNkFs 9TyM02V5aWxFfI42+aivc4KEw69SE9KXwC7FSf5wXzuTot97N9Phj/Z3+jx443jo2NR34XgF 89cct7wJMjOF7bBefo0fPPZQuIma0Zym71cP61OP/i11ahNye6HGKfxGCOcs5wW9kRQEk8P9 M/k2wt3mt/fCQnuP/mWutNPt95w9wSsUyATLmtNrwccz63XOwU0EVcufkQEQAOfX3n0g0fZz Bgm/S2zF/kxQKCEKP8ID+Vz8sy2GpDvveBq4H2Y34XWsT1zLJdvqPI4af4ZSMxuerWjXbVWb T6d4odQIG0fKx4F8NccDqbgHeZRNajXeeJ3R7gAzvWvQNLz4piHrO/B4tf8svmRBL0ZB5P5A 2uhdwLU3NZuK22zpNn4is87BPWF8HhY0L5fafgDMOqnf4guJVJPYNPhUFzXUbPqOKOkL8ojk CXxkOFHAbjstSK5Ca3fKquY3rdX3DNo+EL7FvAiw1mUtS+5GeYE+RMnDCsVFm/C7kY8c2d0G NWkB9pJM5+mnIoFNxy7YBcldYATVeOHoY4LyaUWNnAvFYWp08dHWfZo9WCiJMuTfgtH9tc75 7QanMVdPt6fDK8UUXIBLQ2TWr/sQKE9xtFuEmoQGlE1l6bGaDnnMLcYu+Asp3kDT0w4zYGsx 5r6XQVRH4+5N6eHZiaeYtFOujp5n+pjBaQK7wUUjDilPQ5QMzIuCL4YjVoylWiBNknvQWBXS lQCWmavOT9sttGQXdPCC5ynI+1ymZC1ORZKANLnRAb0NH/UCzcsstw2TAkFnMEbo9Zu9w7Kv AxBQXWeXhJI9XQssfrf4Gusdqx8nPEpfOqCtbbwJMATbHyqLt7/oz/5deGuwxgb65pWIzufa N7eop7uh+6bezi+rugUI+w6DABEBAAHCwXwEGAEIACYCGwwWIQQb2cqtc1xMOkYN/MpN3hD3 AP+DWgUCXw7HsgUJEqkpoQAKCRBN3hD3AP+DWrrpD/4qS3dyVRxDcDHIlmguXjC1Q5tZTwNB boaBTPHSy/Nksu0eY7x6HfQJ3xajVH32Ms6t1trDQmPx2iP5+7iDsb7OKAb5eOS8h+BEBDeq 3ecsQDv0fFJOA9ag5O3LLNk+3x3q7e0uo06XMaY7UHS341ozXUUI7wC7iKfoUTv03iO9El5f XpNMx/YrIMduZ2+nd9Di7o5+KIwlb2mAB9sTNHdMrXesX8eBL6T9b+MZJk+mZuPxKNVfEQMQ a5SxUEADIPQTPNvBewdeI80yeOCrN+Zzwy/Mrx9EPeu59Y5vSJOx/z6OUImD/GhX7Xvkt3kq Er5KTrJz3++B6SH9pum9PuoE/k+nntJkNMmQpR4MCBaV/J9gIOPGodDKnjdng+mXliF3Ptu6 3oxc2RCyGzTlxyMwuc2U5Q7KtUNTdDe8T0uE+9b8BLMVQDDfJjqY0VVqSUwImzTDLX9S4g/8 kC4HRcclk8hpyhY2jKGluZO0awwTIMgVEzmTyBphDg/Gx7dZU1Xf8HFuE+UZ5UDHDTnwgv7E th6RC9+WrhDNspZ9fJjKWRbveQgUFCpe1sa77LAw+XFrKmBHXp9ZVIe90RMe2tRL06BGiRZr jPrnvUsUUsjRoRNJjKKA/REq+sAnhkNPPZ/NNMjaZ5b8Tovi8C0tmxiCHaQYqj7G2rgnT0kt WNyWQQ== Organization: Red Hat In-Reply-To: <20240412114858.407208-5-21cnbao@gmail.com> X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Rspamd-Queue-Id: 937234000E X-Rspam-User: X-Rspamd-Server: rspam04 X-Stat-Signature: 47dxnmyba114ntza437uk75od9w43q7h X-HE-Tag: 1713255388-362140 X-HE-Meta: U2FsdGVkX193O1wvEqRNB3D7K+O1+j0PRJ8b3v2dI+PSRNllBGc9dww4ItvgF7fHveqL3eVkr9rUlklS7yXKvojn0aLjbz03dp/Arewl0bgoO8NY7zHZwP2FSsGC/sBsN78f8e9v2t+kMENvPUpvOM6ep0R68ez2cE7QEsCmLi/ePScJSCxs4onNgR2YRBMaeY69kUkGnNxe+n9zAyUF6gBeaz31U1iPMPXUVgxtxy/TBB7Lnob6PLC5pPJgfe5TFkDGJkG2Fc6OiDokxE5e1ePpes8fbmGRFOfCGCmhkEea68xYfGNo25wX7icb/EvxlgdNCsfNvccdC8yCwqae4251e0JrhbKK1ZndlJSFZEcWGm5vafKO4XoabV+MJFPj1UUobh/rUpBqkk9VVKW11xlGYG7ruzcrIl9BW2CFSwNkpI/PL7MqG2r6Idkdh3foX2fJrewpWJvArJxZ7oblJ96edLiBwJcCLd9VTBQWE+5aXs843XesdHr1sSyO0NBb/EWaJyZTFY0wJvqL6YoSqOccjwmmq6DnO8AtZv7/ZlHqY6y0js7aFD/RVaEnw7ODrh9FzkLnfHaa9DtfJ/ZlmQjwrvoaCNutSSaLS3T58NumPSkpJmRw5wjQNh7ikiQGEXhldqo2hjJfpVaURdwkepGk/GAmRI/qWzC4/pnB+XIRL520foLRPOUzswyaADilOgnnknf7AtN2idx+x0Kc438m6qrpReIkBwtqDd1YMqMb14oNjFkVgU5JsKmq6xdmlw2zPQFpqzFlrIhlmRf35ic6VZ4TWourl8wJp91DJRh3TyYCf2tTvzNb65Qouwy16zigI8D16GullbiWjAKq04wXCf69nVy3d/yWOtDIOoI1LRplJEYCQy2Yj46+/qdMZk+Xv6qwmewKIxnlReL6VpB05SEofrtx166t2dgRtxxi8BnC1uoJVLO5rYCwIW5NbioM99mJeyuPorCmL9S xg2t42SU 1a4phthQjs94VshiUXnAFxl0Ro8EYYBgTcJSeuG9+rdxqJKUUJmLssCCUllR/DFTA+IKRpd/K42qKbs2vSYgMKNllt86+7xivVMq4/joZKWthJuxLM7GtjiePLbFBuiePnDjC/SoouTNzsrvVmb1cO9HSOvnM27/lYUOzahXwDdqWOdR6uAJxDM+V8duO1KZeh+D/9Xk0tl/2M59jnjaHqfJZ74R1WeC+FZzJVcSgz9xQV0KRiFSwiiIfXBy3FOh0khbBpk9ji+/oQSu9W4CtiFnNw3ZvoqigqYnwACmqISyMzhyVOTOLQte2t6Cq1lNHzUylGF2WV+VhaDDeTceuqg7BAXM7Bn11+mv5WCjNCWX2QFWNRMch9Q7luplG5av0Xzeb8njGJ6hJHUXDkQ7mnqwe9o0TRYHf6MKDAQXt5XUpe62jJ1/rnao2HbuIm2gRpsiLjpYODUdbfDoOyUCBkYQR20uYC7SX10TnTG6iexFFIFmFVEFY402Qr6enTka6UmpfrRGlkrNt1CkBY7oG70mZD6HwGp4ma6Zcp24Akao1isU2l1wwfoVKwGqunhexTqlmVP2z82l2DsfrOn2GSAtt3bKn/92vvO45QNVv52fvayF9NhCPxnhMOhtbpM5UP0CsDo6M2g6d5Jm17VaAFG9efDO3dg5yUTj0PyixKlFXMMU3qIuNl6nDWYBORYT/T4m3AYXxo7nwYM8OQHF5Y93jV7hpYgFIENu5FHeLzMtlUbjAJMcN8V+oH9AJ/z45eUXYzYjmSjvL8AuW/xNfVC9WApua+COefpU+4NADdNQ9d9wFVwrgjsfN/0X1g7l3D05FuaxTwdIgZYku3tegKmRiAxLHGW/0BZOGWSvbW6Sk03slLbPr2TM6w5mGkC0HaMSiFJzPk2vnSVA= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 12.04.24 13:48, Barry Song wrote: > From: Barry Song > > The documentation does not align with the code. In > __do_huge_pmd_anonymous_page(), THP_FAULT_FALLBACK is incremented when > mem_cgroup_charge() fails, despite the allocation succeeding, whereas > THP_FAULT_ALLOC is only incremented after a successful charge. > > Signed-off-by: Barry Song > Reviewed-by: Ryan Roberts > Cc: Chris Li > Cc: David Hildenbrand > Cc: Domenico Cerasuolo > Cc: Kairui Song > Cc: Matthew Wilcox (Oracle) > Cc: Peter Xu > Cc: Ryan Roberts > Cc: Suren Baghdasaryan > Cc: Yosry Ahmed > Cc: Yu Zhao > Cc: Jonathan Corbet > --- Reviewed-by: David Hildenbrand -- Cheers, David / dhildenb